Re: XFree86 crash, Bezier thing (was Re: Is phk rewriting the kernel over the weekend?)

2002-09-30 Thread Maxim Sobolev

On Sun, Sep 29, 2002 at 12:17:54PM -0700, Eric Anholt wrote:
 On Sun, 2002-09-29 at 10:25, Wesley Morgan wrote:
  Does this bug effect -stable? It only showed up in -current recently.
  Isn't it a bigger chance that something on the FreeBSD side made this bug
  much more visible?
  
  On Sun, 29 Sep 2002, Maxim Sobolev wrote:
  
   I think it should be fixed in FreeBSD ports before 4.7, because it
   is really annoying when server crashes without any particular
   reason.
  
   Eric, what do you think about it?
  
   -Maxim
 
 From what I had heard on the lists it was only a thing that happened
 when people upgraded kernels, and that it had stopped after some date of
 kernel.  I hadn't experienced it, so I ignored it.  I don't know about
 that link posted, I thought that was a mozilla bug that was supposed to
 be fixed.

I don't think that it is related to kernel (what kernel has to do with
Type1 font renderer in X server???). I'm seeing this problem when trying
to open MS Word document in AbiWord, perhaps a bug in AbiWord itself,
but IMO no application should be able to crash the server, so that we
need to fix it ASAP.

-Maxim

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Is phk rewriting the kernel over the weekend?

2002-09-29 Thread Poul-Henning Kamp

In message [EMAIL PROTECTED], walt writes:
I need some of whatever it is you're taking.

Hehehehe :-)

What happened was that I spent too much time on a stupid bug in the
GEOM code, and decided that my life was too short for that.

I've worked with FlexeLint in my earlier life and decided that even
at my hourly rates, spending $1k on a good tool is good economy.

After running it on various bits of my own code I decided to let it
loose on LINT.  And what can I say ?  It finds bugs in our code!

Some are stylistic, some are potential some are actual.  As with
all tools, one should not blindly apply the output.

What makes this tool interesting compared to a normal lint, is a
feature called specific walk.

As it goes, it tries to trace values and memory as best it can, and
it will record which functions are called with which values from
where.  It will then reexamine those functions in the light of those
possible paramter values and see if that looks sane.

I'll agree with bruce that this is nothing people can't do themselves,
but I think getting a program to do it may be faster and more reliable.

Here is an example of what it finds (this is not to pick on anybody,
it was just the first one I spotted now):

During Specific Walk:
  File ../../../ufs/ufs/ufs_vnops.c line 1757: ufs_makeinode(!=0, ?, ?, ?)
../../../ufs/ufs/ufs_vnops.c  2384  Warning 429: Custodial pointer 'acl' (line
2265) has not been freed or returned

This basically says that ufs_makeinode() was called from line 1757 and the
first argument is know to be non-NULL, the others we know nothing about.

Tracing through ufs_makeinode(), it knows that malloc allocates memory and
tracks that Custodial pointer through the code and notices that we can
return from ufs_makeinode() without having disposed of the pointer in
some sensible way.

As far as I can tell, that means that a FREE(acl, M_ACL) is missing in
line 2384 and we have a really good and productive memory-leak if you
create files/directories in directories which don't have an ACL.

Now, $1k is not loose change, and a 5 concurrent user network license
for the cluster would cost $3k, but maybe we should put that on the
donations want list anyway ?  Or is this foundation work ?

Poul-Henning

PS: Flexelint is distributed as obfuscated KR C source, which compiles
on any and all system with a just moderately non-disgusting C compiler.

-- 
Poul-Henning Kamp   | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD committer   | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Is phk rewriting the kernel over the weekend?

2002-09-29 Thread walt

Poul-Henning Kamp wrote:
 In message [EMAIL PROTECTED], walt writes:
 
I need some of whatever it is you're taking.
 
 
 Hehehehe :-)
 
 I've worked with FlexeLint in my earlier life and decided that even
 at my hourly rates, spending $1k on a good tool is good economy.

A credible demonstration of increased productivity.  This is good
advertising for the FlexeLint people and they should gratefully
donate your copy :-)

I wonder if it could find the very annoying crashes in the X server.

-- 
I'm sick of hearing about how big my Beziers are!


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: XFree86 crash, Bezier thing (was Re: Is phk rewriting the kernel over the weekend?)

2002-09-29 Thread Maxim Sobolev

I think it should be fixed in FreeBSD ports before 4.7, because it
is really annoying when server crashes without any particular
reason.

Eric, what do you think about it?

-Maxim

On Sun, Sep 29, 2002 at 03:17:41PM +0200, Frode Nordahl wrote:
 Hey,
 
 On Sun, 2002-09-29 at 14:51, walt wrote:
 [snip]
  
  I wonder if it could find the very annoying crashes in the X server.
  
  -- 
  I'm sick of hearing about how big my Beziers are!
 
 I found this on the Xpert mailinglist:
 http://www.xfree86.org/pipermail/xpert/2002-June/018300.html
 
 Seems like this won't get fixed until XFree86 4.3.0, but the bug seems
 to be in the Type1 font handler only. (a call to abort())
 
 I have removed it from my XFree86 config now, and I'm hoping for no more
 Bezier crashes :)
 
 
 Mvh,
 Frode Nordahl
 
 
 To Unsubscribe: send mail to [EMAIL PROTECTED]
 with unsubscribe freebsd-current in the body of the message

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Is phk rewriting the kernel over the weekend?

2002-09-28 Thread walt

I need some of whatever it is you're taking.


-- 
Time for my nap...


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message