Re: LukemFTP and command-line multiple downloads

2003-02-16 Thread Mike Heffner

On 14-Feb-2003 Kris Kennaway wrote:
| On Fri, Feb 14, 2003 at 03:37:49PM -0800, Kris Kennaway wrote:
| On Fri, Feb 14, 2003 at 03:34:06PM -0800, Kris Kennaway wrote:
|  Since upgrading bento to running 5.0, it appears that I can no longer
|  download multiple files from a FTP server by specifying a glob
|  pattern
|  on the command-line:
|  
|  e.g.
|  
|  /usr/bin/ftp -4a
|  ftp://snapshots.jp.freebsd.org/pub/FreeBSD/snapshots/alpha/5-LATEST/ba
|  se/base.\?\?
| 
| This appears to work (as it used to) under 4.x.
| 
| It was pointed out to me that this is because 5.0 now uses
| lukemftp..can the maintainers please look into this ASAP?  In the
| meantime I'll have to stick with the older 5.0 ftp client.
| 

Try the attached patch. If this works for you I'll pass it on to Luke.


Mike

-- 
  Mike Heffner   mheffner@[acm.]vt.edu
 [EMAIL PROTECTED]


Index: fetch.c
===
RCS file: /cvs/ncvs/src/contrib/lukemftp/src/fetch.c,v
retrieving revision 1.1.1.3
diff -u -r1.1.1.3 fetch.c
--- fetch.c 15 Jun 2002 09:40:34 -  1.1.1.3
+++ fetch.c 16 Feb 2003 19:47:46 -
@@ -1372,7 +1372,7 @@
dir ? dir : null, file ? file : null);
 
dirhasglob = filehasglob = 0;
-   if (doglob  urltype == CLASSIC_URL_T) {
+   if (doglob  (urltype == CLASSIC_URL_T || urltype == FTP_URL_T)) {
if (! EMPTYSTRING(dir)  strpbrk(dir, *?[]{}) != NULL)
dirhasglob = 1;
if (! EMPTYSTRING(file)  strpbrk(file, *?[]{}) != NULL)



Re: LukemFTP and command-line multiple downloads

2003-02-14 Thread Kris Kennaway
On Fri, Feb 14, 2003 at 03:37:49PM -0800, Kris Kennaway wrote:
 On Fri, Feb 14, 2003 at 03:34:06PM -0800, Kris Kennaway wrote:
  Since upgrading bento to running 5.0, it appears that I can no longer
  download multiple files from a FTP server by specifying a glob pattern
  on the command-line:
  
  e.g.
  
  /usr/bin/ftp -4a 
ftp://snapshots.jp.freebsd.org/pub/FreeBSD/snapshots/alpha/5-LATEST/base/base.\?\?
 
 This appears to work (as it used to) under 4.x.

It was pointed out to me that this is because 5.0 now uses
lukemftp..can the maintainers please look into this ASAP?  In the
meantime I'll have to stick with the older 5.0 ftp client.

Kris



msg52361/pgp0.pgp
Description: PGP signature