Fw: OpenZFS support merged: problem mounting ZFS within JAILs

[O. Hartmann]

Begin forwarded message:

Date: Fri, 4 Sep 2020 14:06:12 +0200
From: "O. Hartmann" 
To: Matthew Macy 
Cc: freebsd-current , freebsd-fs
, freebsd-hack...@freebsd.org Subject: Re: OpenZFS
support merged: problem mounting ZFS within JAILs


On Mon, 24 Aug 2020 19:38:53 -0700
Matthew Macy  wrote:

> r364746 merged OpenZFS support in to HEAD.
>
> The change should be transparent unless you want to use new features.
> I caution against 'zpool upgrade' for the next few weeks.
>
> https://svnweb.freebsd.org/base?view=revision=364746
>
> If you encounter problems please report them to me, Ryan Moeller, and
> -current. ___
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Hello.

We just upgraded several boxes running CURRENT to r365325. These systems are
running customized kernels with ZFS statically compiled in. the host's OS is
derived from "make buildworld buildkernel" in /usr/src.

Jails on that hosts are maintained vi /etc/jail.conf, but system is installed
by misusage of ezjail. So far the environemnt.

One of the jails is a dedicated poudriere jail using ZFS. This worked so far.
Every pool this specific jail or any other jail is mounting is located below

POOL/ezjail

therefore we consider

enforce_statfs= "1";

in /etc/jail.conf as sufficient. After updating all /etc/default/ and
/etc/rc.d of those poudriere-jails with ZFS everything should be inline
regarding new requests for OpenZFS .

But now enforce_statfs= "1"; isn't sufficient anymore, the jais fail to startup
with a mount error complaining about insufficient access rights. The problem
partially disappear by setting enforce_statfs= "0";, but this isn't what we
want and personally I consider it a risk. But furthermore, several ZFS datasets
prior to the upgrade successfully being exported from the hosts pools and mount
from withing the jail are now invisible within the jail.

According to /usr/src/UPDATING, tag 20200824, the features of the ZFS pools of
the main hosts have been left untouched so far, no feature upgrade has been
performed.

Some hints would be nice.

Kind regards,

oh
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged: problem mounting ZFS within JAILs

[O. Hartmann]

On Mon, 24 Aug 2020 19:38:53 -0700
Matthew Macy  wrote:

> r364746 merged OpenZFS support in to HEAD.
>
> The change should be transparent unless you want to use new features.
> I caution against 'zpool upgrade' for the next few weeks.
>
> https://svnweb.freebsd.org/base?view=revision=364746
>
> If you encounter problems please report them to me, Ryan Moeller, and
> -current. ___
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Hello.

We just upgraded several boxes running CURRENT to r365325. These systems are
running customized kernels with ZFS statically compiled in. the host's OS is
derived from "make buildworld buildkernel" in /usr/src.

Jails on that hosts are maintained vi /etc/jail.conf, but system is installed
by misusage of ezjail. So far the environemnt.

One of the jails is a dedicated poudriere jail using ZFS. This worked so far.
Every pool this specific jail or any other jail is mounting is located below

POOL/ezjail

therefore we consider

enforce_statfs= "1";

in /etc/jail.conf as sufficient. After updating all /etc/default/ and
/etc/rc.d of those poudriere-jails with ZFS everything should be inline
regarding new requests for OpenZFS .

But now enforce_statfs= "1"; isn't sufficient anymore, the jais fail to startup
with a mount error complaining about insufficient access rights. The problem
partially disappear by setting enforce_statfs= "0";, but this isn't what we
want and personally I consider it a risk. But furthermore, several ZFS datasets
prior to the upgrade successfully being exported from the hosts pools and mount
from withing the jail are now invisible within the jail.

According to /usr/src/UPDATING, tag 20200824, the features of the ZFS pools of
the main hosts have been left untouched so far, no feature upgrade has been
performed.

Some hints would be nice.

Kind regards,

oh
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Kurt Jaeger]

Hi!

> > > I caution against 'zpool upgrade' for the next few weeks.
> > > https://svnweb.freebsd.org/base?view=revision=364746

> > A system running r363767 can upgrade to some revision after r364746
> > and reboot and come up without big issues, running the new openzfs code ?
> > Or is some additional step required ?

> Barring some unusual configuration that no one else there should not be a
> problem. The only known issue of immediate concern (that was only raised a
> day or two ago :-/) is zfs delegation in poudriere.

This is my package builder box, where I also receive mail, so ... 8-}

> If you rely on that I'd say wait a couple days, otherwise proceed.

It has it's files on a ZPOOL.

How can I find if my poudriere uses zfs delegation ?

https://www.freebsd.org/doc/handbook/zfs-zfs-allow.html

says something about:

sysctl vfs.usermount

which returns 0 (so no usermounts) and:

zfs allow -l zroot/pou

which returns empty. So I guess I can upgrade.

-- 
p...@opsec.eu+49 171 3101372Now what ?
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Matthew Macy]

On Sat, Aug 29, 2020 at 08:47 Kurt Jaeger  wrote:

> Hi!
>
>
>
> > r364746 merged OpenZFS support in to HEAD.
>
> >
>
> > The change should be transparent unless you want to use new features.
>
> > I caution against 'zpool upgrade' for the next few weeks.
>
> > https://svnweb.freebsd.org/base?view=revision=364746
>
>
>
> A system running r363767 can upgrade to some revision after r364746
>
> and reboot and come up without big issues, running the new openzfs code ?
>
>
>
> Or is some additional step required ?
>


Barring some unusual configuration that no one else there should not be a
problem. The only known issue of immediate concern (that was only raised a
day or two ago :-/) is zfs delegation in poudriere. If you rely on that I’d
say wait a couple days, otherwise proceed.

-M


>
>
> --
>
> p...@opsec.eu+49 171 3101372Now what ?
>
>
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Kurt Jaeger]

Hi!

> r364746 merged OpenZFS support in to HEAD.
> 
> The change should be transparent unless you want to use new features.
> I caution against 'zpool upgrade' for the next few weeks.
> https://svnweb.freebsd.org/base?view=revision=364746

A system running r363767 can upgrade to some revision after r364746
and reboot and come up without big issues, running the new openzfs code ?

Or is some additional step required ?

-- 
p...@opsec.eu+49 171 3101372Now what ?
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Toomas Soome]

> On 25. Aug 2020, at 22:49, driesm.michi...@gmail.com wrote:
> 
>> -Original Message-
>> From: owner-freebsd...@freebsd.org  On
>> Behalf Of Matthew Macy
>> Sent: Tuesday, 25 August 2020 04:39
>> To: freebsd-current ; freebsd-fs > f...@freebsd.org>; freebsd-hack...@freebsd.org
>> Subject: OpenZFS support merged
>> 
>> r364746 merged OpenZFS support in to HEAD.
> 
> First of all a big thank you to the whole team that made this possible!
> 
> Secondly, I would like to check in if the following statement is still in
> effect (taken from https://zfsonfreebsd.github.io/ZoF):
> "Beware that the FreeBSD boot loader does not allow booting from root pools
> with encryption active (even if it is not in use), so do not try encryption
> on a pool you boot from"
> 
> When we are talking about encryption active, does that mean the feature flag
> active or from the moment one sets encryption=on on any dataset of the root
> pool?
> As a follow-up, if it is not currently not possible, are there any
> long/short term plans to add the missing bits to our boot loader?µ


Yes. The current boot loader can handle features before switch to OpenZFS. New 
features will be added, it just will take some time.

rgds,
toomas

> 
>> 
>> The change should be transparent unless you want to use new features.
>> I caution against 'zpool upgrade' for the next few weeks.
>> 
>> https://svnweb.freebsd.org/base?view=revision=364746
>> 
>> If you encounter problems please report them to me, Ryan Moeller, and -
>> current.
>> ___
>> freebsd...@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/freebsd-fs
>> To unsubscribe, send any mail to "freebsd-fs-unsubscr...@freebsd.org"
> 
> ___
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Ben Woods]

On Tue, 25 Aug 2020 at 10:39 am, Matthew Macy  wrote:

> r364746 merged OpenZFS support in to HEAD.
>
>
>
> The change should be transparent unless you want to use new features.
>
> I caution against 'zpool upgrade' for the next few weeks.
>
>
>
> https://svnweb.freebsd.org/base?view=revision=364746



Congratulations and thank you to all involved. This is a great step forward
for FreeBSD.

Looking forward to trying ZFS native encryption, and send/recv of encrypted
datasets!

I’ll second that boot loader support for ZFS native encryption and zstd
compression would greatly complement this change once they are ready.

Regards,
Ben

> 

-- 

--
From: Benjamin Woods
woods...@gmail.com
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Toomas Soome]

> On 25. Aug 2020, at 19:35, Danilo Egêa Gondolfo  wrote:
> 
> On Tue, Aug 25, 2020 at 3:39 AM Matthew Macy  wrote:
> 
>> r364746 merged OpenZFS support in to HEAD.
>> 
>> The change should be transparent unless you want to use new features.
>> I caution against 'zpool upgrade' for the next few weeks.
>> 
>> https://svnweb.freebsd.org/base?view=revision=364746
>> 
>> If you encounter problems please report them to me, Ryan Moeller, and
>> -current.
>> ___
>> freebsd-hack...@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
>> To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
>> 
> 
> Hi, that is good news.
> 
> It seems that our boot loader will fail to boot after zpool upgrade. Is
> that a known issue?
> 

The loader is not updated to support zstd.

rgds,
toomas

> I've replicated my setup, root zfs over GELI, in a VM to avoid any surprise
> (phew!), and it booted fine after upgrading the system. Although it fails
> after zpool upgrade (yes, I know you've asked us to be cautious with zpool
> upgrade):
> 
> ZFS: unsupported feature: org.freebsd:zstd_compress
> ZFS: pool zroot is not supported
> ZFS: can't find pool by guid
> 
> Thank you!
> ___
> freebsd-current@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Ryan Moeller]

On 8/25/20 3:49 PM, driesm.michi...@gmail.com wrote:

-Original Message-
From: owner-freebsd...@freebsd.org  On
Behalf Of Matthew Macy
Sent: Tuesday, 25 August 2020 04:39
To: freebsd-current ; freebsd-fs ; freebsd-hack...@freebsd.org
Subject: OpenZFS support merged

r364746 merged OpenZFS support in to HEAD.

First of all a big thank you to the whole team that made this possible!

Secondly, I would like to check in if the following statement is still in
effect (taken from https://zfsonfreebsd.github.io/ZoF):
"Beware that the FreeBSD boot loader does not allow booting from root pools
with encryption active (even if it is not in use), so do not try encryption
on a pool you boot from"

When we are talking about encryption active, does that mean the feature flag
active or from the moment one sets encryption=on on any dataset of the root
pool?


The feature can be enabled on the pool, but as soon as you use it on any 
dataset
the feature goes from "enabled" to "active" and the boot loader will not 
be able
to read the pool, even if you switch encryption back off. At least 
that's how it
was when the ZoF page was written, if it's different now someone may 
correct me.




As a follow-up, if it is not currently not possible, are there any
long/short term plans to add the missing bits to our boot loader?µ


The change should be transparent unless you want to use new features.
I caution against 'zpool upgrade' for the next few weeks.

https://svnweb.freebsd.org/base?view=revision=364746

If you encounter problems please report them to me, Ryan Moeller, and -
current.
___
freebsd...@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-fs
To unsubscribe, send any mail to "freebsd-fs-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Jakob Alvermark]

On 2020-08-25 20:23, Ryan Moeller wrote:


On 8/25/20 2:09 PM, Jakob Alvermark wrote:


On 2020-08-25 20:06, Ryan Moeller wrote:



On 8/25/20 2:00 PM, Jakob Alvermark wrote:


On 2020-08-25 17:42, Ryan Moeller wrote:


On 8/25/20 9:58 AM, Jakob Alvermark wrote:

Hi,


I updated from r364605 to r364768

'make buildkernel' fails like this:

Building 
/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/zfs/zstd.o 

/usr/src/sys/contrib/openzfs/module/zstd/lib/zstd.c:1336:12: 
fatal error: 'immintrin.h' file not found

#  include    /* support for bextr (experimental) */
   ^
1 error generated.
*** Error code 1

Stop.



I'm trying to figure out how to reproduce this. Are you perhaps 
building with GCC?


-Ryan


Nope.


I do use WITH_META_MODE though, but it shouldn't affect this I think.

I tried clearing out /usr/obj and started a new build, but I still 
get the same error.



Jakob

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org" 


Okay I'm guessing your build env has something like `CPUTYPE?= 
native` in src.conf.  This was also an issue with the original zstd 
import. I've reproduced this error and will commit the fix shortly.




https://svnweb.freebsd.org/changeset/base/364777



It compiles now. And it boots.

Thanks for fixing it so quickly!


Jakob

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

RE: OpenZFS support merged

[driesm.michiels]

> -Original Message-
> From: owner-freebsd...@freebsd.org  On
> Behalf Of Matthew Macy
> Sent: Tuesday, 25 August 2020 04:39
> To: freebsd-current ; freebsd-fs  f...@freebsd.org>; freebsd-hack...@freebsd.org
> Subject: OpenZFS support merged
> 
> r364746 merged OpenZFS support in to HEAD.

First of all a big thank you to the whole team that made this possible!

Secondly, I would like to check in if the following statement is still in
effect (taken from https://zfsonfreebsd.github.io/ZoF):
"Beware that the FreeBSD boot loader does not allow booting from root pools
with encryption active (even if it is not in use), so do not try encryption
on a pool you boot from"

When we are talking about encryption active, does that mean the feature flag
active or from the moment one sets encryption=on on any dataset of the root
pool?
As a follow-up, if it is not currently not possible, are there any
long/short term plans to add the missing bits to our boot loader?µ

> 
> The change should be transparent unless you want to use new features.
> I caution against 'zpool upgrade' for the next few weeks.
> 
> https://svnweb.freebsd.org/base?view=revision=364746
> 
> If you encounter problems please report them to me, Ryan Moeller, and -
> current.
> ___
> freebsd...@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-fs
> To unsubscribe, send any mail to "freebsd-fs-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Ryan Moeller]

On 8/25/20 2:09 PM, Jakob Alvermark wrote:


On 2020-08-25 20:06, Ryan Moeller wrote:



On 8/25/20 2:00 PM, Jakob Alvermark wrote:


On 2020-08-25 17:42, Ryan Moeller wrote:


On 8/25/20 9:58 AM, Jakob Alvermark wrote:

Hi,


I updated from r364605 to r364768

'make buildkernel' fails like this:

Building 
/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/zfs/zstd.o 

/usr/src/sys/contrib/openzfs/module/zstd/lib/zstd.c:1336:12: fatal 
error: 'immintrin.h' file not found

#  include    /* support for bextr (experimental) */
   ^
1 error generated.
*** Error code 1

Stop.



I'm trying to figure out how to reproduce this. Are you perhaps 
building with GCC?


-Ryan


Nope.


I do use WITH_META_MODE though, but it shouldn't affect this I think.

I tried clearing out /usr/obj and started a new build, but I still 
get the same error.



Jakob

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org" 


Okay I'm guessing your build env has something like `CPUTYPE?= 
native` in src.conf.  This was also an issue with the original zstd 
import. I've reproduced this error and will commit the fix shortly.




https://svnweb.freebsd.org/changeset/base/364777




Oh! I do have that.

Thanks.


Jakob

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Jakob Alvermark]

On 2020-08-25 20:06, Ryan Moeller wrote:



On 8/25/20 2:00 PM, Jakob Alvermark wrote:


On 2020-08-25 17:42, Ryan Moeller wrote:


On 8/25/20 9:58 AM, Jakob Alvermark wrote:

Hi,


I updated from r364605 to r364768

'make buildkernel' fails like this:

Building 
/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/zfs/zstd.o 

/usr/src/sys/contrib/openzfs/module/zstd/lib/zstd.c:1336:12: fatal 
error: 'immintrin.h' file not found

#  include    /* support for bextr (experimental) */
   ^
1 error generated.
*** Error code 1

Stop.



I'm trying to figure out how to reproduce this. Are you perhaps 
building with GCC?


-Ryan


Nope.


I do use WITH_META_MODE though, but it shouldn't affect this I think.

I tried clearing out /usr/obj and started a new build, but I still 
get the same error.



Jakob

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org" 


Okay I'm guessing your build env has something like `CPUTYPE?= native` 
in src.conf.  This was also an issue with the original zstd import. 
I've reproduced this error and will commit the fix shortly.



Oh! I do have that.

Thanks.


Jakob

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Ryan Moeller]

On 8/25/20 2:00 PM, Jakob Alvermark wrote:


On 2020-08-25 17:42, Ryan Moeller wrote:


On 8/25/20 9:58 AM, Jakob Alvermark wrote:

Hi,


I updated from r364605 to r364768

'make buildkernel' fails like this:

Building 
/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/zfs/zstd.o 

/usr/src/sys/contrib/openzfs/module/zstd/lib/zstd.c:1336:12: fatal 
error: 'immintrin.h' file not found

#  include    /* support for bextr (experimental) */
   ^
1 error generated.
*** Error code 1

Stop.



I'm trying to figure out how to reproduce this. Are you perhaps 
building with GCC?


-Ryan


Nope.


Okay I'm guessing your build env has something like `CPUTYPE?= native` 
in src.conf.  This was also an issue with the original zstd import. 
I've reproduced this error and will commit the fix shortly.




I do use WITH_META_MODE though, but it shouldn't affect this I think.

I tried clearing out /usr/obj and started a new build, but I still get 
the same error.



Jakob

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Jakob Alvermark]

On 2020-08-25 17:42, Ryan Moeller wrote:


On 8/25/20 9:58 AM, Jakob Alvermark wrote:

Hi,


I updated from r364605 to r364768

'make buildkernel' fails like this:

Building 
/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/zfs/zstd.o
/usr/src/sys/contrib/openzfs/module/zstd/lib/zstd.c:1336:12: fatal 
error: 'immintrin.h' file not found

#  include    /* support for bextr (experimental) */
   ^
1 error generated.
*** Error code 1

Stop.



I'm trying to figure out how to reproduce this. Are you perhaps 
building with GCC?


-Ryan


Nope.

I do use WITH_META_MODE though, but it shouldn't affect this I think.

I tried clearing out /usr/obj and started a new build, but I still get 
the same error.



Jakob

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Danilo Egêa Gondolfo]

On Tue, Aug 25, 2020 at 5:43 PM Matthew Macy  wrote:

> On Tue, Aug 25, 2020 at 9:36 AM Danilo Egêa Gondolfo 
> wrote:
> >
> > On Tue, Aug 25, 2020 at 3:39 AM Matthew Macy  wrote:
> >>
> >> r364746 merged OpenZFS support in to HEAD.
> >>
> >> The change should be transparent unless you want to use new features.
> >> I caution against 'zpool upgrade' for the next few weeks.
> >>
> >> https://svnweb.freebsd.org/base?view=revision=364746
> >>
> >> If you encounter problems please report them to me, Ryan Moeller, and
> -current.
> >> ___
> >> freebsd-hack...@freebsd.org mailing list
> >> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> >> To unsubscribe, send any mail to "
> freebsd-hackers-unsubscr...@freebsd.org"
> >
> >
> > Hi, that is good news.
> >
> > It seems that our boot loader will fail to boot after zpool upgrade. Is
> that a known issue?
>
> No. Unfortunately zstd support was merged in to openzfs very late in
> the CFT. Features needed for read like zstd need to be white listed in
> the loader and added to the support.
>
> -M
>
>
> > I've replicated my setup, root zfs over GELI, in a VM to avoid any
> surprise (phew!), and it booted fine after upgrading the system. Although
> it fails after zpool upgrade (yes, I know you've asked us to be cautious
> with zpool upgrade):
> >
> > ZFS: unsupported feature: org.freebsd:zstd_compress
> > ZFS: pool zroot is not supported
> > ZFS: can't find pool by guid
> >
> > Thank you!
>

Fair enough.

I believe it should be mentioned in the UPDATING file then. It's not clear
that it will happen if one zpool upgrades his/her pools.

Thank you.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Matthew Macy]

On Tue, Aug 25, 2020 at 9:36 AM Danilo Egêa Gondolfo  wrote:
>
> On Tue, Aug 25, 2020 at 3:39 AM Matthew Macy  wrote:
>>
>> r364746 merged OpenZFS support in to HEAD.
>>
>> The change should be transparent unless you want to use new features.
>> I caution against 'zpool upgrade' for the next few weeks.
>>
>> https://svnweb.freebsd.org/base?view=revision=364746
>>
>> If you encounter problems please report them to me, Ryan Moeller, and 
>> -current.
>> ___
>> freebsd-hack...@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
>> To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
>
>
> Hi, that is good news.
>
> It seems that our boot loader will fail to boot after zpool upgrade. Is that 
> a known issue?

No. Unfortunately zstd support was merged in to openzfs very late in
the CFT. Features needed for read like zstd need to be white listed in
the loader and added to the support.

-M


> I've replicated my setup, root zfs over GELI, in a VM to avoid any surprise 
> (phew!), and it booted fine after upgrading the system. Although it fails 
> after zpool upgrade (yes, I know you've asked us to be cautious with zpool 
> upgrade):
>
> ZFS: unsupported feature: org.freebsd:zstd_compress
> ZFS: pool zroot is not supported
> ZFS: can't find pool by guid
>
> Thank you!
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Danilo Egêa Gondolfo]

On Tue, Aug 25, 2020 at 3:39 AM Matthew Macy  wrote:

> r364746 merged OpenZFS support in to HEAD.
>
> The change should be transparent unless you want to use new features.
> I caution against 'zpool upgrade' for the next few weeks.
>
> https://svnweb.freebsd.org/base?view=revision=364746
>
> If you encounter problems please report them to me, Ryan Moeller, and
> -current.
> ___
> freebsd-hack...@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
>

Hi, that is good news.

It seems that our boot loader will fail to boot after zpool upgrade. Is
that a known issue?

I've replicated my setup, root zfs over GELI, in a VM to avoid any surprise
(phew!), and it booted fine after upgrading the system. Although it fails
after zpool upgrade (yes, I know you've asked us to be cautious with zpool
upgrade):

ZFS: unsupported feature: org.freebsd:zstd_compress
ZFS: pool zroot is not supported
ZFS: can't find pool by guid

Thank you!
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Ryan Moeller]

On 8/25/20 9:58 AM, Jakob Alvermark wrote:

Hi,


I updated from r364605 to r364768

'make buildkernel' fails like this:

Building 
/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/zfs/zstd.o
/usr/src/sys/contrib/openzfs/module/zstd/lib/zstd.c:1336:12: fatal 
error: 'immintrin.h' file not found

#  include    /* support for bextr (experimental) */
   ^
1 error generated.
*** Error code 1

Stop.



I'm trying to figure out how to reproduce this. Are you perhaps building 
with GCC?


-Ryan




Best,

Jakob

On 2020-08-25 04:38, Matthew Macy wrote:

r364746 merged OpenZFS support in to HEAD.

The change should be transparent unless you want to use new features.
I caution against 'zpool upgrade' for the next few weeks.

https://svnweb.freebsd.org/base?view=revision=364746

If you encounter problems please report them to me, Ryan Moeller, and 
-current.

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to 
"freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Ryan Moeller]

On 8/25/20 10:43 AM, Bob Bishop wrote:

Hi,


On 25 Aug 2020, at 03:38, Matthew Macy  wrote:

r364746 merged OpenZFS support in to HEAD.

The change should be transparent unless you want to use new features.

For clarity, is autotrim enabled by default? If not, some people will be 
surprised.



It is on by default.

-Ryan




I caution against 'zpool upgrade' for the next few weeks.

https://svnweb.freebsd.org/base?view=revision=364746

If you encounter problems please report them to me, Ryan Moeller, and -current.


--
Bob Bishop
r...@gid.co.uk




___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Bob Bishop]

Hi,

> On 25 Aug 2020, at 03:38, Matthew Macy  wrote:
> 
> r364746 merged OpenZFS support in to HEAD.
> 
> The change should be transparent unless you want to use new features.

For clarity, is autotrim enabled by default? If not, some people will be 
surprised.

> I caution against 'zpool upgrade' for the next few weeks.
> 
> https://svnweb.freebsd.org/base?view=revision=364746
> 
> If you encounter problems please report them to me, Ryan Moeller, and 
> -current.


--
Bob Bishop
r...@gid.co.uk




___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: OpenZFS support merged

[Jakob Alvermark]

Hi,


I updated from r364605 to r364768

'make buildkernel' fails like this:

Building 
/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG/modules/usr/src/sys/modules/zfs/zstd.o
/usr/src/sys/contrib/openzfs/module/zstd/lib/zstd.c:1336:12: fatal 
error: 'immintrin.h' file not found

#  include    /* support for bextr (experimental) */
   ^
1 error generated.
*** Error code 1

Stop.


Best,

Jakob

On 2020-08-25 04:38, Matthew Macy wrote:

r364746 merged OpenZFS support in to HEAD.

The change should be transparent unless you want to use new features.
I caution against 'zpool upgrade' for the next few weeks.

https://svnweb.freebsd.org/base?view=revision=364746

If you encounter problems please report them to me, Ryan Moeller, and -current.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

OpenZFS support merged

[Matthew Macy]

r364746 merged OpenZFS support in to HEAD.

The change should be transparent unless you want to use new features.
I caution against 'zpool upgrade' for the next few weeks.

https://svnweb.freebsd.org/base?view=revision=364746

If you encounter problems please report them to me, Ryan Moeller, and -current.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"