Re: Oversight in /etc/defaults/rc.conf

[Ryan Stone]

On Tue, Jul 12, 2016 at 10:50 AM, RW  wrote:

> Unless I'm misunderstanding the situation. rc.d/iovctl isn't actually
> doing anything by default because of iovctl_files="".
>
> There is an analogy with rc.d/sysctl which runs by default, with a
> an empty sysctl.conf file. This also has no explicit enable entry in
> rc.conf.
>

That is how it is intended to work, and rc.d/sysctl was the inspiration for
that script if memory serves.  I'm not entirely opposed to an iovctl_enable
variable but it seems redundant.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Oversight in /etc/defaults/rc.conf

[Rodney W. Grimes]

> On 07/12/16 13:27, Glen Barber wrote:
> > On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote:
> >> I just upgraded my main machine to 11-STABLE.  Things are mostly working
> >> fine -- however I did notice that the new iovctl rc script is apparently
> >> enabled by default.  That seems like a trivial omission:
> >>
> >> Index: etc/defaults/rc.conf
> >> ===
> >> --- etc/defaults/rc.conf   (revision 302482)
> >> +++ etc/defaults/rc.conf   (working copy)
> >> @@ -695,6 +695,7 @@
> >>  rctl_enable="YES" # Load rctl(8) rules on boot
> >>  rctl_rules="/etc/rctl.conf"   # rctl(8) ruleset. See rctl.conf(5).
> >>
> >> +iovctl_enable="NO"
    Missing explination of knob
> >>  iovctl_files=""   # Config files for iovctl(8)
> >>
> >>  ##
> >>
> > 
> > I'm not sure I understand.  Is there a functional and/or performance
> > impact with it enabled by default?  (Note, I don't disable it in my
> > rc.conf, and there is no /dev/iov/* on my system.)
> 
> I'm not religious about it being turned off per se.  More that it should
> have a clearly defined on/off state shown in the defaults.
> 
> I went for 'off' following the general principle that rc.conf items
> should mostly be off by default and require specific action to enable.
> Yes, there are exceptions to this rule, but I see no particular reason
> that iovctl should be one.  What's the advantage to turning it on by
> default on every FreeBSD installation?
> 
> However, even if it's felt it should be enabled everywhere, then
> shouldn't /etc/defaults/rc.conf have:
> 
> iovctl_enable="YES"

What ever is resolved you also need to add a # comment describing it.

> 
> instead?
> 
>   Cheers,
> 
>   Matthew

-- 
Rod Grimes rgri...@freebsd.org
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Oversight in /etc/defaults/rc.conf

[RW]

On Tue, 12 Jul 2016 15:10:43 +0100
Matthew Seaman wrote:


> I'm not religious about it being turned off per se.  More that it
> should have a clearly defined on/off state shown in the defaults.
> 
> I went for 'off' following the general principle that rc.conf items
> should mostly be off by default and require specific action to enable.
> Yes, there are exceptions to this rule, but I see no particular reason
> that iovctl should be one.  What's the advantage to turning it on by
> default on every FreeBSD installation?

Unless I'm misunderstanding the situation. rc.d/iovctl isn't actually
doing anything by default because of iovctl_files="".

There is an analogy with rc.d/sysctl which runs by default, with a
an empty sysctl.conf file. This also has no explicit enable entry in
rc.conf. 

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Oversight in /etc/defaults/rc.conf

[Glen Barber]

On Tue, Jul 12, 2016 at 03:10:43PM +0100, Matthew Seaman wrote:
> On 07/12/16 13:27, Glen Barber wrote:
> > On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote:
> >> I just upgraded my main machine to 11-STABLE.  Things are mostly working
> >> fine -- however I did notice that the new iovctl rc script is apparently
> >> enabled by default.  That seems like a trivial omission:
> >>
> >> Index: etc/defaults/rc.conf
> >> ===
> >> --- etc/defaults/rc.conf   (revision 302482)
> >> +++ etc/defaults/rc.conf   (working copy)
> >> @@ -695,6 +695,7 @@
> >>  rctl_enable="YES" # Load rctl(8) rules on boot
> >>  rctl_rules="/etc/rctl.conf"   # rctl(8) ruleset. See rctl.conf(5).
> >>
> >> +iovctl_enable="NO"
> >>  iovctl_files=""   # Config files for iovctl(8)
> >>
> >>  ##
> >>
> > 
> > I'm not sure I understand.  Is there a functional and/or performance
> > impact with it enabled by default?  (Note, I don't disable it in my
> > rc.conf, and there is no /dev/iov/* on my system.)
> 
> I'm not religious about it being turned off per se.  More that it should
> have a clearly defined on/off state shown in the defaults.
> 

Ah, this was my confusion.  Thank you for clarifying.

> I went for 'off' following the general principle that rc.conf items
> should mostly be off by default and require specific action to enable.
> Yes, there are exceptions to this rule, but I see no particular reason
> that iovctl should be one.  What's the advantage to turning it on by
> default on every FreeBSD installation?
> 
> However, even if it's felt it should be enabled everywhere, then
> shouldn't /etc/defaults/rc.conf have:
> 
> iovctl_enable="YES"
> 
> instead?
> 

I'm not pro -vs- con either way.  But I think this should be resolved in
head first, and MFC'd to stable/11, as this isn't something I think
should be in the "checklist" when branching.  I think you are really
pointing out a different "bug" here.

Glen



signature.asc
Description: PGP signature

Re: Oversight in /etc/defaults/rc.conf

[Matthew Seaman]

On 07/12/16 13:27, Glen Barber wrote:
> On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote:
>> I just upgraded my main machine to 11-STABLE.  Things are mostly working
>> fine -- however I did notice that the new iovctl rc script is apparently
>> enabled by default.  That seems like a trivial omission:
>>
>> Index: etc/defaults/rc.conf
>> ===
>> --- etc/defaults/rc.conf (revision 302482)
>> +++ etc/defaults/rc.conf (working copy)
>> @@ -695,6 +695,7 @@
>>  rctl_enable="YES"   # Load rctl(8) rules on boot
>>  rctl_rules="/etc/rctl.conf" # rctl(8) ruleset. See rctl.conf(5).
>>
>> +iovctl_enable="NO"
>>  iovctl_files="" # Config files for iovctl(8)
>>
>>  ##
>>
> 
> I'm not sure I understand.  Is there a functional and/or performance
> impact with it enabled by default?  (Note, I don't disable it in my
> rc.conf, and there is no /dev/iov/* on my system.)

I'm not religious about it being turned off per se.  More that it should
have a clearly defined on/off state shown in the defaults.

I went for 'off' following the general principle that rc.conf items
should mostly be off by default and require specific action to enable.
Yes, there are exceptions to this rule, but I see no particular reason
that iovctl should be one.  What's the advantage to turning it on by
default on every FreeBSD installation?

However, even if it's felt it should be enabled everywhere, then
shouldn't /etc/defaults/rc.conf have:

iovctl_enable="YES"

instead?

Cheers,

Matthew





signature.asc
Description: OpenPGP digital signature

Re: Oversight in /etc/defaults/rc.conf

[Allan Jude]

On 2016-07-12 08:27, Glen Barber wrote:
> On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote:
>> I just upgraded my main machine to 11-STABLE.  Things are mostly working
>> fine -- however I did notice that the new iovctl rc script is apparently
>> enabled by default.  That seems like a trivial omission:
>>
>> Index: etc/defaults/rc.conf
>> ===
>> --- etc/defaults/rc.conf (revision 302482)
>> +++ etc/defaults/rc.conf (working copy)
>> @@ -695,6 +695,7 @@
>>  rctl_enable="YES"   # Load rctl(8) rules on boot
>>  rctl_rules="/etc/rctl.conf" # rctl(8) ruleset. See rctl.conf(5).
>>
>> +iovctl_enable="NO"
>>  iovctl_files="" # Config files for iovctl(8)
>>
>>  ##
>>
> 
> I'm not sure I understand.  Is there a functional and/or performance
> impact with it enabled by default?  (Note, I don't disable it in my
> rc.conf, and there is no /dev/iov/* on my system.)
> 
> Glen
> 

If the service should be on by default, then it should have
iovctl_enable="YES" in etc/defaults/rc.conf

One way or the other, a default should be set.

-- 
Allan Jude
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Oversight in /etc/defaults/rc.conf

[Glen Barber]

On Tue, Jul 12, 2016 at 07:17:19AM +0100, Matthew Seaman wrote:
> I just upgraded my main machine to 11-STABLE.  Things are mostly working
> fine -- however I did notice that the new iovctl rc script is apparently
> enabled by default.  That seems like a trivial omission:
> 
> Index: etc/defaults/rc.conf
> ===
> --- etc/defaults/rc.conf  (revision 302482)
> +++ etc/defaults/rc.conf  (working copy)
> @@ -695,6 +695,7 @@
>  rctl_enable="YES"# Load rctl(8) rules on boot
>  rctl_rules="/etc/rctl.conf"  # rctl(8) ruleset. See rctl.conf(5).
> 
> +iovctl_enable="NO"
>  iovctl_files=""  # Config files for iovctl(8)
> 
>  ##
> 

I'm not sure I understand.  Is there a functional and/or performance
impact with it enabled by default?  (Note, I don't disable it in my
rc.conf, and there is no /dev/iov/* on my system.)

Glen



signature.asc
Description: PGP signature

Oversight in /etc/defaults/rc.conf

[Matthew Seaman]

I just upgraded my main machine to 11-STABLE.  Things are mostly working
fine -- however I did notice that the new iovctl rc script is apparently
enabled by default.  That seems like a trivial omission:

Index: etc/defaults/rc.conf
===
--- etc/defaults/rc.conf(revision 302482)
+++ etc/defaults/rc.conf(working copy)
@@ -695,6 +695,7 @@
 rctl_enable="YES"  # Load rctl(8) rules on boot
 rctl_rules="/etc/rctl.conf"# rctl(8) ruleset. See rctl.conf(5).

+iovctl_enable="NO"
 iovctl_files=""# Config files for iovctl(8)

 ##

Cheers,

Matthew





signature.asc
Description: OpenPGP digital signature