Re: [MFC REQUEST] Filename completion in sh(1)
jhell jh...@dataix.net writes: Because SVN in both our patches for tab completion missed filecomplete.h and filecomplete.c [...] the previous patches from des@ myself will break world builds. Speak for yourself. Both files are present in the patch I posted, and I tested it (make toolchain, which builds both libedit and sh) before I posted it. DES -- Dag-Erling Smørgrav - d...@des.no ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
2010/6/21 Dag-Erling Smørgrav d...@des.no: jhell jh...@dataix.net writes: Because SVN in both our patches for tab completion missed filecomplete.h and filecomplete.c [...] the previous patches from des@ myself will break world builds. Speak for yourself. Both files are present in the patch I posted, and I tested it (make toolchain, which builds both libedit and sh) before I posted it. I thank the both of you! I'll test this further today on my 8-STABLE boxes :) -Brandon ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
On 06/21/2010 09:12, Dag-Erling Smørgrav wrote: jhell jh...@dataix.net writes: Sorry but he only mention of filecomplete in your patch is in this section. That is exactly the same in the patch I had originally generated using SVN. Umm, the copy I have on my disk has those files. Just to be sure, I just generated a new diff from the tree I tested it in. DES I can forward the original message If you would like but I think its just a waste of time, it does not have them files in there, verify your sent folder. I do see that your new patch does this is a good thing ;) Since those files do not exist in stable/8 I believe the error was running ( cd /usr/src svn diff %%ARGS_HERE%% ) which I repeated more then once and the files disapear from the diff. The diff you sent in the original attachment had matched mine all except the order in which the files appeared. ANYWAY... two new correct patches now exist on the list so no worries. -- jhell ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
-Brandon Oh, I see. The diff doesn't include the change(s) to histedit.h I would be very interested in a diff for FreeBSD 8.1 Sam Fourman Jr. http://www.fourmannetworks.com/ ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
On 06/16/2010 02:20, Sam Fourman Jr. wrote: -Brandon Oh, I see. The diff doesn't include the change(s) to histedit.h I would be very interested in a diff for FreeBSD 8.1 Sam Fourman Jr. http://www.fourmannetworks.com/ Just got home, So Ill be working on getting this put together over the next few minutes and replying to this thread with a go or no go depending on the outcome and posting the patch. Regards, -- jhell ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
On 06/16/2010 07:53, jhell wrote: On 06/16/2010 07:29, jhell wrote: Just got home, So Ill be working on getting this put together over the next few minutes and replying to this thread with a go or no go depending on the outcome and posting the patch. Here it is: cd /usr/src patch /path/to/patchfile cd /usr/src/include make obj make depend make includes make make install cd /usr/src/lib/libedit make obj make depend make includes make make install cd /usr/src/bin/sh make obj make depend make includes make make install exec /bin/sh cd /[TAB][TAB] Report any inconsistencies to this thread please. Good Luck Regards, In case the patch did not make it, I have uploaded it here: http://bit.ly/a9i7x9 Regards, -- jhell ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
I should probably also mention that it does not have username completion the the following form ~userna[TAB][TAB] But does complete ~/[TAB][TAB] from your own home directory. And if you spell out the username as ~username/[TAB][TAB] that will also work. So do not be surprised. -- jhell ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
On 06/15/2010 22:00, jhell wrote: On 06/15/2010 21:14, Brandon Gooch wrote: I discovered a few moments ago that filename completion had been committed to HEAD[1]!!! This is a (seemingly) small, yet VERY useful addition, and, of course I'm so grateful to Guy Yur and Jilles for getting this into the tree :) I would like to make an official request that this feature be MFC'd to 8-STABLE as soon as reasonably possible. Again, my thanks to you both for your work! -Brandon [1] http://svn.freebsd.org/viewvc/base?view=revisionrevision=209221 Here is a diff from stable/8/bin/sh r209146 - head/bin/sh. This is quite a large difference among the two with the following diffstats. 44 files changed, 1214 insertions(+), 728 deletions(-) This is untested, use at your own risk. Actually, I lied. I have just tested it and it does not compile for the following errors: /usr/src/bin/sh/histedit.c: In function 'histedit': /usr/src/bin/sh/histedit.c:124: error: '_el_fn_sh_complete' undeclared (first use in this function) /usr/src/bin/sh/histedit.c:124: error: (Each undeclared identifier is reported only once /usr/src/bin/sh/histedit.c:124: error: for each function it appears in.) But I do not have time to look into this further until tommorow. Regards, -- jhell ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
On Tue, Jun 15, 2010 at 9:08 PM, jhell jh...@dataix.net wrote: On 06/15/2010 22:00, jhell wrote: On 06/15/2010 21:14, Brandon Gooch wrote: I discovered a few moments ago that filename completion had been committed to HEAD[1]!!! This is a (seemingly) small, yet VERY useful addition, and, of course I'm so grateful to Guy Yur and Jilles for getting this into the tree :) I would like to make an official request that this feature be MFC'd to 8-STABLE as soon as reasonably possible. Again, my thanks to you both for your work! -Brandon [1] http://svn.freebsd.org/viewvc/base?view=revisionrevision=209221 Here is a diff from stable/8/bin/sh r209146 - head/bin/sh. This is quite a large difference among the two with the following diffstats. 44 files changed, 1214 insertions(+), 728 deletions(-) This is untested, use at your own risk. Actually, I lied. I have just tested it and it does not compile for the following errors: /usr/src/bin/sh/histedit.c: In function 'histedit': /usr/src/bin/sh/histedit.c:124: error: '_el_fn_sh_complete' undeclared (first use in this function) /usr/src/bin/sh/histedit.c:124: error: (Each undeclared identifier is reported only once /usr/src/bin/sh/histedit.c:124: error: for each function it appears in.) But I do not have time to look into this further until tommorow. Thanks for this jhell! It appears that a C header file is missing from /usr/include; the function declaration is histedit.h. No problem, just `make install` in /usr/src/include and it should build. -Brandon ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: [MFC REQUEST] Filename completion in sh(1)
On Tue, Jun 15, 2010 at 9:17 PM, Brandon Gooch jamesbrandongo...@gmail.com wrote: On Tue, Jun 15, 2010 at 9:08 PM, jhell jh...@dataix.net wrote: On 06/15/2010 22:00, jhell wrote: On 06/15/2010 21:14, Brandon Gooch wrote: I discovered a few moments ago that filename completion had been committed to HEAD[1]!!! This is a (seemingly) small, yet VERY useful addition, and, of course I'm so grateful to Guy Yur and Jilles for getting this into the tree :) I would like to make an official request that this feature be MFC'd to 8-STABLE as soon as reasonably possible. Again, my thanks to you both for your work! -Brandon [1] http://svn.freebsd.org/viewvc/base?view=revisionrevision=209221 Here is a diff from stable/8/bin/sh r209146 - head/bin/sh. This is quite a large difference among the two with the following diffstats. 44 files changed, 1214 insertions(+), 728 deletions(-) This is untested, use at your own risk. Actually, I lied. I have just tested it and it does not compile for the following errors: /usr/src/bin/sh/histedit.c: In function 'histedit': /usr/src/bin/sh/histedit.c:124: error: '_el_fn_sh_complete' undeclared (first use in this function) /usr/src/bin/sh/histedit.c:124: error: (Each undeclared identifier is reported only once /usr/src/bin/sh/histedit.c:124: error: for each function it appears in.) But I do not have time to look into this further until tommorow. Thanks for this jhell! It appears that a C header file is missing from /usr/include; the function declaration is histedit.h. No problem, just `make install` in /usr/src/include and it should build. -Brandon Oh, I see. The diff doesn't include the change(s) to histedit.h :( oh well, thanks anyway! -Brandon ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
