ata problem with 13/10/2003 current

2003-10-14 Thread Matteo Riondato
After having update my -CURRENT box to yesterday afternoon (Central
Europe Time) sources, I can't get it to boot. It stops probing ata1:
GEOM: create disk ad0 dp=0xc4536a70
ad0: 57259MB MAXTOR 6L060J3 [116336/16/63] at ata0-master UDMA133
GEOM: create disk ad1 dp=0xc4915a70
ad1: 38172MB QUANTUM FIREBALLP AS40.0 [77557/16/63] at ata0-slave \
UDMA100 
ata1: resetting devices ..
acd0: FAILURE - SETFEATURES status=51 READY,DSC,ERROR error=4ABORTED
done
acd0: FAILURE - SETFEATURES device lockup-removed

And it stops here.

On ata1 there are a Liteon CD-ReWriter 48x12x48x (acd0)
and a LG DVD-ROM Drive DRD-8160B (acd1)

I never had problem with ATAng before, so it is probably related to a
recent commit.

Best Regards

--
Rionda aka Matteo Riondato
GUFI Staff Member (http://www.gufi.org)


___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: ata problem with 13/10/2003 current

2003-10-14 Thread Soren Schmidt
It seems Matteo Riondato wrote:
 After having update my -CURRENT box to yesterday afternoon (Central
 Europe Time) sources, I can't get it to boot. It stops probing ata1:
 GEOM: create disk ad0 dp=0xc4536a70
 ad0: 57259MB MAXTOR 6L060J3 [116336/16/63] at ata0-master UDMA133
 GEOM: create disk ad1 dp=0xc4915a70
 ad1: 38172MB QUANTUM FIREBALLP AS40.0 [77557/16/63] at ata0-slave \
 UDMA100 
 ata1: resetting devices ..
 acd0: FAILURE - SETFEATURES status=51 READY,DSC,ERROR error=4ABORTED
 done
 acd0: FAILURE - SETFEATURES device lockup-removed
 
 And it stops here.
 
 On ata1 there are a Liteon CD-ReWriter 48x12x48x (acd0)
 and a LG DVD-ROM Drive DRD-8160B (acd1)
 
 I never had problem with ATAng before, so it is probably related to a
 recent commit.

Could you try this patch please:

Index: ata-queue.c
===
RCS file: /home/ncvs/src/sys/dev/ata/ata-queue.c,v
retrieving revision 1.8
diff -u -r1.8 ata-queue.c
--- ata-queue.c 12 Oct 2003 12:38:03 -  1.8
+++ ata-queue.c 13 Oct 2003 13:05:01 -
@@ -315,20 +315,21 @@
 static void
 ata_timeout(struct ata_request *request)
 {
+struct ata_channel *ch = request-device-channel;
+int quiet = request-flags  ATA_R_QUIET;
+
 /* clear timeout etc */
 request-timeout_handle.callout = NULL;
-#if 0
-/* call interrupt to try finish up the command */
-request-device-channel-hw.interrupt(request-device-channel);
 
-if (request-device-channel-running == NULL) {
-   if (!(request-flags  ATA_R_QUIET))
+/* call hw.interrupt to try finish up the command */
+ch-hw.interrupt(request-device-channel);
+if (ch-running != request) {
+   if (!quiet)
ata_prtdev(request-device,
   WARNING - %s recovered from missing interrupt\n,
   ata_cmd2str(request));
return;
 }
-#endif
 
 /* if this was a DMA request stop the engine to be on the safe side */
 if (request-flags  ATA_R_DMA) {
-Søren
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: ata problem with 13/10/2003 current

2003-10-14 Thread Matteo Riondato
Il Mar, 2003-10-14 alle 15:09, Soren Schmidt ha scritto:
 It seems Matteo Riondato wrote:
  
  I never had problem with ATAng before, so it is probably related to a
  recent commit.
 
 Could you try this patch please:I

 Index: ata-queue.c
 ===

I cannot patch my system:
kaiser# cd /usr/src/sys/dev/ata/
kaiser# patch  /home/rionda/ata-patch.patch 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--
|Index: ata-queue.c
|===
|RCS file: /home/ncvs/src/sys/dev/ata/ata-queue.c,v
|retrieving revision 1.8
|diff -u -r1.8 ata-queue.c
|--- ata-queue.c 12 Oct 2003 12:38:03 -  1.8
|+++ ata-queue.c 13 Oct 2003 13:05:01 -
--
Patching file ata-queue.c using Plan A...
Hunk #1 failed at 315.
1 out of 1 hunks failed--saving rejects to ata-queue.c.rej
done
kaiser#

 -Søren

Regards
-- 
Rionda aka Matteo Riondato
G.U.F.I Staff Member (http://www.gufi.org)
BSD-FAQ-it Main Developer (http://www.gufi.org/~rionda)
GPG key at: http://www.riondabsd.net/riondagpg.asc
Sent from: kaiser.sig11.org running FreeBSD-5.1-CURRENT
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: ata problem with 13/10/2003 current

2003-10-14 Thread Rob MacGregor
From: Soren Schmidt [EMAIL PROTECTED]

Could you try this patch please:

Index: ata-queue.c
===
RCS file: /home/ncvs/src/sys/dev/ata/ata-queue.c,v
retrieving revision 1.8
diff -u -r1.8 ata-queue.c
--- ata-queue.c 12 Oct 2003 12:38:03 -  1.8
+++ ata-queue.c 13 Oct 2003 13:05:01 -
---SNIP---

Happy to say that this patch fixes the resetting devices... problem I'd 
encountered.

Thanks.

--
Rob  |  What part of no was it you didn't understand?
_
Sign-up for a FREE BT Broadband connection today! 
http://www.msn.co.uk/specials/btbroadband

___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: ata problem with 13/10/2003 current

2003-10-14 Thread Matteo Riondato
Il Mar, 2003-10-14 alle 15:09, Soren Schmidt ha scritto:
 It seems Matteo Riondato wrote:
  After having update my -CURRENT box to yesterday afternoon (Central
  Europe Time) sources, I can't get it to boot. It stops probing ata1:
  GEOM: create disk ad0 dp=0xc4536a70
  
  I never had problem with ATAng before, so it is probably related to a
  recent commit.
 
 Could you try this patch please:
 
 Index: ata-queue.c
 =

It works perfectly and solves my problem.
Thanks.
Do you plan to commit it?
Best Regards

-- 
Rionda aka Matteo Riondato
G.U.F.I Staff Member (http://www.gufi.org)
BSD-FAQ-it Main Developer (http://www.gufi.org/~rionda)
GPG key at: http://www.riondabsd.net/riondagpg.asc
Sent from: kaiser.sig11.org running FreeBSD-5.1-CURRENT
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: ata problem with 13/10/2003 current

2003-10-14 Thread Soren Schmidt
It seems Matteo Riondato wrote:
 
 It works perfectly and solves my problem.
 Thanks.
 Do you plan to commit it?

Already done :)

-Søren
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: ata problem with 13/10/2003 current

2003-10-14 Thread Tomi Vainio - Sun Finland
Hi,

I'd like to give a try for this new code solving lost interrupts but
current code still doesn't find all my slave disks.  Is there anything
what might help on this?

  Tomppa
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]