Re: build fails post SVN r304026

2016-08-13 Thread Navdeep Parhar
On Sat, Aug 13, 2016 at 08:30:09PM +, Rick Macklem wrote:
> Lev Serebryakov wrote:
> >On 13.08.2016 16:54, Michael Butler wrote:
> >
> >> Is anyone else seeing this?
> >  Yes, I've posted message to fs@, as it is r304026 for sure (and author
> >was CC:ed too).
> Should be fixed now. Sorry about the breakage. I didn't realize the old
> nfsstat.c wouldn't build with the kernel source patch. (The old nfsstat
> binary does still work, as required to avoid a POLA violation.)
> 
> Anyhow, the changes to nfsstat.c are now committed to head.

I still see errors in nfsstat during buildworld (this is r304065):

Building /usr/obj/usr/src/usr.bin/nfsstat/nfsstat.full
nfsstat.o: In function `compute_new_stats':
/usr/src/usr.bin/nfsstat/nfsstat.c:506: undefined reference to
`devstat_compute_etime'
/usr/src/usr.bin/nfsstat/nfsstat.c:532: undefined reference to
`devstat_compute_etime'
/usr/src/usr.bin/nfsstat/nfsstat.c:506: undefined reference to
`devstat_compute_etime'
/usr/src/usr.bin/nfsstat/nfsstat.c:532: undefined reference to
`devstat_compute_etime'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1

Regards,
Navdeep
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: build fails post SVN r304026

2016-08-13 Thread Rick Macklem
Lev Serebryakov wrote:
>On 13.08.2016 16:54, Michael Butler wrote:
>
>> Is anyone else seeing this?
>  Yes, I've posted message to fs@, as it is r304026 for sure (and author
>was CC:ed too).
Should be fixed now. Sorry about the breakage. I didn't realize the old
nfsstat.c wouldn't build with the kernel source patch. (The old nfsstat
binary does still work, as required to avoid a POLA violation.)

Anyhow, the changes to nfsstat.c are now committed to head.

Sorry about the breakage, rick

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: build fails post SVN r304026

2016-08-13 Thread Lev Serebryakov
On 13.08.2016 16:54, Michael Butler wrote:

> Is anyone else seeing this?
  Yes, I've posted message to fs@, as it is r304026 for sure (and author
was CC:ed too).


-- 
// Lev Serebryakov AKA Black Lion



signature.asc
Description: OpenPGP digital signature


Re: build fails post SVN r304026

2016-08-13 Thread David Wolfskill
On Sat, Aug 13, 2016 at 09:54:02AM -0400, Michael Butler wrote:
> Is anyone else seeing this?
> 
> ===> usr.bin/nfsstat (all)
> Building /usr/obj/usr/src/usr.bin/nfsstat/nfsstat.o
> /usr/src/usr.bin/nfsstat/nfsstat.c:301:4: error: array index 72 is past
> the end of the array (which contains 49 elements) [-Werror,-Warray-bounds]
> ext_nfsstats.srvrpccnt[NFSV4OP_SYMLINK],
> 

I am, as of r304040 (src upgrading from r304004), yes.

Peace,
david
-- 
David H. Wolfskill  da...@catwhisker.org
Those who would murder in the name of God or prophet are blasphemous cowards.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.


signature.asc
Description: PGP signature


build fails post SVN r304026

2016-08-13 Thread Michael Butler
Is anyone else seeing this?

===> usr.bin/nfsstat (all)
Building /usr/obj/usr/src/usr.bin/nfsstat/nfsstat.o
/usr/src/usr.bin/nfsstat/nfsstat.c:301:4: error: array index 72 is past
the end of the array (which contains 49 elements) [-Werror,-Warray-bounds]
ext_nfsstats.srvrpccnt[NFSV4OP_SYMLINK],
^  ~~~
/usr/obj/usr/src/tmp/usr/include/fs/nfs/nfsport.h:457:2: note: array
'srvrpccnt' declared here
int srvrpccnt[NFSV4OP_NOPS + NFSV4OP_FAKENOPS];
^
/usr/src/usr.bin/nfsstat/nfsstat.c:302:4: error: array index 73 is past
the end of the array (which contains 49 elements) [-Werror,-Warray-bounds]
ext_nfsstats.srvrpccnt[NFSV4OP_MKDIR],
^  ~
/usr/obj/usr/src/tmp/usr/include/fs/nfs/nfsport.h:457:2: note: array
'srvrpccnt' declared here
int srvrpccnt[NFSV4OP_NOPS + NFSV4OP_FAKENOPS];
^
/usr/src/usr.bin/nfsstat/nfsstat.c:303:4: error: array index 74 is past
the end of the array (which contains 49 elements) [-Werror,-Warray-bounds]
ext_nfsstats.srvrpccnt[NFSV4OP_RMDIR],
^  ~
/usr/obj/usr/src/tmp/usr/include/fs/nfs/nfsport.h:457:2: note: array
'srvrpccnt' declared here
int srvrpccnt[NFSV4OP_NOPS + NFSV4OP_FAKENOPS];

 [ .. ]

imb
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"