Re: builworld fails due to error in af_inet.c
On Mon, 22 May 2023 16:03:37 +0100 Alexander Chernikov wrote: > Sorry for the breakage (and thanks for markj@ for the prompt fix) > No big deal. It was easy to find the cause and temporarily fix it. > > On 22 May 2023, at 16:00, Gary Jennejohn wrote: > > > > I just ran buildworld using the latest current source. > > > > It dies due to this error in line 385 of /usr/src/sbin/ifconfig/af_inet.c: > > > > static void > > warn_nomask(ifflags) > > > > The compiler really doesn't like not seeing a type for ifflags and bails > > out as the result. > > > > Strangely enough, in_proc() a few lines later clearly has int ifflags in > > its list of variables. > > > > Setting ifflags to int in warn_nomask() fixes the build. > > > > Wasn't this compile tested before it was committed? > It was & it didn't yell on my setup. > That's interesting. Maybe I have some different settings. But the error message was the standard one about badly formed prototypes. -- Gary Jennejohn
Re: builworld fails due to error in af_inet.c
Sorry for the breakage (and thanks for markj@ for the prompt fix) > On 22 May 2023, at 16:00, Gary Jennejohn wrote: > > I just ran buildworld using the latest current source. > > It dies due to this error in line 385 of /usr/src/sbin/ifconfig/af_inet.c: > > static void > warn_nomask(ifflags) > > The compiler really doesn't like not seeing a type for ifflags and bails > out as the result. > > Strangely enough, in_proc() a few lines later clearly has int ifflags in > its list of variables. > > Setting ifflags to int in warn_nomask() fixes the build. > > Wasn't this compile tested before it was committed? It was & it didn’t yell on my setup. > > -- > Gary Jennejohn >
Re: builworld fails due to error in af_inet.c
On Mon, 22 May 2023 15:00:00 + Gary Jennejohn wrote: > I just ran buildworld using the latest current source. > > It dies due to this error in line 385 of /usr/src/sbin/ifconfig/af_inet.c: > > static void > warn_nomask(ifflags) > > The compiler really doesn't like not seeing a type for ifflags and bails > out as the result. > > Strangely enough, in_proc() a few lines later clearly has int ifflags in > its list of variables. > > Setting ifflags to int in warn_nomask() fixes the build. > > Wasn't this compile tested before it was committed? > Woops! It turns out that my source was NOT fully up to date. I just saw that af_inet.c was fixed. Sorry for the noise. -- Gary Jennejohn
builworld fails due to error in af_inet.c
I just ran buildworld using the latest current source. It dies due to this error in line 385 of /usr/src/sbin/ifconfig/af_inet.c: static void warn_nomask(ifflags) The compiler really doesn't like not seeing a type for ifflags and bails out as the result. Strangely enough, in_proc() a few lines later clearly has int ifflags in its list of variables. Setting ifflags to int in warn_nomask() fixes the build. Wasn't this compile tested before it was committed? -- Gary Jennejohn
