current jail panic II

[Bart Thate]

Hi again ;)

this patch ..

http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/kern/uipc_socket.c.diff?r1=1.72r2=1.73

makes my kernel panic.

a snippet from gdb -k ..

#10 0xc01705b5 in socreate (dom=28, aso=0xca35df20, type=2, proto=0,
p=0xc9959be0) at ../../kern/uipc_socket.c:138
138 if (p-p_prison  jail_socket_unixiproute_only 
(kgdb) list
133 if (proto)
134 prp = pffindproto(dom, proto, type);
135 else
136 prp = pffindtype(dom, type);
137
138 if (p-p_prison  jail_socket_unixiproute_only 
139 prp-pr_domain-dom_family != PF_LOCAL 
140 prp-pr_domain-dom_family != PF_INET 
141 prp-pr_domain-dom_family != PF_ROUTE) {
142 return (EPROTONOSUPPORT);
(kgdb) print prp
$1 = (struct protosw *) 0x0

prp is 0x0 but is not checked upon. The check if prp ==0 is done 2 lines
further on. 

  if (prp == 0 || prp-pr_usrreqs-pru_attach == 0)
return (EPROTONOSUPPORT);


since both if-s return EPROTONOSUPPORT the fix is to move the prp == 0 if 
in front of the patches lines. 

Should i send-pr this?


Grtx,

Bart



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Re: current jail panic II

[Jeroen Ruigrok van der Werven]

-On [2613 17:08], Bart Thate ([EMAIL PROTECTED]) wrote:

prp is 0x0 but is not checked upon. The check if prp ==0 is done 2 lines
further on. 

  if (prp == 0 || prp-pr_usrreqs-pru_attach == 0)
return (EPROTONOSUPPORT);


since both if-s return EPROTONOSUPPORT the fix is to move the prp == 0 if 
in front of the patches lines. 

I committed a fix to CURRENT.

Can you verify if this stops the panics you're seeing?

Thanks,

-- 
Jeroen Ruigrok van der Werven  Network- and systemadministrator
[EMAIL PROTECTED]VIA Net.Works The Netherlands
BSD: Technical excellence at its best  http://www.via-net-works.nl
Love conquers all...


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message