Re: e179d973 insta-panics in nl_send_one()
On 1/9/24 22:09, Gleb Smirnoff wrote: On Mon, Jan 08, 2024 at 10:40:52AM +0100, Jakob Alvermark wrote: J> > > --- trap 0xc, rip = 0x...f80d97b78, rsp = 0x... J> > > nl_send_one() at nl_send_one+0x18/frame 0xf J> > > nl_send_group() at nl_send_group+0x1bc/frame 0xf... J> > > _nlmsg_flush() at _nlmsg_flush+0x37/frame 0xf... J> > > rtnl_handle_ifevent() + 0xa1 J> > > if_attach_internal + 0x3df J> > > J> > > I have a picture of the full panic if desired... J> > > J> > > -- J> > > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 J> > > p...@freebsd.org | TCP/IP since RFC 956 J> > > FreeBSD committer | BSD since 4.3-tahoe J> > > Never attribute to malice what can adequately be explained by incompetence. J> J> I get the same panic, with kernel and userland both installed. Sorry, that was my failure. Fix pushed and now working on a regression test that would cover Netlink group writers. It works now, thanks! Jakob
Re: e179d973 insta-panics in nl_send_one()
On Mon, Jan 08, 2024 at 10:40:52AM +0100, Jakob Alvermark wrote: J> > > --- trap 0xc, rip = 0x...f80d97b78, rsp = 0x... J> > > nl_send_one() at nl_send_one+0x18/frame 0xf J> > > nl_send_group() at nl_send_group+0x1bc/frame 0xf... J> > > _nlmsg_flush() at _nlmsg_flush+0x37/frame 0xf... J> > > rtnl_handle_ifevent() + 0xa1 J> > > if_attach_internal + 0x3df J> > > J> > > I have a picture of the full panic if desired... J> > > J> > > -- J> > > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 J> > > p...@freebsd.org | TCP/IP since RFC 956 J> > > FreeBSD committer | BSD since 4.3-tahoe J> > > Never attribute to malice what can adequately be explained by incompetence. J> J> I get the same panic, with kernel and userland both installed. Sorry, that was my failure. Fix pushed and now working on a regression test that would cover Netlink group writers. -- Gleb Smirnoff
Re: e179d973 insta-panics in nl_send_one()
On 1/6/24 23:34, Poul-Henning Kamp wrote: Addendum: I have only installed the new kernel, userland is still from dec18. (Even if that is the cause, we should not panic on bad syscall args.) Poul-Henning Kamp writes: With fresh current: commit e179d9739b1438ae9acb958f80a983eff7e3dce9 Author: Michael Tuexen Date: Sat Jan 6 21:31:46 2024 +0100 tcpsso: support TIME_WAIT state I get an insta-panic as soon as any network interface comes up: --- trap 0xc, rip = 0x...f80d97b78, rsp = 0x... nl_send_one() at nl_send_one+0x18/frame 0xf nl_send_group() at nl_send_group+0x1bc/frame 0xf... _nlmsg_flush() at _nlmsg_flush+0x37/frame 0xf... rtnl_handle_ifevent() + 0xa1 if_attach_internal + 0x3df I have a picture of the full panic if desired... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 p...@freebsd.org | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. I get the same panic, with kernel and userland both installed. Jakob
Re: e179d973 insta-panics in nl_send_one()
Addendum: I have only installed the new kernel, userland is still from dec18. (Even if that is the cause, we should not panic on bad syscall args.) Poul-Henning Kamp writes: > With fresh current: > > commit e179d9739b1438ae9acb958f80a983eff7e3dce9 > Author: Michael Tuexen > Date: Sat Jan 6 21:31:46 2024 +0100 > > tcpsso: support TIME_WAIT state > > I get an insta-panic as soon as any network interface comes up: > > --- trap 0xc, rip = 0x...f80d97b78, rsp = 0x... > nl_send_one() at nl_send_one+0x18/frame 0xf > nl_send_group() at nl_send_group+0x1bc/frame 0xf... > _nlmsg_flush() at _nlmsg_flush+0x37/frame 0xf... > rtnl_handle_ifevent() + 0xa1 > if_attach_internal + 0x3df > > I have a picture of the full panic if desired... > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > p...@freebsd.org | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 p...@freebsd.org | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
e179d973 insta-panics in nl_send_one()
With fresh current: commit e179d9739b1438ae9acb958f80a983eff7e3dce9 Author: Michael Tuexen Date: Sat Jan 6 21:31:46 2024 +0100 tcpsso: support TIME_WAIT state I get an insta-panic as soon as any network interface comes up: --- trap 0xc, rip = 0x...f80d97b78, rsp = 0x... nl_send_one() at nl_send_one+0x18/frame 0xf nl_send_group() at nl_send_group+0x1bc/frame 0xf... _nlmsg_flush() at _nlmsg_flush+0x37/frame 0xf... rtnl_handle_ifevent() + 0xa1 if_attach_internal + 0x3df I have a picture of the full panic if desired... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 p...@freebsd.org | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
