Re: git: 8d49fd7331bc - main - pf: remove DIOCGETRULE and DIOCGETSTATUS : net/py-libdnet and net/scapy now broken, kyua test suite damaged
On 14 Sep 2023, at 15:34, Mark Millard wrote: > [I've cc'd a couple of folks that have dealt with fixing > breakage in the past.] > I’ve submitted a fix for libdnet in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273899 because it blocks net/scapy, which we rely on for tests. I do not plan to fix other ports as well. Best regards, Kristof
Fwd: git: 8d49fd7331bc - main - pf: remove DIOCGETRULE and DIOCGETSTATUS : net/py-libdnet and net/scapy now broken, kyua test suite damaged
[I've cc'd a couple of folks that have dealt with fixing
breakage in the past.]
From: Kristof Provost
Subject: Re: git: 8d49fd7331bc - main - pf: remove DIOCGETRULE and
DIOCGETSTATUS : net/py-libdnet and net/scapy now broken, kyua test suite damaged
Date: September 14, 2023 at 02:02:38 PDT
To: Mark Millard
Cc: Current FreeBSD
>
> Hi Mark,
>
> On 14 Sep 2023, at 7:37, Mark Millard wrote:
>> This change leads the port net/py-libdnet to be broken:
>>
>> --- fw-pf.lo ---
>> fw-pf.c:212:22: error: use of undeclared identifier 'DIOCGETRULE'
>> if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
>> ^
>> fw-pf.c:252:22: error: use of undeclared identifier 'DIOCGETRULE'
>> if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
>> ^
>> --- intf.lo ---
>> for (cnt = 0; !matched && cnt < (int) entry->intf_alias_num; cnt++) {
>> ^
>> intf.c:571:2: note: previous statement is here
>> if (entry->intf_addr.addr_type == ADDR_TYPE_IP &&
>> ^
>> --- fw-pf.lo ---
>> fw-pf.c:296:28: error: use of undeclared identifier 'DIOCGETRULE'
>> if ((ret = ioctl(fw->fd, DIOCGETRULE, &pr)) < 0)
>> ^
>> 3 errors generated.
>>
>> That leads to:
>>
>> [00:00:41] [29] [00:00:26] Finished net/py-libdnet@py39 |
>> py39-libdnet-1.13_4: Failed: build
>> [00:00:42] [29] [00:00:27] Skipping net/scapy@py39 | py39-scapy-2.5.0_1:
>> Dependent port net/py-libdnet@py39 | py39-libdnet-1.13_4 failed
>>
>
> The commit removed those ioctls because they’ve been superseded by newer
> (nvlist-based) versions.
> Ports are strongly advised to use libpfctl rather than trying to deal with
> nvlists themselves.
>
> See https://lists.freebsd.org/archives/freebsd-pf/2023-April/000345.html for
> an example of what the ports will have to do. It’s generally a trivial change.
>
> Best regards,
> Kristof
===
Mark Millard
marklmi at yahoo.com
Re: git: 8d49fd7331bc - main - pf: remove DIOCGETRULE and DIOCGETSTATUS : net/py-libdnet and net/scapy now broken, kyua test suite damaged
Hi Mark,
On 14 Sep 2023, at 7:37, Mark Millard wrote:
> This change leads the port net/py-libdnet to be broken:
>
> --- fw-pf.lo ---
> fw-pf.c:212:22: error: use of undeclared identifier 'DIOCGETRULE'
> if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
> ^
> fw-pf.c:252:22: error: use of undeclared identifier 'DIOCGETRULE'
> if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
> ^
> --- intf.lo ---
> for (cnt = 0; !matched && cnt < (int) entry->intf_alias_num; cnt++) {
> ^
> intf.c:571:2: note: previous statement is here
> if (entry->intf_addr.addr_type == ADDR_TYPE_IP &&
> ^
> --- fw-pf.lo ---
> fw-pf.c:296:28: error: use of undeclared identifier 'DIOCGETRULE'
> if ((ret = ioctl(fw->fd, DIOCGETRULE, &pr)) < 0)
> ^
> 3 errors generated.
>
> That leads to:
>
> [00:00:41] [29] [00:00:26] Finished net/py-libdnet@py39 |
> py39-libdnet-1.13_4: Failed: build
> [00:00:42] [29] [00:00:27] Skipping net/scapy@py39 | py39-scapy-2.5.0_1:
> Dependent port net/py-libdnet@py39 | py39-libdnet-1.13_4 failed
>
The commit removed those ioctls because they’ve been superseded by newer
(nvlist-based) versions.
Ports are strongly advised to use libpfctl rather than trying to deal with
nvlists themselves.
See https://lists.freebsd.org/archives/freebsd-pf/2023-April/000345.html for an
example of what the ports will have to do. It’s generally a trivial change.
Best regards,
Kristof
Re: git: 8d49fd7331bc - main - pf: remove DIOCGETRULE and DIOCGETSTATUS : net/py-libdnet and net/scapy now broken, kyua test suite damaged
This change leads the port net/py-libdnet to be broken:
--- fw-pf.lo ---
fw-pf.c:212:22: error: use of undeclared identifier 'DIOCGETRULE'
if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
^
fw-pf.c:252:22: error: use of undeclared identifier 'DIOCGETRULE'
if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
^
--- intf.lo ---
for (cnt = 0; !matched && cnt < (int) entry->intf_alias_num; cnt++) {
^
intf.c:571:2: note: previous statement is here
if (entry->intf_addr.addr_type == ADDR_TYPE_IP &&
^
--- fw-pf.lo ---
fw-pf.c:296:28: error: use of undeclared identifier 'DIOCGETRULE'
if ((ret = ioctl(fw->fd, DIOCGETRULE, &pr)) < 0)
^
3 errors generated.
That leads to:
[00:00:41] [29] [00:00:26] Finished net/py-libdnet@py39 | py39-libdnet-1.13_4:
Failed: build
[00:00:42] [29] [00:00:27] Skipping net/scapy@py39 | py39-scapy-2.5.0_1:
Dependent port net/py-libdnet@py39 | py39-libdnet-1.13_4 failed
net/scapy is used by parts of the kyua testsuite (when installed,
anyway). So the kyua testsuite is now has damaged functionality
on main [so: 15].
===
Mark Millard
marklmi at yahoo.com
