Re: git commit for WITH_DETECT_TZ_CHANGES breaks date, et al
On Tue, 14 Sep 2021 21:49:28 +0100 Edward Tomasz Napiera〓a wrote: > > > On 14 Sep 2021, at 16:33, Tomoaki AOKI wrote: > > > > On Tue, 14 Sep 2021 10:37:36 +0200 > > Michael Gmelin wrote: > > > >> > >> On Tue, 14 Sep 2021 09:02:46 + > >> Gary Jennejohn wrote: > >> > >>> On Mon, 13 Sep 2021 21:30:02 -0400 > >>> Michael Butler via freebsd-current > >>> wrote: > >>> > After commit ddedf2a11eb20af1ee52cb3da70a57c21904af8f date fails to > recognize any configured timezone when WITH_DETECT_TZ_CHANGES is > not set. > > For example .. > > imb@vm01:/home/imb> date > Tue Sep 14 01:25:57 2021 > > Every other daemon also thinks it's running in UTC+0 :-( > > When libc is recompiled with WITH_DETECT_TZ_CHANGES=yes in > /etc/src.conf, the output is (for me) .. > imb@vm01:/usr/src/lib/libc> date > Mon Sep 13 21:28:29 EDT 2021 > > >>> > >>> Same here. After instaling the new world this morning I was suddenly > >>> in UTC instead of CEST (2 hours difference). > >>> > >>> Thanks for the fix :-) > >> > >> Before reading your message, I (ironically) wanted to tell you about > >> your email's date header containing the wrong timezone ^_^ > >> > >> -m > >> > >> -- > >> Michael Gmelin > >> > > > > Just a thought (not at all tested), but... > > > > #define change_in_tz(X) 0 > > > > in line 393 of localtime.c should be > > > > #define change_in_tz(X) 1 > > > > if I understand correctly. > > > > Or remove line 392 and 393 with guarding added line 470 though 485 with > > #ifdef DETECT_TZ_CHANGES. > > > > Old behaviour never returns there. > > I suspect current code without defining WITH_DETECT_TZ_CHANGES=yes > > in /etc/src.conf make first tzload() call do nothing and forth fallback > > to UTC. > > Hello. Sorry for breakage (and sorry for not noticing this thread > earlier; some day I’ll figure out how to convince GMail to not put > mailing list emails into mailing list mailboxes when I’m Cc-ed). > That’s exactly the fix that got committed. Let me know if there > are any more issues. Confirmed fixed without defining WITH_DETECT_TZ_CHANGES=yes in /etc/src.conf. Thanks! -- Tomoaki AOKI
Re: git commit for WITH_DETECT_TZ_CHANGES breaks date, et al
On Tue, 14 Sep 2021 10:37:36 +0200 Michael Gmelin wrote: > > On Tue, 14 Sep 2021 09:02:46 + > Gary Jennejohn wrote: > > > On Mon, 13 Sep 2021 21:30:02 -0400 > > Michael Butler via freebsd-current > > wrote: > > > > > After commit ddedf2a11eb20af1ee52cb3da70a57c21904af8f date fails to > > > recognize any configured timezone when WITH_DETECT_TZ_CHANGES is > > > not set. > > > > > > For example .. > > > > > > imb@vm01:/home/imb> date > > > Tue Sep 14 01:25:57 2021 > > > > > > Every other daemon also thinks it's running in UTC+0 :-( > > > > > > When libc is recompiled with WITH_DETECT_TZ_CHANGES=yes in > > > /etc/src.conf, the output is (for me) .. > > > imb@vm01:/usr/src/lib/libc> date > > > Mon Sep 13 21:28:29 EDT 2021 > > > > > > > Same here. After instaling the new world this morning I was suddenly > > in UTC instead of CEST (2 hours difference). > > > > Thanks for the fix :-) > > Before reading your message, I (ironically) wanted to tell you about > your email's date header containing the wrong timezone ^_^ > > -m > > -- > Michael Gmelin > Just a thought (not at all tested), but... #definechange_in_tz(X) 0 in line 393 of localtime.c should be #definechange_in_tz(X) 1 if I understand correctly. Or remove line 392 and 393 with guarding added line 470 though 485 with #ifdef DETECT_TZ_CHANGES. Old behaviour never returns there. I suspect current code without defining WITH_DETECT_TZ_CHANGES=yes in /etc/src.conf make first tzload() call do nothing and forth fallback to UTC. -- Tomoaki AOKI
Re: git commit for WITH_DETECT_TZ_CHANGES breaks date, et al
On Tue, 14 Sep 2021 09:02:46 + Gary Jennejohn wrote: > On Mon, 13 Sep 2021 21:30:02 -0400 > Michael Butler via freebsd-current > wrote: > > > After commit ddedf2a11eb20af1ee52cb3da70a57c21904af8f date fails to > > recognize any configured timezone when WITH_DETECT_TZ_CHANGES is > > not set. > > > > For example .. > > > > imb@vm01:/home/imb> date > > Tue Sep 14 01:25:57 2021 > > > > Every other daemon also thinks it's running in UTC+0 :-( > > > > When libc is recompiled with WITH_DETECT_TZ_CHANGES=yes in > > /etc/src.conf, the output is (for me) .. > > imb@vm01:/usr/src/lib/libc> date > > Mon Sep 13 21:28:29 EDT 2021 > > > > Same here. After instaling the new world this morning I was suddenly > in UTC instead of CEST (2 hours difference). > > Thanks for the fix :-) Before reading your message, I (ironically) wanted to tell you about your email's date header containing the wrong timezone ^_^ -m -- Michael Gmelin
Re: git commit for WITH_DETECT_TZ_CHANGES breaks date, et al
On Mon, 13 Sep 2021 21:30:02 -0400 Michael Butler via freebsd-current wrote: > After commit ddedf2a11eb20af1ee52cb3da70a57c21904af8f date fails to recognize > any configured timezone when WITH_DETECT_TZ_CHANGES is not set. > > For example .. > > imb@vm01:/home/imb> date > Tue Sep 14 01:25:57 2021 > > Every other daemon also thinks it's running in UTC+0 :-( > > When libc is recompiled with WITH_DETECT_TZ_CHANGES=yes in /etc/src.conf, the > output is (for me) .. > > imb@vm01:/usr/src/lib/libc> date > Mon Sep 13 21:28:29 EDT 2021 > Same here. After instaling the new world this morning I was suddenly in UTC instead of CEST (2 hours difference). Thanks for the fix :-) -- Gary Jennejohn
git commit for WITH_DETECT_TZ_CHANGES breaks date, et al
After commit ddedf2a11eb20af1ee52cb3da70a57c21904af8f date fails to recognize any configured timezone when WITH_DETECT_TZ_CHANGES is not set. For example .. imb@vm01:/home/imb> date Tue Sep 14 01:25:57 2021 Every other daemon also thinks it's running in UTC+0 :-( When libc is recompiled with WITH_DETECT_TZ_CHANGES=yes in /etc/src.conf, the output is (for me) .. imb@vm01:/usr/src/lib/libc> date Mon Sep 13 21:28:29 EDT 2021 imb
