Re: hwpmc support for Ivy Bridge Xeon
On Mon, Jan 28, 2013 at 7:27 PM, hiren panchasara hiren.panchas...@gmail.com wrote: On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara hiren.panchas...@gmail.com wrote: I've tried to update hwpmc by adding support for xeon class of Ivy bridge processors. Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) I do not have a reference machine to test with. Any help in that regard would be appreciated. Got a machine with ivy bridge xeon. Will test my changes and update here soon. Hiren It seems to be working fine: Here is o/p of pmccontrol -L listing all the event counters: http://www.strugglingcoder.info/patches/hwpmc_ibx_pmccontrol.txt And below is the o/p of pmctest.py script: http://www.strugglingcoder.info/patches/hwpmc_ibx_pmctest.txt cheers, Hiren Here are the diffs against head (245927): http://www.strugglingcoder.info/patches/hwpmc_ibx.txt Thanks, Hiren ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: hwpmc support for Ivy Bridge Xeon
On Tue, Jan 29, 2013 at 12:29 AM, hiren panchasara hiren.panchas...@gmail.com wrote: On Mon, Jan 28, 2013 at 7:27 PM, hiren panchasara hiren.panchas...@gmail.com wrote: On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara hiren.panchas...@gmail.com wrote: I've tried to update hwpmc by adding support for xeon class of Ivy bridge processors. Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) I do not have a reference machine to test with. Any help in that regard would be appreciated. Got a machine with ivy bridge xeon. Will test my changes and update here soon. Hiren It seems to be working fine: Here is o/p of pmccontrol -L listing all the event counters: http://www.strugglingcoder.info/patches/hwpmc_ibx_pmccontrol.txt I don't see anything wrong there. And below is the o/p of pmctest.py script: http://www.strugglingcoder.info/patches/hwpmc_ibx_pmctest.txt With 'pmctest.py' are you talking about the gnn@ script available in tools/ ? What are you profiling (ls, find, the kernel) ? I've recently discovered an excellent tool from Peter in stress2 suite to test pmc. Maybe you can try it. http://svnweb.freebsd.org/base/user/pho/stress2/misc/pmc.sh?revision=237222view=markup cheers, Hiren Here are the diffs against head (245927): http://www.strugglingcoder.info/patches/hwpmc_ibx.txt Thanks, Hiren ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org Thanks -- Davide ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: hwpmc support for Ivy Bridge Xeon
On Tue, Jan 29, 2013 at 2:05 AM, Davide Italiano dav...@freebsd.org wrote: On Tue, Jan 29, 2013 at 12:29 AM, hiren panchasara hiren.panchas...@gmail.com wrote: On Mon, Jan 28, 2013 at 7:27 PM, hiren panchasara hiren.panchas...@gmail.com wrote: On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara hiren.panchas...@gmail.com wrote: I've tried to update hwpmc by adding support for xeon class of Ivy bridge processors. Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) I do not have a reference machine to test with. Any help in that regard would be appreciated. Got a machine with ivy bridge xeon. Will test my changes and update here soon. Hiren It seems to be working fine: Here is o/p of pmccontrol -L listing all the event counters: http://www.strugglingcoder.info/patches/hwpmc_ibx_pmccontrol.txt I don't see anything wrong there. And below is the o/p of pmctest.py script: http://www.strugglingcoder.info/patches/hwpmc_ibx_pmctest.txt With 'pmctest.py' are you talking about the gnn@ script available in tools/ ? Yes. What are you profiling (ls, find, the kernel) ? I was testing simple commands like ls. I've recently discovered an excellent tool from Peter in stress2 suite to test pmc. Maybe you can try it. http://svnweb.freebsd.org/base/user/pho/stress2/misc/pmc.sh?revision=237222view=markup Interesting tool. I will spend more time in looking into it. Though I quickly did run pmc.sh run: run time 0+00:05:00, incarnations 1, load 100, verbose 1 10:48:37 Loop #1 rw: run time 0+00:02:00, incarnations 8, load 70, verbose 1 swap: run time 0+00:02:00, incarnations 38, load 80, verbose 1 creat: run time 0+00:02:00, incarnations 3, load 80, verbose 1 10:52:05 Loop #2 rw: run time 0+00:02:00, incarnations 17, load 70, verbose 1 creat: run time 0+00:02:00, incarnations 18, load 80, verbose 1 mkdir: run time 0+00:02:00, incarnations 9, load 80, verbose 1 Again, I appreciate you helping here, Thanks, Hiren cheers, Hiren Here are the diffs against head (245927): http://www.strugglingcoder.info/patches/hwpmc_ibx.txt Thanks, Hiren ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org Thanks -- Davide ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: hwpmc support for Ivy Bridge Xeon
On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara hiren.panchas...@gmail.com wrote: I've tried to update hwpmc by adding support for xeon class of Ivy bridge processors. Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) I do not have a reference machine to test with. Any help in that regard would be appreciated. Got a machine with ivy bridge xeon. Will test my changes and update here soon. Hiren Here are the diffs against head (245927): http://www.strugglingcoder.info/patches/hwpmc_ibx.txt Thanks, Hiren ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
hwpmc support for Ivy Bridge Xeon
I've tried to update hwpmc by adding support for xeon class of Ivy bridge processors. Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) I do not have a reference machine to test with. Any help in that regard would be appreciated. Here are the diffs against head (245927): http://www.strugglingcoder.info/patches/hwpmc_ibx.txt Thanks, Hiren ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: hwpmc support for Ivy Bridge Xeon
On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara hiren.panchas...@gmail.com wrote: I've tried to update hwpmc by adding support for xeon class of Ivy bridge processors. Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) I do not have a reference machine to test with. Any help in that regard would be appreciated. Here are the diffs against head (245927): http://www.strugglingcoder.info/patches/hwpmc_ibx.txt Thanks, Hiren ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org From a first look appears good -- I've a couple of observations though. I see your patch covers only core events -- am I missing something? Not really important, and I don't want to be pedantic here, but maybe this can be renamed to something less ugly: static int -iap_event_sb_sbx_ib_ok_on_counter(enum pmc_event pe, int ri) +iap_event_sb_sbx_ib_ibx_ok_on_counter(enum pmc_event pe, int ri) -- Davide ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: hwpmc support for Ivy Bridge Xeon
Keeping sbruno in the chain. On Sat, Jan 26, 2013 at 5:41 AM, Davide Italiano dav...@freebsd.org wrote: On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara hiren.panchas...@gmail.com wrote: I've tried to update hwpmc by adding support for xeon class of Ivy bridge processors. Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) I do not have a reference machine to test with. Any help in that regard would be appreciated. Here are the diffs against head (245927): http://www.strugglingcoder.info/patches/hwpmc_ibx.txt Thanks, Hiren ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org From a first look appears good -- I've a couple of observations though. I see your patch covers only core events -- am I missing something? My bad, should've mentioned that diffs only has core events. I could not find uncore events clearly mentioned in the spec. Not really important, and I don't want to be pedantic here, but maybe this can be renamed to something less ugly: static int -iap_event_sb_sbx_ib_ok_on_counter(enum pmc_event pe, int ri) +iap_event_sb_sbx_ib_ibx_ok_on_counter(enum pmc_event pe, int ri) Now when I look at this yes, we should change it. :-) Not sure about the new name. Thanks for looking into it, Hiren ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
