Re: if_xl.c noise
On Sat, 1 May 1999, Matthew Dillon wrote: > : > :You could have answered this yourself by checking in > :/pub/FreeBSD/FreeBSD-current/src/sys/pci/if_xl.c on ftp.cdrom.com. > :Yes, this is only your repository; you must be using some patches > :from Matt Dillon for NFS. The code in -current has the change that > :he made already in it (but with a different comment). Grab a fresh > :copy of if_xl.c and if_xlreg.h from -current and stick with it. > : > :-Bill > > He probably did. I meant to remove those from my NFS stuff... they're > gone now. Hopefully the NFS patches ( non-inclusive of the xl stuff ) > will be committed soon. Excellent. If you need another review, just ask me. I have read the patch and can do a proper review if necessary. -- Doug Rabson Mail: d...@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: if_xl.c noise
: :You could have answered this yourself by checking in :/pub/FreeBSD/FreeBSD-current/src/sys/pci/if_xl.c on ftp.cdrom.com. :Yes, this is only your repository; you must be using some patches :from Matt Dillon for NFS. The code in -current has the change that :he made already in it (but with a different comment). Grab a fresh :copy of if_xl.c and if_xlreg.h from -current and stick with it. : :-Bill He probably did. I meant to remove those from my NFS stuff... they're gone now. Hopefully the NFS patches ( non-inclusive of the xl stuff ) will be committed soon. -Matt To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: if_xl.c noise
Hi, At 5:59 pm -0400 1/5/99, Bill Paul wrote: >[...]>Yes, this is only your repository; you must be using some patches >from Matt Dillon for NFS. Argh. Pointy hat please - didn't notice "C src/sys/pci/if_xl.c" staring me in the face. -- Bob Bishop (0118) 977 4017 international code +44 118 r...@gid.co.ukfax (0118) 989 4254 between 0800 and 1800 UK To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
Re: if_xl.c noise
Of all the gin joints in all the towns in all the world, Bob Bishop had to walk into mine and say: > Hi, > > Does version 1.34 of if_xl.c really look like the following around line > 1886, or is my repository hosed? You could have answered this yourself by checking in /pub/FreeBSD/FreeBSD-current/src/sys/pci/if_xl.c on ftp.cdrom.com. Yes, this is only your repository; you must be using some patches from Matt Dillon for NFS. The code in -current has the change that he made already in it (but with a different comment). Grab a fresh copy of if_xl.c and if_xlreg.h from -current and stick with it. -Bill -- = -Bill Paul(212) 854-6020 | System Manager, Master of Unix-Fu Work: wp...@ctr.columbia.edu | Center for Telecommunications Research Home: wp...@skynet.ctr.columbia.edu | Columbia University, New York City = "It is not I who am crazy; it is I who am mad!" - Ren Hoek, "Space Madness" = To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
if_xl.c noise
Hi, Does version 1.34 of if_xl.c really look like the following around line 1886, or is my repository hosed? <<< if_xl.c /* * Force longword alignment for packet payload for all cpus. This * will optimize NFS ops which have to realign unaligned buffers. */ === /* Force longword alignment for packet payload. */ >>> 1.34 m_new->m_data += 2; <<< if_xl.c === >>> 1.34 c->xl_mbuf = m_new; c->xl_ptr->xl_status = 0; c->xl_ptr->xl_frag.xl_addr = vtophys(mtod(m_new, caddr_t)); c->xl_ptr->xl_frag.xl_len = MCLBYTES | XL_LAST_FRAG; return(0); -- Bob Bishop (0118) 977 4017 international code +44 118 r...@gid.co.ukfax (0118) 989 4254 between 0800 and 1800 UK To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
