Re: kernel breakage in ng_base.c

2000-05-01 Thread f.johan.beisser


hrm, i'm sad to report that it did not work for me..

let me know if you need output from it, i'll see about sending it to you.

-- jan

On Sun, 30 Apr 2000, Gary Jennejohn wrote:

 Here's a simple patch which works for me.
 
 --- /sys/netgraph/ng_base.c   Sun Apr 30 11:32:22 2000
 +++ /sys/netgraph/ng_base.c_mod   Sun Apr 30 11:40:24 2000
 @@ -314,11 +314,16 @@
   int error;
  
   /* Not found, try to load it as a loadable module */
 +#if 0
   snprintf(filename, sizeof(filename), "ng_%s.ko", typename);
   if ((path = linker_search_path(filename)) == NULL)
   return (ENXIO);
   error = linker_load_file(path, lf);
   FREE(path, M_LINKER);
 +#else
 + snprintf(filename, sizeof(filename), "ng_%s", typename);
 + error = linker_load_file(filename, lf);
 +#endif
   if (error != 0)
   return (error);
   lf-userrefs++; /* pretend loaded by the syscall */
 
 
 
 Gary Jennejohn / [EMAIL PROTECTED] [EMAIL PROTECTED]
 
 
 
 
 To Unsubscribe: send mail to [EMAIL PROTECTED]
 with "unsubscribe freebsd-current" in the body of the message
 

 +-/  f. johan beisser  /--+
  email: jan[at]caustic.org   web: http://www.caustic.org/~jan 
   "knowledge is power. power corrupts. study hard, be evil."



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: kernel breakage in ng_base.c

2000-05-01 Thread Gary Jennejohn

"f.johan.beisser" writes:

hrm, i'm sad to report that it did not work for me..

let me know if you need output from it, i'll see about sending it to you.

-- jan

On Sun, 30 Apr 2000, Gary Jennejohn wrote:

 Here's a simple patch which works for me.
 
[patch deleted]

Well, I only have a simple requirement - PPPoE has to work. ng_socket.ko
gets loaded just fine for me, but I'm not really certain that ng_base.c
is doing the loading.

I think the best thing would be to wait for Peter to finish the commit 
since
he knows what's intended to be used here.

However, it might be worth posting your error output to the list as an
aid in finding the correct fix :)

---
Gary Jennejohn / [EMAIL PROTECTED] [EMAIL PROTECTED]




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



kernel breakage in ng_base.c

2000-04-30 Thread Gary Jennejohn

Here's a simple patch which works for me.

--- /sys/netgraph/ng_base.c Sun Apr 30 11:32:22 2000
+++ /sys/netgraph/ng_base.c_mod Sun Apr 30 11:40:24 2000
@@ -314,11 +314,16 @@
int error;
 
/* Not found, try to load it as a loadable module */
+#if 0
snprintf(filename, sizeof(filename), "ng_%s.ko", typename);
if ((path = linker_search_path(filename)) == NULL)
return (ENXIO);
error = linker_load_file(path, lf);
FREE(path, M_LINKER);
+#else
+   snprintf(filename, sizeof(filename), "ng_%s", typename);
+   error = linker_load_file(filename, lf);
+#endif
if (error != 0)
return (error);
lf-userrefs++; /* pretend loaded by the syscall */



Gary Jennejohn / [EMAIL PROTECTED] [EMAIL PROTECTED]




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: kernel breakage in ng_base.c

2000-04-30 Thread Boris Popov

On Sun, 30 Apr 2000, Gary Jennejohn wrote:

 Here's a simple patch which works for me.

This patch is not 100% correct. ng_base should make an attempt to
load module, not KLD. There was a new module_load() function proposed to
inclusion in the API, but for some reason it is not committed yet.

--
Boris Popov



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: kernel breakage in ng_base.c

2000-04-30 Thread Jeroen Ruigrok van der Werven

-On [2430 16:50], Boris Popov ([EMAIL PROTECTED]) wrote:
   This patch is not 100% correct. ng_base should make an attempt to
load module, not KLD. There was a new module_load() function proposed to
inclusion in the API, but for some reason it is not committed yet.

When Peter committed this all he had worked a few days untill too early
in the morning.

It is a lack of sufficient sleep which caught up on him. =)

-- 
Jeroen Ruigrok van der Werven  Network- and systemadministrator
[EMAIL PROTECTED]VIA Net.Works The Netherlands
BSD: Technical excellence at its best  http://www.via-net-works.nl
Answering the questions that no one asks...


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: kernel breakage in ng_base.c

2000-04-30 Thread Boris Popov

On Sun, 30 Apr 2000, Jeroen Ruigrok van der Werven wrote:

 -On [2430 16:50], Boris Popov ([EMAIL PROTECTED]) wrote:
  This patch is not 100% correct. ng_base should make an attempt to
 load module, not KLD. There was a new module_load() function proposed to
 inclusion in the API, but for some reason it is not committed yet.
 
 When Peter committed this all he had worked a few days untill too early
 in the morning.

I should correct myself: this function exists, but declared as
static and called linker_load_module(). Gary, you may try to use it:

linker_load_module(name, NULL);

--
Boris Popov



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message