Re: kernel broken? (pcm)
On 12 Okt, [EMAIL PROTECTED] wrote: > You can try the patch in (my) PR 'kern/14278'. Works. Bye, Alexander. -- What do you mean, my birth certificate expired? http://netchild.home.pages.de A.Leidinger+Home @ WJPServer.CS.Uni-SB.de To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
In <[EMAIL PROTECTED]> Alexander Leidinger <[EMAIL PROTECTED]> wrote: > On 11 Oct, Bill Fumerola wrote: > >>> #makeoptionsCONF_CFLAGS=-fno-builtin >> >> We have enough breakages with the _documented_ kernel options that we > > As Bruce Evans already said, It's documented. > >> don't need to go hunting down oddities. :> > > Have you seen the '#' in "#makeoptions"? I assume a '#' in the config > file means: "Hey config, don't look at this!". Please correct me if I'm > wrong. > > I've tested both variants with and without '#'. After editing the file I > did a 'config -r CONFIG', 'cd ../../compile/CONFIG', 'make depend', > 'make'. I get the error independently of CONF_FLAGS. > Back at home I do it again if you want. Yes, in your case the errors are independent from this "makeoptions ..." line. But you are linking kernel.debug, so the (undefined in kernel) 'abs' function shows itself. You can try the patch in (my) PR 'kern/14278'. N.Dudorov To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On 11 Oct, Bill Fumerola wrote: >> #makeoptions CONF_CFLAGS=-fno-builtin > > We have enough breakages with the _documented_ kernel options that we As Bruce Evans already said, It's documented. > don't need to go hunting down oddities. :> Have you seen the '#' in "#makeoptions"? I assume a '#' in the config file means: "Hey config, don't look at this!". Please correct me if I'm wrong. I've tested both variants with and without '#'. After editing the file I did a 'config -r CONFIG', 'cd ../../compile/CONFIG', 'make depend', 'make'. I get the error independently of CONF_FLAGS. Back at home I do it again if you want. Bye, Alexander. -- http://netchild.home.pages.de A.Leidinger @ WJPServer.CS.Uni-SB.de To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
> >>Such an errors results from (uncommented) kernel option ^^^ > >> > >> #makeoptions CONF_CFLAGS=-fno-builtin > > > > We have enough breakages with the _documented_ kernel options that we > > don't need to go hunting down oddities. :> It's well documented. -fno-builtin is a standard gcc option, and CONF_FLAGS and its use of -fno-builtin is documented in 4 lines in LINT. > Does it mean that I throw away my PR with patches to > the 'newpcm' files which add 'abs' definition and therefore > make it possible to make kernel with > > makeoptions CONF_CFLAGS=-fno-builtin ? No, some patches are needed. I think pcm should use explicit code like (x < 0 : -x : x). It only calls abs() twice. > P.S. It seems to me that this option (or its absent) can > severely influence kernel run time efficience (not in the 'abs' > case, of course ;-). I used to use it for all kernels as a side effect of putting it in /etc/make.conf so that it gets used for LINT. Any efficiency effects seem to be limited to the +-0.1% range. The only place where it is likely to make much difference is for bcopy() vs memcpy() on some machines. The builtin memcpy() can be pessimal. This is supposed to be handled by using bcopy() for large copies and memcpy() (only) for small, fix-sized copies. The builtin memcpy() tends to be better for small copies. Since using memcpy() in the kernel is correct in some cases, it is backed up by a function to handle cases where there is no inline memcpy(). Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On Tue, 12 Oct 1999 [EMAIL PROTECTED] wrote: > In <[EMAIL PROTECTED]> [EMAIL PROTECTED] wrote: > Such an errors results from (uncommented) kernel option > > #makeoptions CONF_CFLAGS=-fno-builtin This option is used in LINT to help expose such errors before they are committed. > because there is NO 'abs' function/macro in this files > (ac97.c, channel.c and mss.c) and they can be only compiled using > gcc's builtin 'abs' abs() doesn't exist in the kernel, so it shouldn't be used. > > linking kernel.debug > > ac97.o: In function `ac97_setmixer': > > /usr/src/sys/compile/WORK/../../dev/pcm/ac97.c(.text+0x18d): undefined reference >to `abs' > > channel.o: In function `chn_setblocksize': Test coverage of pcm in LINT is broken by not configuring pcm because of conflicts with the old sound drivers. Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On Tue, 12 Oct 1999 [EMAIL PROTECTED] wrote: > > We have enough breakages with the _documented_ kernel options that we > > don't need to go hunting down oddities. :> > > Does it mean that I throw away my PR with patches to > the 'newpcm' files which add 'abs' definition and therefore > make it possible to make kernel with > > makeoptions CONF_CFLAGS=-fno-builtin ? > > P.S. It seems to me that this option (or its absent) can > severely influence kernel run time efficience (not in the 'abs' > case, of course ;-). No. I was merely joking around. We welcome your patches. -- - bill fumerola - [EMAIL PROTECTED] - BF1560 - computer horizons corp - - ph:(800) 252-2421 - [EMAIL PROTECTED] - [EMAIL PROTECTED] - To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
In <[EMAIL PROTECTED]> Bill Fumerola <[EMAIL PROTECTED]> wrote: > On Tue, 12 Oct 1999 [EMAIL PROTECTED] wrote: > >> In <[EMAIL PROTECTED]> [EMAIL PROTECTED] wrote: >> Such an errors results from (uncommented) kernel option >> >> #makeoptions CONF_CFLAGS=-fno-builtin > > We have enough breakages with the _documented_ kernel options that we > don't need to go hunting down oddities. :> Does it mean that I throw away my PR with patches to the 'newpcm' files which add 'abs' definition and therefore make it possible to make kernel with makeoptions CONF_CFLAGS=-fno-builtin ? P.S. It seems to me that this option (or its absent) can severely influence kernel run time efficience (not in the 'abs' case, of course ;-). N.Dudorov To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On Tue, 12 Oct 1999 [EMAIL PROTECTED] wrote: > In <[EMAIL PROTECTED]> [EMAIL PROTECTED] wrote: > Such an errors results from (uncommented) kernel option > > #makeoptions CONF_CFLAGS=-fno-builtin We have enough breakages with the _documented_ kernel options that we don't need to go hunting down oddities. :> -- - bill fumerola - [EMAIL PROTECTED] - BF1560 - computer horizons corp - - ph:(800) 252-2421 - [EMAIL PROTECTED] - [EMAIL PROTECTED] - To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
In <[EMAIL PROTECTED]> [EMAIL PROTECTED] wrote: Such an errors results from (uncommented) kernel option #makeoptionsCONF_CFLAGS=-fno-builtin because there is NO 'abs' function/macro in this files (ac97.c, channel.c and mss.c) and they can be only compiled using gcc's builtin 'abs' N.Dudorov > Hi, > > linking kernel.debug > ac97.o: In function `ac97_setmixer': > /usr/src/sys/compile/WORK/../../dev/pcm/ac97.c(.text+0x18d): undefined reference to >`abs' > channel.o: In function `chn_setblocksize': > /usr/src/sys/compile/WORK/../../dev/pcm/channel.c:712: undefined reference to `abs' > mss.o: In function `mss_speed': > /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x182d): undefined reference >to `abs' > /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x183f): undefined reference >to `abs' > /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x1869): undefined reference >to `abs' > mss.o(.text+0x187b):/usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c: more >undefined references to `abs' follow > *** Error code 1 > 1 error > > I tried several cvsups since the morning. > > Kernelconfig attached. > To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
kernel broken? (pcm)
Hi, linking kernel.debug ac97.o: In function `ac97_setmixer': /usr/src/sys/compile/WORK/../../dev/pcm/ac97.c(.text+0x18d): undefined reference to `abs' channel.o: In function `chn_setblocksize': /usr/src/sys/compile/WORK/../../dev/pcm/channel.c:712: undefined reference to `abs' mss.o: In function `mss_speed': /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x182d): undefined reference to `abs' /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x183f): undefined reference to `abs' /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x1869): undefined reference to `abs' mss.o(.text+0x187b):/usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c: more undefined references to `abs' follow *** Error code 1 1 error I tried several cvsups since the morning. Kernelconfig attached. Bye, Alexander. -- Am I supposed to be impressed? http://netchild.home.pages.de A.Leidinger+Home @ WJPServer.CS.Uni-SB.de machine i386 ident WORK maxusers32 makeoptions DEBUG=-g #makeoptionsCONF_CFLAGS=-fno-builtin # # Allow user-mode programs to manipulate their local descriptor tables. # This option is required for the WINE Windows(tm) emulator, and is # not used by anything else (that we know of). # #optionsUSER_LDT#allow user-level control of i386 ldt # Options for the VM subsystem #optionsPQ_NOOPT# No coloring options PQ_LARGECACHE # color for 512k/16k cache #optionsPQ_HUGECACHE# color for 1024k/16k cache #cpuI586_CPU cpu I686_CPU# aka Pentium Pro(tm) options CPU_FASTER_5X86_FPU options CPU_SUSP_HLT options "NO_F00F_HACK" options COMPAT_43 options SYSVSHM options SYSVSEM options SYSVMSG options MD5 options DDB options GDB_REMOTE_CHAT options KTRACE #kernel tracing #optionsPERFMON options UCONSOLE options USERCONFIG #boot -c editor options VISUAL_USERCONFIG #visual boot -c editor options INET#Internet communications protocols pseudo-device ether #Generic Ethernet pseudo-device sppp#Generic Synchronous PPP pseudo-device loop#Network loopback device pseudo-device bpf #Berkeley packet filter pseudo-device disc#Discard device pseudo-device streams options PPP_BSDCOMP #PPP BSD-compress support options PPP_DEFLATE #PPP zlib/deflate/gzip support options PPP_FILTER #enable bpf filtering (needs bpfilter) options MROUTING# Multicast routing options IPFIREWALL #firewall options IPFIREWALL_VERBOSE #print information about # dropped packets options IPFIREWALL_FORWARD #enable transparent proxy support options IPFIREWALL_VERBOSE_LIMIT=100 #limit verbosity options IPDIVERT#divert sockets options IPSTEALTH #support for stealth forwarding options TCP_RESTRICT_RST#restrict emission of TCP RST options ICMP_BANDLIM options FFS #Fast filesystem options CD9660 #ISO 9660 filesystem options KERNFS #Kernel filesystem options MSDOSFS #MS DOS File System options PROCFS #Process filesystem options MFS #Memory File System options NFS #Network File System #optionsNFS_NOSERVER#Disable the NFS-server code. options FFS_ROOT#FFS usable as root device options SOFTUPDATES options P1003_1B options _KPOSIX_PRIORITY_SCHEDULING options _KPOSIX_VERSION=199309L controller scbus0 #base SCSI code #device ch0 #SCSI media changers device da0 #SCSI direct access devices (aka disks) #device sa0 #SCSI tapes device cd0 #SCSI CD-ROMs device pass0 #CAM passthrough driver device pt0 at scbus?# SCSI processor type options CAM_MAX_HIGHPOWER=4 options SCSI_DELAY=5000# Be pessimistic about Joe SCSI device pseudo-device pty #Pseudo ttys pseudo-device speaker #Play IBM BASIC-style noises out your speaker pseudo-device gzip#Exec gzipped a.out's pseudo-device vn #Vnode driver (turns a file into a device) #pseudo-device snp 3 #Snoop device - to look at pty/vty/etc.. options MSGBUF_SIZE=40960 controller isa0 # Enable support for the kernel PLL to use an external PPS signal, # under supervision of [x]ntpd(8) # More
