Re: make in dir

2014-04-02 Thread Warner Losh

On Apr 2, 2014, at 12:15 PM, Konstantin Belousov  wrote:

> On Wed, Apr 02, 2014 at 09:46:34AM -0600, Warner Losh wrote:
>> 
>> On Apr 2, 2014, at 6:15 AM, Konstantin Belousov  wrote:
>> 
>>> Hi,
>>> it seems that recent changes to share/mk broke the ability to do anything
>>> in subdir of the source tree.  As example, on the HEAD r264012 installed
>>> yesterday:
>>> 
>>> sandy% make   
>>> /usr/home/pooma/build/bsd/DEV/src/tools/regression/kqueue
>>> make: "/usr/share/mk/bsd.own.mk" line 436: MK_MAN can't be set by a user.
>> 
>> I was able to recreate this with ?make -m /blah-blah-blah -C 
>> tools/regression/kqueue clean?
>> The important bit being -m. I have a fix that I?ll commit shortly.
>> 
>>> Also, on stable/9 hosting the HEAD cross-env:
>>> cd src && MAKEOBJDIRPREFIX=/usr/home/kostik/build/bsd/DEV/obj-amd64 
>>> DESTDIR=/usr/home/kostik/build/bsd/DEV/netboot/sandy-amd64 
>>> SYSDIR=/usr/home/kostik/build/bsd/DEV/src/sys TARGET=amd64  make  buildenv
>>> Entering world for amd64:amd64
>>> # cd share/mk
>>> # make install
>>> "bsd.own.mk", line 435: Malformed conditional (${.MAKE.LEVEL} == 0)
>>> "bsd.own.mk", line 436: MK_PROFILE can't be set by a user.
>> 
>> This will happen with fmake. I?ve put some safety belts in place in another 
>> fix
>> to keep this from tripping people up (and plan on using a similar technique
>> to keep people from hitting the aicasm bug on such systems).
> I noted that this is from stable/9-hosted buildenv.  Shouldn't buildenv
> mangle the path to select and possibly build bmake if needed ?

Yea, I would have thought so...

> Anyway,  your recent commits seems to fix my problems, thank you.

You are welcome. Don’t hesitate to give a yell if you discover other
problems…

Warner

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: make in dir

2014-04-02 Thread Konstantin Belousov
On Wed, Apr 02, 2014 at 09:46:34AM -0600, Warner Losh wrote:
> 
> On Apr 2, 2014, at 6:15 AM, Konstantin Belousov  wrote:
> 
> > Hi,
> > it seems that recent changes to share/mk broke the ability to do anything
> > in subdir of the source tree.  As example, on the HEAD r264012 installed
> > yesterday:
> > 
> > sandy% make   
> > /usr/home/pooma/build/bsd/DEV/src/tools/regression/kqueue
> > make: "/usr/share/mk/bsd.own.mk" line 436: MK_MAN can't be set by a user.
> 
> I was able to recreate this with ?make -m /blah-blah-blah -C 
> tools/regression/kqueue clean?
> The important bit being -m. I have a fix that I?ll commit shortly.
> 
> > Also, on stable/9 hosting the HEAD cross-env:
> > cd src && MAKEOBJDIRPREFIX=/usr/home/kostik/build/bsd/DEV/obj-amd64 
> > DESTDIR=/usr/home/kostik/build/bsd/DEV/netboot/sandy-amd64 
> > SYSDIR=/usr/home/kostik/build/bsd/DEV/src/sys TARGET=amd64  make  buildenv
> > Entering world for amd64:amd64
> > # cd share/mk
> > # make install
> > "bsd.own.mk", line 435: Malformed conditional (${.MAKE.LEVEL} == 0)
> > "bsd.own.mk", line 436: MK_PROFILE can't be set by a user.
> 
> This will happen with fmake. I?ve put some safety belts in place in another 
> fix
> to keep this from tripping people up (and plan on using a similar technique
> to keep people from hitting the aicasm bug on such systems).
I noted that this is from stable/9-hosted buildenv.  Shouldn't buildenv
mangle the path to select and possibly build bmake if needed ?

Anyway,  your recent commits seems to fix my problems, thank you.


pgp8b5xlXmaJB.pgp
Description: PGP signature


Re: make in dir

2014-04-02 Thread Warner Losh

On Apr 2, 2014, at 6:15 AM, Konstantin Belousov  wrote:

> Hi,
> it seems that recent changes to share/mk broke the ability to do anything
> in subdir of the source tree.  As example, on the HEAD r264012 installed
> yesterday:
> 
> sandy% make   
> /usr/home/pooma/build/bsd/DEV/src/tools/regression/kqueue
> make: "/usr/share/mk/bsd.own.mk" line 436: MK_MAN can't be set by a user.

I was able to recreate this with ‘make -m /blah-blah-blah -C 
tools/regression/kqueue clean’
The important bit being -m. I have a fix that I’ll commit shortly.

> Also, on stable/9 hosting the HEAD cross-env:
> cd src && MAKEOBJDIRPREFIX=/usr/home/kostik/build/bsd/DEV/obj-amd64 
> DESTDIR=/usr/home/kostik/build/bsd/DEV/netboot/sandy-amd64 
> SYSDIR=/usr/home/kostik/build/bsd/DEV/src/sys TARGET=amd64  make  buildenv
> Entering world for amd64:amd64
> # cd share/mk
> # make install
> "bsd.own.mk", line 435: Malformed conditional (${.MAKE.LEVEL} == 0)
> "bsd.own.mk", line 436: MK_PROFILE can't be set by a user.

This will happen with fmake. I’ve put some safety belts in place in another fix
to keep this from tripping people up (and plan on using a similar technique
to keep people from hitting the aicasm bug on such systems).

Warner


___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: make in dir

2014-04-02 Thread Warner Losh

On Apr 2, 2014, at 6:15 AM, Konstantin Belousov  wrote:

> Hi,
> it seems that recent changes to share/mk broke the ability to do anything
> in subdir of the source tree.  As example, on the HEAD r264012 installed
> yesterday:
> 
> sandy% make   
> /usr/home/pooma/build/bsd/DEV/src/tools/regression/kqueue
> make: "/usr/share/mk/bsd.own.mk" line 436: MK_MAN can't be set by a user.

I’ve had reports of this, but couldn’t recreate it. Will try again...

> Also, on stable/9 hosting the HEAD cross-env:
> cd src && MAKEOBJDIRPREFIX=/usr/home/kostik/build/bsd/DEV/obj-amd64 
> DESTDIR=/usr/home/kostik/build/bsd/DEV/netboot/sandy-amd64 
> SYSDIR=/usr/home/kostik/build/bsd/DEV/src/sys TARGET=amd64  make  buildenv
> Entering world for amd64:amd64
> # cd share/mk
> # make install
> "bsd.own.mk", line 435: Malformed conditional (${.MAKE.LEVEL} == 0)
> "bsd.own.mk", line 436: MK_PROFILE can't be set by a user.
> # ^D

This is news to me...

> I believe I am not the first person reporting the problem.

Half true…

Warner
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


make in dir

2014-04-02 Thread Konstantin Belousov
Hi,
it seems that recent changes to share/mk broke the ability to do anything
in subdir of the source tree.  As example, on the HEAD r264012 installed
yesterday:

sandy% make   /usr/home/pooma/build/bsd/DEV/src/tools/regression/kqueue
make: "/usr/share/mk/bsd.own.mk" line 436: MK_MAN can't be set by a user.

Also, on stable/9 hosting the HEAD cross-env:
cd src && MAKEOBJDIRPREFIX=/usr/home/kostik/build/bsd/DEV/obj-amd64 
DESTDIR=/usr/home/kostik/build/bsd/DEV/netboot/sandy-amd64 
SYSDIR=/usr/home/kostik/build/bsd/DEV/src/sys TARGET=amd64  make  buildenv
Entering world for amd64:amd64
# cd share/mk
# make install
"bsd.own.mk", line 435: Malformed conditional (${.MAKE.LEVEL} == 0)
"bsd.own.mk", line 436: MK_PROFILE can't be set by a user.
# ^D

I believe I am not the first person reporting the problem.


pgp71PvCxEAPv.pgp
Description: PGP signature