Re: sys/Makefile .if defined(MODULES_WITH_WORLD)
On Mon, 2018-07-09 at 11:50 +0200, Julian H. Stacey wrote: > Hi current@ > src/sys/dev/amdsbwd/amdsbwd.c broke src/sys/modules > > Is it immediately intuitive & well known to developers working in > sys/dev > to enable MODULES_WITH_WORLD before a test make all before a commit ? > > Or what should we do to increase the liklehood of commiters catching > modules/ errors before a commit ? > > With src/ > .ctm_status src-cur 13573 > .svn_revision 335362 > sys/Makefile has > .if defined(MODULES_WITH_WORLD) > SUBDIR+=modules > & nothing from cd /usr/src; find . -name \*src.conf\* > & no default /etc/src.conf with no > MODULES_WITH_WORLD=YES > so make all does not build /sys/modules/ > so this not seen from /sys/modules/ > ===> amdsbwd (all) > cc -O2 -pipe -DBERKLIX=YES -fno-strict-aliasing -Werror -D_KERNEL > -DKLD_MODULE -nostdinc -I. -I/data/release/s1/usr/src/sys > -I/data/release/s1/usr/src/sys/contrib/ck/include -fno-common -fno- > omit-frame-pointer -mno-omit-leaf-frame-pointer -MD - > MF.depend.amdsbwd.o -MTamdsbwd.o -mcmodel=kernel -mno-red-zone -mno- > mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables > -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls > -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer- > arith -Wcast-qual -Wundef -Wno-pointer-sign > -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs > -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error- > tautological-compare -Wno-error-empty-body -Wno-error-parentheses- > equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno- > error-shift-negative-value -Wno-address-of-packed-member -mno-aes > -mno-avx -std=iso9899:1999 -c > /data/release/s1/usr/src/sys/dev/amdsbwd/amdsbwd.c -o amdsbwd.o > /data/release/s1/usr/src/sys/dev/amdsbwd/amdsbwd.c:52:10: fatal > error: > 'opt_amdsbwd.h' file not found > #include "opt_amdsbwd.h" > > > PS With > .ctm_status src-cur 13601 > .svn_revision 336117 > nothing from > find . -name opt_amdsbwd.h > but this has > src/sys/dev/amdsbwd/amdsbwd.c > #include "opt_amdsbwd.h" > I haven't yet upgraded my src/ yet to see if it still fails. > > Cheers, > Julian Should be fixed in r336134. -- Ian ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
sys/Makefile .if defined(MODULES_WITH_WORLD)
Hi current@ src/sys/dev/amdsbwd/amdsbwd.c broke src/sys/modules Is it immediately intuitive & well known to developers working in sys/dev to enable MODULES_WITH_WORLD before a test make all before a commit ? Or what should we do to increase the liklehood of commiters catching modules/ errors before a commit ? With src/ .ctm_status src-cur 13573 .svn_revision 335362 sys/Makefile has .if defined(MODULES_WITH_WORLD) SUBDIR+=modules & nothing from cd /usr/src; find . -name \*src.conf\* & no default /etc/src.conf with no MODULES_WITH_WORLD=YES so make all does not build /sys/modules/ so this not seen from /sys/modules/ ===> amdsbwd (all) cc -O2 -pipe -DBERKLIX=YES -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/data/release/s1/usr/src/sys -I/data/release/s1/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD -MF.depend.amdsbwd.o -MTamdsbwd.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 -c /data/release/s1/usr/src/sys/dev/amdsbwd/amdsbwd.c -o amdsbwd.o /data/release/s1/usr/src/sys/dev/amdsbwd/amdsbwd.c:52:10: fatal error: 'opt_amdsbwd.h' file not found #include "opt_amdsbwd.h" PS With .ctm_status src-cur 13601 .svn_revision 336117 nothing from find . -name opt_amdsbwd.h but this has src/sys/dev/amdsbwd/amdsbwd.c #include "opt_amdsbwd.h" I haven't yet upgraded my src/ yet to see if it still fails. Cheers, Julian -- Julian Stacey, Computer Consultant, Systems Engineer, BSD Linux Unix, Munich Brexit Referendum stole 3.7 million votes inc. from 700,000 British in EU. UK Goverment lies it's democratic in Article 50 paragraph 3 of letter to EU. http://berklix.eu/queen/ https://www.peoples-vote.uk 193,000 @ 8 Jul 2018 ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
