Re: sys/sys/param.h: 'main' instead of 'Master'?
Master of origin;-) -- Deze e-mail en de inhoud is vertrouwelijk en uitsluitend bestemd voor de geadresseerde(n). Indien u niet de geadresseerde bent van deze e-mail verzoeken wij u dit direct door te geven aan de verzender door middel van een reply e-mail en de ontvangen e-mail uit uw systemen te verwijderen. Als u geen geadresseerde bent, is het niet toegestaan om kennis te nemen van de inhoud, deze te kopieren, te verspreiden, bekend te maken aan derden noch anderszins te gebruiken. The information contained in this e-mail is confidential and may be legally privileged. It is intended solely for the addressee. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful. Please notify us immediately if you have received it in error by reply e-mail and then delete this message from your system. Thanks, _ _ (_)(_) (,,) =()= ((__)\ _|L\___/ Save The Lab Rats On Fri, Apr 16, 2021 at 10:23 PM Warner Losh wrote: > On Fri, Apr 16, 2021 at 12:20 PM Michael Gmelin wrote: > > > > > > > > On 16. Apr 2021, at 19:29, Rodney W. Grimes < > > freebsd-...@gndrsh.dnsmgr.net> wrote: > > > > > > > > >> > > >> n Fri, Apr 16, 2021 at 11:36 AM Rainer Hurling > wrote: > > >>> > > >>> While viewing sys/sys/param.h I noticed that the comment of the > > >>> definition of __FreeBSD_version is probably out of date. > > >>> > > >>> Since the switch to Git, doesn't it have to be 'main' instead of > > 'master'? > > >>> > > >> > > >> This isn't based on a branch name, though I guess if one were going to > > >> touch it anyways then "Authoritative" would be a better descriptor. > > > > > > As well as "Origin". > > > > (Single) Source of Truth, maybe? > > > > s/Master, p/P/ also makes sense. > > Warner > > > > -m > > > > > > > >> > > >>> #cd /usr/src > > >>> #diff -urN sys/sys/param.h.orig sys/sys/param.h | colordiff > > >>> --- sys/sys/param.h.orig2021-04-09 12:59:25.363286000 +0200 > > >>> +++ sys/sys/param.h 2021-04-16 18:28:46.621429000 +0200 > > >>> @@ -60,7 +60,7 @@ > > >>> * in the range 5 to 9. > > >>> */ > > >>> #undef __FreeBSD_version > > >>> -#define __FreeBSD_version 147 /* Master, propagated to > > newvers */ > > >>> +#define __FreeBSD_version 147 /* main, propagated to > newvers > > */ > > >>> > > >>> /* > > >>> * __FreeBSD_kernel__ indicates that this system uses the kernel of > > >>> FreeBSD, > > >>> > > >>> ___ > > >>> freebsd-current@freebsd.org mailing list > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-current > > >>> To unsubscribe, send any mail to " > > freebsd-current-unsubscr...@freebsd.org" > > >> ___ > > >> freebsd-current@freebsd.org mailing list > > >> https://lists.freebsd.org/mailman/listinfo/freebsd-current > > >> To unsubscribe, send any mail to " > > freebsd-current-unsubscr...@freebsd.org" > > >> > > > > > > -- > > > Rod Grimes > > rgri...@freebsd.org > > > ___ > > > freebsd-current@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > > To unsubscribe, send any mail to " > > freebsd-current-unsubscr...@freebsd.org" > > > > ___ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to " > freebsd-current-unsubscr...@freebsd.org" > > > ___ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" > ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
On Mon, Apr 19, 2021 at 7:12 AM Rodney W. Grimes < freebsd-...@gndrsh.dnsmgr.net> wrote: > > On Sun, Apr 18, 2021 at 07:07:44PM -0400, Ed Maste wrote: > > > On Fri, 16 Apr 2021 at 16:22, Warner Losh wrote: > > > > > > > > > > As well as "Origin". > > > > > > > > > > (Single) Source of Truth, maybe? > > > > > > > > s/Master, p/P/ also makes sense. > > > > > > IMO instead of lightly rewording the existing comment we could just > > > remove it, it doesn't really add any clarity. > > > > > > Instead we ought to add an introductory sentence or two to the block > > > comment above, explaining what __FreeBSD_version actually is. > > > > fully agreed here! I had to explained many time what __FreeBSD_version > actually > > was. A clear comment would be great ;) > > Yes please! Well, we explain the scheme w/o explaining when / why you'd want to bump it. https://reviews.freebsd.org/D29850 has my attempt to do the latter. Please comment there... Warner ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
> On Sun, Apr 18, 2021 at 07:07:44PM -0400, Ed Maste wrote: > > On Fri, 16 Apr 2021 at 16:22, Warner Losh wrote: > > > > > > > > As well as "Origin". > > > > > > > > (Single) Source of Truth, maybe? > > > > > > s/Master, p/P/ also makes sense. > > > > IMO instead of lightly rewording the existing comment we could just > > remove it, it doesn't really add any clarity. > > > > Instead we ought to add an introductory sentence or two to the block > > comment above, explaining what __FreeBSD_version actually is. > > fully agreed here! I had to explained many time what __FreeBSD_version > actually > was. A clear comment would be great ;) Yes please! -- Rod Grimes rgri...@freebsd.org ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
On Sun, Apr 18, 2021 at 07:07:44PM -0400, Ed Maste wrote: > On Fri, 16 Apr 2021 at 16:22, Warner Losh wrote: > > > > > > As well as "Origin". > > > > > > (Single) Source of Truth, maybe? > > > > s/Master, p/P/ also makes sense. > > IMO instead of lightly rewording the existing comment we could just > remove it, it doesn't really add any clarity. > > Instead we ought to add an introductory sentence or two to the block > comment above, explaining what __FreeBSD_version actually is. fully agreed here! I had to explained many time what __FreeBSD_version actually was. A clear comment would be great ;) Bapt ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
On Fri, 16 Apr 2021 at 16:22, Warner Losh wrote: > > > > As well as "Origin". > > > > (Single) Source of Truth, maybe? > > s/Master, p/P/ also makes sense. IMO instead of lightly rewording the existing comment we could just remove it, it doesn't really add any clarity. Instead we ought to add an introductory sentence or two to the block comment above, explaining what __FreeBSD_version actually is. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
On Fri, Apr 16, 2021 at 12:20 PM Michael Gmelin wrote: > > > > On 16. Apr 2021, at 19:29, Rodney W. Grimes < > freebsd-...@gndrsh.dnsmgr.net> wrote: > > > > > >> > >> n Fri, Apr 16, 2021 at 11:36 AM Rainer Hurling wrote: > >>> > >>> While viewing sys/sys/param.h I noticed that the comment of the > >>> definition of __FreeBSD_version is probably out of date. > >>> > >>> Since the switch to Git, doesn't it have to be 'main' instead of > 'master'? > >>> > >> > >> This isn't based on a branch name, though I guess if one were going to > >> touch it anyways then "Authoritative" would be a better descriptor. > > > > As well as "Origin". > > (Single) Source of Truth, maybe? > s/Master, p/P/ also makes sense. Warner > -m > > > > >> > >>> #cd /usr/src > >>> #diff -urN sys/sys/param.h.orig sys/sys/param.h | colordiff > >>> --- sys/sys/param.h.orig2021-04-09 12:59:25.363286000 +0200 > >>> +++ sys/sys/param.h 2021-04-16 18:28:46.621429000 +0200 > >>> @@ -60,7 +60,7 @@ > >>> * in the range 5 to 9. > >>> */ > >>> #undef __FreeBSD_version > >>> -#define __FreeBSD_version 147 /* Master, propagated to > newvers */ > >>> +#define __FreeBSD_version 147 /* main, propagated to newvers > */ > >>> > >>> /* > >>> * __FreeBSD_kernel__ indicates that this system uses the kernel of > >>> FreeBSD, > >>> > >>> ___ > >>> freebsd-current@freebsd.org mailing list > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-current > >>> To unsubscribe, send any mail to " > freebsd-current-unsubscr...@freebsd.org" > >> ___ > >> freebsd-current@freebsd.org mailing list > >> https://lists.freebsd.org/mailman/listinfo/freebsd-current > >> To unsubscribe, send any mail to " > freebsd-current-unsubscr...@freebsd.org" > >> > > > > -- > > Rod Grimes > rgri...@freebsd.org > > ___ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to " > freebsd-current-unsubscr...@freebsd.org" > > ___ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" > ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
> On 16. Apr 2021, at 19:29, Rodney W. Grimes > wrote: > > >> >> n Fri, Apr 16, 2021 at 11:36 AM Rainer Hurling wrote: >>> >>> While viewing sys/sys/param.h I noticed that the comment of the >>> definition of __FreeBSD_version is probably out of date. >>> >>> Since the switch to Git, doesn't it have to be 'main' instead of 'master'? >>> >> >> This isn't based on a branch name, though I guess if one were going to >> touch it anyways then "Authoritative" would be a better descriptor. > > As well as "Origin". (Single) Source of Truth, maybe? -m > >> >>> #cd /usr/src >>> #diff -urN sys/sys/param.h.orig sys/sys/param.h | colordiff >>> --- sys/sys/param.h.orig2021-04-09 12:59:25.363286000 +0200 >>> +++ sys/sys/param.h 2021-04-16 18:28:46.621429000 +0200 >>> @@ -60,7 +60,7 @@ >>> * in the range 5 to 9. >>> */ >>> #undef __FreeBSD_version >>> -#define __FreeBSD_version 147 /* Master, propagated to newvers */ >>> +#define __FreeBSD_version 147 /* main, propagated to newvers */ >>> >>> /* >>> * __FreeBSD_kernel__ indicates that this system uses the kernel of >>> FreeBSD, >>> >>> ___ >>> freebsd-current@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-current >>> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" >> ___ >> freebsd-current@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" >> > > -- > Rod Grimes rgri...@freebsd.org > ___ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
> n Fri, Apr 16, 2021 at 11:36 AM Rainer Hurling wrote: > > > > While viewing sys/sys/param.h I noticed that the comment of the > > definition of __FreeBSD_version is probably out of date. > > > > Since the switch to Git, doesn't it have to be 'main' instead of 'master'? > > > > This isn't based on a branch name, though I guess if one were going to > touch it anyways then "Authoritative" would be a better descriptor. As well as "Origin". > > > #cd /usr/src > > #diff -urN sys/sys/param.h.orig sys/sys/param.h | colordiff > > --- sys/sys/param.h.orig2021-04-09 12:59:25.363286000 +0200 > > +++ sys/sys/param.h 2021-04-16 18:28:46.621429000 +0200 > > @@ -60,7 +60,7 @@ > > * in the range 5 to 9. > > */ > > #undef __FreeBSD_version > > -#define __FreeBSD_version 147 /* Master, propagated to newvers */ > > +#define __FreeBSD_version 147 /* main, propagated to newvers */ > > > > /* > > * __FreeBSD_kernel__ indicates that this system uses the kernel of > > FreeBSD, > > > > ___ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" > ___ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" > -- Rod Grimes rgri...@freebsd.org ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
Am 16.04.21 um 18:38 schrieb Kyle Evans: > n Fri, Apr 16, 2021 at 11:36 AM Rainer Hurling wrote: >> >> While viewing sys/sys/param.h I noticed that the comment of the >> definition of __FreeBSD_version is probably out of date. >> >> Since the switch to Git, doesn't it have to be 'main' instead of 'master'? >> > > This isn't based on a branch name, though I guess if one were going to > touch it anyways then "Authoritative" would be a better descriptor. Sounds reasonable. Thanks for the explanation. > >> #cd /usr/src >> #diff -urN sys/sys/param.h.orig sys/sys/param.h | colordiff >> --- sys/sys/param.h.orig2021-04-09 12:59:25.363286000 +0200 >> +++ sys/sys/param.h 2021-04-16 18:28:46.621429000 +0200 >> @@ -60,7 +60,7 @@ >> * in the range 5 to 9. >> */ >> #undef __FreeBSD_version >> -#define __FreeBSD_version 147 /* Master, propagated to newvers */ >> +#define __FreeBSD_version 147 /* main, propagated to newvers */ >> >> /* >> * __FreeBSD_kernel__ indicates that this system uses the kernel of >> FreeBSD, >> ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: sys/sys/param.h: 'main' instead of 'Master'?
n Fri, Apr 16, 2021 at 11:36 AM Rainer Hurling wrote: > > While viewing sys/sys/param.h I noticed that the comment of the > definition of __FreeBSD_version is probably out of date. > > Since the switch to Git, doesn't it have to be 'main' instead of 'master'? > This isn't based on a branch name, though I guess if one were going to touch it anyways then "Authoritative" would be a better descriptor. > #cd /usr/src > #diff -urN sys/sys/param.h.orig sys/sys/param.h | colordiff > --- sys/sys/param.h.orig2021-04-09 12:59:25.363286000 +0200 > +++ sys/sys/param.h 2021-04-16 18:28:46.621429000 +0200 > @@ -60,7 +60,7 @@ > * in the range 5 to 9. > */ > #undef __FreeBSD_version > -#define __FreeBSD_version 147 /* Master, propagated to newvers */ > +#define __FreeBSD_version 147 /* main, propagated to newvers */ > > /* > * __FreeBSD_kernel__ indicates that this system uses the kernel of > FreeBSD, > > ___ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
sys/sys/param.h: 'main' instead of 'Master'?
While viewing sys/sys/param.h I noticed that the comment of the definition of __FreeBSD_version is probably out of date. Since the switch to Git, doesn't it have to be 'main' instead of 'master'? #cd /usr/src #diff -urN sys/sys/param.h.orig sys/sys/param.h | colordiff --- sys/sys/param.h.orig2021-04-09 12:59:25.363286000 +0200 +++ sys/sys/param.h 2021-04-16 18:28:46.621429000 +0200 @@ -60,7 +60,7 @@ * in the range 5 to 9. */ #undef __FreeBSD_version -#define __FreeBSD_version 147 /* Master, propagated to newvers */ +#define __FreeBSD_version 147 /* main, propagated to newvers */ /* * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD, ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
