virtualbox-ose: missing OpenGL dependency

2014-01-08 Thread Jimmy Olgeni 


Hello,

After the latest QT4 changes I noticed that VirtualBox needs a 
dependency on graphics/qt4-opengl, so here it is (checked on 
poudriere):


Index: Makefile
===
--- Makefile(revision 339028)
+++ Makefile(working copy)
@@ -27,7 +27,8 @@
python:${PORTSDIR}/lang/python
 LIB_DEPENDS=   libpng.so:${PORTSDIR}/graphics/png \
libxslt.so:${PORTSDIR}/textproc/libxslt \
-   libcurl.so:${PORTSDIR}/ftp/curl
+   libcurl.so:${PORTSDIR}/ftp/curl \
+   libQtOpenGL.so:${PORTSDIR}/graphics/qt4-opengl
 RUN_DEPENDS=   ${KMODDIR}/vboxdrv.ko:${PORTSDIR}/emulators/virtualbox-ose-kmod 
\
cdrecord:${PORTSDIR}/sysutils/cdrtools

--
jimmy
___
freebsd-emulation@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-emulation
To unsubscribe, send any mail to freebsd-emulation-unsubscr...@freebsd.org

Re: virtualbox-ose: missing OpenGL dependency

2014-01-08 Thread Bernhard Fröhlich 
On Wed, Jan 8, 2014 at 12:29 PM, Jimmy Olgeni olg...@olgeni.com wrote:

 Hello,

 After the latest QT4 changes I noticed that VirtualBox needs a dependency on
 graphics/qt4-opengl, so here it is (checked on poudriere):

 Index: Makefile
 ===
 --- Makefile(revision 339028)
 +++ Makefile(working copy)
 @@ -27,7 +27,8 @@
 python:${PORTSDIR}/lang/python
  LIB_DEPENDS=   libpng.so:${PORTSDIR}/graphics/png \
 libxslt.so:${PORTSDIR}/textproc/libxslt \
 -   libcurl.so:${PORTSDIR}/ftp/curl
 +   libcurl.so:${PORTSDIR}/ftp/curl \
 +   libQtOpenGL.so:${PORTSDIR}/graphics/qt4-opengl
  RUN_DEPENDS=
 ${KMODDIR}/vboxdrv.ko:${PORTSDIR}/emulators/virtualbox-ose-kmod \
 cdrecord:${PORTSDIR}/sysutils/cdrtools

You might be correct but the patch looks wrong to me so I propose the following.

Index: emulators/virtualbox-ose/Makefile
===
--- emulators/virtualbox-ose/Makefile(revision 339142)
+++ emulators/virtualbox-ose/Makefile(working copy)
@@ -124,7 +124,7 @@

 .if ${PORT_OPTIONS:MQT4}
 QT_NONSTANDARD=yes
-USE_QT4=gui network moc_build uic_build rcc_build linguist
+USE_QT4=gui network moc_build opengl uic_build rcc_build linguist
 INSTALLS_ICONS=yes
 VBOX_FRONTENDS+=VirtualBox VBoxTestOGL

-- 
Bernhard Froehlich
http://www.bluelife.at/
___
freebsd-emulation@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-emulation
To unsubscribe, send any mail to freebsd-emulation-unsubscr...@freebsd.org

Re: virtualbox-ose: missing OpenGL dependency

2014-01-08 Thread Jimmy Olgeni 


On Wed, 8 Jan 2014, Bernhard Fröhlich wrote:


You might be correct but the patch looks wrong to me so I propose the following.

Index: emulators/virtualbox-ose/Makefile
===
--- emulators/virtualbox-ose/Makefile(revision 339142)
+++ emulators/virtualbox-ose/Makefile(working copy)
@@ -124,7 +124,7 @@

.if ${PORT_OPTIONS:MQT4}
QT_NONSTANDARD=yes
-USE_QT4=gui network moc_build uic_build rcc_build linguist
+USE_QT4=gui network moc_build opengl uic_build rcc_build linguist
INSTALLS_ICONS=yes
VBOX_FRONTENDS+=VirtualBox VBoxTestOGL


I also brought in X11 :|

Rebuilding with the new patch right now...

Thanks!

--
jimmy
___
freebsd-emulation@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-emulation
To unsubscribe, send any mail to freebsd-emulation-unsubscr...@freebsd.org