Re: Spot the error

2009-08-05 Thread Dimitry Andric
On 2009-08-05 02:15, Mel Flynn wrote:
 I would expect Unable to load fs:  + ENOENT. I was asking if this was 
 fixable, cause it looked like the code has been abstracted to the point that 
 specific errors were hard, but maybe I missed something.

It does not seem easily fixable.  The problem is that the mount command
simply prints out the error of the system call, and doesn't have any
idea which of the (many) parameters was wrong.

You could change the returned error in this particular case to ENOENT,
of course, but that might be considered even more confusing.  Like,
What do you mean, that SCSI disk doesn't exist? It's right there in
/dev!

One could also argue for EINVAL, but there's the bikeshed again... :)
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org


Re: Spot the error

2009-08-05 Thread Alfred Perlstein
* Dimitry Andric dimi...@andric.com [090805 06:51] wrote:
 On 2009-08-05 02:15, Mel Flynn wrote:
  I would expect Unable to load fs:  + ENOENT. I was asking if this was 
  fixable, cause it looked like the code has been abstracted to the point 
  that 
  specific errors were hard, but maybe I missed something.
 
 It does not seem easily fixable.  The problem is that the mount command
 simply prints out the error of the system call, and doesn't have any
 idea which of the (many) parameters was wrong.
 
 You could change the returned error in this particular case to ENOENT,
 of course, but that might be considered even more confusing.  Like,
 What do you mean, that SCSI disk doesn't exist? It's right there in
 /dev!
 
 One could also argue for EINVAL, but there's the bikeshed again... :)

mount 9 could be augmented to preflight/postflight the vfs type name
through the provide a better error.


-- 
- Alfred Perlstein
.- AMA, VMOA #5191, 03 vmax, 92 gs500, 85 ch250
.- FreeBSD committer
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org