[PATCH] libusbhid(3) should not clear report_size field
Dear Hackers, while working on bluetooth hid implementation i found out that libusbhid(3) has minor problem. it turns out that netbsd folks already fixed this. http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libusbhid/parse.c.diff?sortby=dater1=1.4r2=1.5f=u so, i'd like to commit the patch below. who is our resident USB HID expert? please speak up if there is any problem, concern or objection. thanks, max freefall% scvs diff -u src/lib/libusbhid cvs server: Diffing src/lib/libusbhid Index: src/lib/libusbhid/parse.c === RCS file: /home/ncvs/src/lib/libusbhid/parse.c,v retrieving revision 1.8 diff -u -r1.8 parse.c --- src/lib/libusbhid/parse.c 9 Apr 2003 01:52:48 - 1.8 +++ src/lib/libusbhid/parse.c 26 Jan 2004 22:25:26 - @@ -86,7 +86,6 @@ c-string_minimum = 0; c-string_maximum = 0; c-set_delimiter = 0; - c-report_size = 0; } hid_data_t __ Do you Yahoo!? Yahoo! SiteBuilder - Free web site building tool. Try it! http://webhosting.yahoo.com/ps/sb/ ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: [PATCH] libusbhid(3) should not clear report_size field
On Mon, 26 Jan 2004, Maksim Yevmenkin wrote: Index: src/lib/libusbhid/parse.c === RCS file: /home/ncvs/src/lib/libusbhid/parse.c,v retrieving revision 1.8 diff -u -r1.8 parse.c --- src/lib/libusbhid/parse.c 9 Apr 2003 01:52:48 - 1.8 +++ src/lib/libusbhid/parse.c 26 Jan 2004 22:25:26 - @@ -86,7 +86,6 @@ c-string_minimum = 0; c-string_maximum = 0; c-set_delimiter = 0; - c-report_size = 0; } hid_data_t I've tried to keep them in sync in the past so this looks good to me. -- 10 40 80 C0 00 FF FF FF FF C0 00 00 00 00 10 AA AA 03 00 00 00 08 00 ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: [PATCH] libusbhid(3) should not clear report_size field
Matthew N. Dodd wrote: On Mon, 26 Jan 2004, Maksim Yevmenkin wrote: Index: src/lib/libusbhid/parse.c === RCS file: /home/ncvs/src/lib/libusbhid/parse.c,v retrieving revision 1.8 diff -u -r1.8 parse.c --- src/lib/libusbhid/parse.c 9 Apr 2003 01:52:48 - 1.8 +++ src/lib/libusbhid/parse.c 26 Jan 2004 22:25:26 - @@ -86,7 +86,6 @@ c-string_minimum = 0; c-string_maximum = 0; c-set_delimiter = 0; - c-report_size = 0; } hid_data_t I've tried to keep them in sync in the past so this looks good to me. Oh. I was under inpression of this: lib/libusbhid/Makefile:MAINTAINER= [EMAIL PROTECTED] I sent patch above to maintainer about three month ago but get no responce. Fianlly mailed everyone incl. NetBSD guys, filled PR and gaveup :-( Obviously Nick is very busy with real life and there is a sence to expand/reassign/release ubs maintainership? All the best, Alexander. ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to [EMAIL PROTECTED]
