Re: Consistent use of lex flags
All these changes look good. Since they aren't changes to lex itself, but how the base uses standard lex interfaces, I'd say we should just commit it. Warner On Aug 8, 2012, at 2:59 PM, Dan McGregor wrote: Hi. I was just noticing that mkcsmapper doesn't build with clang. I saw two ways to do this, the first being to #define YY_NO_INPUT, and the other to use the %option noinput lex flag. While there, I decided to explore and I changed a bunch of #defines to the standard lex way of doing things. I thought it would be good if all the code that originated in FreeBSD could be consistent. Thoughts? lex.diff___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Consistent use of lex flags
Hi. I was just noticing that mkcsmapper doesn't build with clang. I saw two ways to do this, the first being to #define YY_NO_INPUT, and the other to use the %option noinput lex flag. While there, I decided to explore and I changed a bunch of #defines to the standard lex way of doing things. I thought it would be good if all the code that originated in FreeBSD could be consistent. Thoughts? lex.diff Description: Binary data ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Re: Consistent use of lex flags
On Wed, Aug 8, 2012 at 1:59 PM, Dan McGregor danismostlik...@gmail.com wrote: Hi. I was just noticing that mkcsmapper doesn't build with clang. I saw two ways to do this, the first being to #define YY_NO_INPUT, and the other to use the %option noinput lex flag. While there, I decided to explore and I changed a bunch of #defines to the standard lex way of doing things. I thought it would be good if all the code that originated in FreeBSD could be consistent. Thoughts? Probably should CC gabor@ next time (done this time) and maybe involve the NetBSD folks as this code is sort of upstreamed from them IIRC. Cheers! -Garrett ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
