Re: New rc.d init script roadmap
Cyrille Lefevre <[EMAIL PROTECTED]> wrote: > > I'm just reporting this one exists as you report the existence of > Kevin Way's work two days ago. of course, it would be better to > have a -rc mailing list. Not really. One more list to follow, when threads in existing lists will probably be enough for this. We don't have one mailing list for every port category, or for every different part of contrib/. It's overkill to create a list for something like this IMHO :/ -giorgos To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
David O'Brien wrote: > On Thu, Oct 18, 2001 at 11:29:59PM +0200, Cyrille Lefevre wrote: > > > > I've prepared a status report about this project. the xml file in > > attachment have to be reviewed since I've just put descriptions > > from FreeBSD-rc's Yahoo! Group and your email message. > > WHY in the world are you sending in a "status" report about this? to record this task as a real project and to avoid duplicates works... > >From this thread we are still flushing out details to the point there is > nothing we can say. > > > first of all, there should be a consensus about the owner of > > this project ? also, who create the FreeBSD-rc's Yahoo! Group ? > > We don't need a Yahoo! group. There is zero wrong with the archived > FreeBSD mailing lists. They have worked for FreeBSD development for 8 > years now. I'm just reporting this one exists as you report the existence of Kevin Way's work two days ago. of course, it would be better to have a -rc mailing list. Cyrille. -- Cyrille Lefevre mailto:[EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
On Thu, Oct 18, 2001 at 11:29:59PM +0200, Cyrille Lefevre wrote: > > I've prepared a status report about this project. the xml file in > attachment have to be reviewed since I've just put descriptions > from FreeBSD-rc's Yahoo! Group and your email message. WHY in the world are you sending in a "status" report about this? >From this thread we are still flushing out details to the point there is nothing we can say. > first of all, there should be a consensus about the owner of > this project ? also, who create the FreeBSD-rc's Yahoo! Group ? We don't need a Yahoo! group. There is zero wrong with the archived FreeBSD mailing lists. They have worked for FreeBSD development for 8 years now. -- -- David ([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
On Thu, Oct 18, 2001 at 09:47:53PM +0200, Dag-Erling Smorgrav wrote: > Dag-Erling Smorgrav <[EMAIL PROTECTED]> writes: > > Your rcorder patch is incorrect. > > Here's a correct patch. Does anybody mind if I commit this and > connect rcorder(8) to the build? YES I MIND!! What part of "it is on the vendor branch for now" don't you understand? Stop picking at the trival fruit on the ground and instead help with the fruit in /etc/rc.d/. I really didn't think this thread was going to bikeshed, but I was very wrong. Lets work on an actual prototype (who cares if it is rough) so we have something that actually does *something*. If you don't like my patch, you are certainly free to post another one. -- -- David ([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
On 18-Oct-01 Dag-Erling Smorgrav wrote: > Gordon Tetlow <[EMAIL PROTECTED]> writes: >> Actually, fparseln() is defined in libutil.h (per the man page). I don't >> have my current box available (power outage at home), but if you could >> look over it, it should work. > > Ah, that's right - I couldn't find the right header, I should have > simply looked at the libutil Makefile. Thanks! Or the fparseln(3) manpage which lists the includes. :) -- John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
On 18 Oct 2001, Dag-Erling Smorgrav wrote: > John Baldwin <[EMAIL PROTECTED]> writes: > > Huh? Int on alpha is 32, and pointer is 64. > > I thought we were ILP64 on 64-bit archs, but you're right. And I > ought to know better... Fortunately (?) it doesn't matter in this case. Function arguments which are passed in registers are all promoted to 64bits. -- Doug Rabson Mail: [EMAIL PROTECTED] Phone: +44 20 8348 6160 To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
after reading -arch, the contact and links sections have been updated. Cyrille. -- Cyrille Lefevre mailto:[EMAIL PROTECTED] rcNG: Improving FreeBSD startup scripts Doug Barton Commiter [EMAIL PROTECTED] Kevin Way Contributor [EMAIL PROTECTED] Gordon Tetlow Contributor [EMAIL PROTECTED] http://groups.yahoo.com/group/FreeBSD-rc/";>Improving FreeBSD startup scripts http://www.cs.rmit.edu.au/~lukem/bibliography.html";>Luke Mewburn's papers http://www.netbsd.org/Documentation/rc/";>NetBSD Initialization and Services Control http://overtone.org/rc.d/";>FreeBSD rc.d reorganization project <-- from http://groups.yahoo.com/group/FreeBSD-rc/ --> This group is for discussion about the startup scripts in FreeBSD, primarily the scripts in /etc/rc*. Primary focus will be on improvements and importation of NetBSD's excellent work on this topic. <-- from [EMAIL PROTECTED] --> Alright folks, I finally got off my butt last night and put together a roadmap for the migration to the new rc.d init scripts that were imported from NetBSD a long time ago and just sat in the tree. M1 (Patch included) Setup infrastructure Make rcorder compile Hook rc.subr into the distribution (and mergemaster) Hook rcorder into the world Add toggle in rc.conf to switch between rc_ng and current boot scripts M2 Get FreeBSD to boot with the new boot scripts Rewrite the /etc/rc.d scripts to work with FreeBSD M3 Add some FreeBSD specific support into rc.subr M4 Add true dependency checking to the infrastructure so that starting nfsd will start mountd and rpcbind Add support into rc.subr Add dependencies into rc.d scripts I'd like a couple of people to take a look at this and then I'll submit a pr for it if there aren't too many objections. I'm expecting M2 to run into quite a bikeshed, but hey, I got my nice shiny asbestos back from the cleaners.
Re: New rc.d init script roadmap
John Baldwin <[EMAIL PROTECTED]> writes: > Huh? Int on alpha is 32, and pointer is 64. I thought we were ILP64 on 64-bit archs, but you're right. And I ought to know better... DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
On 18-Oct-01 Dag-Erling Smorgrav wrote: > Gordon Tetlow <[EMAIL PROTECTED]> writes: >> M1 (Patch included) >> Setup infrastructure >> Make rcorder compile > > Your rcorder patch is incorrect. FreeBSD lacks a prototype for > fparseln(). It so happens that it doesn't make any difference on any > of the platforms FreeBSD supports (because our ints and pointers are > the same size), but that's no reason not to do things right. Huh? Int on alpha is 32, and pointer is 64. -- John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
Hi, I've prepared a status report about this project. the xml file in attachment have to be reviewed since I've just put descriptions from FreeBSD-rc's Yahoo! Group and your email message. first of all, there should be a consensus about the owner of this project ? also, who create the FreeBSD-rc's Yahoo! Group ? then you have to submit a status report to avoid duplicates work... I also done some stuffs on this some months ago, but I have to review it. don't remember the status of my job... :( Cyrille. -- Cyrille Lefevre mailto:[EMAIL PROTECTED] Improving FreeBSD startup scripts Doug Barton Commiter [EMAIL PROTECTED] Gordon Tetlow Contributor [EMAIL PROTECTED] http://groups.yahoo.com/group/FreeBSD-rc/";>Improving FreeBSD startup scripts http://www.cs.rmit.edu.au/~lukem/bibliography.html";>Luke Mewburn's papers http://www.netbsd.org/Documentation/rc/";>NetBSD Initialization and Services Control <-- from http://groups.yahoo.com/group/FreeBSD-rc/ --> This group is for discussion about the startup scripts in FreeBSD, primarily the scripts in /etc/rc*. Primary focus will be on improvements and importation of NetBSD's excellent work on this topic. <-- from [EMAIL PROTECTED] --> Alright folks, I finally got off my butt last night and put together a roadmap for the migration to the new rc.d init scripts that were imported from NetBSD a long time ago and just sat in the tree. M1 (Patch included) Setup infrastructure Make rcorder compile Hook rc.subr into the distribution (and mergemaster) Hook rcorder into the world Add toggle in rc.conf to switch between rc_ng and current boot scripts M2 Get FreeBSD to boot with the new boot scripts Rewrite the /etc/rc.d scripts to work with FreeBSD M3 Add some FreeBSD specific support into rc.subr M4 Add true dependency checking to the infrastructure so that starting nfsd will start mountd and rpcbind Add support into rc.subr Add dependencies into rc.d scripts I'd like a couple of people to take a look at this and then I'll submit a pr for it if there aren't too many objections. I'm expecting M2 to run into quite a bikeshed, but hey, I got my nice shiny asbestos back from the cleaners.
Re: New rc.d init script roadmap
Gordon Tetlow <[EMAIL PROTECTED]> writes: > Actually, fparseln() is defined in libutil.h (per the man page). I don't > have my current box available (power outage at home), but if you could > look over it, it should work. Ah, that's right - I couldn't find the right header, I should have simply looked at the libutil Makefile. Thanks! DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
On 18 Oct 2001, Dag-Erling Smorgrav wrote: > Dag-Erling Smorgrav <[EMAIL PROTECTED]> writes: > > Your rcorder patch is incorrect. > > Here's a correct patch. Does anybody mind if I commit this and > connect rcorder(8) to the build? Actually, fparseln() is defined in libutil.h (per the man page). I don't have my current box available (power outage at home), but if you could look over it, it should work. -gordon Index: rcorder.c === RCS file: /home/ncvs/src/sbin/rcorder/rcorder.c,v retrieving revision 1.1.1.1 diff -u -r1.1.1.1 rcorder.c --- rcorder.c 16 Jun 2001 07:16:14 - 1.1.1.1 +++ rcorder.c 18 Oct 2001 19:45:27 - @@ -41,7 +41,11 @@ #include #include #include +#if defined(__NetBSD__) #include +#else +#include +#endif #include "ealloc.h" #include "sprite.h" To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
On 18 Oct 2001, Dag-Erling Smorgrav wrote: > Gordon Tetlow <[EMAIL PROTECTED]> writes: > > M1 (Patch included) > > Setup infrastructure > > Make rcorder compile > > Your rcorder patch is incorrect. FreeBSD lacks a prototype for > fparseln(). It so happens that it doesn't make any difference on any > of the platforms FreeBSD supports (because our ints and pointers are > the same size), but that's no reason not to do things right. I was wondering about that warning myself, but it seemed to work and I don't try to pretend to be a master of C. I'll stick to the shell world in general. > Also, I don't see the point in munging the Makefile like you do - I > think we can live with having a Makefile that's slightly (and > trivially) different from NetBSD's. Fair enough, everyone seemed to be touting the flag of portability so I just added it into the mix as well. -gordon To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
Dag-Erling Smorgrav <[EMAIL PROTECTED]> writes:
> Here's a correct patch.
Murphy's Law of Attachments, etc.
DES
--
Dag-Erling Smorgrav - [EMAIL PROTECTED]
Index: Makefile
===
RCS file: /home/ncvs/src/sbin/rcorder/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- Makefile 16 Jun 2001 07:16:14 - 1.1.1.1
+++ Makefile 18 Oct 2001 19:44:57 -
@@ -3,11 +3,12 @@
PROG= rcorder
SRCS= ealloc.c hash.c rcorder.c
MAN= rcorder.8
+WARNS?= 2
LDADD+= -lutil
DPADD+= ${LIBUTIL}
# XXX hack for make's hash.[ch]
-CPPFLAGS+= -DORDER
+CFLAGS+= -DORDER
.include
Index: rcorder.c
===
RCS file: /home/ncvs/src/sbin/rcorder/rcorder.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 rcorder.c
--- rcorder.c 16 Jun 2001 07:16:14 - 1.1.1.1
+++ rcorder.c 18 Oct 2001 19:45:27 -
@@ -41,7 +41,11 @@
#include
#include
#include
+#if defined(__NetBSD__)
#include
+#else
+char *fparseln(FILE *, size_t *, size_t *, const char[3], int);
+#endif
#include "ealloc.h"
#include "sprite.h"
Re: New rc.d init script roadmap
Dag-Erling Smorgrav <[EMAIL PROTECTED]> writes:
> Your rcorder patch is incorrect.
Here's a correct patch. Does anybody mind if I commit this and
connect rcorder(8) to the build?
DES
--
Dag-Erling Smorgrav - [EMAIL PROTECTED]
Index: Makefile
===
RCS file: /home/ncvs/src/sbin/rcorder/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- Makefile 16 Jun 2001 07:16:14 - 1.1.1.1
+++ Makefile 18 Oct 2001 19:44:57 -
@@ -3,11 +3,12 @@
PROG= rcorder
SRCS= ealloc.c hash.c rcorder.c
MAN= rcorder.8
+WARNS?= 2
LDADD+= -lutil
DPADD+= ${LIBUTIL}
# XXX hack for make's hash.[ch]
-CPPFLAGS+= -DORDER
+CFLAGS+= -DORDER
.include
Index: rcorder.c
===
RCS file: /home/ncvs/src/sbin/rcorder/rcorder.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 rcorder.c
--- rcorder.c 16 Jun 2001 07:16:14 - 1.1.1.1
+++ rcorder.c 18 Oct 2001 19:45:27 -
@@ -41,7 +41,11 @@
#include
#include
#include
+#if defined(__NetBSD__)
#include
+#else
+char *fparseln(FILE *, size_t *, size_t *, const char[3], int);
+#endif
#include "ealloc.h"
#include "sprite.h"
Re: New rc.d init script roadmap
Dag-Erling Smorgrav <[EMAIL PROTECTED]> writes: > Your rcorder patch is incorrect. Here's a correct patch. Does anybody mind if I commit this and connect rcorder(8) to the build? DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
Re: New rc.d init script roadmap
Gordon Tetlow <[EMAIL PROTECTED]> writes: > M1 (Patch included) > Setup infrastructure > Make rcorder compile Your rcorder patch is incorrect. FreeBSD lacks a prototype for fparseln(). It so happens that it doesn't make any difference on any of the platforms FreeBSD supports (because our ints and pointers are the same size), but that's no reason not to do things right. Also, I don't see the point in munging the Makefile like you do - I think we can live with having a Makefile that's slightly (and trivially) different from NetBSD's. DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
New rc.d init script roadmap
Alright folks, I finally got off my butt last night and put together a
roadmap for the migration to the new rc.d init scripts that were imported
from NetBSD a long time ago and just sat in the tree.
M1 (Patch included)
Setup infrastructure
Make rcorder compile
Hook rc.subr into the distribution (and mergemaster)
Hook rcorder into the world
Add toggle in rc.conf to switch between rc_ng and current boot scripts
M2
Get FreeBSD to boot with the new boot scripts
Rewrite the /etc/rc.d scripts to work with FreeBSD
M3
Add some FreeBSD specific support into rc.subr
M4
Add true dependency checking to the infrastructure so that starting nfsd
will start mountd and rpcbind
Add support into rc.subr
Add dependencies into rc.d scripts
I'd like a couple of people to take a look at this and then I'll submit a
pr for it if there aren't too many objections. I'm expecting M2 to run
into quite a bikeshed, but hey, I got my nice shiny asbestos back from the
cleaners.
-gordon
--- etc/Makefile.orig Wed Oct 17 20:04:07 2001
+++ etc/MakefileWed Oct 17 22:29:38 2001
@@ -13,7 +13,7 @@
motd modems netconfig networks newsyslog.conf \
pam.conf phones printcap profile protocols \
rc rc.atm rc.devfs rc.diskless1 rc.diskless2 rc.firewall rc.firewall6 \
- rc.network rc.network6 rc.pccard rc.serial rc.shutdown \
+ rc.network rc.network6 rc.pccard rc.serial rc.shutdown rc.subr \
rc.syscons rc.sysctl remote rpc security services shells sysctl.conf \
syslog.conf usbd.conf \
etc.${MACHINE_ARCH}/disktab \
--- etc/rc.d/Makefile.orig Wed Oct 17 20:04:00 2001
+++ etc/rc.d/Makefile Wed Oct 17 22:25:26 2001
@@ -1,8 +1,6 @@
# $NetBSD: Makefile,v 1.16 2001/01/14 15:37:22 minoura Exp $
-.include
-
-FILES= DAEMON LOGIN NETWORK SERVERS accounting amd apmd bootparams \
+BIN= DAEMON LOGIN NETWORK SERVERS accounting amd apmd bootparams \
bootconf.sh ccd cleartmp cron dhclient dhcpd dhcrelay dmesg \
fsck gated inetd ipfilter ipmon ipnat ipsec isdnd kdc ldconfig \
lkm1 lkm2 lkm3 local lpd mopd motd mountall mountcritlocal \
@@ -12,9 +10,12 @@
savecore screenblank sendmail securelevel sshd swap1 swap2 sysdb \
sysctl syslogd timed ttys virecover wscons xdm xfs ypbind \
yppasswdd ypserv
-FILESDIR= /etc/rc.d
-FILESMODE= ${BINMODE}
-NOPROG= noprog
+BINDIR=/etc/rc.d
+NOOBJ=
+
+beforeinstall:
+ ${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m 755 ${BIN} \
+ ${DESTDIR}${BINDIR}
.include
--- etc/defaults/rc.conf.orig Wed Oct 17 20:03:57 2001
+++ etc/defaults/rc.confWed Oct 17 22:40:54 2001
@@ -19,6 +19,7 @@
### Important initial Boot-time options
##
+rc_ng="NO" # Set to YES to enable new-style rc. Experimental.
swapfile="NO" # Set to name of swapfile if aux swapfile desired.
apm_enable="NO"# Set to YES to enable APM BIOS functions (or NO).
apmd_enable="NO" # Run apmd to handle APM event from userland.
--- etc/rc.orig Wed Oct 17 20:04:06 2001
+++ etc/rc Wed Oct 17 22:40:54 2001
@@ -71,6 +71,30 @@
. /etc/rc.conf
fi
+case ${rc_ng} in
+[Yy][Ee][Ss])
+ . /etc/rc.subr
+
+ _rc_conf_loaded=YES
+
+ if [ "$1" = autoboot ]; then
+ autoboot=yes
+ _rc_fast_run=yes# run_rc_command(): do fast booting
+ fi
+
+ files=`rcorder -s nostart /etc/rc.d/*`
+
+ for _rc_elem in $files; do
+ run_rc_script $_rc_elem start
+ done
+
+ exit 0
+ ;;
+*)
+ # fall-through to the old rc scripts
+ ;;
+esac
+
feed_dev_random() {
if [ -f "${1}" -a -r "${1}" -a -s "${1}" ]; then
# echo "Using ${1} as an entropy file"
--- etc/rc.shutdown.origWed Oct 17 20:04:07 2001
+++ etc/rc.shutdown Wed Oct 17 22:40:54 2001
@@ -52,6 +52,26 @@
. /etc/rc.conf
fi
+case ${rc_ng} in
+[Yy][Ee][Ss])
+ . /etc/rc.subr
+
+ files=`rcorder -k shutdown /etc/rc.d/*`
+ for i in $files; do # reverse order of files
+ nfiles="$i $nfiles"
+ done
+ files=$nfiles
+
+ for i in $files; do
+ run_rc_script $i stop
+ done
+
+ exit 0
+ ;;
+*)
+ ;;
+esac
+
# Write some entropy so the rebooting /dev/random can reseed
#
case ${entropy_file} in
--- sbin/rcorder/Makefile.orig Sat Jun 16 00:16:14 2001
+++ sbin/rcorder/Makefile Wed Oct 17 21:58:35 2001
@@ -1,4 +1,5 @@
# $NetBSD: Makefile,v 1.1 1999/11/23 05:28:20 mrg Exp $
+SYS!= uname -s
PROG= rcorder
SRCS= ealloc.c hash.c rcorder.c
@@ -8,6 +9,12 @@
DPADD+=${LIBUTIL}
# XXX hack for make's hash.[ch]
+.if ${SYS} == NetBSD
CPPFLAGS+= -DORDER
+.elif ${S
