Re: PORTS_MODULES in src.conf: make: don't know how to make instclean. Stop
On Mon, 2 Jul 2012, David Wolfskill wrote: Huh??!? At least as far back as 06 Jan (based on the mtime of /etc/src.conf), I had set up src.conf to read: PORTS_MODULES=x11/nvidia-driver Don't do that. PORTS_MODULES is documented to belong in make.conf, not src.conf. That said, dougb has tweaked the behavior of PORTS_MODULES recently, so you could look more carefully at those changes. (r237090 and r237958, both have been merged back to 7/8/9.) -Ben Kaduk ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Re: PORTS_MODULES in src.conf: make: don't know how to make instclean. Stop
On 07/02/2012 09:25, Benjamin Kaduk wrote: On Mon, 2 Jul 2012, David Wolfskill wrote: Huh??!? At least as far back as 06 Jan (based on the mtime of /etc/src.conf), I had set up src.conf to read: PORTS_MODULES=x11/nvidia-driver Don't do that. PORTS_MODULES is documented to belong in make.conf, not src.conf. It works fine in src.conf. Please point to the documentation you speak of so that it can be fixed. That said, dougb has tweaked the behavior of PORTS_MODULES recently Yes, this is my mistake, I'll fix it. -- This .signature sanitized for your protection ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Re: PORTS_MODULES in src.conf: make: don't know how to make instclean. Stop
On Mon, 2 Jul 2012, Doug Barton wrote: On 07/02/2012 09:25, Benjamin Kaduk wrote: On Mon, 2 Jul 2012, David Wolfskill wrote: Huh??!? At least as far back as 06 Jan (based on the mtime of /etc/src.conf), I had set up src.conf to read: PORTS_MODULES=x11/nvidia-driver Don't do that. PORTS_MODULES is documented to belong in make.conf, not src.conf. It works fine in src.conf. Please point to the documentation you speak of so that it can be fixed. PORTS_MODULES is listed in make.conf.5, and is not listed in src.conf.5. From src.conf: The only purpose of src.conf is to control the compilation of the FreeBSD source code, which is usually located in /usr/src. This would seem to not include Ports code (which is usually located in /usr/ports). I'm pretty sure it's come up in the past that src.conf should only be used for those build options explicitly documented in it, and not other settings, and the implementation may be subject to change (so that other settings would no longer work) in the future. If you would like me to go search for those previous discussions, I can try, but my reading of these man pages is that it's pretty clear-cut. -Ben ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Re: PORTS_MODULES in src.conf: make: don't know how to make instclean. Stop
The problem is fixed now. This time I tested build and install with the same code. :( Sorry for the breakage, Doug -- This .signature sanitized for your protection ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Re: PORTS_MODULES in src.conf: make: don't know how to make instclean. Stop
On Mon, Jul 02, 2012 at 03:21:07PM -0700, Doug Barton wrote: The problem is fixed now. This time I tested build and install with the same code. :( Ah; I see. Cool; thanks! :-) Sorry for the breakage, ... Eh; let's hope that's the worst thing that happens for the rest of the month, shall we? :-) (If it is, we will truly be blessed!) Peace, david -- David H. Wolfskill da...@catwhisker.org Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. pgp2qKpHgbR1g.pgp Description: PGP signature
Re: PORTS_MODULES in src.conf: make: don't know how to make instclean. Stop
On 07/02/2012 13:41, Benjamin Kaduk wrote: On Mon, 2 Jul 2012, Doug Barton wrote: On 07/02/2012 09:25, Benjamin Kaduk wrote: On Mon, 2 Jul 2012, David Wolfskill wrote: Huh??!? At least as far back as 06 Jan (based on the mtime of /etc/src.conf), I had set up src.conf to read: PORTS_MODULES=x11/nvidia-driver Don't do that. PORTS_MODULES is documented to belong in make.conf, not src.conf. It works fine in src.conf. Please point to the documentation you speak of so that it can be fixed. PORTS_MODULES is listed in make.conf.5, and is not listed in src.conf.5. I see. That's a side effect of the wacky way in which src.conf.5 is built, combined with the fact that no one has yet migrated the things in make.conf.5 that predated the creation of src.conf altogether. There are numerous other examples, including KERNCONF and MODULES_OVERRIDE that I have in my src.conf just off the top of my head. Fixing this would be a great task for a doc person who wanted to get more exposure to src stuff. :) From src.conf: The only purpose of src.conf is to control the compilation of the FreeBSD source code, which is usually located in /usr/src. This would seem to not include Ports code (which is usually located in /usr/ports). I think the first usually is the one that is more relevant. However, that sentence is badly phrased to start with. It should probably say something like, The /etc/src.conf file is used for make options that are exclusive to the build process for the base OS. Since PORTS_MODULES falls into that category (even though the code lives in ports, it's part of the base build process), it qualifies. Also, and much more importantly, putting it in src.conf actually works, which you probably should have checked first before commenting. :) I'm pretty sure it's come up in the past that src.conf should only be used for those build options explicitly documented in it, and not other settings Unfortunately, there has been confusion on this point in the past, I agree. However it's important to note that the documentation is not necessarily the final appeal to authority, since we wrote the documentation, and we get it wrong sometimes. :) Doug -- This .signature sanitized for your protection ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
