Re: cvs commit: src/lib/libatm atm_addr.c cache_key.c ioctl_subr.c ip_addr.c ip_checksum.c timer.c

[Terry Lambert]

David O'Brien wrote:
 
 On Sun, Sep 16, 2001 at 06:35:27AM +1000, Bruce Evans wrote:
  Especially the empty line after the copyright message:
 
 Agreed.
 
   __FBSDID($FreeBSD: src/lib/libatm/atm_addr.c,v 1.6 2001/09/15 19:36:55 dillon 
Exp $);
 
 What about changing this to __FBSD(), which is what I was using in a
 prototype to reduce the number of characters in the macro name (and thus
 reduce the wrap around).

That's a silly reason to change a macro.

If you need two characters back, you should change Matt Dillon's
login from dillon to matt.

(Now see how stupid the original suggestion sounded?).

-- Terry

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message

Re: cvs commit: src/lib/libatm atm_addr.c cache_key.c ioctl_subr.c ip_addr.c ip_checksum.c timer.c

[Bruce Evans]

On Sat, 15 Sep 2001, Matt Dillon wrote:

 I'm redirecting this to freebsd-hackers.

 Ok, I've comitted a new set of changes to libatm.  Please check them out.
 When we get a format that enough people are happy with we can start
 converting the other libraries.  I'm not particularly interested in
 fixing old old problems, I just want to get the __FBSDID() stuff in shape.

I prefer the following (for one of the changed files).  Especially the
empty line after the copyright message:

%%%
Index: atm_addr.c
===
RCS file: /home/ncvs/src/lib/libatm/atm_addr.c,v
retrieving revision 1.6
diff -u -2 -r1.6 atm_addr.c
--- atm_addr.c  2001/09/15 19:36:55 1.6
+++ atm_addr.c  2001/09/15 20:25:39
@@ -24,10 +24,12 @@
  * notice must be reproduced on all copies.
  */
-#include sys/cdefs.h
+
+#ifdef VENDOR_ID
 #ifndef lint
-#if 0  /* original (broken) import id */
 static char *RCSid = @(#) $Id: atm_addr.c,v 1.1 1998/07/09 21:45:18 johnc Exp $;
 #endif
 #endif
+
+#include sys/cdefs.h
 __FBSDID($FreeBSD: src/lib/libatm/atm_addr.c,v 1.6 2001/09/15 19:36:55 dillon Exp 
$);

%%%

(VENDOR_ID is intended to be left undefined.)

This still changes the vendor id excessively relative to rev.1.1.  The
vendor put it after the comment after the copyright comment, and restoring
it in rev.1.5 moved it to a different place.

Bruce


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message

Re: cvs commit: src/lib/libatm atm_addr.c cache_key.c ioctl_subr.c ip_addr.c ip_checksum.c timer.c

[David O'Brien]

On Sun, Sep 16, 2001 at 06:35:27AM +1000, Bruce Evans wrote:
 Especially the empty line after the copyright message:

Agreed.
 
  __FBSDID($FreeBSD: src/lib/libatm/atm_addr.c,v 1.6 2001/09/15 19:36:55 dillon Exp 
$);

What about changing this to __FBSD(), which is what I was using in a
prototype to reduce the number of characters in the macro name (and thus
reduce the wrap around).

-- 
-- David  ([EMAIL PROTECTED])

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message

Re: cvs commit: src/lib/libatm atm_addr.c cache_key.c ioctl_subr.c ip_addr.c ip_checksum.c timer.c

[Matt Dillon]

:What about changing this to __FBSD(), which is what I was using in a
:prototype to reduce the number of characters in the macro name (and thus
:reduce the wrap around).
:
:-- 
:-- David  ([EMAIL PROTECTED])

__FBSD() is too generic for a #define name in what is essentially a 
global header file.  These are rcs id's, so it should be something like
__FBSDID() or __FBSD_ID() or something like that, not just __FBSD().

-Matt


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-hackers in the body of the message