Re: whois(1) patch for review
hi, On Fri, Jun 22, 2001 at 03:37:17AM +0200, Dag-Erling Smorgrav wrote: Arg.. I wish you had contacted me before doing this work. From looking at your patch, your using an old copy of my work. The newest one is available at: http://testbed.q9media.net/freebsd/whois.patch and will be committed very-shortly-now(tm). Since Mike's patch is a style cleanup with no functional impact except plugging a memory leak, I feel it's better to commit it first, and merge in Alexey's patch later, after it's been reviewed by this forum. Thanks! It makes things easer :) To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
On Fri, Jun 22, 2001 at 03:37:17AM +0200, Dag-Erling Smorgrav wrote: Mike Barcroft [EMAIL PROTECTED] writes: Arg.. I wish you had contacted me before doing this work. From looking at your patch, your using an old copy of my work. The newest one is available at: http://testbed.q9media.net/freebsd/whois.patch and will be committed very-shortly-now(tm). Since Mike's patch is a style cleanup with no functional impact except plugging a memory leak, I feel it's better to commit it first, and merge in Alexey's patch later, after it's been reviewed by this forum. Uh wrong. There were other non-style bits than just the memory leak. For instance the cast changes are functionalty related, not style. It should have been done in two commits. -- -- David ([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
On Thu, Jun 21, 2001 at 04:08:21PM +0300, Alexey Zelkin wrote: For example you can have following string in your whoisservers configuration file (system wide -- /usr/share/misc/whoiservers or personal ~/.whoisservers): System wide configuration files should be in /etc, not /usr/share/misc. -- -- David ([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
On 21 Jun, Andrey A. Chernov wrote: For domain names it works without '-Q' too. The main problem not with domain names wich have .suffix found via whois-servers.net, but for identificators or subnets without suffix, like: whois -c ru XXX-RIPN whois -c ru 123.123.123.123 What about /etc/whoisrc instead of /usr/share/whoisI_don't_know_anymore? Bye, Alexander. -- I believe the technical term is Oops! http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
whois(1) patch for review
hi, I have made few modifications to whois(1) to shut up BDECFLAGS warnings, cleanup code, and add new features. Main aim of this patch is to add flexibility to people who want to point whois(1) to non-deault whois server, i.e. have to type -h server name many times. It adds new command line modifier -c to declare server code. Originally it was supposed to point to country's whois server, but with no modifications can be used for other areas. For example you can have following string in your whoisservers configuration file (system wide -- /usr/share/misc/whoiservers or personal ~/.whoisservers): local whois.mydomain.com To point whois(1) to this server now you need to use whois -h whois.mydaomin.com XYZ with patch whois -clocal XYZ It also supposed to be used for country's whois servers. For example with whoisservers. ... ru whois.ripn.net ua whois.net.ua ... whois -c ru freebsd.org.ru (use -- whois.ripn.net) whois -c ua freebsd.org.ua (use -- whois.net.ua) Resume: with this patch included to add new country's whois server we'll need to add only one string to text file, not to modify whois(1) code as it has been done by Andrey for '-R' and as some pending PR's proposed to do. PS: I also removed -R switch for whois(1) which was used to point to Russian whois server, since it is replaced with -c ru PPS: It's tested on STABLE, but I don't think that there can be problems with -current. PPPS: Patch is dirty threfore any ideas on its cleanup are welcome. Also additional idea on improving whois(1) flexibility are welcome! I hope to get some free time on this weekend and commit it if nobody has strong objections. http://phantom.cris.net/~phantom/whois_patch.tgz To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
On Thu, Jun 21, 2001 at 04:08:21PM +0300, Alexey Zelkin wrote: hi, I have made few modifications to whois(1) to shut up BDECFLAGS warnings, cleanup code, and add new features. [snip] Resume: with this patch included to add new country's whois server we'll need to add only one string to text file, not to modify whois(1) code as it has been done by Andrey for '-R' and as some pending PR's proposed to do. PS: I also removed -R switch for whois(1) which was used to point to Russian whois server, since it is replaced with -c ru PPS: It's tested on STABLE, but I don't think that there can be problems with -current. PPPS: Patch is dirty threfore any ideas on its cleanup are welcome. Also additional idea on improving whois(1) flexibility are welcome! I hope to get some free time on this weekend and commit it if nobody has strong objections. http://phantom.cris.net/~phantom/whois_patch.tgz Wow. I think there's been a GREAT deal of duplication of effort over whois(1).. Have you looked at Mike Barcroft's patches, posted both as a PR and as a longish thread on -audit a couple of days ago, or at Joachim Strombergson's patches, posted as a longish thread on -audit a month or so ago? My understanding is that Mike Barcroft's patches remove the warnings, and Joachim Strombergson was working on the server list thing :) G'luck, Peter -- This sentence would be seven words long if it were six words shorter. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
hi, On Thu, Jun 21, 2001 at 04:25:46PM +0300, Peter Pentchev wrote: I have made few modifications to whois(1) to shut up BDECFLAGS warnings, cleanup code, and add new features. [snip] Resume: with this patch included to add new country's whois server we'll need to add only one string to text file, not to modify whois(1) code as it has been done by Andrey for '-R' and as some pending PR's proposed to do. PS: I also removed -R switch for whois(1) which was used to point to Russian whois server, since it is replaced with -c ru PPS: It's tested on STABLE, but I don't think that there can be problems with -current. PPPS: Patch is dirty threfore any ideas on its cleanup are welcome. Also additional idea on improving whois(1) flexibility are welcome! I hope to get some free time on this weekend and commit it if nobody has strong objections. http://phantom.cris.net/~phantom/whois_patch.tgz Wow. I think there's been a GREAT deal of duplication of effort over whois(1).. Have you looked at Mike Barcroft's patches, posted both as a PR and as a longish thread on -audit a couple of days ago, or at Joachim Strombergson's patches, posted as a longish thread on -audit a month or so ago? My understanding is that Mike Barcroft's patches remove the warnings, and Joachim Strombergson was working on the server list thing :) I did not follow things going on carefully for almost two months while I'd a deal with graduate project, but now since it's finished (Yay!!!) and I got some time I started to dig to old patches (made during last three months) and it's one of them. :) I'd incorporated few missing points from Mike's PR and have on hold Joachim's (I have plans and ideas to make it even more optimized). So, if people also started to work on this topic it shows its actuality, IMHO. :-) To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
On Thu, Jun 21, 2001 at 04:08:21PM +0300, Alexey Zelkin wrote: It adds new command line modifier -c to declare server code. Originally it was supposed to point to country's whois server, but with no modifications can be used for other areas. For example you can have following string in your whoisservers configuration file (system wide -- /usr/share/misc/whoiservers or personal ~/.whoisservers): local whois.mydomain.com I wrote a patch for the openbsd whois client a year or so ago which used lookups under the whois-servers.net zone to locate appropriate whois servers for domain names. Looks like someone ported that to FreeBSD's client (the -Q option). Just thought I'd mention it, since your examples include: It also supposed to be used for country's whois servers. For example with whoisservers. ... ruwhois.ripn.net uawhois.net.ua ... whois -c ru freebsd.org.ru (use -- whois.ripn.net) whois -Q freebsd.org.ru whois -c ua freebsd.org.ua (use -- whois.net.ua) whois -Q freebsd.org.ua Resume: with this patch included to add new country's whois server we'll need to add only one string to text file, not to modify whois(1) code as it has been done by Andrey for '-R' and as some pending PR's proposed to do. This list is already maintained in the whois-servers.net zone. Joe To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
On Thu, Jun 21, 2001 at 10:23:43PM +0400, Andrey A. Chernov wrote: On Thu, Jun 21, 2001 at 10:39:05 -0400, Joe Abley wrote: whois -c ru freebsd.org.ru (use -- whois.ripn.net) whois -Q freebsd.org.ru whois -c ua freebsd.org.ua (use -- whois.net.ua) whois -Q freebsd.org.ua Resume: with this patch included to add new country's whois server we'll need to add only one string to text file, not to modify whois(1) code as it has been done by Andrey for '-R' and as some pending PR's proposed to do. This list is already maintained in the whois-servers.net zone. For domain names it works without '-Q' too. The main problem not with domain names wich have .suffix found via whois-servers.net, but for identificators or subnets without suffix, like: whois -c ru XXX-RIPN whois -c ru 123.123.123.123 That seems entirely reasonable. I just wanted to point out that it wasn't necessary to maintain a big local list of whois servers for individual tlds in the case that you're looking up domains. Your patch certainly looks usable for other resources retrievable using whois. Joe To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
I did not follow things going on carefully for almost two months while I'd a deal with graduate project, but now since it's finished (Yay!!!) and I got some time I started to dig to old patches (made during last three months) and it's one of them. :) I'd incorporated few missing points from Mike's PR and have on hold Joachim's (I have plans and ideas to make it even more optimized). So, if people also started to work on this topic it shows its actuality, IMHO. :-) Arg.. I wish you had contacted me before doing this work. From looking at your patch, your using an old copy of my work. The newest one is available at: http://testbed.q9media.net/freebsd/whois.patch and will be committed very-shortly-now(tm). Best regards, Mike Barcroft To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
Re: whois(1) patch for review
Mike Barcroft [EMAIL PROTECTED] writes: Arg.. I wish you had contacted me before doing this work. From looking at your patch, your using an old copy of my work. The newest one is available at: http://testbed.q9media.net/freebsd/whois.patch and will be committed very-shortly-now(tm). Since Mike's patch is a style cleanup with no functional impact except plugging a memory leak, I feel it's better to commit it first, and merge in Alexey's patch later, after it's been reviewed by this forum. DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-hackers in the body of the message
