[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

--- Comment #7 from commit-h...@freebsd.org ---
A commit references this bug:

Author: ae
Date: Tue Oct 31 10:31:47 UTC 2017
New revision: 325229
URL: https://svnweb.freebsd.org/changeset/base/325229

Log:
  MFC r324947:
Add IPv6 support for O_TCPDATALEN opcode.

PR: 222746

Changes:
_U  stable/11/
  stable/11/sys/netpfil/ipfw/ip_fw2.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

--- Comment #8 from commit-h...@freebsd.org ---
A commit references this bug:

Author: ae
Date: Tue Oct 31 11:09:39 UTC 2017
New revision: 325230
URL: https://svnweb.freebsd.org/changeset/base/325230

Log:
  MFC r324947:
Add IPv6 support for O_TCPDATALEN opcode.

PR: 222746

Changes:
_U  stable/10/
  stable/10/sys/netpfil/ipfw/ip_fw2.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

--- Comment #6 from commit-h...@freebsd.org ---
A commit references this bug:

Author: ae
Date: Tue Oct 24 08:39:06 UTC 2017
New revision: 324947
URL: https://svnweb.freebsd.org/changeset/base/324947

Log:
  Add IPv6 support for O_TCPDATALEN opcode.

  PR:   222746
  MFC after:1 week

Changes:
  head/sys/netpfil/ipfw/ip_fw2.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

Tatsuki Makino  changed:

   What|Removed |Added

 Attachment #186915|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

--- Comment #5 from Tatsuki Makino  ---
(In reply to Andrey V. Elsukov from comment #4)

attachment 187283 can be applied to stable/10.
I am using it on the following uname -a.
FreeBSD T2.test 10.4-STABLE FreeBSD 10.4-STABLE #0 r324782M: Fri Oct 20
02:30:37 UTC 2017 r...@t2.test:/usr/obj/usr/src/sys/GENERIC  amd64
It works as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

--- Comment #4 from Andrey V. Elsukov  ---
Created attachment 187283
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=187283=edit
Proposed patch for tcplen

Can you test this patch instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

Tatsuki Makino  changed:

   What|Removed |Added

 Attachment #186894|0   |1
is obsolete||

--- Comment #3 from Tatsuki Makino  ---
Created attachment 186915
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=186915=edit
patch for CURRENT

(In reply to Andrey V. Elsukov from comment #2)

Thank you.
I made a new one. How about this one?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

Andrey V. Elsukov  changed:

   What|Removed |Added

 CC||a...@freebsd.org

--- Comment #2 from Andrey V. Elsukov  ---
(In reply to Tatsuki Makino from comment #1)
> Created attachment 186894 [details]
> patch for CURRENT
> 
> attachment 186874 [details] reused the variable iplen. But iplen overflows
> when ip6_plen is greater than 65495.
> The new patch does not use the sum of header size and payload size.

You need to handle the case when ip6_plen == 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

Tatsuki Makino  changed:

   What|Removed |Added

 Attachment #186874|0   |1
is obsolete||

--- Comment #1 from Tatsuki Makino  ---
Created attachment 186894
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=186894=edit
patch for CURRENT

attachment 186874 reused the variable iplen. But iplen overflows when ip6_plen
is greater than 65495.
The new patch does not use the sum of header size and payload size.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"

[Bug 222746] ipfw: tcpdatalen does not exactly match IPv6 packets.

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222746

Mark Linimon  changed:

   What|Removed |Added

   Keywords||patch
   Assignee|freebsd-b...@freebsd.org|freebsd-ipfw@FreeBSD.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-ipfw@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ipfw
To unsubscribe, send any mail to "freebsd-ipfw-unsubscr...@freebsd.org"