Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
The following reply was made to PR kern/134557; it has been noted by GNATS. From: Z3tbl4 [] z3t...@gmail.com To: bug-follo...@freebsd.org, sergei.cherv...@gmail.com Cc: Subject: Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem Date: Fri, 14 Aug 2009 02:28:54 +0400 SGVsbG8gd29ybGQhIElzIGl0IHBvc3NpYmxlIHRvIHBhdGNoIG5nX2lmYWNlLmMgYW5kIG5nX2lm YWNlLmggb24KRnJlZUJTRCA2LjQtUkVMRUFTRSBzb21laG93PwpUaGFuayB5b3UuCiMjIyMjIyMj IyMjIyMjIyMjIyMjIyMK99PFzSDQ0snXxdQsINDP08/XxdTVytTFIN7UzyDExczB1Ngg1yDUwcvP yiDTydTVwcPJyS4uLgruwSDG0sUgKFA0IDNHSHopIDYuNC1yZWxlYXNlIMXT1NggbXBkNSwg0cTS zyDTz8LSwc7PINMKY3B1ICAgICAgICAgICAgIEk2ODZfQ1BVCm9wdGlvbnMgICAgICAgICBTTVAK b3B0aW9ucyAgICAgICAgIElQRklSRVdBTEwKb3B0aW9ucyAgICAgICAgIElQRElWRVJUCm9wdGlv bnMgICAgICAgICBEVU1NWU5FVApvcHRpb25zICAgICAgICAgTkVUR1JBUEgKb3B0aW9ucyAgICAg ICAgIE5FVEdSQVBIX1BQUApvcHRpb25zICAgICAgICAgTkVUR1JBUEhfUFBUUEdSRQoK1yDQ0s/J 2tfPzNjO2cUgzc/Nxc7U2SDawdfJ08HF1CDOxdTH0sHGLCDQ0sPF09MgInN3aTE6IG5ldCIgz9TW ydLBxdQK18XT2CDQ0s/DxdPTz9IsINfTxSDTxdTF19nFIMvB0tTZINDF0sXT1MHA1CDP1NfF3sHU 2Cwgy8/O08/M2ArSwcLP1MHF1Cwgzc/Wzs8g0sXC1dTO1dTY09EuCvPJzNjOzyDQz8fVx8zJ1ywg zsHbo8wsIN7UzyDc1MEgz9vJwsvBINfP2s7Jy8HF1CDJ2i3awSDUz8fPLCDe1M8gbXBkCtrBw8nL zMnXwcXUIMvBy8/KLdTPINPF1MXXz8og0MHLxdQgKN7UzyDX0NLJzsPJ0MUg08/HzMHT1cXU09Eg 0wrOwcLMwMTFzsnRzckpIMLBx9LF0M/S1CAia2Vybi8xMzI5ODQiCmh0dHA6Ly9saXN0cy5mcmVl YnNkLm9yZy9waXBlcm1haWwvZnJlZWJzZC1idWdzLzIwMDktTWFyY2gvMC4uLiAuCu7B26PMINDB 1N4gxMzRIC9zeXMvbmV0Z3JhcGgvbmdfaWZhY2UuYywgbmdfaWZhY2UuaCwgzs8gwsXEwSDXINTP zSwK3tTPIM/OIM7FINPPwsnSwcXU09Eg0M/EIDYuNCAo18nEyc3PIMTM0SDG0sDIIDcgySDX2dvF KS4K5dPMySDL1M8g2s7BxdQgy8HLIMnT0NLB18nU2CDc1M/UIG5nX2lmYWNlLmMg0M/EIDYuNCDC 1cTVIMLF2s3F0s7PCsLMwcfPxMHSxc4sINPQwdPJws8uCg== ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
Synopsis: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem State-Changed-From-To: open-closed State-Changed-By: mav State-Changed-When: Sat Jul 4 06:01:31 UTC 2009 State-Changed-Why: Patch committed and merged to 7-SATBLE. http://www.freebsd.org/cgi/query-pr.cgi?pr=134557 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
Hello Mikolaj,
I confirm that this patch fixes the issue.
Thank you very much! Now pptp through pppoe works fine!
Bohdan Tymkiv
On Tue, Jun 30, 2009 at 10:40 PM, Mikolaj Golubto.my.troc...@gmail.com wrote:
The following reply was made to PR kern/134557; it has been noted by GNATS.
From: Mikolaj Golub to.my.troc...@gmail.com
To: bug-follo...@freebsd.org
Cc: freebsd-net@FreeBSD.org, Sergei Cherveni sergei.cherv...@gmail.com,
Alexander Motin m...@freebsd.org
Subject: Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up -
ng_pptp problem
Date: Tue, 30 Jun 2009 22:33:12 +0300
--=-=-=
Unfortunately, the problem was introduced by this commit :-)
--
Author: mav
Date: Sat Jan 31 12:48:09 2009 UTC (4 months, 4 weeks ago)
Log Message:
MFC rev. 187495
Check for infinite recursion possible on some broken PPTP/L2TP/... VPN
setups.
Mark packets with mbuf_tag on first interface passage and drop on second.
PR: ports/129625, ports/125303
--
If a packet goes through two or more ng interfaces, while loop in the tag
checking code can run infinitely. The attached patch should fix this.
--
Mikolaj Golub
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment; filename=ng_iface.c.patch
--- netgraph/ng_iface.c.orig 2009-06-30 21:47:54.0 +0300
+++ netgraph/ng_iface.c 2009-06-30 21:49:29.0 +0300
@@ -365,7 +365,8 @@
}
/* Protect from deadly infinite recursion. */
- while ((mtag = m_tag_locate(m, MTAG_NGIF, MTAG_NGIF_CALLED, NULL))) {
+ mtag = NULL;
+ while ((mtag = m_tag_locate(m, MTAG_NGIF, MTAG_NGIF_CALLED, mtag))) {
if (*(struct ifnet **)(mtag + 1) == ifp) {
log(LOG_NOTICE, Loop detected on %s\n,
ifp-if_xname);
m_freem(m);
--=-=-=--
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
Unfortunately, the problem was introduced by this commit :-)
--
Author: mav
Date: Sat Jan 31 12:48:09 2009 UTC (4 months, 4 weeks ago)
Log Message:
MFC rev. 187495
Check for infinite recursion possible on some broken PPTP/L2TP/... VPN setups.
Mark packets with mbuf_tag on first interface passage and drop on second.
PR: ports/129625, ports/125303
--
If a packet goes through two or more ng interfaces, while loop in the tag
checking code can run infinitely. The attached patch should fix this.
--
Mikolaj Golub
--- netgraph/ng_iface.c.orig 2009-06-30 21:47:54.0 +0300
+++ netgraph/ng_iface.c 2009-06-30 21:49:29.0 +0300
@@ -365,7 +365,8 @@
}
/* Protect from deadly infinite recursion. */
- while ((mtag = m_tag_locate(m, MTAG_NGIF, MTAG_NGIF_CALLED, NULL))) {
+ mtag = NULL;
+ while ((mtag = m_tag_locate(m, MTAG_NGIF, MTAG_NGIF_CALLED, mtag))) {
if (*(struct ifnet **)(mtag + 1) == ifp) {
log(LOG_NOTICE, Loop detected on %s\n, ifp-if_xname);
m_freem(m);
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
The following reply was made to PR kern/134557; it has been noted by GNATS.
From: Mikolaj Golub to.my.troc...@gmail.com
To: bug-follo...@freebsd.org
Cc: freebsd-net@FreeBSD.org, Sergei Cherveni sergei.cherv...@gmail.com,
Alexander Motin m...@freebsd.org
Subject: Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up -
ng_pptp problem
Date: Tue, 30 Jun 2009 22:33:12 +0300
--=-=-=
Unfortunately, the problem was introduced by this commit :-)
--
Author:mav
Date: Sat Jan 31 12:48:09 2009 UTC (4 months, 4 weeks ago)
Log Message:
MFC rev. 187495
Check for infinite recursion possible on some broken PPTP/L2TP/... VPN setups.
Mark packets with mbuf_tag on first interface passage and drop on second.
PR:ports/129625, ports/125303
--
If a packet goes through two or more ng interfaces, while loop in the tag
checking code can run infinitely. The attached patch should fix this.
--
Mikolaj Golub
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment; filename=ng_iface.c.patch
--- netgraph/ng_iface.c.orig 2009-06-30 21:47:54.0 +0300
+++ netgraph/ng_iface.c2009-06-30 21:49:29.0 +0300
@@ -365,7 +365,8 @@
}
/* Protect from deadly infinite recursion. */
- while ((mtag = m_tag_locate(m, MTAG_NGIF, MTAG_NGIF_CALLED, NULL))) {
+ mtag = NULL;
+ while ((mtag = m_tag_locate(m, MTAG_NGIF, MTAG_NGIF_CALLED, mtag))) {
if (*(struct ifnet **)(mtag + 1) == ifp) {
log(LOG_NOTICE, Loop detected on %s\n, ifp-if_xname);
m_freem(m);
--=-=-=--
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
The following reply was made to PR kern/134557; it has been noted by GNATS. From: Roar Pettersen roar.petter...@uib.no To: bug-follo...@freebsd.org Cc: Subject: Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem Date: Wed, 10 Jun 2009 19:09:00 +0200 (CEST) Hi ! We also see a similar problem with FreeBSD 7.2-Stable and MPD 5.3, after 4-5 days then the mpd process goes into a deadlock. Not able to kill the process or reload the server, have to press the Power Off button. System load is normaly 2-3%, but when the problem occur it raise to 30-35%. No error messages, nothing in the log files. The problem is releated to FreeBSD 7.2, no problem with 7.1. -- Roar Pettersen Universitetet i Bergen - The University of Bergen BERGEN - Norway ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
The following reply was made to PR kern/134557; it has been noted by GNATS. From: Bohdan Tymkiv bohdan...@gmail.com To: bug-follo...@freebsd.org, sergei.cherv...@gmail.com Cc: Subject: Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem Date: Tue, 09 Jun 2009 19:12:28 +0300 I confirm that downgrading to 7.1-RELEASE-p5 from svn sources on the same machine fixes the issue. -- Bohdan Tymkiv bohdan...@gmail.com Home ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
The following reply was made to PR kern/134557; it has been noted by GNATS. From: Motomichi Matsuzaki mz...@e-mail.ne.jp To: bug-follo...@freebsd.org, m...@freebsd.org Cc: Subject: Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem Date: Sat, 06 Jun 2009 22:53:08 +0900 Here is the same problem. I'm using mpd 4.4.1, which is configured to keep PPPoE connection to ISP. Mpd is also configured as a PPTP server, and it has worked fine on 7.1R; no problems both on normal PPPoE operation and incoming PPTP connection. However, upgrading to 7.2R (by freebsd-update) has changed the situation. -- Motomichi Matsuzaki, PhD mz...@e-mail.ne.jp ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
I can confirm this issue. I have a FreeBSD 7.2-STABLE box with mpd 5.3 configured as PPPoE client that connects to my ISP. If I make any PPTP VPN connection that goes through this PPPoE link my server hangs. I made some investigations and found that deadlock occurs only when pptp connection goes via pppoe link, connection from local network works fine. Deadlock occurs exactly when first data packet is sent through pptp connection. mpd can be configured as server that listens on my external pppoe interface or it can be configured as client that connects to other server in internet. In both cases it hangs. -- Bohdan Tymkiv bohdan...@gmail.com Home ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
The following reply was made to PR kern/134557; it has been noted by GNATS. From: Bohdan Tymkiv bohdan...@gmail.com To: bug-follo...@freebsd.org, sergei.cherv...@gmail.com Cc: Subject: Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem Date: Sat, 06 Jun 2009 19:01:14 +0300 I can confirm this issue. I have a FreeBSD 7.2-STABLE box with mpd 5.3 configured as PPPoE client that connects to my ISP. If I make any PPTP VPN connection that goes through this PPPoE link my server hangs. I made some investigations and found that deadlock occurs only when pptp connection goes via pppoe link, connection from local network works fine. Deadlock occurs exactly when first data packet is sent through pptp connection. mpd can be configured as server that listens on my external pppoe interface or it can be configured as client that connects to other server in internet. In both cases it hangs. -- Bohdan Tymkiv bohdan...@gmail.com ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
The following reply was made to PR kern/134557; it has been noted by GNATS. From: Alexander Motin m...@freebsd.org To: bug-follo...@freebsd.org, sergei.cherv...@gmail.com Cc: Subject: Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem Date: Tue, 19 May 2009 23:16:13 +0300 Are you sure, that you haven't made routing or some other kind traffic loop in kernel? There was added some protection against it recently, but may be you have found some new way to do it? It was quite popular. -- Alexander Motin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
Old Synopsis: 7.2 with mpd5.3 hanging up - ng_pptp problem New Synopsis: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem Responsible-Changed-From-To: freebsd-bugs-freebsd-net Responsible-Changed-By: linimon Responsible-Changed-When: Fri May 15 17:20:25 UTC 2009 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=134557 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
