Re: [CFT] New dialog for ports

2013-03-20 Thread Baptiste Daroussin
On Wed, Mar 20, 2013 at 02:39:14AM +, Steve Wills wrote:
 On 03/14/13 09:55, Baptiste Daroussin wrote:
  Hi all,
  
  Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
  tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
  dialog(1)
  designed specifically for the options, in particular for optionsng.
  
  It uses libdialog (recent version) and extend it with a new widget able to 
  deal
  with both normal and radio options in the same window.
  
  dialog4ports will live forever in ports so that it can easily be updated 
  and get
  support for new features on all supported arches at the same time.
  
  It bundles libdialog on FreeBSD versions that doesn't have a recent 
  libdialog in
  base (read 8.x)
  
  dialog4ports also support a new feature: it has a help dialog to be able to
  print a human readable help text if possible.
  
  Here is a patch to the ports tree that makes it use dialog4ports by default.
  What it does is:
  When make config is requested and dialog4ports is not installed yet the 
  ports
  tree will install dialog4ports first.
  
  New feature for maintainer, if a pkg-help file is found inside the port
  directory then dialog will show to the user a help file is available et 
  propose
  him to hint F1 or ^E to show the said help file
  
  http://people.freebsd.org/~bapt/d4p.diff
  
  Please test!
 
 I didn't get a chance to test this before it was committed, but I'm
 currently running into this:
 
 
 % pwd
 /usr/local/tinderbox/portstrees/FreeBSD/ports/www/apache22
 % sudo make config
 dialog4ports isn't installed, do you want to install it now? [Y/n] n
 env: /usr/local/bin/dialog4ports: No such file or directory
 === Options unchanged
 %
 
 And I'm prompted every time. Is this how it's supposed to work?
 
 Steve
 

I wonder if it is worth to let the question to install dialog4ports.

I mean dialog4ports being mandatory you should just be installed directly
doesn't it?

anyone have an opinion about this?

I will remove the question on 27/03 if I got more please do than please don't at
that time.

regards,
Bapt


pgpb8hndsk0ko.pgp
Description: PGP signature


Re: [CFT] New dialog for ports

2013-03-20 Thread Baptiste Daroussin
On Wed, Mar 20, 2013 at 12:48:33AM -0400, Robert Simmons wrote:
 I'm getting the same error after the most recent portsnap update.  It
 looks like this has been added as a default for all make config
 commands now.  Perhaps these changes should be backed out so it's not
 the default for everything?
 

Why won't it be the default, it is a dropin replacement because the older one
wasn't able to represent the new features. I don't see a single reason to not
switch directly from one to the other.

regards,
Bapt


pgpq87mTezNyx.pgp
Description: PGP signature


Re: [CFT] New dialog for ports

2013-03-20 Thread David Demelier
2013/3/20 Baptiste Daroussin b...@freebsd.org:
 On Wed, Mar 20, 2013 at 02:39:14AM +, Steve Wills wrote:
 On 03/14/13 09:55, Baptiste Daroussin wrote:
  Hi all,
 
  Ilya A. Arkhipov wrote dialog4ports which has just been added into the 
  ports
  tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
  dialog(1)
  designed specifically for the options, in particular for optionsng.
 
  It uses libdialog (recent version) and extend it with a new widget able to 
  deal
  with both normal and radio options in the same window.
 
  dialog4ports will live forever in ports so that it can easily be updated 
  and get
  support for new features on all supported arches at the same time.
 
  It bundles libdialog on FreeBSD versions that doesn't have a recent 
  libdialog in
  base (read 8.x)
 
  dialog4ports also support a new feature: it has a help dialog to be able to
  print a human readable help text if possible.
 
  Here is a patch to the ports tree that makes it use dialog4ports by 
  default.
  What it does is:
  When make config is requested and dialog4ports is not installed yet the 
  ports
  tree will install dialog4ports first.
 
  New feature for maintainer, if a pkg-help file is found inside the port
  directory then dialog will show to the user a help file is available et 
  propose
  him to hint F1 or ^E to show the said help file
 
  http://people.freebsd.org/~bapt/d4p.diff
 
  Please test!

 I didn't get a chance to test this before it was committed, but I'm
 currently running into this:


 % pwd
 /usr/local/tinderbox/portstrees/FreeBSD/ports/www/apache22
 % sudo make config
 dialog4ports isn't installed, do you want to install it now? [Y/n] n
 env: /usr/local/bin/dialog4ports: No such file or directory
 === Options unchanged
 %

 And I'm prompted every time. Is this how it's supposed to work?

 Steve


 I wonder if it is worth to let the question to install dialog4ports.

 I mean dialog4ports being mandatory you should just be installed directly
 doesn't it?

 anyone have an opinion about this?

 I will remove the question on 27/03 if I got more please do than please don't 
 at
 that time.


If the user does not want dialogs at all then it should write
something like NO_DIALOG=yes in the /etc/make.conf., otherwise we
assume that the user *wants* the dialog so the question is just
no-sense for me (and for much people I guess).

So please just remove it as it's a normal dependency of the port tree.

 regards,
 Bapt



--
Demelier David
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-20 Thread Vitaly Magerya
Daniel Nebdal wrote:
 I just found a niggle:
 I have LANG=en_US.UTF-8 , NCURSES_NO_UTF8_ACS=1, TERM=xterm, and I'm
 using putty to connect to a FreeBSD-10 machine running a snapshot from
 february with ports from an hour ago. Putty is set to Translation:
 UTF-8, and use unicode line drawing code points.
 
 With those settings, dialog gives me nice line drawing characters (for
 some reason). If I unset NCURSES_NO_UTF8_ACS, all boxes are drawn
 using random letters instead. (jlmqx, to be exact.)

They're not actually random; 'jlmqx' is the ASCII rendering of line
drawing characters in ACS (alternative charset), which putty doesn't
support in UTF-8 mode (therefore it shows the ASCII, not the ASC versions).

 The problem: ports config dialogs are _always_ drawn with the same
 random letters, and I haven't found any setting or combination of
 settings that works.
 
 This is probably more of a mis-configuration on my side

I'm seeing the same thing too.

I think I've found what causes it: unlike dialog, dialog4ports does not
call setlocale(3) during startup. Try saving the attached patch as
'ports-mgmt/dialog4ports/files/patch-dialog4ports.c' and reinstalling
dialog4ports; report back if it'll help.
--- dialog4ports.c.orig 2013-03-20 14:07:09.0 +0200
+++ dialog4ports.c  2013-03-20 14:07:56.0 +0200
@@ -32,6 +32,7 @@
 #include stdio.h
 #include stdlib.h
 #include stringlist.h
+#include locale.h
 
 #include mixedlist.h
 
@@ -213,6 +214,7 @@
char *helpfile;
DIALOG_MIXEDLIST* items;
 
+   setlocale(LC_ALL, );
init_dialog(stdin, stdout);
errno = 0;
 
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org

Re: [CFT] New dialog for ports

2013-03-20 Thread Steve Wills

 I wonder if it is worth to let the question to install dialog4ports.

 I mean dialog4ports being mandatory you should just be installed directly
 doesn't it?

 anyone have an opinion about this?

 I will remove the question on 27/03 if I got more please do than please
 don't at
 that time.

The question does lead one to think it's optional. If it's not optional,
then there shouldn't be a prompt. I think it should be optional. IMHO, the
requirement being mandator violates POLA, as does the prompt. These are
questions that should have been answered before it was committed.

Steve


___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-20 Thread Baptiste Daroussin
On Wed, Mar 20, 2013 at 10:07:15AM -0400, Steve Wills wrote:
 
  I wonder if it is worth to let the question to install dialog4ports.
 
  I mean dialog4ports being mandatory you should just be installed directly
  doesn't it?
 
  anyone have an opinion about this?
 
  I will remove the question on 27/03 if I got more please do than please
  don't at
  that time.
 
 The question does lead one to think it's optional. If it's not optional,
 then there shouldn't be a prompt. I think it should be optional. IMHO, the
 requirement being mandator violates POLA, as does the prompt. These are
 questions that should have been answered before it was committed.
 
 Steve
 
 

Why would dialog4ports be optional, the dialog(1) from base isn't able to
reflect what the new option framwork does, keeping it and both code to have
both, looks like a non sense to me.

Bapt


pgpXV0bQeOnNz.pgp
Description: PGP signature


Re: [CFT] New dialog for ports

2013-03-20 Thread Daniel Nebdal
On Wed, Mar 20, 2013 at 1:19 PM, Vitaly Magerya vmage...@gmail.com wrote:
 Daniel Nebdal wrote:
 I just found a niggle:
 I have LANG=en_US.UTF-8 , NCURSES_NO_UTF8_ACS=1, TERM=xterm, and I'm
 using putty to connect to a FreeBSD-10 machine running a snapshot from
 february with ports from an hour ago. Putty is set to Translation:
 UTF-8, and use unicode line drawing code points.

 With those settings, dialog gives me nice line drawing characters (for
 some reason). If I unset NCURSES_NO_UTF8_ACS, all boxes are drawn
 using random letters instead. (jlmqx, to be exact.)

 They're not actually random; 'jlmqx' is the ASCII rendering of line
 drawing characters in ACS (alternative charset), which putty doesn't
 support in UTF-8 mode (therefore it shows the ASCII, not the ASC versions).

 The problem: ports config dialogs are _always_ drawn with the same
 random letters, and I haven't found any setting or combination of
 settings that works.

 This is probably more of a mis-configuration on my side

 I'm seeing the same thing too.

 I think I've found what causes it: unlike dialog, dialog4ports does not
 call setlocale(3) during startup. Try saving the attached patch as
 'ports-mgmt/dialog4ports/files/patch-dialog4ports.c' and reinstalling
 dialog4ports; report back if it'll help.

That works perfectly - thanks.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-20 Thread Kevin Oberman
On Wed, Mar 20, 2013 at 7:12 AM, Baptiste Daroussin b...@freebsd.org wrote:
 On Wed, Mar 20, 2013 at 10:07:15AM -0400, Steve Wills wrote:
 
  I wonder if it is worth to let the question to install dialog4ports.
 
  I mean dialog4ports being mandatory you should just be installed directly
  doesn't it?
 
  anyone have an opinion about this?
 
  I will remove the question on 27/03 if I got more please do than please
  don't at
  that time.

 The question does lead one to think it's optional. If it's not optional,
 then there shouldn't be a prompt. I think it should be optional. IMHO, the
 requirement being mandator violates POLA, as does the prompt. These are
 questions that should have been answered before it was committed.

 Steve



 Why would dialog4ports be optional, the dialog(1) from base isn't able to
 reflect what the new option framwork does, keeping it and both code to have
 both, looks like a non sense to me.

bapt,

I think you may be missing the point. It's not whether dialog4ports
should be default, it's whether you should be ASKED if you want to
install it. It's now a dependency of the ports system and, like other
dependencies, should just be installed without asking questions.

I suspect that, for the most part, you are in violent agreement with
those asking THE QUERY, not dialog4ports, to be removed.
-- 
R. Kevin Oberman, Network Engineer
E-mail: rkober...@gmail.com
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-20 Thread Bryan Drewery
On 3/14/2013 4:55 AM, Baptiste Daroussin wrote:
 Hi all,
 
 Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
 tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
 dialog(1)
 designed specifically for the options, in particular for optionsng.
 

I have removed the prompt now. This is a required dependency for ports
not much different than other dependencies. It is necessary to render,
interact and configure options in the new options framework. The old UI
was seriously lacking in functionality and extendability. It was
crutched by only being in base, meaning any change we made would need to
wait for a *FreeBSD release* to improve or change the situation. Now we
can make continual incremental improvements to the ports config dialog.

NO_DIALOG can be used to avoid this config dialog.

The old config code was removed as there is really no good reason to
keep it and maintain it. It would be prone to bitrot and risk even
showing the wrong options. There is a several-second delay before
bringing up the new dialog now on the first time. After that this will
just update as usual with portmaster runs.

-- 
Regards,
Bryan Drewery
bdrewery@freenode/EFNet



signature.asc
Description: OpenPGP digital signature


Re: [CFT] New dialog for ports

2013-03-19 Thread Daniel Nebdal
On Thu, Mar 14, 2013 at 10:55 AM, Baptiste Daroussin b...@freebsd.org wrote:
 Hi all,

 Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
 tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
 dialog(1)
 designed specifically for the options, in particular for optionsng.

 It uses libdialog (recent version) and extend it with a new widget able to 
 deal
 with both normal and radio options in the same window.

 dialog4ports will live forever in ports so that it can easily be updated and 
 get
 support for new features on all supported arches at the same time.

 It bundles libdialog on FreeBSD versions that doesn't have a recent libdialog 
 in
 base (read 8.x)

 dialog4ports also support a new feature: it has a help dialog to be able to
 print a human readable help text if possible.

 Here is a patch to the ports tree that makes it use dialog4ports by default.
 What it does is:
 When make config is requested and dialog4ports is not installed yet the ports
 tree will install dialog4ports first.

 New feature for maintainer, if a pkg-help file is found inside the port
 directory then dialog will show to the user a help file is available et 
 propose
 him to hint F1 or ^E to show the said help file

 http://people.freebsd.org/~bapt/d4p.diff

 Please test!

 regards,
 Bapt


I just found a niggle:
I have LANG=en_US.UTF-8 , NCURSES_NO_UTF8_ACS=1, TERM=xterm, and I'm
using putty to connect to a FreeBSD-10 machine running a snapshot from
february with ports from an hour ago. Putty is set to Translation:
UTF-8, and use unicode line drawing code points.

With those settings, dialog gives me nice line drawing characters (for
some reason). If I unset NCURSES_NO_UTF8_ACS, all boxes are drawn
using random letters instead. (jlmqx, to be exact.)

The problem: ports config dialogs are _always_ drawn with the same
random letters, and I haven't found any setting or combination of
settings that works.

This is probably more of a mis-configuration on my side than a
dialog4ports problem, but still - it's slightly odd that it acts
different than dialog. :)
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-19 Thread Steve Wills
On 03/14/13 09:55, Baptiste Daroussin wrote:
 Hi all,
 
 Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
 tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
 dialog(1)
 designed specifically for the options, in particular for optionsng.
 
 It uses libdialog (recent version) and extend it with a new widget able to 
 deal
 with both normal and radio options in the same window.
 
 dialog4ports will live forever in ports so that it can easily be updated and 
 get
 support for new features on all supported arches at the same time.
 
 It bundles libdialog on FreeBSD versions that doesn't have a recent libdialog 
 in
 base (read 8.x)
 
 dialog4ports also support a new feature: it has a help dialog to be able to
 print a human readable help text if possible.
 
 Here is a patch to the ports tree that makes it use dialog4ports by default.
 What it does is:
 When make config is requested and dialog4ports is not installed yet the ports
 tree will install dialog4ports first.
 
 New feature for maintainer, if a pkg-help file is found inside the port
 directory then dialog will show to the user a help file is available et 
 propose
 him to hint F1 or ^E to show the said help file
 
 http://people.freebsd.org/~bapt/d4p.diff
 
 Please test!

I didn't get a chance to test this before it was committed, but I'm
currently running into this:


% pwd
/usr/local/tinderbox/portstrees/FreeBSD/ports/www/apache22
% sudo make config
dialog4ports isn't installed, do you want to install it now? [Y/n] n
env: /usr/local/bin/dialog4ports: No such file or directory
=== Options unchanged
%

And I'm prompted every time. Is this how it's supposed to work?

Steve

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-19 Thread Robert Simmons
I'm getting the same error after the most recent portsnap update.  It
looks like this has been added as a default for all make config
commands now.  Perhaps these changes should be backed out so it's not
the default for everything?

On Tue, Mar 19, 2013 at 10:39 PM, Steve Wills swi...@freebsd.org wrote:
 On 03/14/13 09:55, Baptiste Daroussin wrote:
 Hi all,

 Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
 tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
 dialog(1)
 designed specifically for the options, in particular for optionsng.

 It uses libdialog (recent version) and extend it with a new widget able to 
 deal
 with both normal and radio options in the same window.

 dialog4ports will live forever in ports so that it can easily be updated and 
 get
 support for new features on all supported arches at the same time.

 It bundles libdialog on FreeBSD versions that doesn't have a recent 
 libdialog in
 base (read 8.x)

 dialog4ports also support a new feature: it has a help dialog to be able to
 print a human readable help text if possible.

 Here is a patch to the ports tree that makes it use dialog4ports by default.
 What it does is:
 When make config is requested and dialog4ports is not installed yet the ports
 tree will install dialog4ports first.

 New feature for maintainer, if a pkg-help file is found inside the port
 directory then dialog will show to the user a help file is available et 
 propose
 him to hint F1 or ^E to show the said help file

 http://people.freebsd.org/~bapt/d4p.diff

 Please test!

 I didn't get a chance to test this before it was committed, but I'm
 currently running into this:


 % pwd
 /usr/local/tinderbox/portstrees/FreeBSD/ports/www/apache22
 % sudo make config
 dialog4ports isn't installed, do you want to install it now? [Y/n] n
 env: /usr/local/bin/dialog4ports: No such file or directory
 === Options unchanged
 %

 And I'm prompted every time. Is this how it's supposed to work?

 Steve

 ___
 freebsd-ports@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-ports
 To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-17 Thread Marco Steinbach

Baptiste Daroussin wrote on 14.03.2013 10:55:

Hi all,

Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
tree ports-mgmt/dialog4ports, this is intended to be a replacement for dialog(1)
designed specifically for the options, in particular for optionsng.

It uses libdialog (recent version) and extend it with a new widget able to deal
with both normal and radio options in the same window.


I very much like this from the few ports I tried it with for now.

Having UI elements in a config dialog behave like real radio groups is 
great, separating them from each other with horizontal lines adds 
greatly to readability and usabilty from where I sit.


Being able to specifiy a descriptive text to be displayed in the heading 
of radio option groups is a very welcome feature, since that'll give me 
a chance to be more concise about what the user will get from the group.


I think 'make showconfig' should learn to display these, also.

Albeit being a rather small change, I quite like the use of a small 'X' 
letter for ticked options.



dialog4ports will live forever in ports so that it can easily be updated and get
support for new features on all supported arches at the same time.

It bundles libdialog on FreeBSD versions that doesn't have a recent libdialog in
base (read 8.x)

dialog4ports also support a new feature: it has a help dialog to be able to
print a human readable help text if possible.


That's also very useful.  I thought about asking for having long lines 
being automatically reflowed to screen width, but this would probably 
open a small can of worms.  Anyway, help is supposed to give hints, not 
to replace documentation, and using fmt(1) on pkg-help before submission 
is not exactly rocket science.



Here is a patch to the ports tree that makes it use dialog4ports by default.
What it does is:
When make config is requested and dialog4ports is not installed yet the ports
tree will install dialog4ports first.

New feature for maintainer, if a pkg-help file is found inside the port
directory then dialog will show to the user a help file is available et propose
him to hint F1 or ^E to show the said help file

http://people.freebsd.org/~bapt/d4p.diff

Please test!


Nice work -- much appreciated :)

MfG CoCo
PS: There's a typo in the message asking for the dialog4ports 
installation.  It reads '... installed to you want ...', but probably 
should read '... installed, do you want ...'.


___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-17 Thread Warren Block

On Thu, 14 Mar 2013, Baptiste Daroussin wrote:


Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
tree ports-mgmt/dialog4ports, this is intended to be a replacement for dialog(1)
designed specifically for the options, in particular for optionsng.


My one complaint is that, last I looked, long option descriptions are 
not supported.  We really need this.  A maintainer should be concerned 
with clear option descriptions and not have to restrict their length at 
the cost of clarity.  The user should not have to interpret short or 
cut-off option descriptions.

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-17 Thread Baptiste Daroussin
On Sun, Mar 17, 2013 at 03:17:58PM +0100, Marco Steinbach wrote:
 Baptiste Daroussin wrote on 14.03.2013 10:55:
  Hi all,
  
  Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
  tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
  dialog(1)
  designed specifically for the options, in particular for optionsng.
  
  It uses libdialog (recent version) and extend it with a new widget able to 
  deal
  with both normal and radio options in the same window.
 
 I very much like this from the few ports I tried it with for now.
 
 Having UI elements in a config dialog behave like real radio groups is 
 great, separating them from each other with horizontal lines adds 
 greatly to readability and usabilty from where I sit.
 
 Being able to specifiy a descriptive text to be displayed in the heading 
 of radio option groups is a very welcome feature, since that'll give me 
 a chance to be more concise about what the user will get from the group.
 
 I think 'make showconfig' should learn to display these, also.
 
 Albeit being a rather small change, I quite like the use of a small 'X' 
 letter for ticked options.
 
  dialog4ports will live forever in ports so that it can easily be updated 
  and get
  support for new features on all supported arches at the same time.
  
  It bundles libdialog on FreeBSD versions that doesn't have a recent 
  libdialog in
  base (read 8.x)
  
  dialog4ports also support a new feature: it has a help dialog to be able to
  print a human readable help text if possible.
 
 That's also very useful.  I thought about asking for having long lines 
 being automatically reflowed to screen width, but this would probably 
 open a small can of worms.  Anyway, help is supposed to give hints, not 
 to replace documentation, and using fmt(1) on pkg-help before submission 
 is not exactly rocket science.
 
  Here is a patch to the ports tree that makes it use dialog4ports by default.
  What it does is:
  When make config is requested and dialog4ports is not installed yet the 
  ports
  tree will install dialog4ports first.
  
  New feature for maintainer, if a pkg-help file is found inside the port
  directory then dialog will show to the user a help file is available et 
  propose
  him to hint F1 or ^E to show the said help file
  
  http://people.freebsd.org/~bapt/d4p.diff
  
  Please test!
 
 Nice work -- much appreciated :)
 
 MfG CoCo
 PS: There's a typo in the message asking for the dialog4ports 
 installation.  It reads '... installed to you want ...', but probably 
 should read '... installed, do you want ...'.
 

Thanks for tests and feedback, also thanks for the typo, I ll fix before
committing.

regards,
Bapt


pgphxUuRsO54d.pgp
Description: PGP signature


Re: [CFT] New dialog for ports

2013-03-17 Thread Baptiste Daroussin
On Sun, Mar 17, 2013 at 08:56:13AM -0600, Warren Block wrote:
 On Thu, 14 Mar 2013, Baptiste Daroussin wrote:
 
  Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
  tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
  dialog(1)
  designed specifically for the options, in particular for optionsng.
 
 My one complaint is that, last I looked, long option descriptions are 
 not supported.  We really need this.  A maintainer should be concerned 
 with clear option descriptions and not have to restrict their length at 
 the cost of clarity.  The user should not have to interpret short or 
 cut-off option descriptions.

pkg-help might help here in the first place, second this could be worked on for
a 0.2 version ;), have you tried anyway long description with this version? I
think they just works correctly, but I haven't tested.

regards,
Bapt


pgppgeEsm8m7Q.pgp
Description: PGP signature


Re: [CFT] New dialog for ports

2013-03-17 Thread Marco Steinbach

Baptiste Daroussin wrote on 17.03.2013 16:11:

On Sun, Mar 17, 2013 at 08:56:13AM -0600, Warren Block wrote:

On Thu, 14 Mar 2013, Baptiste Daroussin wrote:


Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
tree ports-mgmt/dialog4ports, this is intended to be a replacement for dialog(1)
designed specifically for the options, in particular for optionsng.
My one complaint is that, last I looked, long option descriptions are 
not supported.  We really need this.  A maintainer should be concerned 
with clear option descriptions and not have to restrict their length at 
the cost of clarity.  The user should not have to interpret short or 
cut-off option descriptions.


pkg-help might help here in the first place, second this could be worked on for
a 0.2 version ;), have you tried anyway long description with this version? I
think they just works correctly, but I haven't tested.


I tried.  They get truncated, instead of overflowing and hosing the layout.

MfG CoCo

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: [CFT] New dialog for ports

2013-03-17 Thread Baptiste Daroussin
On Sun, Mar 17, 2013 at 04:15:56PM +0100, Marco Steinbach wrote:
 Baptiste Daroussin wrote on 17.03.2013 16:11:
  On Sun, Mar 17, 2013 at 08:56:13AM -0600, Warren Block wrote:
  On Thu, 14 Mar 2013, Baptiste Daroussin wrote:
 
  Ilya A. Arkhipov wrote dialog4ports which has just been added into the 
  ports
  tree ports-mgmt/dialog4ports, this is intended to be a replacement for 
  dialog(1)
  designed specifically for the options, in particular for optionsng.
  My one complaint is that, last I looked, long option descriptions are 
  not supported.  We really need this.  A maintainer should be concerned 
  with clear option descriptions and not have to restrict their length at 
  the cost of clarity.  The user should not have to interpret short or 
  cut-off option descriptions.
  
  pkg-help might help here in the first place, second this could be worked on 
  for
  a 0.2 version ;), have you tried anyway long description with this version? 
  I
  think they just works correctly, but I haven't tested.
 
 I tried.  They get truncated, instead of overflowing and hosing the layout.
 
 MfG CoCo
 

Ok thanks let's push this feature request for 0.2 then

regards,
Bapt


pgpIriO7Ms51E.pgp
Description: PGP signature


[CFT] New dialog for ports

2013-03-14 Thread Baptiste Daroussin
Hi all,

Ilya A. Arkhipov wrote dialog4ports which has just been added into the ports
tree ports-mgmt/dialog4ports, this is intended to be a replacement for dialog(1)
designed specifically for the options, in particular for optionsng.

It uses libdialog (recent version) and extend it with a new widget able to deal
with both normal and radio options in the same window.

dialog4ports will live forever in ports so that it can easily be updated and get
support for new features on all supported arches at the same time.

It bundles libdialog on FreeBSD versions that doesn't have a recent libdialog in
base (read 8.x)

dialog4ports also support a new feature: it has a help dialog to be able to
print a human readable help text if possible.

Here is a patch to the ports tree that makes it use dialog4ports by default.
What it does is:
When make config is requested and dialog4ports is not installed yet the ports
tree will install dialog4ports first.

New feature for maintainer, if a pkg-help file is found inside the port
directory then dialog will show to the user a help file is available et propose
him to hint F1 or ^E to show the said help file

http://people.freebsd.org/~bapt/d4p.diff

Please test!

regards,
Bapt


pgpk6NG9Nl3AD.pgp
Description: PGP signature