Re: [CFT] net-im/ejabberd to 16.02

2016-03-13 Thread Ashish SHUKLA 
On Mon, 14 Mar 2016 00:13:34 -0500, Kyle Evans  said:
| Hello!

| The updated port includes a ZLIB flag that seems to be used for
| inclusion/exclusion of the ezlib.* files, but ejabberd still attempts
| to load ezlib.app and fails to do so with the default setup. Am I
| missing something important here?

| Thanks,

| Kyle Evans

Hi Kyle,

Thanks for the report.

I have committed a fix. This should hopefully resolve the problem.

It seems like the option ZLIB is not quite optional, as it seems[1].

References:
[1] https://github.com/processone/ejabberd/blob/master/src/ejabberd_app.erl#L259

HTH
-- 
Ashish SHUKLA  | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

“Giving up smoking  is the easiest thing in the  world. I know because
I’ve done it thousands of times.”
(Mark Twain)

Sent from my Emacs


signature.asc
Description: PGP signature

Re: [CFT] net-im/ejabberd to 16.02

2016-03-13 Thread Kyle Evans 
Hello!

The updated port includes a ZLIB flag that seems to be used for
inclusion/exclusion of the ezlib.* files, but ejabberd still attempts
to load ezlib.app and fails to do so with the default setup. Am I
missing something important here?

Thanks,

Kyle Evans

-- 
--Kyle Evans
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: [CFT] net-im/ejabberd to 16.02

2016-03-11 Thread Ashish SHUKLA 
On Fri, 11 Mar 2016 19:00:54 +0100, Kurt Jaeger  said:
| Hi!

|| | https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-1.diff
|| 
|| Correct URL is: 
https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-2.diff

| The update hit the tree. Thanks for the persistence in providing
| this patch!

Thanks Kurt, I was going to commit it myself though. :)

-- 
Ashish SHUKLA  | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

“There  are three  principal  ways  to lose  money:  wine, women,  and
engineers. While the first two are  more pleasant, the third is by far
the more certain.”
(Baron Rothschild, ca. 1800)

Sent from my Emacs


signature.asc
Description: PGP signature

Re: [CFT] net-im/ejabberd to 16.02

2016-03-11 Thread Kurt Jaeger 
Hi!

> | https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-1.diff
> 
> Correct URL is: https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-2.diff

The update hit the tree. Thanks for the persistence in providing
this patch!

-- 
p...@opsec.eu+49 171 3101372 4 years to go !
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: [CFT] net-im/ejabberd to 16.02

2016-03-10 Thread Ashish SHUKLA 
On Fri, 11 Mar 2016 11:59:02 +0530, ash...@freebsd.org (Ashish SHUKLA) said:

[...]

| https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-1.diff

Correct URL is: https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-2.diff

| sha256: fe30991ecff239034127ee491b5ab279456517bbe9a078330d34b58341dd8723

Going to sleep :(

-- 
Ashish SHUKLA  | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

“The Ministry of Peace concerns itself with war, the Ministry of Truth
with lies,  the Ministry  of Love  with torture,  and the  Ministry of
Plenty with starvation.”
   (George Orwell, "Nineteen Eighty-Four", 1949)

Sent from my Emacs
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: [CFT] net-im/ejabberd to 16.02

2016-03-10 Thread Ashish SHUKLA 
On Wed, 9 Mar 2016 16:50:27 +0100, Kurt Jaeger  said:
| Hi!

|| Thanks for reminding about it. I have fixed all the issues. Please find the
|| latest diff below:
|| 
|| https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-1.diff
|| sha256: ea3adc38f58a3e4cdc9d52c6aa8fd84610ab24da82a22be1c368406b5f09d1bc

| Now it misses some ezlib files, if I check with make check-plist:

| ===> Checking for items in pkg-plist which are not in STAGEDIR
| Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/ebin/ezlib.app
| Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/ebin/ezlib.beam
| Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/ebin/ezlib_app.beam
| Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/ebin/ezlib_sup.beam
| Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/priv/lib/ezlib_drv.so
| ===> Error: Plist issues found.

Thanks for pointing out the issues. I missed testing for this last time. I
have updated the diff, and tested it again, and the issues are again.

Following are the details of the new diff:

https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-1.diff
sha256: fe30991ecff239034127ee491b5ab279456517bbe9a078330d34b58341dd8723

Thanks!
-- 
Ashish SHUKLA  | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

“Progress doesn't  come from early risers  – progress is made  by lazy
men looking for easier ways to do things.”
  (Robert A. Heinlein, 1973)

Sent from my Emacs


signature.asc
Description: PGP signature

Re: [CFT] net-im/ejabberd to 16.02

2016-03-09 Thread Kurt Jaeger 
Hi!

> Thanks for reminding about it. I have fixed all the issues. Please find the
> latest diff below:
> 
> https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-1.diff
> sha256: ea3adc38f58a3e4cdc9d52c6aa8fd84610ab24da82a22be1c368406b5f09d1bc

Now it misses some ezlib files, if I check with make check-plist:

===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/ebin/ezlib.app
Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/ebin/ezlib.beam
Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/ebin/ezlib_app.beam
Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/ebin/ezlib_sup.beam
Error: Missing: 
%%EJABBERD_LIBDIR%%/%%PORTNAME%%-%%PORTVERSION%%/lib/ezlib-1.0.1/priv/lib/ezlib_drv.so
===> Error: Plist issues found.

-- 
p...@opsec.eu+49 171 3101372 4 years to go !
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: [CFT] net-im/ejabberd to 16.02

2016-03-09 Thread Ashish SHUKLA 
On Tue, 8 Mar 2016 18:40:52 +0100, Kurt Jaeger  said:
| Hi!

|| I have updated my diff to install the file at the expected location. Other
|| changes in this update is cleanup, and updation of dependencies tarball.

| Please, may I suggest you test the resulting port with

| portlint -AC

| ? There are a few issues, among them the exec/unexec in the pkg-plist,
| which nowadays can be cleaned up with @sample.

| See:

| 
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#plist-keywords-sample

| For the really tricky patch-.. file, what about using the
| EXTRA_PATCHES contruct instead ?

Hi,

Thanks for reminding about it. I have fixed all the issues. Please find the
latest diff below:

https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-1.diff
sha256: ea3adc38f58a3e4cdc9d52c6aa8fd84610ab24da82a22be1c368406b5f09d1bc

Thanks!
-- 
Ashish SHUKLA  | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

“If I were to compare a human's heart with the ocean, the ocean would be
stagnant.”   (Recruit, Arakawa Under the Bridge)

Sent from my Emacs


signature.asc
Description: PGP signature

Re: [CFT] net-im/ejabberd to 16.02 (was: Re: [CFT] net-im/ejabberd to 16.01)

2016-03-08 Thread Kurt Jaeger 
Hi!

> I have updated my diff to install the file at the expected location. Other
> changes in this update is cleanup, and updation of dependencies tarball.

Please, may I suggest you test the resulting port with

portlint -AC

? There are a few issues, among them the exec/unexec in the pkg-plist,
which nowadays can be cleaned up with @sample.

See:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#plist-keywords-sample

For the really tricky patch-.. file, what about using the
EXTRA_PATCHES contruct instead ?

-- 
p...@opsec.eu+49 171 3101372 4 years to go !
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

[CFT] net-im/ejabberd to 16.02 (was: Re: [CFT] net-im/ejabberd to 16.01)

2016-03-08 Thread Ashish SHUKLA 
On Mon, 7 Mar 2016 20:19:46 +0100, Matthieu Volat  said:
| On Mon, 07 Mar 2016 12:27:11 +0530
| ash...@freebsd.org (Ashish SHUKLA) wrote:

|| On Sat, 5 Mar 2016 18:09:35 +0100, Matthieu Volat  said:
|| 
|| [...]
|| 
|| Hi,
|| 
|| | Ok, back on business!
|| 
|| | My issue with the non-applied patchs is that those were not creates in the 
files subdir in ejabberd, but in a ejabberd/files subdir.
|| 
|| That is likely due to the missing/incorrect, use of 'patch -pN'. I remember
|| testing successful diff application before posting on the list, except for a
|| 404-ing URL in one of my diffs.

| Yeah, it was a simple patch -p0 call... But anyway, that won't matter for 
final distribution...

|| 
|| | Regarding the pam module installation, it seems to be installed in :
|| | /usr/local/lib/erlang/lib/ejabberd-16.01/lib/p1_pam-1.0.0/priv/bin/epam
|| 
|| | But ejabberd at start will fail with :
|| | 2016-03-05 17:52:49.297 [error] <0.394.0> Can't open file
|| | 
"/usr/local/lib/erlang/lib/ejabberd-16.01/lib/erlang/lib/ejabberd-16.01/priv/bin/epam":
 enoent
|| 
|| | So I guess it's not installed in the right place?
|| 
|| I guess, although I don't see in the sources, where exactly it refer to this
|| path, or even install the module. I'll check and get back to you.

| I forgot to tell that I did not see it either, but I tried to put it manually 
and pam support was working.

It seems this is mentioned here p1_pam/src/epam.erl at:

142 get_bin_path() ->
143 case os:getenv("EJABBERD_BIN_PATH") of
144 false ->
145 case code:priv_dir(p1_pam) of
146 {error, _} ->
147 filename:join(["priv", "bin"]);
148 Path ->
149 filename:join([Path, "bin"])
150 end;
151 Path ->
152 Path
153 end.

I have updated my diff to install the file at the expected location. Other
changes in this update is cleanup, and updation of dependencies tarball.

Could you (and anyone else) please try the diff and see if it works for you,
and let me know before this March 04, 2016, hopefully no more releases this
time :) ?

https://people.freebsd.org/~ashish/diffs/ejabberd-16.02-0.diff
sha256: 4992e303b2dc7e3ee814d032991cdea7cec8e373f23d94d2e4c9e633b6a245a1

Thanks for your efforts, and time testing this, and providing the
feedback. It's really appreciated.

-- 
Ashish SHUKLA  | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

“Yeah, sure. Babies learn their mother tongue by reading the great
philosophers…“ (Pascal Bourguignon, comp.lang.lisp)

Sent from my Emacs


signature.asc
Description: PGP signature