Re: [CORRECTION] Change to the header in ports Makefiles, take two
Thomas Abthorpe portmgr-secret...@freebsd.org wrote: Sometimes, as a result of a repocopy, or changed maintainership, the Created By and MAINTAINER is no longer in synchronisation. To avoid confusion, the first line can be removed, optionally leaving us with a one line header. # $FreeBSD$ Removing the line of attribution is to be done only at the consent/request of the original contributor. Why bother? I always thought that this leaving the original maintainer intact is a nice way to say thank you to the person who brought this piece to FreeBSD. //Marcin ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
[CORRECTION] Change to the header in ports Makefiles, take two
It was recently posted on, http://blogs.freebsdish.org/portmgr/2012/09/01/change-to-the-header-in-ports-makefiles/ that we would adopt a new header for the ports Makefiles. The initial discussion seemed to show enough support for the idea of completely stripping the header, leaving only the $FreeBSD$ tag. After the announcement was made, more people stated strong feelings that when and where possible attribution be maintained in the header. A private discussion was held among ports committers, and while opinions were as varied as the individuals who shared them, it was decided to unify on a two line header. # Created by: J.Q. Public jqpub...@someaddress.com # $FreeBSD$ The Whom line from the classic six line header becomes Created By. Sometimes, as a result of a repocopy, or changed maintainership, the Created By and MAINTAINER is no longer in synchronisation. To avoid confusion, the first line can be removed, optionally leaving us with a one line header. # $FreeBSD$ Removing the line of attribution is to be done only at the consent/request of the original contributor. As before, we ask this header only be updated in conjunction with a regular update, as we do not want any unnecessary churn to the repo prior to the pending Ports Feature Freeze. Thomas on behalf of portmgr@ http://blogs.freebsdish.org/portmgr/2012/09/17/change-to-the-header-in-ports-makefiles-take-two/ ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [CORRECTION] Change to the header in ports Makefiles, take two
On Mon, Sep 17, 2012 at 9:33 AM, Thomas Abthorpe portmgr-secret...@freebsd.org wrote: It was recently posted on, http://blogs.freebsdish.org/portmgr/2012/09/01/change-to-the-header-in-ports-makefiles/ that we would adopt a new header for the ports Makefiles. The initial discussion seemed to show enough support for the idea of completely stripping the header, leaving only the $FreeBSD$ tag. After the announcement was made, more people stated strong feelings that when and where possible attribution be maintained in the header. A private discussion was held among ports committers, and while opinions were as varied as the individuals who shared them, it was decided to unify on a two line header. # Created by: J.Q. Public jqpub...@someaddress.com # $FreeBSD$ The Whom line from the classic six line header becomes Created By. Sometimes, as a result of a repocopy, or changed maintainership, the Created By and MAINTAINER is no longer in synchronisation. To avoid confusion, the first line can be removed, optionally leaving us with a one line header. # $FreeBSD$ Wouldn't it make sense to have the # $FreeBSD$ line be the first line of the file, so that it never changes? Having some files where the FreeBSD tag is first, and other files where it's second seems arbitrarily inconsistent. Lines that don't change should come first, so that things are always the same. IMHO, of course. :) -- Freddie Cash fjwc...@gmail.com ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [CORRECTION] Change to the header in ports Makefiles, take two
On 09/17/12 11:43, Freddie Cash wrote: On Mon, Sep 17, 2012 at 9:33 AM, Thomas Abthorpe portmgr-secret...@freebsd.org wrote: It was recently posted on, http://blogs.freebsdish.org/portmgr/2012/09/01/change-to-the-header-in-ports-makefiles/ that we would adopt a new header for the ports Makefiles. The initial discussion seemed to show enough support for the idea of completely stripping the header, leaving only the $FreeBSD$ tag. After the announcement was made, more people stated strong feelings that when and where possible attribution be maintained in the header. A private discussion was held among ports committers, and while opinions were as varied as the individuals who shared them, it was decided to unify on a two line header. # Created by: J.Q. Public jqpub...@someaddress.com # $FreeBSD$ The Whom line from the classic six line header becomes Created By. Sometimes, as a result of a repocopy, or changed maintainership, the Created By and MAINTAINER is no longer in synchronisation. To avoid confusion, the first line can be removed, optionally leaving us with a one line header. # $FreeBSD$ Wouldn't it make sense to have the # $FreeBSD$ line be the first line of the file, so that it never changes? Having some files where the FreeBSD tag is first, and other files where it's second seems arbitrarily inconsistent. Lines that don't change should come first, so that things are always the same. IMHO, of course. :) You want *consistency* ? What will people ask for next? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [CORRECTION] Change to the header in ports Makefiles, take two
On Mon, Sep 17, 2012 at 11:43 AM, Freddie Cash fjwc...@gmail.com wrote: On Mon, Sep 17, 2012 at 9:33 AM, Thomas Abthorpe portmgr-secret...@freebsd.org wrote: It was recently posted on, http://blogs.freebsdish.org/portmgr/2012/09/01/change-to-the-header-in-ports-makefiles/ that we would adopt a new header for the ports Makefiles. The initial discussion seemed to show enough support for the idea of completely stripping the header, leaving only the $FreeBSD$ tag. After the announcement was made, more people stated strong feelings that when and where possible attribution be maintained in the header. A private discussion was held among ports committers, and while opinions were as varied as the individuals who shared them, it was decided to unify on a two line header. # Created by: J.Q. Public jqpub...@someaddress.com # $FreeBSD$ The Whom line from the classic six line header becomes Created By. Sometimes, as a result of a repocopy, or changed maintainership, the Created By and MAINTAINER is no longer in synchronisation. To avoid confusion, the first line can be removed, optionally leaving us with a one line header. # $FreeBSD$ Wouldn't it make sense to have the # $FreeBSD$ line be the first line of the file, so that it never changes? Having some files where the FreeBSD tag is first, and other files where it's second seems arbitrarily inconsistent. Lines that don't change should come first, so that things are always the same. The copyright always come first. The $FreeBSD$ does change at the each commit. IMHO, of course. :) I don't care if it's IMHO, but dude you are pain in ass already. -- Freddie Cash fjwc...@gmail.com -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: [CORRECTION] Change to the header in ports Makefiles, take two
[ Jeremy Messenger wrote on Mon 17.Sep'12 at 11:59:08 -0500 ] IMHO, of course. :) I don't care if it's IMHO, but dude you are pain in ass already. -- Freddie Cash fjwc...@gmail.com What is a pain in the arse are comments like this. We use FreeBSD and people make decisions about its development and progress which affects those of us that use it, so I think we have the right to ask questions and make comments about these changes without being publicly criticised in such a rude manner. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
