Re: Clang Import Breakage

2019-03-24 Thread Konstantin Belousov 
On Sun, Mar 24, 2019 at 07:03:11AM +0100, Jan Beich wrote:
> Sean Bruno  writes:
> 
> > On 3/23/19 5:57 PM, Dimitry Andric wrote:
> >> This is fallout of ,
> >> which enabled --no-allow-shlib-undefined by default.  See also
> >> .  Executive summary: lots of programs
> >> do not specify all their required libraries, a.k.a. "under-linking".
> >> 
> >> I haven't yet reverted lld's new default, since it seems that a lot of
> >> under-linking fixes are now being made.  These problems will also occur
> >> when linking with gold, for instance, so it is quite useful to solve
> >> them once and for all.
> >> 
> >> -Dimitry
> >
> > Oh, hrm.  Ok.
> >
> > So, before the changes, my port succeeds in adding libogg to its LD list
> > when doing its link.
> 
> LLD before and BFD linker didn't complain that your port bootlegged
> libogg via libvorbis. For one, libvorbis may stop depending on libogg,
> may bundle libogg as a static library or import libogg symbols with
> LOCAL visibility.
But in this case, you get the breakage even with the ld.bfd, and if
you get over the static linking stage, with runtime linker as well.
This is exactly the issue that disabling of underlinking uncovers:
if you use a symbol provided by a library, the library must appear in
DT_NEEDED.

> 
> Ditto for libssl bootlegging libcrypto.
> ___
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Clang Import Breakage

2019-03-24 Thread Jan Beich 
Sean Bruno  writes:

> On 3/23/19 5:57 PM, Dimitry Andric wrote:
>> This is fallout of ,
>> which enabled --no-allow-shlib-undefined by default.  See also
>> .  Executive summary: lots of programs
>> do not specify all their required libraries, a.k.a. "under-linking".
>> 
>> I haven't yet reverted lld's new default, since it seems that a lot of
>> under-linking fixes are now being made.  These problems will also occur
>> when linking with gold, for instance, so it is quite useful to solve
>> them once and for all.
>> 
>> -Dimitry
>
> Oh, hrm.  Ok.
>
> So, before the changes, my port succeeds in adding libogg to its LD list
> when doing its link.

LLD before and BFD linker didn't complain that your port bootlegged
libogg via libvorbis. For one, libvorbis may stop depending on libogg,
may bundle libogg as a static library or import libogg symbols with
LOCAL visibility.

Ditto for libssl bootlegging libcrypto.
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Clang Import Breakage

2019-03-23 Thread Sean Bruno 


On 3/23/19 5:57 PM, Dimitry Andric wrote:
> This is fallout of ,
> which enabled --no-allow-shlib-undefined by default.  See also
> .  Executive summary: lots of programs
> do not specify all their required libraries, a.k.a. "under-linking".
> 
> I haven't yet reverted lld's new default, since it seems that a lot of
> under-linking fixes are now being made.  These problems will also occur
> when linking with gold, for instance, so it is quite useful to solve
> them once and for all.
> 
> -Dimitry

Oh, hrm.  Ok.

So, before the changes, my port succeeds in adding libogg to its LD list
when doing its link.

I can't tell if that's the same thing as "under-linking" in this case.

sean



signature.asc
Description: OpenPGP digital signature

Re: Clang Import Breakage

2019-03-23 Thread Dimitry Andric 
On 24 Mar 2019, at 00:22, Sean Bruno  wrote:
> 
> audio/shout-idjc seems to have broken in a new and exciting way after
> the 8.0 import.
> 
> It would appear that the ports infrastructure detects libssl and libogg
> exist (if the beginning of my logs are to be believed) but then are not
> used during libtool/LD stages later on resulting in missing symbols.
> This does not happen prior to the import so I am assuming I am missing
> something explicit here.
> 
> http://beefy12.nyi.freebsd.org/data/head-amd64-default/p496405_s345355/logs/errors/libshout-idjc-2.4.2.log

This is fallout of ,
which enabled --no-allow-shlib-undefined by default.  See also
.  Executive summary: lots of programs
do not specify all their required libraries, a.k.a. "under-linking".

I haven't yet reverted lld's new default, since it seems that a lot of
under-linking fixes are now being made.  These problems will also occur
when linking with gold, for instance, so it is quite useful to solve
them once and for all.

-Dimitry



signature.asc
Description: Message signed with OpenPGP

Clang Import Breakage

2019-03-23 Thread Sean Bruno 
audio/shout-idjc seems to have broken in a new and exciting way after
the 8.0 import.

It would appear that the ports infrastructure detects libssl and libogg
exist (if the beginning of my logs are to be believed) but then are not
used during libtool/LD stages later on resulting in missing symbols.
This does not happen prior to the import so I am assuming I am missing
something explicit here.

http://beefy12.nyi.freebsd.org/data/head-amd64-default/p496405_s345355/logs/errors/libshout-idjc-2.4.2.log



signature.asc
Description: OpenPGP digital signature