Re: firefox build broken by SVN r520537?

2019-12-23 Thread Kevin Oberman
Yes, it is a known issue, but only shows up when gtk3 is built without
Wayland support. See bug 242790. gecko@ is waiting for an upstream patch.
Until then the recommendation is to remove the patch which looks like
simply reverting to PORTREVISION 3.
--
Kevin Oberman, Part time kid herder and retired Network Engineer.
E-mail: rkober...@gmail.com
PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683


On Sun, Dec 22, 2019 at 12:32 PM Michael Butler 
wrote:

> Is noone else seeing ..
>
> In file included from Unified_cpp_toolkit_xre0.cpp:56:
> /usr/ports/www/firefox/work/firefox-71.0/toolkit/xre/glxtest.cpp:39:10:
> fatal error: 'mozilla/widget/mozwayland.h' file not found
> #include "mozilla/widget/mozwayland.h"
>  ^
>
> imb
> ___
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
>
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken by SVN r520537?

2019-12-22 Thread Jan Beich
Michael Butler  writes:

> Is noone else seeing ..
>
> In file included from Unified_cpp_toolkit_xre0.cpp:56:
> /usr/ports/www/firefox/work/firefox-71.0/toolkit/xre/glxtest.cpp:39:10:
> fatal error: 'mozilla/widget/mozwayland.h' file not found
> #include "mozilla/widget/mozwayland.h"
>  ^

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242790
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


firefox build broken by SVN r520537?

2019-12-22 Thread Michael Butler
Is noone else seeing ..

In file included from Unified_cpp_toolkit_xre0.cpp:56:
/usr/ports/www/firefox/work/firefox-71.0/toolkit/xre/glxtest.cpp:39:10:
fatal error: 'mozilla/widget/mozwayland.h' file not found
#include "mozilla/widget/mozwayland.h"
 ^

imb
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Firefox build broken

2017-02-09 Thread Andriy Gapon
On 09/02/2017 16:17, Dimitry Andric wrote:
> On 9 Feb 2017, at 14:03, Domagoj Stolfa  wrote:
>>
>> It would seem that the firefox build is broken on 12.0-CURRENT. I've been
>> getting the same error as seem on [1]. Has anyone else experienced this?
>>
>> [1] 
>> https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20170206/408053.html
> 
> It's a problem in the DTRACE option.  See https://bugs.freebsd.org/216871 .
> 
> For now, if you don't need DTrace support, just turn it off.

Can this be done by default?  So, that the binary packages for "FreeBSD 12" can
be built.


-- 
Andriy Gapon
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Firefox build broken

2017-02-09 Thread Dimitry Andric
On 9 Feb 2017, at 14:03, Domagoj Stolfa  wrote:
> 
> It would seem that the firefox build is broken on 12.0-CURRENT. I've been
> getting the same error as seem on [1]. Has anyone else experienced this?
> 
> [1] 
> https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20170206/408053.html

It's a problem in the DTRACE option.  See https://bugs.freebsd.org/216871 .

For now, if you don't need DTrace support, just turn it off.

-Dimitry



signature.asc
Description: Message signed with OpenPGP


Firefox build broken

2017-02-09 Thread Domagoj Stolfa
Hello,

It would seem that the firefox build is broken on 12.0-CURRENT. I've been
getting the same error as seem on [1]. Has anyone else experienced this?

[1] 
https://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20170206/408053.html

--
Best regards,
Domagoj Stolfa


signature.asc
Description: PGP signature


Re: firefox build broken under clang 3.3

2013-05-07 Thread Dimitry Andric

On 2013-05-07 14:59, Rafael Espíndola wrote:

On 1 May 2013 00:26, Rafael Espíndola  wrote:

This is now

http://llvm.org/bugs/show_bug.cgi?id=15882


And it got fixed! :-)

It just missed 3.3 branching, but I will make sure it gets ported.


Okay, can the original posters that suffered from the crash, please try
the attached patch on their -current source, then try to rebuild the
Firefox port, and check if the crash has disappeared?

If you just want to incrementally build clang, you can do:

  cd /usr/src/lib/clang/libllvmvectorize
  make
  cd /usr/src/usr.bin/clang/clang
  make
  sudo make install

-Dimitry
Index: contrib/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
===
--- contrib/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp	(revision 250331)
+++ contrib/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp	(working copy)
@@ -214,7 +214,7 @@ class InnerLoopVectorizer {
   /// This function adds 0, 1, 2 ... to each vector element, starting at zero.
   /// If Negate is set then negative numbers are added e.g. (0, -1, -2, ...).
   /// The sequence starts at StartIndex.
-  Value *getConsecutiveVector(Value* Val, unsigned StartIdx, bool Negate);
+  Value *getConsecutiveVector(Value* Val, int StartIdx, bool Negate);
 
   /// When we go over instructions in the basic block we rely on previous
   /// values within the current basic block or on loop invariant values.
@@ -771,7 +771,7 @@ Value *InnerLoopVectorizer::getBroadcastInstrs(Val
   return Shuf;
 }
 
-Value *InnerLoopVectorizer::getConsecutiveVector(Value* Val, unsigned StartIdx,
+Value *InnerLoopVectorizer::getConsecutiveVector(Value* Val, int StartIdx,
  bool Negate) {
   assert(Val->getType()->isVectorTy() && "Must be a vector");
   assert(Val->getType()->getScalarType()->isIntegerTy() &&
@@ -784,8 +784,8 @@ Value *InnerLoopVectorizer::getBroadcastInstrs(Val
 
   // Create a vector of consecutive numbers from zero to VF.
   for (int i = 0; i < VLen; ++i) {
-int Idx = Negate ? (-i): i;
-Indices.push_back(ConstantInt::get(ITy, StartIdx + Idx));
+int64_t Idx = Negate ? (-i) : i;
+Indices.push_back(ConstantInt::get(ITy, StartIdx + Idx, Negate));
   }
 
   // Add the consecutive indices to the vector value.
@@ -1928,7 +1928,8 @@ InnerLoopVectorizer::vectorizeBlockInLoop(LoopVect
   // After broadcasting the induction variable we need to make the
   // vector consecutive by adding  ... -3, -2, -1, 0.
   for (unsigned part = 0; part < UF; ++part)
-Entry[part] = getConsecutiveVector(Broadcasted, -VF * part, true);
+Entry[part] = getConsecutiveVector(Broadcasted, -(int)VF * part,
+   true);
   continue;
 }
 
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: firefox build broken under clang 3.3

2013-05-07 Thread Rafael Espíndola
On 1 May 2013 00:26, Rafael Espíndola  wrote:
> This is now
>
> http://llvm.org/bugs/show_bug.cgi?id=15882

And it got fixed! :-)

It just missed 3.3 branching, but I will make sure it gets ported.

Cheers,
Rafael
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: firefox build broken under clang 3.3

2013-05-05 Thread Brandon Gooch
On Tue, Apr 30, 2013 at 11:26 PM, Rafael Espíndola
 wrote:
> This is now
>
> http://llvm.org/bugs/show_bug.cgi?id=15882
>
> Someone familiar with the baseline compiler might be able to spot what
> is wrong with the optimization.
>
> Cheers,
> Rafael

Just an FYI, I've been using firefox-21.0.b3,1 from:

$ svn info
Path: .
Working Copy Root Path: /usr/home/brandon/wc/freebsd-gecko
URL: https://trillian.chruetertee.ch/svn/freebsd-gecko/trunk/www/firefox
Repository Root: https://trillian.chruetertee.ch/svn/freebsd-gecko
Repository UUID: 6ab5617d-af29-de11-a9e3-001676731981
Revision: 1258
Node Kind: directory
Schedule: normal
Last Changed Author: jbeich
Last Changed Rev: 1256
Last Changed Date: 2013-04-30 04:35:07 -0500 (Tue, 30 Apr 2013)

I've not have a crash since.

-Brandon
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-30 Thread Rafael Espíndola
This is now

http://llvm.org/bugs/show_bug.cgi?id=15882

Someone familiar with the baseline compiler might be able to spot what
is wrong with the optimization.

Cheers,
Rafael
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-30 Thread Rafael Espíndola
OK, I was able to reproduce this. I am trying to reduce the testcase.

On 30 April 2013 14:23, Dimitry Andric  wrote:
> On Apr 30, 2013, at 18:34, Jan Beich  wrote:
> ...
>> The faulting function is lost within crash handler. If you build
>> firefox with
>>
>>  # use DEBUG_FLAGS or set STRIP to empty explicitly
>>  CFLAGS += ${DEBUG_FLAGS}
>>  DEBUG_FLAGS += -O0 -g
>>
>> jaeger jit crash would look like
>>
>> http://lists.freebsd.org/pipermail/freebsd-current/2013-April/041165.html
>
> The firefox crash in that post was with -O2, so it is most likely not due to 
> the vectorizer then.
>
> In any case, I have not been able to reproduce that either.  I have browsed 
> stackoverflow.com for about 5 minutes, clicking a whole bunch of random 
> articles and links, and no problems whatsoever occurred.  That is with the 
> default www/firefox port, which seems to be the released Firefox 20.0, at its 
> default settings, on amd64.
>
>
>> It doesn't happen on firefox23 with baseline jit[1] disabled via pref.
>> A big change like zones (bug 759585) may have refactored code enough
>> to not hit the clang bug. So, try either clang trunk or
>>
>> http://trillian.chruetertee.ch/freebsd-gecko/changeset/1256/trunk/www/firefox/files/patch-clang33
>>
>> The latter pessimizes inlining for clang 3.2 as well.
>>
>> [1] baseline crashes in a different way
>>https://bugzilla.mozilla.org/show_bug.cgi?id=860867
>
> I do not like the workaround in that Mozilla bug, since it simply disables 
> the vectorizer.  I can understand that software must always ship tomorrow, 
> but it would have been nicer to attempt to figure out what is incorrectly 
> optimized, and why...
>
>
>>> Rebuilding with debugging symbols provides no further insight, as that
>>> seems to provide a work-around for whatever the root cause may be
>>> (i.e. no more segfaults).
>>
>> DEBUG enables compile-time diagnostics and strips any -O* from CFLAGS.
>
> Indeed.  To work around this, use the following diff:
>
> Index: Mk/bsd.port.mk
> ===
> --- Mk/bsd.port.mk  (revision 316903)
> +++ Mk/bsd.port.mk  (working copy)
> @@ -1580,7 +1580,7 @@
>  .if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG)
>  STRIP_CMD= ${TRUE}
>  DEBUG_FLAGS?=  -g
> -CFLAGS:=   ${CFLAGS:N-O*:N-fno-strict*} ${DEBUG_FLAGS}
> +CFLAGS:=   ${CFLAGS} ${DEBUG_FLAGS}
>  .endif
>
>  .if defined(NOPORTDOCS)
>
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-30 Thread Dimitry Andric
On Apr 30, 2013, at 18:34, Jan Beich  wrote:
...
> The faulting function is lost within crash handler. If you build
> firefox with
> 
>  # use DEBUG_FLAGS or set STRIP to empty explicitly
>  CFLAGS += ${DEBUG_FLAGS}
>  DEBUG_FLAGS += -O0 -g
> 
> jaeger jit crash would look like
> 
> http://lists.freebsd.org/pipermail/freebsd-current/2013-April/041165.html

The firefox crash in that post was with -O2, so it is most likely not due to 
the vectorizer then.

In any case, I have not been able to reproduce that either.  I have browsed 
stackoverflow.com for about 5 minutes, clicking a whole bunch of random 
articles and links, and no problems whatsoever occurred.  That is with the 
default www/firefox port, which seems to be the released Firefox 20.0, at its 
default settings, on amd64.


> It doesn't happen on firefox23 with baseline jit[1] disabled via pref.
> A big change like zones (bug 759585) may have refactored code enough
> to not hit the clang bug. So, try either clang trunk or
> 
> http://trillian.chruetertee.ch/freebsd-gecko/changeset/1256/trunk/www/firefox/files/patch-clang33
> 
> The latter pessimizes inlining for clang 3.2 as well.
> 
> [1] baseline crashes in a different way
>https://bugzilla.mozilla.org/show_bug.cgi?id=860867

I do not like the workaround in that Mozilla bug, since it simply disables the 
vectorizer.  I can understand that software must always ship tomorrow, but it 
would have been nicer to attempt to figure out what is incorrectly optimized, 
and why...


>> Rebuilding with debugging symbols provides no further insight, as that
>> seems to provide a work-around for whatever the root cause may be
>> (i.e. no more segfaults).
> 
> DEBUG enables compile-time diagnostics and strips any -O* from CFLAGS.

Indeed.  To work around this, use the following diff:

Index: Mk/bsd.port.mk
===
--- Mk/bsd.port.mk  (revision 316903)
+++ Mk/bsd.port.mk  (working copy)
@@ -1580,7 +1580,7 @@
 .if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG)
 STRIP_CMD= ${TRUE}
 DEBUG_FLAGS?=  -g
-CFLAGS:=   ${CFLAGS:N-O*:N-fno-strict*} ${DEBUG_FLAGS}
+CFLAGS:=   ${CFLAGS} ${DEBUG_FLAGS}
 .endif
 
 .if defined(NOPORTDOCS)

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-30 Thread Dimitry Andric
On Apr 30, 2013, at 17:25, Dimitry Andric  wrote:
...
> In any case, I have just built the latest Firefox from ports, with clang 3.3, 
> and I see no issues at all.  At least with approximately 10 minutes of 
> browsing, and visiting a varied bunch of sites.  I do have it built with 
> debug info, but without cranking down the optimization level to -O0 (which is 
> what bsd.port.mk seems to do, unfortunately).
> 
> I will rebuild it again, without any debug info, to see if that makes any 
> difference.  I don't think it will, though...

Rebuilt without debug info, worked just fine.  Is there a particular scenario 
that makes it crash?

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-30 Thread Jan Beich
Brandon Gooch  writes:

> On Fri, Apr 19, 2013 at 1:06 PM, Florian Smeets  wrote:
>> On 19.04.13 19:48, Dimitry Andric wrote:
>>> On Apr 19, 2013, at 17:56, Florian Smeets  wrote:
>>>
 On 19.04.13 04:01, kit wrote:
> updated current and now firefox and thunderbird both fail to build under
> the new clang 3.3. has anyone seen this or know how to fix?

 The fix is here:

 http://tb.smeets.im/~flo/gecko-clang33-fixes.diff

 It will be committed after the freeze.
>>>
>>> Are these fixes from upstream?  If not, it would be nice to send them 
>>> there...
>>>
>>>
>>
>> patch-bug854936 is a workaround because we don't have
>> http://llvm.org/viewvc/llvm-project?view=revision&revision=178950 yet.
>>
>> firefox-nightly (in our gecko svn repo) already compiles fine without
>> patch-clang33
>>
>> So everything should be fine :)
>>
>> Florian
>
> Thanks for fixing the build issues.
>
> Now, I've built Firefox with Clang, but the darn thing segfaults at
> the drop of a hat:
>
> $ gdb /usr/local/bin/firefox firefox.core
> ...
> (gdb) bt
> #0  0x0008011eefaa in thr_kill () from /lib/libc.so.7
> #1  0x0008024d254d in XRE_InstallX11ErrorHandler ()
>from /usr/local/lib/firefox/libxul.so
> #2  0x000800f74116 in swapcontext () from /lib/libthr.so.3
> #3  0x000800f73d39 in sigaction () from /lib/libthr.so.3
> #4  0x7193 in ?? ()
> #5  0x000800f73c20 in sigaction () from /lib/libthr.so.3
> Previous frame inner to this frame (corrupt stack?)

The faulting function is lost within crash handler. If you build
firefox with

  # use DEBUG_FLAGS or set STRIP to empty explicitly
  CFLAGS += ${DEBUG_FLAGS}
  DEBUG_FLAGS += -O0 -g

jaeger jit crash would look like

http://lists.freebsd.org/pipermail/freebsd-current/2013-April/041165.html

It doesn't happen on firefox23 with baseline jit[1] disabled via pref.
A big change like zones (bug 759585) may have refactored code enough
to not hit the clang bug. So, try either clang trunk or

http://trillian.chruetertee.ch/freebsd-gecko/changeset/1256/trunk/www/firefox/files/patch-clang33

The latter pessimizes inlining for clang 3.2 as well.

[1] baseline crashes in a different way
https://bugzilla.mozilla.org/show_bug.cgi?id=860867

>
> Rebuilding with debugging symbols provides no further insight, as that
> seems to provide a work-around for whatever the root cause may be
> (i.e. no more segfaults).

DEBUG enables compile-time diagnostics and strips any -O* from CFLAGS.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-30 Thread Dimitry Andric
On Apr 30, 2013, at 05:28, Brandon Gooch  wrote:
...
> Thanks for fixing the build issues.
> 
> Now, I've built Firefox with Clang, but the darn thing segfaults at
> the drop of a hat:
> 
> $ gdb /usr/local/bin/firefox firefox.core
> ...
> (gdb) bt
> #0  0x0008011eefaa in thr_kill () from /lib/libc.so.7
> #1  0x0008024d254d in XRE_InstallX11ErrorHandler ()
>   from /usr/local/lib/firefox/libxul.so
> #2  0x000800f74116 in swapcontext () from /lib/libthr.so.3
> #3  0x000800f73d39 in sigaction () from /lib/libthr.so.3
> #4  0x7193 in ?? ()
> #5  0x000800f73c20 in sigaction () from /lib/libthr.so.3
> Previous frame inner to this frame (corrupt stack?)
> 
> Rebuilding with debugging symbols provides no further insight, as that
> seems to provide a work-around for whatever the root cause may be
> (i.e. no more segfaults).
> 
> Are any of you seeing something similar?

Which exact version of head do you have, and which version(s) of ports?  Are 
you running WITH_NEW_XORG or not?

In any case, I have just built the latest Firefox from ports, with clang 3.3, 
and I see no issues at all.  At least with approximately 10 minutes of 
browsing, and visiting a varied bunch of sites.  I do have it built with debug 
info, but without cranking down the optimization level to -O0 (which is what 
bsd.port.mk seems to do, unfortunately).

I will rebuild it again, without any debug info, to see if that makes any 
difference.  I don't think it will, though...

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-29 Thread Brandon Gooch
On Fri, Apr 19, 2013 at 1:06 PM, Florian Smeets  wrote:
> On 19.04.13 19:48, Dimitry Andric wrote:
>> On Apr 19, 2013, at 17:56, Florian Smeets  wrote:
>>
>>> On 19.04.13 04:01, kit wrote:
 updated current and now firefox and thunderbird both fail to build under
 the new clang 3.3. has anyone seen this or know how to fix?
>>>
>>> The fix is here:
>>>
>>> http://tb.smeets.im/~flo/gecko-clang33-fixes.diff
>>>
>>> It will be committed after the freeze.
>>
>> Are these fixes from upstream?  If not, it would be nice to send them 
>> there...
>>
>>
>
> patch-bug854936 is a workaround because we don't have
> http://llvm.org/viewvc/llvm-project?view=revision&revision=178950 yet.
>
> firefox-nightly (in our gecko svn repo) already compiles fine without
> patch-clang33
>
> So everything should be fine :)
>
> Florian

Thanks for fixing the build issues.

Now, I've built Firefox with Clang, but the darn thing segfaults at
the drop of a hat:

$ gdb /usr/local/bin/firefox firefox.core
...
(gdb) bt
#0  0x0008011eefaa in thr_kill () from /lib/libc.so.7
#1  0x0008024d254d in XRE_InstallX11ErrorHandler ()
   from /usr/local/lib/firefox/libxul.so
#2  0x000800f74116 in swapcontext () from /lib/libthr.so.3
#3  0x000800f73d39 in sigaction () from /lib/libthr.so.3
#4  0x7193 in ?? ()
#5  0x000800f73c20 in sigaction () from /lib/libthr.so.3
Previous frame inner to this frame (corrupt stack?)

Rebuilding with debugging symbols provides no further insight, as that
seems to provide a work-around for whatever the root cause may be
(i.e. no more segfaults).

Are any of you seeing something similar?

-Brandon
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-19 Thread Florian Smeets
On 19.04.13 19:48, Dimitry Andric wrote:
> On Apr 19, 2013, at 17:56, Florian Smeets  wrote:
> 
>> On 19.04.13 04:01, kit wrote:
>>> updated current and now firefox and thunderbird both fail to build under
>>> the new clang 3.3. has anyone seen this or know how to fix?
>>
>> The fix is here:
>>
>> http://tb.smeets.im/~flo/gecko-clang33-fixes.diff
>>
>> It will be committed after the freeze.
> 
> Are these fixes from upstream?  If not, it would be nice to send them there...
> 
> 

patch-bug854936 is a workaround because we don't have
http://llvm.org/viewvc/llvm-project?view=revision&revision=178950 yet.

firefox-nightly (in our gecko svn repo) already compiles fine without
patch-clang33

So everything should be fine :)

Florian



signature.asc
Description: OpenPGP digital signature


Re: firefox build broken under clang 3.3

2013-04-19 Thread Dimitry Andric
On Apr 19, 2013, at 17:56, Florian Smeets  wrote:

> On 19.04.13 04:01, kit wrote:
>> updated current and now firefox and thunderbird both fail to build under
>> the new clang 3.3. has anyone seen this or know how to fix?
> 
> The fix is here:
> 
> http://tb.smeets.im/~flo/gecko-clang33-fixes.diff
> 
> It will be committed after the freeze.

Are these fixes from upstream?  If not, it would be nice to send them there...


___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: firefox build broken under clang 3.3

2013-04-19 Thread Florian Smeets
On 19.04.13 04:01, kit wrote:
> updated current and now firefox and thunderbird both fail to build under
> the new clang 3.3. has anyone seen this or know how to fix?

The fix is here:

http://tb.smeets.im/~flo/gecko-clang33-fixes.diff

It will be committed after the freeze.

Florian



signature.asc
Description: OpenPGP digital signature


firefox build broken under clang 3.3

2013-04-19 Thread kit
updated current and now firefox and thunderbird both fail to build under
the new clang 3.3. has anyone seen this or know how to fix?

gmake[3]: Entering directory 
`/tmp/obj/usr/ports/www/firefox/work/mozilla-release/obj-x86_64-portbld-freebsd10.0/js/src'
/usr/bin/clang++ -o jsanalyze.o -c  -I./../../dist/system_wrappers_js -include 
../../../js/src/config/gcc_hidden.h -DENABLE_TYPEDARRAY_MOVE 
-DENABLE_YARR_JIT=1 -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -DEXPORT_JS_API 
-DJS_HAS_CTYPES -DDLL_PREFIX=\"lib\" -DDLL_SUFFIX=\".so\" -DUSE_ZLIB 
-I/usr/local/lib/libffi-3.0.11/include   -I.  
-I../../../js/src/../../mfbt/double-conversion -I../../../js/src -I. 
-I./../../dist/include  -I/usr/local/include/nspr  -I../../../js/src 
-I../../../js/src/assembler -I../../../js/src/yarr  -fPIC -Qunused-arguments 
-isystem/usr/local/include  -I/usr/local/include -Qunused-arguments -Wall 
-Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits 
-Wempty-body -Werror=conversion-null -Wno-ctor-dtor-privacy 
-Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros 
-Wno-c++0x-extensions -Wno-extended-offsetof -Wno-unknown-warning-option 
-Wno-return-type-c-linkage -Wno-mismatched-tags -O2 -pipe -fno-strict-aliasing 
-fno-rtti -ff
 unction-sections -fdata-sections -fno-exceptions -pipe  -DNDEBUG -DTRIMMED -O2 
-fomit-frame-pointer -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1  
-Qunused-arguments -isystem/usr/local/include  -I/usr/local/include 
-DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/jsanalyze.o.pp  
/tmp/obj/usr/ports/www/firefox/work/mozilla-release/js/src/jsanalyze.cpp
In file included from 
/tmp/obj/usr/ports/www/firefox/work/mozilla-release/js/src/jsanalyze.cpp:14:
In file included from ../../../js/src/jsinferinlines.h:21:
In file included from ../../../js/src/vm/Stack-inl.h:19:
In file included from ../../../js/src/jsscriptinlines.h:21:
In file included from ../../../js/src/jsscopeinlines.h:26:
In file included from ../../../js/src/jscntxtinlines.h:15:
In file included from ../../../js/src/jsprobes.h:23:
../../../js/src/vm/ObjectImpl-inl.h:215:55: error: use of undeclared identifier
  'UndefinedValue'; did you mean 'UndefinedValue'?
sp->init(comp, this->asObjectPtr(), offset++, UndefinedValue());
  ^~
  UndefinedValue
../../../js/src/jsapi.h:639:1: note: 'UndefinedValue' declared here
UndefinedValue()
^
In file included from 
/tmp/obj/usr/ports/www/firefox/work/mozilla-release/js/src/jsanalyze.cpp:14:
In file included from ../../../js/src/jsinferinlines.h:21:
In file included from ../../../js/src/vm/Stack-inl.h:19:
In file included from ../../../js/src/jsscriptinlines.h:21:
In file included from ../../../js/src/jsscopeinlines.h:26:
In file included from ../../../js/src/jscntxtinlines.h:15:
In file included from ../../../js/src/jsprobes.h:23:
../../../js/src/vm/ObjectImpl-inl.h:217:55: error: use of undeclared identifier
  'UndefinedValue'; did you mean 'UndefinedValue'?
sp->init(comp, this->asObjectPtr(), offset++, UndefinedValue());
  ^~
  UndefinedValue
../../../js/src/jsapi.h:639:1: note: 'UndefinedValue' declared here
UndefinedValue()
^
2 errors generated.
gmake[3]: *** [jsanalyze.o] Error 1
gmake[3]: Leaving directory 
`/tmp/obj/usr/ports/www/firefox/work/mozilla-release/obj-x86_64-portbld-freebsd10.0/js/src'
gmake[2]: *** [libs_tier_js] Error 2
gmake[2]: Leaving directory 
`/tmp/obj/usr/ports/www/firefox/work/mozilla-release/obj-x86_64-portbld-freebsd10.0'
gmake[1]: *** [tier_js] Error 2
gmake[1]: Leaving directory 
`/tmp/obj/usr/ports/www/firefox/work/mozilla-release/obj-x86_64-portbld-freebsd10.0'
gmake: *** [default] Error 2
*** [do-build] Error code 1

Stop in /usr/ports/www/firefox.
test:/usr/ports/www/firefox[536]$ clang -v
FreeBSD clang version 3.3 (trunk 178860) 20130405
Target: x86_64-unknown-freebsd10.0
Thread model: posix

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"