Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-06-29 Thread Steven Hartland

Yep after applying the latest patch + making sure the rename
is done I don't have any outstanding issues with the port.

   Regards
   Steve

- Original Message - 
From: "David Keller" 

To: "Steven Hartland" 
Cc: "FreeBSD Ports" ; "Scot Hetzel" ; "Sergey A. 
Osokin" 
Sent: Sunday, June 29, 2014 4:02 PM
Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2



Hi,

This should correct the symlink creation error.

Regards,

David

On Wed, Apr 16, 2014 at 5:01 PM, Steven Hartland
 wrote:

Good catch on the WITH_APACHEPORT, thats old pre new options hang over,
switched to a straight else, as one or the other must be selected.

Looks like the svn diff didnt show the move, if you run the following:
svn mv files/pkg-message.in files/pkg-message-apache.in
before applying the attached patch with the WITH_APACHEPORT fix you
should be good.


   Regards
   Steve
- Original Message - From: "Sergey A. Osokin" 
To: "Steven Hartland" 
Cc: "FreeBSD Ports" ; "Scot Hetzel" ;
"David Keller" 
Sent: Wednesday, April 16, 2014 10:03 AM

Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2



Hi Steven,

unfortunately your version is different, especially this part of the code:

SUB_LIST+= GEM_LIB_DIR=${GEM_LIB_DIR} RUBY=${RUBY}
-SUB_FILES= pkg-message
+.if ${PORT_OPTIONS:MNGINX}
+SUB_FILES+=pkg-message-nginx
+PKGMESSAGE=pkg-message-nginx
+.elif defined(WITH_APACHEPORT)
+SUB_FILES+=pkg-message-apache
+PKGMESSAGE=pkg-message-apache
+.endif

Please explain what's the WITH_APACHEPORT knob, also, what's the
pkg-message-apache file, missing from your original patch.

And anyway.  On the staging phase I have following error:

===>  Staging for rubygem-passenger-4.0.41_3
===>   rubygem-passenger-4.0.41_3 depends on package:
rubygem-fastthread>=1.0.7 - found
===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-rack>=1.4.5
- found
===>   rubygem-passenger-4.0.41_3 depends on package:
rubygem-daemon_controller>=1.2.0 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/gem19 -
found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/ruby19 -
found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/sbin/apxs -
found
===>   Generating temporary packing list
Building native extensions.  This could take a while...
Successfully installed passenger-4.0.41
1 gem installed
Installing RDoc documentation for passenger-4.0.41...
(CC=clang CXX=clang++
/usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module
--auto)
/usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:247:in
`to_specs': Could not find passenger (>= 0) amongst
[daemon_controller-1.2.0, fastthread-1.0.7, rack-1.4.5, rake-10.2.2]
(Gem::LoadError)
   from
/usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:256:in `to_spec'
   from /usr/local/lib/ruby/site_ruby/1.9/rubygems.rb:1231:in `gem'
   from
/usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module:22:in
`'
*** Error code 1

Any idea?

--
Sergey A. Osokin
o...@freebsd.org.

On Tue, Apr 15, 2014 at 12:59:14AM +0100, Steven Hartland wrote:


Hi Sergey, could you clarify which parts you believe are features?

I know there are a number of changes but all of them I'd class as fixes
and not really features.

For reference here's a description of the changes:-

* Added missing license
* Display the correct install message for both nginx and apache
* Fix staging build of nginx, apache and link components
* Ensure download_cache is included in the package which prevents warning
 on removal due to failure to delete directory.
* Updated LIB_DEPENDS to latest recommended format

Just to be sure we're both talking about the same changes I've attached
the latest version for reference.

   Regards
   Steve
- Original Message ----- From: "Sergey A. Osokin" 
To: "Steven Hartland" 
Cc: "FreeBSD Ports" ; "Scot Hetzel"
; "David Keller" 
Sent: Tuesday, April 15, 2014 12:00 AM
Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2


>Hi Steven,
>
>unfortunately, your patch is wrong and this is why I can't commit your
> changes.
>
>What's wrong in your patch?  You have mixed features and bugfixes in one
> patch.
>Please provide bugfix only patch.
>
>-- >ozz
>
>On Sun, Apr 13, 2014 at 12:28:41PM +0100, Steven Hartland wrote:
>>- Original Message - From: "David Keller"
>> 
>>
>>
>>>Hi Sergey,
>>>
>>>It's not related to gem dependency error but the symlink creation
>>>might be incorrect:
>>>${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
>>>
>>

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-06-29 Thread David Keller
Hi,

This should correct the symlink creation error.

Regards,

David

On Wed, Apr 16, 2014 at 5:01 PM, Steven Hartland
 wrote:
> Good catch on the WITH_APACHEPORT, thats old pre new options hang over,
> switched to a straight else, as one or the other must be selected.
>
> Looks like the svn diff didnt show the move, if you run the following:
> svn mv files/pkg-message.in files/pkg-message-apache.in
> before applying the attached patch with the WITH_APACHEPORT fix you
> should be good.
>
>
>Regards
>Steve
> - Original Message - From: "Sergey A. Osokin" 
> To: "Steven Hartland" 
> Cc: "FreeBSD Ports" ; "Scot Hetzel" ;
> "David Keller" 
> Sent: Wednesday, April 16, 2014 10:03 AM
>
> Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2
>
>
>> Hi Steven,
>>
>> unfortunately your version is different, especially this part of the code:
>>
>> SUB_LIST+= GEM_LIB_DIR=${GEM_LIB_DIR} RUBY=${RUBY}
>> -SUB_FILES= pkg-message
>> +.if ${PORT_OPTIONS:MNGINX}
>> +SUB_FILES+=pkg-message-nginx
>> +PKGMESSAGE=pkg-message-nginx
>> +.elif defined(WITH_APACHEPORT)
>> +SUB_FILES+=pkg-message-apache
>> +PKGMESSAGE=pkg-message-apache
>> +.endif
>>
>> Please explain what's the WITH_APACHEPORT knob, also, what's the
>> pkg-message-apache file, missing from your original patch.
>>
>> And anyway.  On the staging phase I have following error:
>>
>> ===>  Staging for rubygem-passenger-4.0.41_3
>> ===>   rubygem-passenger-4.0.41_3 depends on package:
>> rubygem-fastthread>=1.0.7 - found
>> ===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-rack>=1.4.5
>> - found
>> ===>   rubygem-passenger-4.0.41_3 depends on package:
>> rubygem-daemon_controller>=1.2.0 - found
>> ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/gem19 -
>> found
>> ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/ruby19 -
>> found
>> ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/sbin/apxs -
>> found
>> ===>   Generating temporary packing list
>> Building native extensions.  This could take a while...
>> Successfully installed passenger-4.0.41
>> 1 gem installed
>> Installing RDoc documentation for passenger-4.0.41...
>> (CC=clang CXX=clang++
>> /usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module
>> --auto)
>> /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:247:in
>> `to_specs': Could not find passenger (>= 0) amongst
>> [daemon_controller-1.2.0, fastthread-1.0.7, rack-1.4.5, rake-10.2.2]
>> (Gem::LoadError)
>>from
>> /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:256:in `to_spec'
>>from /usr/local/lib/ruby/site_ruby/1.9/rubygems.rb:1231:in `gem'
>>from
>> /usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module:22:in
>> `'
>> *** Error code 1
>>
>> Any idea?
>>
>> --
>> Sergey A. Osokin
>> o...@freebsd.org.
>>
>> On Tue, Apr 15, 2014 at 12:59:14AM +0100, Steven Hartland wrote:
>>>
>>> Hi Sergey, could you clarify which parts you believe are features?
>>>
>>> I know there are a number of changes but all of them I'd class as fixes
>>> and not really features.
>>>
>>> For reference here's a description of the changes:-
>>>
>>> * Added missing license
>>> * Display the correct install message for both nginx and apache
>>> * Fix staging build of nginx, apache and link components
>>> * Ensure download_cache is included in the package which prevents warning
>>>  on removal due to failure to delete directory.
>>> * Updated LIB_DEPENDS to latest recommended format
>>>
>>> Just to be sure we're both talking about the same changes I've attached
>>> the latest version for reference.
>>>
>>>Regards
>>>Steve
>>> - Original Message - From: "Sergey A. Osokin" 
>>> To: "Steven Hartland" 
>>> Cc: "FreeBSD Ports" ; "Scot Hetzel"
>>> ; "David Keller" 
>>> Sent: Tuesday, April 15, 2014 12:00 AM
>>> Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2
>>>
>>>
>>> >Hi Steven,
>>> >
>>> >unfortunately, your patch is wrong and this is why I can't commit your
>&g

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-16 Thread Steven Hartland

Good catch on the WITH_APACHEPORT, thats old pre new options hang over,
switched to a straight else, as one or the other must be selected.

Looks like the svn diff didnt show the move, if you run the following:
svn mv files/pkg-message.in files/pkg-message-apache.in
before applying the attached patch with the WITH_APACHEPORT fix you
should be good.

   Regards
   Steve
- Original Message - 
From: "Sergey A. Osokin" 

To: "Steven Hartland" 
Cc: "FreeBSD Ports" ; "Scot Hetzel" ; "David 
Keller" 
Sent: Wednesday, April 16, 2014 10:03 AM
Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2



Hi Steven,

unfortunately your version is different, especially this part of the code:

SUB_LIST+= GEM_LIB_DIR=${GEM_LIB_DIR} RUBY=${RUBY}
-SUB_FILES= pkg-message
+.if ${PORT_OPTIONS:MNGINX}
+SUB_FILES+=pkg-message-nginx
+PKGMESSAGE=pkg-message-nginx
+.elif defined(WITH_APACHEPORT)
+SUB_FILES+=pkg-message-apache
+PKGMESSAGE=pkg-message-apache
+.endif

Please explain what's the WITH_APACHEPORT knob, also, what's the
pkg-message-apache file, missing from your original patch.

And anyway.  On the staging phase I have following error:

===>  Staging for rubygem-passenger-4.0.41_3
===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-fastthread>=1.0.7 
- found
===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-rack>=1.4.5 - 
found
===>   rubygem-passenger-4.0.41_3 depends on package: 
rubygem-daemon_controller>=1.2.0 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/gem19 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/ruby19 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/sbin/apxs - found
===>   Generating temporary packing list
Building native extensions.  This could take a while...
Successfully installed passenger-4.0.41
1 gem installed
Installing RDoc documentation for passenger-4.0.41...
(CC=clang CXX=clang++ 
/usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module --auto)
/usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:247:in `to_specs': Could not find passenger (>= 0) amongst 
[daemon_controller-1.2.0, fastthread-1.0.7, rack-1.4.5, rake-10.2.2] (Gem::LoadError)

   from /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:256:in 
`to_spec'
   from /usr/local/lib/ruby/site_ruby/1.9/rubygems.rb:1231:in `gem'
   from 
/usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module:22:in
 `'
*** Error code 1

Any idea?

--
Sergey A. Osokin
o...@freebsd.org.

On Tue, Apr 15, 2014 at 12:59:14AM +0100, Steven Hartland wrote:

Hi Sergey, could you clarify which parts you believe are features?

I know there are a number of changes but all of them I'd class as fixes
and not really features.

For reference here's a description of the changes:-

* Added missing license
* Display the correct install message for both nginx and apache
* Fix staging build of nginx, apache and link components
* Ensure download_cache is included in the package which prevents warning
 on removal due to failure to delete directory.
* Updated LIB_DEPENDS to latest recommended format

Just to be sure we're both talking about the same changes I've attached
the latest version for reference.

   Regards
   Steve
- Original Message - From: "Sergey A. Osokin" 
To: "Steven Hartland" 
Cc: "FreeBSD Ports" ; "Scot Hetzel" ; "David 
Keller" 
Sent: Tuesday, April 15, 2014 12:00 AM
Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2


>Hi Steven,
>
>unfortunately, your patch is wrong and this is why I can't commit your changes.
>
>What's wrong in your patch?  You have mixed features and bugfixes in one patch.
>Please provide bugfix only patch.
>
>-- 
>ozz

>
>On Sun, Apr 13, 2014 at 12:28:41PM +0100, Steven Hartland wrote:
>>- Original Message - From: "David Keller" 
>>
>>
>>>Hi Sergey,
>>>
>>>It's not related to gem dependency error but the symlink creation
>>>might be incorrect:
>>>${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
>>>
>>>Will create the following symlink:
>>>/usr/local/lib/ruby/gems/1.9/gems/passenger ->
>>>lib/ruby/gems/1.9/gems/passenger-4.0.41
>>>
>>>Rather than:
>>>/usr/local/lib/ruby/gems/1.9/gems/passenger ->
>>>/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41
>>>
>>>Or:
>>>/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
>>>
>>>
>>>You might prefer using:
>>>${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
>>

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-16 Thread Sergey A. Osokin
Hi Steven,

unfortunately your version is different, especially this part of the code:

 SUB_LIST+= GEM_LIB_DIR=${GEM_LIB_DIR} RUBY=${RUBY}
-SUB_FILES= pkg-message
+.if ${PORT_OPTIONS:MNGINX}
+SUB_FILES+=pkg-message-nginx
+PKGMESSAGE=pkg-message-nginx
+.elif defined(WITH_APACHEPORT)
+SUB_FILES+=pkg-message-apache
+PKGMESSAGE=pkg-message-apache
+.endif

Please explain what's the WITH_APACHEPORT knob, also, what's the
pkg-message-apache file, missing from your original patch.

And anyway.  On the staging phase I have following error:

===>  Staging for rubygem-passenger-4.0.41_3
===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-fastthread>=1.0.7 
- found
===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-rack>=1.4.5 - 
found
===>   rubygem-passenger-4.0.41_3 depends on package: 
rubygem-daemon_controller>=1.2.0 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/gem19 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/ruby19 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/sbin/apxs - found
===>   Generating temporary packing list
Building native extensions.  This could take a while...
Successfully installed passenger-4.0.41
1 gem installed
Installing RDoc documentation for passenger-4.0.41...
(CC=clang CXX=clang++ 
/usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module
 --auto)
/usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:247:in `to_specs': 
Could not find passenger (>= 0) amongst [daemon_controller-1.2.0, 
fastthread-1.0.7, rack-1.4.5, rake-10.2.2] (Gem::LoadError)
from /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:256:in 
`to_spec'
from /usr/local/lib/ruby/site_ruby/1.9/rubygems.rb:1231:in `gem'
from 
/usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module:22:in
 `'
*** Error code 1

Any idea?

-- 
Sergey A. Osokin
o...@freebsd.org.

On Tue, Apr 15, 2014 at 12:59:14AM +0100, Steven Hartland wrote:
> Hi Sergey, could you clarify which parts you believe are features?
> 
> I know there are a number of changes but all of them I'd class as fixes
> and not really features.
> 
> For reference here's a description of the changes:-
> 
> * Added missing license
> * Display the correct install message for both nginx and apache
> * Fix staging build of nginx, apache and link components
> * Ensure download_cache is included in the package which prevents warning
>  on removal due to failure to delete directory.
> * Updated LIB_DEPENDS to latest recommended format
> 
> Just to be sure we're both talking about the same changes I've attached
> the latest version for reference.
> 
>Regards
>Steve
> - Original Message - From: "Sergey A. Osokin" 
> To: "Steven Hartland" 
> Cc: "FreeBSD Ports" ; "Scot Hetzel" ; 
> "David Keller" 
> Sent: Tuesday, April 15, 2014 12:00 AM
> Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2
> 
> 
> >Hi Steven,
> >
> >unfortunately, your patch is wrong and this is why I can't commit your 
> >changes.
> >
> >What's wrong in your patch?  You have mixed features and bugfixes in one 
> >patch.
> >Please provide bugfix only patch.
> >
> >-- 
> >ozz
> >
> >On Sun, Apr 13, 2014 at 12:28:41PM +0100, Steven Hartland wrote:
> >>- Original Message - From: "David Keller" 
> >>
> >>
> >>>Hi Sergey,
> >>>
> >>>It's not related to gem dependency error but the symlink creation
> >>>might be incorrect:
> >>>${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> >>>
> >>>Will create the following symlink:
> >>>/usr/local/lib/ruby/gems/1.9/gems/passenger ->
> >>>lib/ruby/gems/1.9/gems/passenger-4.0.41
> >>>
> >>>Rather than:
> >>>/usr/local/lib/ruby/gems/1.9/gems/passenger ->
> >>>/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41
> >>>
> >>>Or:
> >>>/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
> >>>
> >>>
> >>>You might prefer using:
> >>>${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
> >>>${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> >>>
> >>>Or even:
> >>>${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> >>
> >>My current version has:
> >>(cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s ${GEM_NAME} ${PORTNAME}

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-15 Thread David Keller
Hello Sergey,

Steven's patch already contains the symlink bugfix :-)

Regards,

David

On Tue, Apr 15, 2014 at 12:57 AM, Sergey A. Osokin  wrote:
> Hi David,
>
> kindly provide a patch.
>
> --
> ozz
>
> On Sun, Apr 13, 2014 at 12:23:56PM +0200, David Keller wrote:
>> Hi Sergey,
>>
>> It's not related to gem dependency error but the symlink creation
>> might be incorrect:
>> ${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
>>
>> Will create the following symlink:
>> /usr/local/lib/ruby/gems/1.9/gems/passenger ->
>> lib/ruby/gems/1.9/gems/passenger-4.0.41
>>
>> Rather than:
>> /usr/local/lib/ruby/gems/1.9/gems/passenger ->
>> /usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41
>>
>> Or:
>> /usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
>>
>>
>> You might prefer using:
>> ${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
>> ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
>>
>> Or even:
>> ${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
>>
>> David
>>
>> On Sun, Apr 13, 2014 at 4:13 AM, Sergey A. Osokin  wrote:
>> > On Sat, Apr 12, 2014 at 03:09:04AM -0500, Scot Hetzel wrote:
>> >> On Fri, Apr 11, 2014 at 5:51 PM, Steven Hartland
>> >>  wrote:
>> >> > The change is from :N -> :M
>> >> > .if ${PORT_OPTIONS:MDEBUG}
>> >> >
>> >>  - Select only those words that match DEBUG
>> >>
>> >> > Which occurs 220 in the port tree and:
>> >> >
>> >> > .if ${PORT_OPTIONS:NDEBUG}
>> >> >
>> >> - Select words that don't match DEBUG
>> >>
>> >> > Which only occurs twice, so TBH I assumed it was a typo given every 
>> >> > other
>> >> > option uses PORTOPTIONS:M${option}
>> >> >
>> >> > Unfortunately the docs don't seem to provide any clarification
>> >> > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
>> >> > so if anyone could chime in with some details on the exact meanings that
>> >> > would be most appreciated.
>> >> >
>> >> You have to read the make(1) man page:
>> >>
>> >> http://www.freebsd.org/cgi/man.cgi?query=make&sektion=1
>> >
>> > So, the patch is here.
>> >
>> > But now I've got following error:
>> >
>> > x1% sudo make install
>> > ===>  Staging for rubygem-passenger-4.0.41_3
>> > ===>   rubygem-passenger-4.0.41_3 depends on package: 
>> > rubygem-fastthread>=1.0.7 - found
>> > ===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-rack>=1.4.5 
>> > - found
>> > ===>   rubygem-passenger-4.0.41_3 depends on package: 
>> > rubygem-daemon_controller>=1.2.0 - found
>> > ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/gem19 - 
>> > found
>> > ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/ruby19 - 
>> > found
>> > ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/sbin/apxs - 
>> > found
>> > ===>   rubygem-passenger-4.0.41_3 depends on shared library: libeio.so - 
>> > found
>> > ===>   rubygem-passenger-4.0.41_3 depends on shared library: libev.so - 
>> > found
>> > ===>   rubygem-passenger-4.0.41_3 depends on shared library: libcurl.so - 
>> > found
>> > ===>   Generating temporary packing list
>> > Building native extensions.  This could take a while...
>> > Successfully installed passenger-4.0.41
>> > 1 gem installed
>> > Installing RDoc documentation for passenger-4.0.41...
>> > (CC=clang CXX=clang++ 
>> > /usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module
>> >  --auto)
>> > /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:247:in 
>> > `to_specs': Could not find passenger (>= 0) amongst 
>> > [daemon_controller-1.2.0, fastthread-1.0.7, rack-1.4.5, rake-10.2.2] 
>> > (Gem::LoadError)
>> > from 
>> > /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:256:in `to_spec'
>> > from /usr/local/lib/ruby/site_ruby/1.9/rubygems.rb:1231:in `gem'
>> > from 
>> > /usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module:22:in
>> >  `'
>> > *** Error code 1
>> >
>> > Stop.
>> >
>> > Any idea what's wrong here?
>> >
>> > Index: Makefile
>> > ===
>> > --- Makefile(revision 351090)
>> > +++ Makefile(working copy)
>> > @@ -3,7 +3,7 @@
>> >
>> >  PORTNAME=  passenger
>> >  PORTVERSION=   4.0.41
>> > -PORTREVISION=  2
>> > +PORTREVISION=  3
>> >  CATEGORIES=www rubygems
>> >  MASTER_SITES=  RG
>> >  PKGNAMEPREFIX= rubygem-
>> > @@ -39,11 +39,11 @@
>> >  .endif
>> >  .endif
>> >
>> > -LIB_DEPENDS+=  eio:${PORTSDIR}/devel/libeio \
>> > -   ev:${PORTSDIR}/devel/libev \
>> > -   curl:${PORTSDIR}/ftp/curl
>> > -BUILD_DEPENDS+=
>> > rubygem-fastthread>=1.0.1:${PORTSDIR}/devel/rubygem-fastthread \
>> > -   rubygem-rack>=0:${PORTSDIR}/www/rubygem-rack \
>> > +LIB_DEPENDS+=  libeio.so:${PORTSDIR}/devel/libeio \
>> > +   libev.so:${PORTSDIR}/devel/libev \
>> > +   libcurl.so:${PORTSDIR}/ftp/curl
>> > +BUILD_DEPENDS+=
>> > rubyg

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-14 Thread Steven Hartland

Hi Sergey, could you clarify which parts you believe are features?

I know there are a number of changes but all of them I'd class as fixes
and not really features.

For reference here's a description of the changes:-

* Added missing license
* Display the correct install message for both nginx and apache
* Fix staging build of nginx, apache and link components
* Ensure download_cache is included in the package which prevents warning
 on removal due to failure to delete directory.
* Updated LIB_DEPENDS to latest recommended format

Just to be sure we're both talking about the same changes I've attached
the latest version for reference.

   Regards
   Steve
- Original Message - 
From: "Sergey A. Osokin" 

To: "Steven Hartland" 
Cc: "FreeBSD Ports" ; "Scot Hetzel" ; "David 
Keller" 
Sent: Tuesday, April 15, 2014 12:00 AM
Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2



Hi Steven,

unfortunately, your patch is wrong and this is why I can't commit your changes.

What's wrong in your patch?  You have mixed features and bugfixes in one patch.
Please provide bugfix only patch.

--
ozz

On Sun, Apr 13, 2014 at 12:28:41PM +0100, Steven Hartland wrote:

- Original Message - From: "David Keller" 


>Hi Sergey,
>
>It's not related to gem dependency error but the symlink creation
>might be incorrect:
>${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
>
>Will create the following symlink:
>/usr/local/lib/ruby/gems/1.9/gems/passenger ->
>lib/ruby/gems/1.9/gems/passenger-4.0.41
>
>Rather than:
>/usr/local/lib/ruby/gems/1.9/gems/passenger ->
>/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41
>
>Or:
>/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
>
>
>You might prefer using:
>${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
>${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
>
>Or even:
>${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}

My current version has:
(cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s ${GEM_NAME} ${PORTNAME})

Which I will create:
/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41

@Sergey: For your apache module problem try the attached patch / full
version which fixes that for me.

I'd previously only ever built the nginx version and looks like the
apache2 module build was broken when stage support was added.

I've confirmed it builds but I don't have an apache2 install to test
fully with here so if you could let me know if it works and I'll get all
the changes checked in.

   Regards
   Steve




___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


rubygem-passenger.patch
Description: Binary data
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-14 Thread Sergey A. Osokin
Hi Steven,

unfortunately, your patch is wrong and this is why I can't commit your changes.

What's wrong in your patch?  You have mixed features and bugfixes in one patch.
Please provide bugfix only patch.

-- 
ozz

On Sun, Apr 13, 2014 at 12:28:41PM +0100, Steven Hartland wrote:
> - Original Message - From: "David Keller" 
> 
> 
> >Hi Sergey,
> >
> >It's not related to gem dependency error but the symlink creation
> >might be incorrect:
> >${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> >
> >Will create the following symlink:
> >/usr/local/lib/ruby/gems/1.9/gems/passenger ->
> >lib/ruby/gems/1.9/gems/passenger-4.0.41
> >
> >Rather than:
> >/usr/local/lib/ruby/gems/1.9/gems/passenger ->
> >/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41
> >
> >Or:
> >/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
> >
> >
> >You might prefer using:
> >${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
> >${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> >
> >Or even:
> >${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> 
> My current version has:
> (cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s ${GEM_NAME} ${PORTNAME})
> 
> Which I will create:
> /usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
> 
> @Sergey: For your apache module problem try the attached patch / full
> version which fixes that for me.
> 
> I'd previously only ever built the nginx version and looks like the
> apache2 module build was broken when stage support was added.
> 
> I've confirmed it builds but I don't have an apache2 install to test
> fully with here so if you could let me know if it works and I'll get all
> the changes checked in.
> 
>Regards
>Steve



___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-14 Thread Sergey A. Osokin
Hi David,

kindly provide a patch.

-- 
ozz

On Sun, Apr 13, 2014 at 12:23:56PM +0200, David Keller wrote:
> Hi Sergey,
> 
> It's not related to gem dependency error but the symlink creation
> might be incorrect:
> ${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> 
> Will create the following symlink:
> /usr/local/lib/ruby/gems/1.9/gems/passenger ->
> lib/ruby/gems/1.9/gems/passenger-4.0.41
> 
> Rather than:
> /usr/local/lib/ruby/gems/1.9/gems/passenger ->
> /usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41
> 
> Or:
> /usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41
> 
> 
> You might prefer using:
> ${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
> ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> 
> Or even:
> ${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
> 
> David
> 
> On Sun, Apr 13, 2014 at 4:13 AM, Sergey A. Osokin  wrote:
> > On Sat, Apr 12, 2014 at 03:09:04AM -0500, Scot Hetzel wrote:
> >> On Fri, Apr 11, 2014 at 5:51 PM, Steven Hartland
> >>  wrote:
> >> > The change is from :N -> :M
> >> > .if ${PORT_OPTIONS:MDEBUG}
> >> >
> >>  - Select only those words that match DEBUG
> >>
> >> > Which occurs 220 in the port tree and:
> >> >
> >> > .if ${PORT_OPTIONS:NDEBUG}
> >> >
> >> - Select words that don't match DEBUG
> >>
> >> > Which only occurs twice, so TBH I assumed it was a typo given every other
> >> > option uses PORTOPTIONS:M${option}
> >> >
> >> > Unfortunately the docs don't seem to provide any clarification
> >> > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
> >> > so if anyone could chime in with some details on the exact meanings that
> >> > would be most appreciated.
> >> >
> >> You have to read the make(1) man page:
> >>
> >> http://www.freebsd.org/cgi/man.cgi?query=make&sektion=1
> >
> > So, the patch is here.
> >
> > But now I've got following error:
> >
> > x1% sudo make install
> > ===>  Staging for rubygem-passenger-4.0.41_3
> > ===>   rubygem-passenger-4.0.41_3 depends on package: 
> > rubygem-fastthread>=1.0.7 - found
> > ===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-rack>=1.4.5 - 
> > found
> > ===>   rubygem-passenger-4.0.41_3 depends on package: 
> > rubygem-daemon_controller>=1.2.0 - found
> > ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/gem19 - 
> > found
> > ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/ruby19 - 
> > found
> > ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/sbin/apxs - 
> > found
> > ===>   rubygem-passenger-4.0.41_3 depends on shared library: libeio.so - 
> > found
> > ===>   rubygem-passenger-4.0.41_3 depends on shared library: libev.so - 
> > found
> > ===>   rubygem-passenger-4.0.41_3 depends on shared library: libcurl.so - 
> > found
> > ===>   Generating temporary packing list
> > Building native extensions.  This could take a while...
> > Successfully installed passenger-4.0.41
> > 1 gem installed
> > Installing RDoc documentation for passenger-4.0.41...
> > (CC=clang CXX=clang++ 
> > /usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module
> >  --auto)
> > /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:247:in `to_specs': 
> > Could not find passenger (>= 0) amongst [daemon_controller-1.2.0, 
> > fastthread-1.0.7, rack-1.4.5, rake-10.2.2] (Gem::LoadError)
> > from 
> > /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:256:in `to_spec'
> > from /usr/local/lib/ruby/site_ruby/1.9/rubygems.rb:1231:in `gem'
> > from 
> > /usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module:22:in
> >  `'
> > *** Error code 1
> >
> > Stop.
> >
> > Any idea what's wrong here?
> >
> > Index: Makefile
> > ===
> > --- Makefile(revision 351090)
> > +++ Makefile(working copy)
> > @@ -3,7 +3,7 @@
> >
> >  PORTNAME=  passenger
> >  PORTVERSION=   4.0.41
> > -PORTREVISION=  2
> > +PORTREVISION=  3
> >  CATEGORIES=www rubygems
> >  MASTER_SITES=  RG
> >  PKGNAMEPREFIX= rubygem-
> > @@ -39,11 +39,11 @@
> >  .endif
> >  .endif
> >
> > -LIB_DEPENDS+=  eio:${PORTSDIR}/devel/libeio \
> > -   ev:${PORTSDIR}/devel/libev \
> > -   curl:${PORTSDIR}/ftp/curl
> > -BUILD_DEPENDS+=
> > rubygem-fastthread>=1.0.1:${PORTSDIR}/devel/rubygem-fastthread \
> > -   rubygem-rack>=0:${PORTSDIR}/www/rubygem-rack \
> > +LIB_DEPENDS+=  libeio.so:${PORTSDIR}/devel/libeio \
> > +   libev.so:${PORTSDIR}/devel/libev \
> > +   libcurl.so:${PORTSDIR}/ftp/curl
> > +BUILD_DEPENDS+=
> > rubygem-fastthread>=1.0.7:${PORTSDIR}/devel/rubygem-fastthread \
> > +   rubygem-rack>=1.4.5:${PORTSDIR}/www/rubygem-rack \
> > 
> > rubygem-daemon_controller>=1.2.0:${PORTSDIR}/devel/rubygem-daemon_controller
> >  RUN_DEPENDS:=  ${BUILD_DEPENDS}
> >
> > @@ -81,7 +81,7 @

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-13 Thread Steven Hartland
- Original Message - 
From: "David Keller" 




Hi Sergey,

It's not related to gem dependency error but the symlink creation
might be incorrect:
${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}

Will create the following symlink:
/usr/local/lib/ruby/gems/1.9/gems/passenger ->
lib/ruby/gems/1.9/gems/passenger-4.0.41

Rather than:
/usr/local/lib/ruby/gems/1.9/gems/passenger ->
/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41

Or:
/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41


You might prefer using:
${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}

Or even:
${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}


My current version has:
(cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s ${GEM_NAME} ${PORTNAME})

Which I will create:
/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41

@Sergey: For your apache module problem try the attached patch / full
version which fixes that for me.

I'd previously only ever built the nginx version and looks like the
apache2 module build was broken when stage support was added.

I've confirmed it builds but I don't have an apache2 install to test
fully with here so if you could let me know if it works and I'll get all
the changes checked in.

   Regards
   Steve

Makefile
Description: Binary data


Makefile.patch
Description: Binary data
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-13 Thread David Keller
Hi Sergey,

It's not related to gem dependency error but the symlink creation
might be incorrect:
${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}

Will create the following symlink:
/usr/local/lib/ruby/gems/1.9/gems/passenger ->
lib/ruby/gems/1.9/gems/passenger-4.0.41

Rather than:
/usr/local/lib/ruby/gems/1.9/gems/passenger ->
/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41

Or:
/usr/local/lib/ruby/gems/1.9/gems/passenger -> passenger-4.0.41


You might prefer using:
${LN} -s ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME}
${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}

Or even:
${LN} -s ${GEM_NAME} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}

David

On Sun, Apr 13, 2014 at 4:13 AM, Sergey A. Osokin  wrote:
> On Sat, Apr 12, 2014 at 03:09:04AM -0500, Scot Hetzel wrote:
>> On Fri, Apr 11, 2014 at 5:51 PM, Steven Hartland
>>  wrote:
>> > The change is from :N -> :M
>> > .if ${PORT_OPTIONS:MDEBUG}
>> >
>>  - Select only those words that match DEBUG
>>
>> > Which occurs 220 in the port tree and:
>> >
>> > .if ${PORT_OPTIONS:NDEBUG}
>> >
>> - Select words that don't match DEBUG
>>
>> > Which only occurs twice, so TBH I assumed it was a typo given every other
>> > option uses PORTOPTIONS:M${option}
>> >
>> > Unfortunately the docs don't seem to provide any clarification
>> > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
>> > so if anyone could chime in with some details on the exact meanings that
>> > would be most appreciated.
>> >
>> You have to read the make(1) man page:
>>
>> http://www.freebsd.org/cgi/man.cgi?query=make&sektion=1
>
> So, the patch is here.
>
> But now I've got following error:
>
> x1% sudo make install
> ===>  Staging for rubygem-passenger-4.0.41_3
> ===>   rubygem-passenger-4.0.41_3 depends on package: 
> rubygem-fastthread>=1.0.7 - found
> ===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-rack>=1.4.5 - 
> found
> ===>   rubygem-passenger-4.0.41_3 depends on package: 
> rubygem-daemon_controller>=1.2.0 - found
> ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/gem19 - 
> found
> ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/ruby19 - 
> found
> ===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/sbin/apxs - 
> found
> ===>   rubygem-passenger-4.0.41_3 depends on shared library: libeio.so - found
> ===>   rubygem-passenger-4.0.41_3 depends on shared library: libev.so - found
> ===>   rubygem-passenger-4.0.41_3 depends on shared library: libcurl.so - 
> found
> ===>   Generating temporary packing list
> Building native extensions.  This could take a while...
> Successfully installed passenger-4.0.41
> 1 gem installed
> Installing RDoc documentation for passenger-4.0.41...
> (CC=clang CXX=clang++ 
> /usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module
>  --auto)
> /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:247:in `to_specs': 
> Could not find passenger (>= 0) amongst [daemon_controller-1.2.0, 
> fastthread-1.0.7, rack-1.4.5, rake-10.2.2] (Gem::LoadError)
> from /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:256:in 
> `to_spec'
> from /usr/local/lib/ruby/site_ruby/1.9/rubygems.rb:1231:in `gem'
> from 
> /usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module:22:in
>  `'
> *** Error code 1
>
> Stop.
>
> Any idea what's wrong here?
>
> Index: Makefile
> ===
> --- Makefile(revision 351090)
> +++ Makefile(working copy)
> @@ -3,7 +3,7 @@
>
>  PORTNAME=  passenger
>  PORTVERSION=   4.0.41
> -PORTREVISION=  2
> +PORTREVISION=  3
>  CATEGORIES=www rubygems
>  MASTER_SITES=  RG
>  PKGNAMEPREFIX= rubygem-
> @@ -39,11 +39,11 @@
>  .endif
>  .endif
>
> -LIB_DEPENDS+=  eio:${PORTSDIR}/devel/libeio \
> -   ev:${PORTSDIR}/devel/libev \
> -   curl:${PORTSDIR}/ftp/curl
> -BUILD_DEPENDS+=
> rubygem-fastthread>=1.0.1:${PORTSDIR}/devel/rubygem-fastthread \
> -   rubygem-rack>=0:${PORTSDIR}/www/rubygem-rack \
> +LIB_DEPENDS+=  libeio.so:${PORTSDIR}/devel/libeio \
> +   libev.so:${PORTSDIR}/devel/libev \
> +   libcurl.so:${PORTSDIR}/ftp/curl
> +BUILD_DEPENDS+=
> rubygem-fastthread>=1.0.7:${PORTSDIR}/devel/rubygem-fastthread \
> +   rubygem-rack>=1.4.5:${PORTSDIR}/www/rubygem-rack \
> 
> rubygem-daemon_controller>=1.2.0:${PORTSDIR}/devel/rubygem-daemon_controller
>  RUN_DEPENDS:=  ${BUILD_DEPENDS}
>
> @@ -81,7 +81,7 @@
> s! -feliminate-unused-debug-symbols 
> -feliminate-unused-debug-types!!g; \
> 201,203s!true!false!' \
> ${WRKSRC}/build/basics.rb
> -.if ${PORT_OPTIONS:NDEBUG}
> +.if ${PORT_OPTIONS:MDEBUG}
> @${REINPLACE_CMD} \
> 's!-DPASSENGER_DEBUG!-DNDEBUG!g' \
> ${WRKSRC}/build/basics.rb
> @@ -101,19 +

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-12 Thread Sergey A. Osokin
On Sat, Apr 12, 2014 at 03:09:04AM -0500, Scot Hetzel wrote:
> On Fri, Apr 11, 2014 at 5:51 PM, Steven Hartland
>  wrote:
> > The change is from :N -> :M
> > .if ${PORT_OPTIONS:MDEBUG}
> >
>  - Select only those words that match DEBUG
> 
> > Which occurs 220 in the port tree and:
> >
> > .if ${PORT_OPTIONS:NDEBUG}
> >
> - Select words that don't match DEBUG
> 
> > Which only occurs twice, so TBH I assumed it was a typo given every other
> > option uses PORTOPTIONS:M${option}
> >
> > Unfortunately the docs don't seem to provide any clarification
> > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
> > so if anyone could chime in with some details on the exact meanings that
> > would be most appreciated.
> >
> You have to read the make(1) man page:
> 
> http://www.freebsd.org/cgi/man.cgi?query=make&sektion=1

So, the patch is here.

But now I've got following error:

x1% sudo make install
===>  Staging for rubygem-passenger-4.0.41_3
===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-fastthread>=1.0.7 
- found
===>   rubygem-passenger-4.0.41_3 depends on package: rubygem-rack>=1.4.5 - 
found
===>   rubygem-passenger-4.0.41_3 depends on package: 
rubygem-daemon_controller>=1.2.0 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/gem19 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/bin/ruby19 - found
===>   rubygem-passenger-4.0.41_3 depends on file: /usr/local/sbin/apxs - found
===>   rubygem-passenger-4.0.41_3 depends on shared library: libeio.so - found
===>   rubygem-passenger-4.0.41_3 depends on shared library: libev.so - found
===>   rubygem-passenger-4.0.41_3 depends on shared library: libcurl.so - found
===>   Generating temporary packing list
Building native extensions.  This could take a while...
Successfully installed passenger-4.0.41
1 gem installed
Installing RDoc documentation for passenger-4.0.41...
(CC=clang CXX=clang++ 
/usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module
 --auto)
/usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:247:in `to_specs': 
Could not find passenger (>= 0) amongst [daemon_controller-1.2.0, 
fastthread-1.0.7, rack-1.4.5, rake-10.2.2] (Gem::LoadError)
from /usr/local/lib/ruby/site_ruby/1.9/rubygems/dependency.rb:256:in 
`to_spec'
from /usr/local/lib/ruby/site_ruby/1.9/rubygems.rb:1231:in `gem'
from 
/usr/home/osa/ports/www/rubygem-passenger/work/stage/usr/local/bin/passenger-install-apache2-module:22:in
 `'
*** Error code 1

Stop.

Any idea what's wrong here?

Index: Makefile
===
--- Makefile(revision 351090)
+++ Makefile(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=  passenger
 PORTVERSION=   4.0.41
-PORTREVISION=  2
+PORTREVISION=  3
 CATEGORIES=www rubygems
 MASTER_SITES=  RG
 PKGNAMEPREFIX= rubygem-
@@ -39,11 +39,11 @@
 .endif
 .endif
 
-LIB_DEPENDS+=  eio:${PORTSDIR}/devel/libeio \
-   ev:${PORTSDIR}/devel/libev \
-   curl:${PORTSDIR}/ftp/curl
-BUILD_DEPENDS+=
rubygem-fastthread>=1.0.1:${PORTSDIR}/devel/rubygem-fastthread \
-   rubygem-rack>=0:${PORTSDIR}/www/rubygem-rack \
+LIB_DEPENDS+=  libeio.so:${PORTSDIR}/devel/libeio \
+   libev.so:${PORTSDIR}/devel/libev \
+   libcurl.so:${PORTSDIR}/ftp/curl
+BUILD_DEPENDS+=
rubygem-fastthread>=1.0.7:${PORTSDIR}/devel/rubygem-fastthread \
+   rubygem-rack>=1.4.5:${PORTSDIR}/www/rubygem-rack \

rubygem-daemon_controller>=1.2.0:${PORTSDIR}/devel/rubygem-daemon_controller
 RUN_DEPENDS:=  ${BUILD_DEPENDS}
 
@@ -81,7 +81,7 @@
s! -feliminate-unused-debug-symbols 
-feliminate-unused-debug-types!!g; \
201,203s!true!false!' \
${WRKSRC}/build/basics.rb
-.if ${PORT_OPTIONS:NDEBUG}
+.if ${PORT_OPTIONS:MDEBUG}
@${REINPLACE_CMD} \
's!-DPASSENGER_DEBUG!-DNDEBUG!g' \
${WRKSRC}/build/basics.rb
@@ -101,19 +101,23 @@
's!-lpthread!${PTHREAD_LIBS}!g' \
${WRKSRC}/lib/phusion_passenger/platform_info/cxx_portability.rb
 
-post-build:
+post-install:
 .if ${PORT_OPTIONS:MAPACHE22}
-   (CC=${CC} CXX=${CXX} ${WRKSRC}/bin/passenger-install-apache2-module 
--auto)
+   (CC=${CC} CXX=${CXX} 
${STAGEDIR}${PREFIX}/bin/passenger-install-apache2-module --auto)
 .endif
-
 .if ${PORT_OPTIONS:MNGINX}
-   (cd ${WRKSRC} && CC=${CC} CXX=${CXX} ${RAKE_BIN} nginx)
+   (cd ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${GEM_NAME} && CC=${CC} CXX=${CXX} 
${RAKE_BIN} nginx)
 .endif
 .if ${PORT_OPTIONS:MSYMLINK}
-   ${LN} -s ${GEM_LIB_DIR} ${STAGE}${PREFIX}/${GEMS_DIR}/${PORTNAME}
+   ${LN} -s ${GEM_LIB_DIR} ${STAGEDIR}${PREFIX}/${GEMS_DIR}/${PORTNAME}
 .endif
 
-   ${FIND} ${WRKSRC} -name '*.o' -delete
-   ${FIND} ${WRKSRC} -name '*.bak' -delete
+   ${FIND} ${STAGEDIR} -name '*.o' -delete
+  

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-12 Thread Scot Hetzel
On Fri, Apr 11, 2014 at 5:51 PM, Steven Hartland
 wrote:
> The change is from :N -> :M
> .if ${PORT_OPTIONS:MDEBUG}
>
 - Select only those words that match DEBUG

> Which occurs 220 in the port tree and:
>
> .if ${PORT_OPTIONS:NDEBUG}
>
- Select words that don't match DEBUG

> Which only occurs twice, so TBH I assumed it was a typo given every other
> option uses PORTOPTIONS:M${option}
>
> Unfortunately the docs don't seem to provide any clarification
> http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
> so if anyone could chime in with some details on the exact meanings that
> would be most appreciated.
>
You have to read the make(1) man page:

http://www.freebsd.org/cgi/man.cgi?query=make&sektion=1
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread Steven Hartland

The change is from :N -> :M
.if ${PORT_OPTIONS:MDEBUG}

Which occurs 220 in the port tree and:

.if ${PORT_OPTIONS:NDEBUG}

Which only occurs twice, so TBH I assumed it was a typo given every other
option uses PORTOPTIONS:M${option}

Unfortunately the docs don't seem to provide any clarification
http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
so if anyone could chime in with some details on the exact meanings that
would be most appreciated.

   Regards
   Steve

- Original Message - 
From: "Sergey A. Osokin" 

To: "Steven Hartland" 
Cc: "David Keller" ; 
Sent: Friday, April 11, 2014 11:27 PM
Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2



Hi Steven,

looks good, except one thing:

-.if ${PORT_OPTIONS:NDEBUG}
+.if ${PORT_OPTIONS:MDEBUG}

Could you explain what's the actual change here.

Also, please bump PORTREVISION for final patch.

--
Sergey A. Osokin
o...@freebsd.org


   Regards
   Steve
- Original Message - From: "David Keller" 
To: 
Cc: 
Sent: Friday, April 11, 2014 10:29 AM
Subject: FreeBSD Port: rubygem-passenger-4.0.41_2


>Hello,
>
>Since
>
>rev *350664* (Wed Apr 9 02:36:08 2014 UTC)
>
>
>After *#make install *from */usr/ports/www/rubygem-passenger*
>
>/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41/*buildout*
>
>
>is no longer populated with passenger binaries, hence nginx complains that
>passenger is not installed.
>
>Mannualy copying *buildout* directory from
>*/usr/ports/www/rubygem-passenger/work/**passenger-4.0.41/* resolves the
>issue.
>
>Regards.
>___
>freebsd-ports@freebsd.org mailing list
>http://lists.freebsd.org/mailman/listinfo/freebsd-ports
>To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
>





___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread Sergey A. Osokin
Hi Steven,

looks good, except one thing:

-.if ${PORT_OPTIONS:NDEBUG}
+.if ${PORT_OPTIONS:MDEBUG}

Could you explain what's the actual change here.

Also, please bump PORTREVISION for final patch.

-- 
Sergey A. Osokin
o...@freebsd.org

>Regards
>Steve
> - Original Message - From: "David Keller" 
> To: 
> Cc: 
> Sent: Friday, April 11, 2014 10:29 AM
> Subject: FreeBSD Port: rubygem-passenger-4.0.41_2
> 
> 
> >Hello,
> >
> >Since
> >
> >rev *350664* (Wed Apr 9 02:36:08 2014 UTC)
> >
> >
> >After *#make install *from */usr/ports/www/rubygem-passenger*
> >
> >/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41/*buildout*
> >
> >
> >is no longer populated with passenger binaries, hence nginx complains that
> >passenger is not installed.
> >
> >Mannualy copying *buildout* directory from
> >*/usr/ports/www/rubygem-passenger/work/**passenger-4.0.41/* resolves the
> >issue.
> >
> >Regards.
> >___
> >freebsd-ports@freebsd.org mailing list
> >http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> >To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
> >


___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread David Keller
Managed to get it working with:

(cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s *${GEM_NAME}* ${PORTNAME})

Now everything is working.

If you want it to be perfect, you may change the post install message from

passenger_root /usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41
> passenger_ruby /usr/local/bin/ruby19


to

passenger_root /usr/local/lib/ruby/gems/1.9/gems/passenger
> passenger_ruby /usr/local/bin/ruby19



When symlink option is enabled.

Thanks for patches :-)


On Fri, Apr 11, 2014 at 1:09 PM, Steven Hartland wrote:

> - Original Message - From: "Steven Hartland" <
> kill...@multiplay.co.uk>
> To: "David Keller" 
> Cc: ; 
> Sent: Friday, April 11, 2014 12:04 PM
> Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2
>
>
>
>  - Original Message - From: "David Keller" <
>> david.kel...@litchis.fr>
>>
>>
>>  It's working :-)
>>>
>>> But the symlink seems incorrect:
>>> * passenger -> lib/ruby/gems/1.9/gems/passenger-4.0.41
>>>
>>> I might be better like this:
>>> * passenger -> passenger-4.0.41
>>>
>>
>> Sorry David I've never used the link option, I just corrected
>> the syntax to work with stage, could you give me some context
>> on that please?
>>
>
> Actually I think I know what you might mean try changing the LN cmd
> to:
> (cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s ${GEM_LIB_DIR}
> ${PORTNAME})
>
>Regards
>Steve
>
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread Steven Hartland
- Original Message - 
From: "Steven Hartland" 

To: "David Keller" 
Cc: ; 
Sent: Friday, April 11, 2014 12:04 PM
Subject: Re: FreeBSD Port: rubygem-passenger-4.0.41_2


- Original Message - 
From: "David Keller" 




It's working :-)

But the symlink seems incorrect:
* passenger -> lib/ruby/gems/1.9/gems/passenger-4.0.41

I might be better like this:
* passenger -> passenger-4.0.41


Sorry David I've never used the link option, I just corrected
the syntax to work with stage, could you give me some context
on that please?


Actually I think I know what you might mean try changing the LN cmd
to:
(cd ${STAGEDIR}${PREFIX}/${GEMS_DIR} && ${LN} -s ${GEM_LIB_DIR} ${PORTNAME})

   Regards
   Steve
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread Steven Hartland
- Original Message - 
From: "David Keller" 




It's working :-)

But the symlink seems incorrect:
* passenger -> lib/ruby/gems/1.9/gems/passenger-4.0.41

I might be better like this:
* passenger -> passenger-4.0.41


Sorry David I've never used the link option, I just corrected
the syntax to work with stage, could you give me some context
on that please?

   Regards
   Steve
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread David Keller
It's working :-)

But the symlink seems incorrect:
* passenger -> lib/ruby/gems/1.9/gems/passenger-4.0.41

I might be better like this:
* passenger -> passenger-4.0.41

On Fri, Apr 11, 2014 at 12:13 PM, Steven Hartland
 wrote:
> I've been playing with this and other issues with that port, try the
> attached patch.
>
>Regards
>Steve
> - Original Message - From: "David Keller" 
> To: 
> Cc: 
> Sent: Friday, April 11, 2014 10:29 AM
> Subject: FreeBSD Port: rubygem-passenger-4.0.41_2
>
>
>> Hello,
>>
>> Since
>>
>> rev *350664* (Wed Apr 9 02:36:08 2014 UTC)
>>
>>
>> After *#make install *from */usr/ports/www/rubygem-passenger*
>>
>> /usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41/*buildout*
>>
>>
>>
>> is no longer populated with passenger binaries, hence nginx complains that
>> passenger is not installed.
>>
>> Mannualy copying *buildout* directory from
>> */usr/ports/www/rubygem-passenger/work/**passenger-4.0.41/* resolves the
>> issue.
>>
>> Regards.
>> ___
>> freebsd-ports@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
>> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread Steven Hartland

I've been playing with this and other issues with that port, try the attached 
patch.

   Regards
   Steve
- Original Message - 
From: "David Keller" 

To: 
Cc: 
Sent: Friday, April 11, 2014 10:29 AM
Subject: FreeBSD Port: rubygem-passenger-4.0.41_2



Hello,

Since

rev *350664* (Wed Apr 9 02:36:08 2014 UTC)


After *#make install *from */usr/ports/www/rubygem-passenger*

/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41/*buildout*


is no longer populated with passenger binaries, hence nginx complains that
passenger is not installed.

Mannualy copying *buildout* directory from
*/usr/ports/www/rubygem-passenger/work/**passenger-4.0.41/* resolves the
issue.

Regards.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


rubygem-passenger-stage-fix.patch
Description: Binary data
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread David Keller
PS: building with symlink enabled causes another issue:

===>  Staging for rubygem-passenger-4.0.41_2
> ===>   rubygem-passenger-4.0.41_2 depends on executable: nginx - found
> ===>   rubygem-passenger-4.0.41_2 depends on package:
> rubygem-fastthread>=1.0.1 - found
> ===>   rubygem-passenger-4.0.41_2 depends on package: rubygem-rack>=0 -
> found
> ===>   rubygem-passenger-4.0.41_2 depends on package:
> rubygem-daemon_controller>=1.2.0 - found
> ===>   rubygem-passenger-4.0.41_2 depends on file: /usr/local/bin/gem19 -
> found
> ===>   rubygem-passenger-4.0.41_2 depends on file: /usr/local/bin/ruby19 -
> found
> ===>   rubygem-passenger-4.0.41_2 depends on shared library: eio - found
> ===>   rubygem-passenger-4.0.41_2 depends on shared library: ev - found
> ===>   rubygem-passenger-4.0.41_2 depends on shared library: curl - found
> ===>   Generating temporary packing list
> Building native extensions.  This could take a while...
> Successfully installed passenger-4.0.41
> 1 gem installed
> Installing RDoc documentation for passenger-4.0.41...
> > Compressing man pages (compress-man)
> ===>  Installing for rubygem-passenger-4.0.41_2
> ===>   Registering installation for rubygem-passenger-4.0.41_2
> pkg-static:
> lstat(/usr/ports/www/rubygem-passenger/work/stage/usr/local/lib/ruby/gems/1.9/gems/passenger):
> No such file or directory


David


On Fri, Apr 11, 2014 at 11:29 AM, David Keller wrote:

> Hello,
>
> Since
>
> rev *350664* (Wed Apr 9 02:36:08 2014 UTC)
>
>
> After *#make install *from */usr/ports/www/rubygem-passenger*
>
> /usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41/*buildout*
>
>
> is no longer populated with passenger binaries, hence nginx complains that
> passenger is not installed.
>
> Mannualy copying *buildout* directory from
> */usr/ports/www/rubygem-passenger/work/**passenger-4.0.41/* resolves the
> issue.
>
> Regards.
>
>
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


FreeBSD Port: rubygem-passenger-4.0.41_2

2014-04-11 Thread David Keller
Hello,

Since

rev *350664* (Wed Apr 9 02:36:08 2014 UTC)


After *#make install *from */usr/ports/www/rubygem-passenger*

/usr/local/lib/ruby/gems/1.9/gems/passenger-4.0.41/*buildout*


is no longer populated with passenger binaries, hence nginx complains that
passenger is not installed.

Mannualy copying *buildout* directory from
*/usr/ports/www/rubygem-passenger/work/**passenger-4.0.41/* resolves the
issue.

Regards.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"