Re: FreeBSD telldusd port fix for devd script

2017-10-05 Thread Johan Ström
Hello again,

cleaned up and submitted as
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222790

Found that there was an old PR still hanging around with similar devd
patch, which you had already provided, but it was never applied. Well,
this one superseeds it :)

Glad to hear it works 24/7! Same here, almost at least. Too bad upstream
(Telldus) have stopped developing it, there are a few quirks that could
be fixed such as


On 04/10/17 16:51, Hans Petter Selasky wrote:
> On 10/04/17 16:30, Johan Ström wrote:
>> Ah, okay. Well, it works now and didn't work with the old devd rule,
>> I'm happy with that :)
>>
>> Shall I create a patch and submit to bugzilla, or are you fixing this
>> as part of bigger cleanup?
>
> Please submit it straight to ports. No more cleanup from my side at
> the present. telldus is working great btw 24/7 !
>
> --HPS
>

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD telldusd port fix for devd script

2017-10-04 Thread Hans Petter Selasky

On 10/04/17 16:30, Johan Ström wrote:

Ah, okay. Well, it works now and didn't work with the old devd rule, I'm happy 
with that :)

Shall I create a patch and submit to bugzilla, or are you fixing this as part 
of bigger cleanup?


Please submit it straight to ports. No more cleanup from my side at the 
present. telldus is working great btw 24/7 !


--HPS

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD telldusd port fix for devd script

2017-10-04 Thread Johan Ström
Ah, okay. Well, it works now and didn't work with the old devd rule, I'm happy 
with that :)

Shall I create a patch and submit to bugzilla, or are you fixing this as part 
of bigger cleanup?


On October 4, 2017 10:03:21 AM GMT+02:00, Hans Petter Selasky 
 wrote:
>On 10/04/17 07:59, Johan Ström wrote:
>> Hi,
>> 
>> thanks, verified and seems to work fine, at least on unplug/re-plug.
>> 
>> I added a "logger "logger ATTACH event on $cdev;" to the action too.
>On
>> unplug-plug scenario this was logged and all worked fine [1].
>> On a reboot it did not log it [2], but it actually seems to have
>> executed, as the dialer group have been set on ugen0.2 and telldusd
>is
>> able to interact with it.
>> 
>> Can I expect that this will execute on system boot too, or is there
>some
>> other magic involved for that? logger not ready for use at that
>stage,
>> but devd is perhaps?
>
>Yes, but it is not executed until the devd is started. All the events 
>are queued in the kernel and then when devd opens they are read and 
>executed.
>
>--HPS

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD telldusd port fix for devd script

2017-10-04 Thread Hans Petter Selasky

On 10/04/17 07:59, Johan Ström wrote:

Hi,

thanks, verified and seems to work fine, at least on unplug/re-plug.

I added a "logger "logger ATTACH event on $cdev;" to the action too. On
unplug-plug scenario this was logged and all worked fine [1].
On a reboot it did not log it [2], but it actually seems to have
executed, as the dialer group have been set on ugen0.2 and telldusd is
able to interact with it.

Can I expect that this will execute on system boot too, or is there some
other magic involved for that? logger not ready for use at that stage,
but devd is perhaps?


Yes, but it is not executed until the devd is started. All the events 
are queued in the kernel and then when devd opens they are read and 
executed.


--HPS

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD telldusd port fix for devd script

2017-10-03 Thread Johan Ström
Hi,

thanks, verified and seems to work fine, at least on unplug/re-plug.

I added a "logger "logger ATTACH event on $cdev;" to the action too. On
unplug-plug scenario this was logged and all worked fine [1].
On a reboot it did not log it [2], but it actually seems to have
executed, as the dialer group have been set on ugen0.2 and telldusd is
able to interact with it.

Can I expect that this will execute on system boot too, or is there some
other magic involved for that? logger not ready for use at that stage,
but devd is perhaps?

Johan


1. Device inserted
Oct  4 07:43:48 back-1 kernel: ugen0.2:  at usbus0
Oct  4 07:43:48 back-1 kernel: uftdi0:  on usbus0
Oct  4 07:43:48 back-1 devd: Executing 'logger ATTACH event on ugen0.2;
chgrp dialer /dev/ugen0.2; chmod 660 /dev/ugen0.2
/usr/local/sbin/tdadmin --pid 0x0c30 --vid 0x1781 --serial A6008W8a
controller connect'
Oct  4 07:43:48 back-1 johan: ATTACH event on ugen0.2
...
Oct  4 07:44:17 back-1 telldusd: Connecting to TellStick (1781/C30) with
serial A6008W8a


2. System boot with device already plugged in
Oct  4 07:49:12 back-1 kernel: ugen0.2:  at usbus0
...
Oct  4 07:49:12 back-1 kernel: uftdi0:  on usbus0
...
Oct  4 07:49:34 back-1 telldusd: Connecting to TellStick (1781/C30) with
serial A6008W8a


But nothing from devd or ATTACH event.


On 30/09/17 21:07, Hans Petter Selasky wrote:
> Hi Johan,
>
> The following devd script is not fully correct.
>
>> --- tdadmin/freebsd-devd-tellstick.conf    2014-04-06
>> 22:40:11.0 +0200
>> +++ tdadmin/freebsd-devd-tellstick.conf    2014-04-06
>> 20:37:50.501751596 +0200
>> @@ -0,0 +1,12 @@
>> +attach 10 {
>> +    device-name "uftdi[0-9]+";
>> +    match "vendor" "0x1781";
>> +    match "product" "0x0c30";
>> +
>> +    action "chgrp dialer /dev/ugen$port.$devaddr; chmod 660
>> /dev/ugen$port.$devaddr;
>> +    @CMAKE_INSTALL_PREFIX@/sbin/tdadmin --pid $product --vid
>> $vendor --serial $sernum controller connect";
>> +};
>
> It should be:
>
> notify 10 {
>     match "system" "USB";
>     match "subsystem" "DEVICE";
>     match "type" "ATTACH";
>     match "vendor" "0x1781";
>     match "product" "0x0c30";
> action "chgrp dialer /dev/$cdev; chmod 660 /dev/$cdev
> @CMAKE_INSTALL_PREFIX@/sbin/tdadmin --pid $product --vid $vendor
> --serial $sernum controller connect";
> }
>
> Can you test and update the port in FreeBSD ?
>
> Thank you!
>
> --HPS

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

FreeBSD telldusd port fix for devd script

2017-09-30 Thread Hans Petter Selasky

Hi Johan,

The following devd script is not fully correct.


--- tdadmin/freebsd-devd-tellstick.conf 2014-04-06 22:40:11.0 +0200
+++ tdadmin/freebsd-devd-tellstick.conf 2014-04-06 20:37:50.501751596 +0200
@@ -0,0 +1,12 @@
+attach 10 {
+   device-name "uftdi[0-9]+";
+   match "vendor" "0x1781";
+   match "product" "0x0c30";
+
+   action "chgrp dialer /dev/ugen$port.$devaddr; chmod 660 
/dev/ugen$port.$devaddr;
+   @CMAKE_INSTALL_PREFIX@/sbin/tdadmin --pid $product --vid $vendor 
--serial $sernum controller connect";
+};


It should be:

notify 10 {
match "system" "USB";
match "subsystem" "DEVICE";
match "type" "ATTACH";
match "vendor" "0x1781";
match "product" "0x0c30";
	action "chgrp dialer /dev/$cdev; chmod 660 /dev/$cdev 
@CMAKE_INSTALL_PREFIX@/sbin/tdadmin --pid $product --vid $vendor 
--serial $sernum controller connect";

}

Can you test and update the port in FreeBSD ?

Thank you!

--HPS
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"