Re: NO_OPTIONS_SORT makes options disappear
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/04/2012 23:04, Baptiste Daroussin wrote: > On Mon, Jun 04, 2012 at 03:58:24PM -0700, Doug Barton wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> On 06/04/2012 15:40, Baptiste Daroussin wrote: >>> Can you try with this patch ? >>> http://people.freebsd.org/~bapt/bsd.options.mk.diff >>> >>> Still adding NO_OPTIONS_SORT=yes >> >> With this change the options are no longer sorted, and do appear, >> but they appear twice. >> >> FYI, you can test this yourself in the dns/bind* ports. > > Fixed Sorry for the late response, but I can confirm that this is fixed, along with my other concerns about backwards compatibility. Thanks for addressing these issues so quickly. I think that this will greatly ease the transition to the new system, and significantly improve the user experience. Doug - -- This .signature sanitized for your protection -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJP05V7AAoJEFzGhvEaGryE0gMIAKN5OY38rvCte2UM9ZsfVdJp 5BclP9Gwza6W1h73o+C+TsZLed/vxCGcx6nc3AcQ4MISBKmmMilo7eFTwm+4y+5p coQURm0/Kq3UZBeBeJpJBQ9g9j8ADACIfadCAr7MTUiw3uNpAzxr8zvIA6jy4atS BkkOnXDUhJy0zoIlPcQebt7dxdUceWj87/2O41T5YSGvIELWFWGdfhFjMNHP1dJ+ pu6v6oRBEJ8rHtqeRgjUAdntlhbI4OWmInJUwMNJMErV1zTQL0FwIBOch34dIapt 91EzNiMkUDfehRZaQ1G+9VToDHZWkv5wZQ2hBgysBaCRCTS3pMcH1MbS8ffhWzQ= =VwWh -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: NO_OPTIONS_SORT makes options disappear
On Mon, Jun 04, 2012 at 03:58:24PM -0700, Doug Barton wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 06/04/2012 15:40, Baptiste Daroussin wrote: > > Can you try with this patch ? > > http://people.freebsd.org/~bapt/bsd.options.mk.diff > > > > Still adding NO_OPTIONS_SORT=yes > > With this change the options are no longer sorted, and do appear, but > they appear twice. > > FYI, you can test this yourself in the dns/bind* ports. Fixed regards, Bapt pgpFaT9X34WS7.pgp Description: PGP signature
Re: NO_OPTIONS_SORT makes options disappear
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/04/2012 15:40, Baptiste Daroussin wrote: > Can you try with this patch ? > http://people.freebsd.org/~bapt/bsd.options.mk.diff > > Still adding NO_OPTIONS_SORT=yes With this change the options are no longer sorted, and do appear, but they appear twice. FYI, you can test this yourself in the dns/bind* ports. - -- This .signature sanitized for your protection -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJPzT2QAAoJEFzGhvEaGryE24sH/jv7clUvUcvoIZgq0GKdO2El quu8iqCAQ1J95RRJv6V5y11mcEEgAyTcafJz3QDGiqWC6Ih6m/ghbESe/1sCstjv rVfL2GZNTNucNAJqET4A7kdiFB1CdTLu9iTWPRoGgX3Ix1I4luABiafzfvTayRh6 f666fMV9LkXa5otwKRiL0pzWDycjsHfrBsllZ/he+b7UZni6qEd+V3fnzx38QQOx Fbn8HboGh7Is/ZBcUYdMUbBcL2pJtfqlRB2WOC8KqQ92luBk3Ht+RNdcVuXDaqaO 8c1gYDY8pz/Pg7oU+UtVw/84AvMX8qV3Li/NgaV+zjVFMekQzaYsQv42dJTrhKE= =pvcA -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: NO_OPTIONS_SORT makes options disappear
On Mon, Jun 04, 2012 at 03:28:24PM -0700, Doug Barton wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 06/04/2012 15:22, Baptiste Daroussin wrote: > > On Mon, Jun 04, 2012 at 01:47:03PM -0700, Doug Barton wrote: > >> The new options framework sorts all of the options by default > >> before presenting them to the user. I have mixed feelings about > >> this, however there is supposed to be a workaround for those of > >> us who have grouped the options for our ports into logical > >> chunks, NO_OPTIONS_SORT. > >> > >> Today I tried defining that in my BIND ports so that users would > >> not be confused during the upgrade process, and got this: > >> > >> make config ===> No options to configure > >> > >> I tried defining NO_OPTIONS_SORT both before and after including > >> bsd.port.pre.mk, got the same result for both. > > > Have you tried keeping you port as-is > > I left it as-is since I don't have time to do anything else. This > results in a bad user experience since the options are now all sorted > into alphabetical order instead of the meaningful groupings that I had > them in. > > > or converting it ? > > I don't have time to do that right now, and this should not be > necessary in order to maintain backwards compatibility with what I > already had. I can accept adding the NO_OPTIONS_SORT knob, but the > fact that adding it causes things to be dramatically more broken than > they already are is a bug. > > > Can you send me a diff so that I can have a deeper look tomorrow > > morning GMT+1? > > I described what I did in detail in my OP. Adding NO_OPTIONS_SORT was > the only change I made. > > Doug > > - -- > > This .signature sanitized for your protection > -BEGIN PGP SIGNATURE- > Version: GnuPG v2.0.19 (FreeBSD) > > iQEcBAEBCAAGBQJPzTaIAAoJEFzGhvEaGryEOuUH/2WcSn0Wn8xMoUzhIJBm2x2Z > Axog5WoLoL/uuddijCsAQyQlG4OxYaatMvIPBg2kImqZDdZV0wDvrp/vcg3vngYX > zvq2kpzfc0y8BT01UWi6BNGJXymDHZ0/b8NKv7pYrUWvTLta4Ae8wxtxZciGsAVL > ITMFXygIDhu8KWtWmfakP5bJpwexz+v20M1CoKhBWJ8FuawcicZctOscbUCYn4HE > KK4kYcmO/sb8C5n8aCehJXQbcZX77wftSDUatfNpv8WTxyDPzKpms3SwmfOUIMnd > XSnh4O4eiyIccPk9OCE4EMOmizlJhBxMpgEPp6a0QeAwmWaYA09dTiyhbexXcXQ= > =FlRt > -END PGP SIGNATURE- Can you try with this patch ? http://people.freebsd.org/~bapt/bsd.options.mk.diff Still adding NO_OPTIONS_SORT=yes regards, Bapt pgpqB5zUo4uGd.pgp Description: PGP signature
Re: NO_OPTIONS_SORT makes options disappear
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/04/2012 15:31, Baptiste Daroussin wrote: > I'll try to come asap with a fix for that Thanks! - -- This .signature sanitized for your protection -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJPzTggAAoJEFzGhvEaGryEDWQIANWiHMBaIxszTHK1lCRqMEWh 4u92DCt9C7JpqKRPnNf+5Do/AWivaWY23lXEeNN3IuJM2p6gy41qbu/zHWxJ8enm E/UWiDY2vwaWxmsi0ZdUZV9VzV11IZ59/mO5ewLZ+U/WzQcfmDiOYMpQa721kU7o 10meB+YY5inpH6tOSU/ZcaEuREIpb2vSgOmk9EMv5Ki8j6dBETKafeOYMO8SpJKQ u6ofVsqkeOg3vZqexaPd/Xp3KXekkfof+4EFwarvh1OZtzau1OVhRss2hnpzcsQW WAz4PkMXAyMXJ8NYm1wY5TGNOYCqaIqhyzTXHchIYSlH8gtsJ5UaXkXfmU+dt0o= =vPPy -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: NO_OPTIONS_SORT makes options disappear
On Mon, Jun 04, 2012 at 03:28:24PM -0700, Doug Barton wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 06/04/2012 15:22, Baptiste Daroussin wrote: > > On Mon, Jun 04, 2012 at 01:47:03PM -0700, Doug Barton wrote: > >> The new options framework sorts all of the options by default > >> before presenting them to the user. I have mixed feelings about > >> this, however there is supposed to be a workaround for those of > >> us who have grouped the options for our ports into logical > >> chunks, NO_OPTIONS_SORT. > >> > >> Today I tried defining that in my BIND ports so that users would > >> not be confused during the upgrade process, and got this: > >> > >> make config ===> No options to configure > >> > >> I tried defining NO_OPTIONS_SORT both before and after including > >> bsd.port.pre.mk, got the same result for both. > > > Have you tried keeping you port as-is > > I left it as-is since I don't have time to do anything else. This > results in a bad user experience since the options are now all sorted > into alphabetical order instead of the meaningful groupings that I had > them in. > > > or converting it ? > > I don't have time to do that right now, and this should not be > necessary in order to maintain backwards compatibility with what I > already had. I can accept adding the NO_OPTIONS_SORT knob, but the > fact that adding it causes things to be dramatically more broken than > they already are is a bug. I'll try to come asap with a fix for that > > > Can you send me a diff so that I can have a deeper look tomorrow > > morning GMT+1? > > I described what I did in detail in my OP. Adding NO_OPTIONS_SORT was > the only change I made. > > Doug > > - -- > > This .signature sanitized for your protection > -BEGIN PGP SIGNATURE- > Version: GnuPG v2.0.19 (FreeBSD) > > iQEcBAEBCAAGBQJPzTaIAAoJEFzGhvEaGryEOuUH/2WcSn0Wn8xMoUzhIJBm2x2Z > Axog5WoLoL/uuddijCsAQyQlG4OxYaatMvIPBg2kImqZDdZV0wDvrp/vcg3vngYX > zvq2kpzfc0y8BT01UWi6BNGJXymDHZ0/b8NKv7pYrUWvTLta4Ae8wxtxZciGsAVL > ITMFXygIDhu8KWtWmfakP5bJpwexz+v20M1CoKhBWJ8FuawcicZctOscbUCYn4HE > KK4kYcmO/sb8C5n8aCehJXQbcZX77wftSDUatfNpv8WTxyDPzKpms3SwmfOUIMnd > XSnh4O4eiyIccPk9OCE4EMOmizlJhBxMpgEPp6a0QeAwmWaYA09dTiyhbexXcXQ= > =FlRt > -END PGP SIGNATURE- pgpc86sRXYAg9.pgp Description: PGP signature
Re: NO_OPTIONS_SORT makes options disappear
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/04/2012 15:22, Baptiste Daroussin wrote: > On Mon, Jun 04, 2012 at 01:47:03PM -0700, Doug Barton wrote: >> The new options framework sorts all of the options by default >> before presenting them to the user. I have mixed feelings about >> this, however there is supposed to be a workaround for those of >> us who have grouped the options for our ports into logical >> chunks, NO_OPTIONS_SORT. >> >> Today I tried defining that in my BIND ports so that users would >> not be confused during the upgrade process, and got this: >> >> make config ===> No options to configure >> >> I tried defining NO_OPTIONS_SORT both before and after including >> bsd.port.pre.mk, got the same result for both. > Have you tried keeping you port as-is I left it as-is since I don't have time to do anything else. This results in a bad user experience since the options are now all sorted into alphabetical order instead of the meaningful groupings that I had them in. > or converting it ? I don't have time to do that right now, and this should not be necessary in order to maintain backwards compatibility with what I already had. I can accept adding the NO_OPTIONS_SORT knob, but the fact that adding it causes things to be dramatically more broken than they already are is a bug. > Can you send me a diff so that I can have a deeper look tomorrow > morning GMT+1? I described what I did in detail in my OP. Adding NO_OPTIONS_SORT was the only change I made. Doug - -- This .signature sanitized for your protection -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJPzTaIAAoJEFzGhvEaGryEOuUH/2WcSn0Wn8xMoUzhIJBm2x2Z Axog5WoLoL/uuddijCsAQyQlG4OxYaatMvIPBg2kImqZDdZV0wDvrp/vcg3vngYX zvq2kpzfc0y8BT01UWi6BNGJXymDHZ0/b8NKv7pYrUWvTLta4Ae8wxtxZciGsAVL ITMFXygIDhu8KWtWmfakP5bJpwexz+v20M1CoKhBWJ8FuawcicZctOscbUCYn4HE KK4kYcmO/sb8C5n8aCehJXQbcZX77wftSDUatfNpv8WTxyDPzKpms3SwmfOUIMnd XSnh4O4eiyIccPk9OCE4EMOmizlJhBxMpgEPp6a0QeAwmWaYA09dTiyhbexXcXQ= =FlRt -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: NO_OPTIONS_SORT makes options disappear
On Mon, Jun 04, 2012 at 01:47:03PM -0700, Doug Barton wrote: > The new options framework sorts all of the options by default before > presenting them to the user. I have mixed feelings about this, however > there is supposed to be a workaround for those of us who have grouped > the options for our ports into logical chunks, NO_OPTIONS_SORT. > > Today I tried defining that in my BIND ports so that users would not be > confused during the upgrade process, and got this: > > make config > ===> No options to configure > > I tried defining NO_OPTIONS_SORT both before and after including > bsd.port.pre.mk, got the same result for both. > > Suggestions welcome, > > Doug > > -- > > This .signature sanitized for your protection Have you tried keeping you port as-is or converting it ? Can you send me a diff so that I can have a deeper look tomorrow morning GMT+1? regards, Bapt pgpfOrZymwIrq.pgp Description: PGP signature
NO_OPTIONS_SORT makes options disappear
The new options framework sorts all of the options by default before presenting them to the user. I have mixed feelings about this, however there is supposed to be a workaround for those of us who have grouped the options for our ports into logical chunks, NO_OPTIONS_SORT. Today I tried defining that in my BIND ports so that users would not be confused during the upgrade process, and got this: make config ===> No options to configure I tried defining NO_OPTIONS_SORT both before and after including bsd.port.pre.mk, got the same result for both. Suggestions welcome, Doug -- This .signature sanitized for your protection ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
