Re: New pkg-message[.in] guideline idea
2010/6/24 Garrett Cooper yanef...@gmail.com:
On Thu, Jun 24, 2010 at 9:43 AM, David DEMELIER
demelier.da...@gmail.com wrote:
2010/6/24 Freddie Cash fjwc...@gmail.com:
On Thu, Jun 24, 2010 at 12:04 AM, David DEMELIER
demelier.da...@gmail.com wrote:
2010/6/24 Janne Snabb sn...@epipe.com:
On Wed, 23 Jun 2010, David DEMELIER wrote:
2010/6/23 Janne Snabb sn...@epipe.com:
I find it completely useless and plainly stupid to edit the
pkg-messages of all ports to include lots of equal signs for tty-based
formatting purposes.
We can take a long time to do that (we don't have to do it quickly),
but it could be useful to standardize it for one reason :
You will see that it's a message from the port maintainer/submitter
and not from the program itself! Sometimes configure scripts stage say
some useless things to the user.
You obviously did not get my point.
I fully agree with you that displaying a line of equals signs on
tty based interfaces to make the messages stand out from other crap
when installing ports makes sense, but I STRONGLY oppose to the
idea of putting this visual formatting in the actual message files.
It is just not the right place to put it in.
I see, so maybe in the future you would like some tools that can print
the message, like a GTK+ dialog, QT dialog, or an other tool, if it's
your point I agree. I don't specially want a equal == line, I would
just something consistent, why not : nothing ? Yes we can just print
the text without any visual characters, and the [future] tool will
print the message as it want.
No, what he's saying is:
- put the logic to print the separators into the appropriate bsd.*.mk file
- remove all separators from all pkg-message* files
That way, you can update the separators at any time by editing a
single file, instead of editing 20,000+ pkg-message files. And, that
way, future tools can override the separator set in the mk file.
Leave the pkg-message files as unformatted text. Put the formatting
into the mk file.
Separate content from style.
Yes, that was I said, sorry if you did not understand well :-)
The only problem is that pushing all of this logic into bsd.*.mk only
solves half the problem: from source installations. It doesn't cover
binary installations via pkg_install.
I think Doug and Phillip were on the right track with pushing the data
into a pkg_install consumable format, but the only problem is that
creating additional code that handles one more corner case for
@comment will serve to only slow down the plist parser unnecessarily.
That's why I was suggesting a scripting infrastructure, like so:
pkgmsg() {
local message=$1
pkgmsg_separator
echo $message
pkgmsg_separator
}
Example:
echo This is an install message for my awesome new package
foo-BLAH +DISPLAY
pkgmsg `cat +DISPLAY`
And considering that you almost get the functionality for free via
pkg_install (from pkg_create(8)):
-D displayfile
Display the file (by concatenating it to stdout) after installing
the package. Useful for things like legal notices on almost-free
software, etc.
The thing about using a script function like pkgmsg too is that it can
be dynamically overwritten by certain groups in order to tailor the
messages (or mute output for customer purposes after everything has
passed QA if they use pkg_install in a product) to the meet their
needs when doing localized installations or deployments as well.
So, why not just add the relevant bits as I described?
Thanks,
-Garrett
I like this idea,
in fact the best thing to do would be to remove any kind of decoration
and just keeping the text in the pkg-message. Then we could write
something like the SECURITY REPORT.
So it would be something like that :
=== SECURITY REPORT:
This port has installed the following files which may act as network
servers and may therefore pose a remote security risk to the system.
/usr/local/lib/libtorrent-rasterbar.so.5
If there are vulnerabilities in these programs there may be a security
risk to the system. FreeBSD makes no guarantee about the security of
ports included in the Ports Collection. Please type 'make deinstall'
to deinstall the port if this is a concern.
For more information, and contact details about the security
status of this software, see the following webpage:
http://www.rasterbar.com/products/libtorrent/index.html
=== Message for pkg_name_here:
Text here...
=== Registering installation for pkg_name_here
Then if the pkg-message is clean, only text and white line, the Mk/*
infrastructure can write any kind of useless decoration, same for the
GUI tools.
--
Demelier David
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
On Thu, Jun 24, 2010 at 12:04 AM, David DEMELIER demelier.da...@gmail.com wrote: 2010/6/24 Janne Snabb sn...@epipe.com: On Wed, 23 Jun 2010, David DEMELIER wrote: 2010/6/23 Janne Snabb sn...@epipe.com: I find it completely useless and plainly stupid to edit the pkg-messages of all ports to include lots of equal signs for tty-based formatting purposes. We can take a long time to do that (we don't have to do it quickly), but it could be useful to standardize it for one reason : You will see that it's a message from the port maintainer/submitter and not from the program itself! Sometimes configure scripts stage say some useless things to the user. You obviously did not get my point. I fully agree with you that displaying a line of equals signs on tty based interfaces to make the messages stand out from other crap when installing ports makes sense, but I STRONGLY oppose to the idea of putting this visual formatting in the actual message files. It is just not the right place to put it in. I see, so maybe in the future you would like some tools that can print the message, like a GTK+ dialog, QT dialog, or an other tool, if it's your point I agree. I don't specially want a equal == line, I would just something consistent, why not : nothing ? Yes we can just print the text without any visual characters, and the [future] tool will print the message as it want. No, what he's saying is: - put the logic to print the separators into the appropriate bsd.*.mk file - remove all separators from all pkg-message* files That way, you can update the separators at any time by editing a single file, instead of editing 20,000+ pkg-message files. And, that way, future tools can override the separator set in the mk file. Leave the pkg-message files as unformatted text. Put the formatting into the mk file. Separate content from style. -- Freddie Cash fjwc...@gmail.com ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
On Thu, Jun 24, 2010 at 9:43 AM, David DEMELIER
demelier.da...@gmail.com wrote:
2010/6/24 Freddie Cash fjwc...@gmail.com:
On Thu, Jun 24, 2010 at 12:04 AM, David DEMELIER
demelier.da...@gmail.com wrote:
2010/6/24 Janne Snabb sn...@epipe.com:
On Wed, 23 Jun 2010, David DEMELIER wrote:
2010/6/23 Janne Snabb sn...@epipe.com:
I find it completely useless and plainly stupid to edit the
pkg-messages of all ports to include lots of equal signs for tty-based
formatting purposes.
We can take a long time to do that (we don't have to do it quickly),
but it could be useful to standardize it for one reason :
You will see that it's a message from the port maintainer/submitter
and not from the program itself! Sometimes configure scripts stage say
some useless things to the user.
You obviously did not get my point.
I fully agree with you that displaying a line of equals signs on
tty based interfaces to make the messages stand out from other crap
when installing ports makes sense, but I STRONGLY oppose to the
idea of putting this visual formatting in the actual message files.
It is just not the right place to put it in.
I see, so maybe in the future you would like some tools that can print
the message, like a GTK+ dialog, QT dialog, or an other tool, if it's
your point I agree. I don't specially want a equal == line, I would
just something consistent, why not : nothing ? Yes we can just print
the text without any visual characters, and the [future] tool will
print the message as it want.
No, what he's saying is:
- put the logic to print the separators into the appropriate bsd.*.mk file
- remove all separators from all pkg-message* files
That way, you can update the separators at any time by editing a
single file, instead of editing 20,000+ pkg-message files. And, that
way, future tools can override the separator set in the mk file.
Leave the pkg-message files as unformatted text. Put the formatting
into the mk file.
Separate content from style.
Yes, that was I said, sorry if you did not understand well :-)
The only problem is that pushing all of this logic into bsd.*.mk only
solves half the problem: from source installations. It doesn't cover
binary installations via pkg_install.
I think Doug and Phillip were on the right track with pushing the data
into a pkg_install consumable format, but the only problem is that
creating additional code that handles one more corner case for
@comment will serve to only slow down the plist parser unnecessarily.
That's why I was suggesting a scripting infrastructure, like so:
pkgmsg() {
local message=$1
pkgmsg_separator
echo $message
pkgmsg_separator
}
Example:
echo This is an install message for my awesome new package
foo-BLAH +DISPLAY
pkgmsg `cat +DISPLAY`
And considering that you almost get the functionality for free via
pkg_install (from pkg_create(8)):
-D displayfile
Display the file (by concatenating it to stdout) after installing
the package. Useful for things like legal notices on almost-free
software, etc.
The thing about using a script function like pkgmsg too is that it can
be dynamically overwritten by certain groups in order to tailor the
messages (or mute output for customer purposes after everything has
passed QA if they use pkg_install in a product) to the meet their
needs when doing localized installations or deployments as well.
So, why not just add the relevant bits as I described?
Thanks,
-Garrett
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
New pkg-message[.in] guideline idea
Hi freebsd-ports@, I would like to propose you something that I would like to be done. It's a cosmetic, useless thing but I like when things are made homogeneously. That is the problem : as you can see, sometimes port tells a message to the user but some maintainers used delimiters to begin/end the message such as a lot of *** or === or blank spaces. If you already did use NetBSD pkgsrc, you can see that *every* MESSAGE is composed like this : === $NetBSD: MESSAGE,v 1.1.1.1 2008/10/20 09:28:51 wiz Exp $ Note you need audio/audacious-plugins to actually play music. === I would do something like this to the FreeBSD ports, if you agree with me I can check every messages and modify them. I can also put something in the FreeBSD porter's handbook to write a pkg-message template I know that there is much more important work to do, that's why I can take all this work for myself. Please report any feedback, With kind regards. -- Demelier David ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/23/10 14:00, Ion-Mihai Tetcu wrote: On Wed, 23 Jun 2010 14:16:07 +0200 David DEMELIER demelier.da...@gmail.com wrote: Hi freebsd-ports@, I would like to propose you something that I would like to be done. It's a cosmetic, useless thing but I like when things are made homogeneously. That is the problem : as you can see, sometimes port tells a message to the user but some maintainers used delimiters to begin/end the message such as a lot of *** or === or blank spaces. If you already did use NetBSD pkgsrc, you can see that *every* MESSAGE is composed like this : === $NetBSD: MESSAGE,v 1.1.1.1 2008/10/20 09:28:51 wiz Exp $ Note you need audio/audacious-plugins to actually play music. === I would do something like this to the FreeBSD ports, if you agree with me I can check every messages and modify them. I can also put something in the FreeBSD porter's handbook to write a pkg-message template I know that there is much more important work to do, that's why I can take all this work for myself. Please report any feedback, With kind regards. Go ahead please. You'll need to keep the patch in sync for some time, so use CVS to make the patch. Ping me when you are ready. I am interested in this as well. If I can be of assistance I will. - -- - 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollu...@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer,FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFMIhv5dbiP+9ubjBwRAu8NAJ9Vw255Xhi5n6U3D7YwkV4DctgSjACeLYA7 xZqXsFPmLkOHVN2lyEUOSJc= =w85t -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
On Wed, Jun 23, 2010 at 02:16:07PM +0200, David DEMELIER wrote: Hi freebsd-ports@, I would like to propose you something that I would like to be done. It's a cosmetic, useless thing but I like when things are made homogeneously. That is the problem : as you can see, sometimes port tells a message to the user but some maintainers used delimiters to begin/end the message such as a lot of *** or === or blank spaces. If you already did use NetBSD pkgsrc, you can see that *every* MESSAGE is composed like this : === $NetBSD: MESSAGE,v 1.1.1.1 2008/10/20 09:28:51 wiz Exp $ Note you need audio/audacious-plugins to actually play music. === I would do something like this to the FreeBSD ports, if you agree with me I can check every messages and modify them. I can also put something in the FreeBSD porter's handbook to write a pkg-message template I know that there is much more important work to do, that's why I can take all this work for myself. I think a better solution is to do what portmaster does and display all the pkg-message files as one of the last things it does. I had a patch to do this sitting in portmgr@ queue but it needs more work. A combination of some standardization of pkg-message files and displaying them all at the end of a build would be best. -- WXS ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/23/10 14:40, Wesley Shields wrote: On Wed, Jun 23, 2010 at 02:16:07PM +0200, David DEMELIER wrote: Hi freebsd-ports@, I would like to propose you something that I would like to be done. It's a cosmetic, useless thing but I like when things are made homogeneously. That is the problem : as you can see, sometimes port tells a message to the user but some maintainers used delimiters to begin/end the message such as a lot of *** or === or blank spaces. If you already did use NetBSD pkgsrc, you can see that *every* MESSAGE is composed like this : === $NetBSD: MESSAGE,v 1.1.1.1 2008/10/20 09:28:51 wiz Exp $ Note you need audio/audacious-plugins to actually play music. === I would do something like this to the FreeBSD ports, if you agree with me I can check every messages and modify them. I can also put something in the FreeBSD porter's handbook to write a pkg-message template I know that there is much more important work to do, that's why I can take all this work for myself. I think a better solution is to do what portmaster does and display all the pkg-message files as one of the last things it does. I had a patch to do this sitting in portmgr@ queue but it needs more work. A combination of some standardization of pkg-message files and displaying them all at the end of a build would be best. Yes thats definitely a needed feature. I think we need 2 things: 1) All pkg-message whether .in or not go through the 'sed' that SUB_LIST/PLIST_SUB do. 2) You collect them in to /var/db/pkg and loop and display at end. As a consequence all formatting should be removed from the individual pkg-message[.in] files and added in #2. Ideally I'd say we should just slowly switch everything to FILESDIR/pkg-message[.in] but portmgr@ already veto'd that before so I'll drop that idea. - -- - 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollu...@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer,FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFMIh4ydbiP+9ubjBwRAix1AKCK76puppTw5UC3bWBS3t+zkQ+W/wCfWsPo GoWKEF6l7lZZABMYeynZHAs= =N0Vw -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
On Wed, 23 Jun 2010, David DEMELIER wrote: I would do something like this to the FreeBSD ports, if you agree with me I can check every messages and modify them. I can also put something in the FreeBSD porter's handbook to write a pkg-message template I find it completely useless and plainly stupid to edit the pkg-messages of all ports to include lots of equal signs for tty-based formatting purposes. In my opinion the messages in the ports tree should contain (English language, word based) messages, and if some visual formatting is desired, it should be done by the upper layer which displays the message (such as the ports framework, a web site which displays information about various ports, or whatever). The more clueful web monkeys have known to separate content from visual formatting for several years, why should FreeBSD make the same mistake the web monkeys did when www first became popular? However I fully support the idea that all the relevant messages should be displayed at the end of a build/upgrade process whenever technically feasible (otherwise they will just fly past while I am having a lunch or whatever). If the boild/upgrade process fails in the middle, the messages of successful builds/upgrades should still be displayed, even though the end of the process has not been reached. -- Janne Snabb / EPIPE Communications sn...@epipe.com - http://epipe.com/ ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
2010/6/23 Janne Snabb sn...@epipe.com: On Wed, 23 Jun 2010, David DEMELIER wrote: I would do something like this to the FreeBSD ports, if you agree with me I can check every messages and modify them. I can also put something in the FreeBSD porter's handbook to write a pkg-message template I find it completely useless and plainly stupid to edit the pkg-messages of all ports to include lots of equal signs for tty-based formatting purposes. In my opinion the messages in the ports tree should contain (English language, word based) messages, and if some visual formatting is desired, it should be done by the upper layer which displays the message (such as the ports framework, a web site which displays information about various ports, or whatever). We can take a long time to do that (we don't have to do it quickly), but it could be useful to standardize it for one reason : You will see that it's a message from the port maintainer/submitter and not from the program itself! Sometimes configure scripts stage say some useless things to the user. The more clueful web monkeys have known to separate content from visual formatting for several years, why should FreeBSD make the same mistake the web monkeys did when www first became popular? However I fully support the idea that all the relevant messages should be displayed at the end of a build/upgrade process whenever technically feasible (otherwise they will just fly past while I am having a lunch or whatever). If the boild/upgrade process fails in the middle, the messages of successful builds/upgrades should still be displayed, even though the end of the process has not been reached. I agree too. -- Demelier David ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
On 06/23/10 07:46, Philip M. Gollucci wrote: On 06/23/10 14:40, Wesley Shields wrote: On Wed, Jun 23, 2010 at 02:16:07PM +0200, David DEMELIER wrote: Hi freebsd-ports@, I would like to propose you something that I would like to be done. It's a cosmetic, useless thing but I like when things are made homogeneously. I admit that my initial reaction was mixed in the sense that I don't like removing the ability of maintainers to be creative without good reason. However after thinking about this (and reviewing the other posts) I think that the benefits of being consistent so that the user knows what is a message and what is not are worth it. That is the problem : as you can see, sometimes port tells a message to the user but some maintainers used delimiters to begin/end the message such as a lot of *** or === or blank spaces. If you already did use NetBSD pkgsrc, you can see that *every* MESSAGE is composed like this : === $NetBSD: MESSAGE,v 1.1.1.1 2008/10/20 09:28:51 wiz Exp $ Not to dive too quickly into the details, but I would see no value in actually displaying the CVS $Id to the user. :) Note you need audio/audacious-plugins to actually play music. === I would do something like this to the FreeBSD ports, if you agree with me I can check every messages and modify them. I can also put something in the FreeBSD porter's handbook to write a pkg-message template I know that there is much more important work to do, that's why I can take all this work for myself. That's great! When I first started in FreeBSD I wasn't new to programming but I was new to Unix, and taking on projects like this was a great way to get involved, give back to the community, and learn more about the system. I think a better solution is to do what portmaster does and display all the pkg-message files as one of the last things it does. I had a patch to do this sitting in portmgr@ queue but it needs more work. FWIW, portmaster users have commented to me many times that this is one of their favorite features, and that they find it very useful. So much so that I wish it were my idea, but it actually came from a user. :) I think it would be great if the ports infrastructure were able to do this as well. A combination of some standardization of pkg-message files and displaying them all at the end of a build would be best. Yes thats definitely a needed feature. I think we need 2 things: 1) All pkg-message whether .in or not go through the 'sed' that SUB_LIST/PLIST_SUB do. I like this idea better than forcing them all to be in /files, and I can't see any reason not to do it. 2) You collect them in to /var/db/pkg and loop and display at end. As a consequence all formatting should be removed from the individual pkg-message[.in] files and added in #2. I'm ambivalent about this. My first thought was that the formatting should happen in step #1. What portmaster does is build each port one at a time, and it makes a note if a port has a pkg-message. Then it does what you suggest in #2 by cat'ing them all to $PAGER. However, thinking more about it I could see how not doing the formatting until step 2 could work, so however it turns out to be easiest should be fine. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover!http://SupersetSolutions.com/ ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/23/10 19:15, Doug Barton wrote: I think we need 2 things: 1) All pkg-message whether .in or not go through the 'sed' that SUB_LIST/PLIST_SUB do. I like this idea better than forcing them all to be in /files, and I can't see any reason not to do it. The other benefit is you can carry over the PLIST logic with @comment to conditionalize lines in the message and thus eliminate all that crap from Makefiles. 2) You collect them in to /var/db/pkg and loop and display at end. As a consequence all formatting should be removed from the individual pkg-message[.in] files and added in #2. I'm ambivalent about this. My first thought was that the formatting should happen in step #1. What portmaster does is build each port one at a time, and it makes a note if a port has a pkg-message. Then it does what you suggest in #2 by cat'ing them all to $PAGER. However, thinking more about it I could see how not doing the formatting until step 2 could work, so however it turns out to be easiest should be fine. I believe we are agreeing. I didn't say anything about portmaster/portupgrade. The pkg/make infrastructure needs to do it at the end so that it works via pkg_add, make, or portmaster et al. - -- - 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollu...@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer,FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (FreeBSD) iD4DBQFMIl5KdbiP+9ubjBwRApYMAJ0ZgYpsSy41WeNNZxKjpgK2HpKdcwCYh54j 7t2X4DuUUkkrAdeLTr2Kiw== =BrZx -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
On 06/23/10 12:19, Philip M. Gollucci wrote: On 06/23/10 19:15, Doug Barton wrote: I think we need 2 things: 1) All pkg-message whether .in or not go through the 'sed' that SUB_LIST/PLIST_SUB do. I like this idea better than forcing them all to be in /files, and I can't see any reason not to do it. The other benefit is you can carry over the PLIST logic with @comment to conditionalize lines in the message and thus eliminate all that crap from Makefiles. Yes, simpler is better. :) 2) You collect them in to /var/db/pkg and loop and display at end. As a consequence all formatting should be removed from the individual pkg-message[.in] files and added in #2. I'm ambivalent about this. My first thought was that the formatting should happen in step #1. What portmaster does is build each port one at a time, and it makes a note if a port has a pkg-message. Then it does what you suggest in #2 by cat'ing them all to $PAGER. However, thinking more about it I could see how not doing the formatting until step 2 could work, so however it turns out to be easiest should be fine. I believe we are agreeing. I didn't say anything about portmaster/portupgrade. The pkg/make infrastructure needs to do it at the end so that it works via pkg_add, make, or portmaster et al. Yes, we are agreeing. I was simply adding my perspective as a tool author to your proposal. I also agree that the ports infrastructure itself should be as robust as possible, and include features like this whenever it can. hth, Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover!http://SupersetSolutions.com/ ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: New pkg-message[.in] guideline idea
On Wed, 23 Jun 2010 18:28:22 +0200 David DEMELIER demelier.da...@gmail.com wrote: Because I always used mv, vim, diff to generate patches I need some time to learn the way to do patches with cvs. http://ionut.tetcu.info/FreeBSD/How-to-submit-a-diff.txt HTH, -- IOnut - Un^d^dregistered ;) FreeBSD user Intellectual Property is nowhere near as valuable as Intellect FreeBSD committer - ite...@freebsd.org, PGP Key ID 057E9F8B493A297B signature.asc Description: PGP signature
Re: New pkg-message[.in] guideline idea
On Wed, 23 Jun 2010, David DEMELIER wrote: 2010/6/23 Janne Snabb sn...@epipe.com: I find it completely useless and plainly stupid to edit the pkg-messages of all ports to include lots of equal signs for tty-based formatting purposes. We can take a long time to do that (we don't have to do it quickly), but it could be useful to standardize it for one reason : You will see that it's a message from the port maintainer/submitter and not from the program itself! Sometimes configure scripts stage say some useless things to the user. You obviously did not get my point. I fully agree with you that displaying a line of equals signs on tty based interfaces to make the messages stand out from other crap when installing ports makes sense, but I STRONGLY oppose to the idea of putting this visual formatting in the actual message files. It is just not the right place to put it in. As I pointed out in my previous message, these messages are displayed by various different means for different purposes by different pieces of software (on tty, through GUI, on web sites, etc). Some of that software does not exist right now, but may be implemented in future (I am thinking here of for example a Synaptic like tool for managing the installed software). A line of equals signs looks good on a 80 character wide tty screen when the important message is surrounded by other non-important output, but it just looks stupid when displayed by a GUI or on a web site. Putting the visual cues in pkg-messages files would require every other display mechanism to have a logic to strip them out (for example when displaying the message on X display as a word-wrapped pop-up-window of random width). Why not just change the current display logic to emit these visual cues on a tty when installing ports? It is a single edit to a single file and does not introduce useless clutter in approximately 2209 pkg-message* files in the ports tree. I do realize that many of the current pkg-messages do include similar visual visual formatting already in a non-standard way. One port uses equals signs, another port uses hyphens, etc. Those should be all removed from pkg-messages when the ports infrastructure displays a standardized visual separator automatically. I do not oppose to the other related ideas (such as making a logic to optionally display a part of a message only when some option was enabled). -- Janne Snabb / EPIPE Communications sn...@epipe.com - http://epipe.com/ ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
