Re: NfSen Port PATCH

2013-11-14 Thread Chad Gross 
No problem; it happens.

Chad


On Wed, Nov 13, 2013 at 5:20 PM, Mark Felder  wrote:

>
> On Nov 13, 2013, at 12:27, Chad Gross  wrote:
>
> > I found an issue with the nfsen port Makefile. It is not properly
> > configured to expand the %%PORTNAME%% variable used when generating the
> > nfsen config file.
> >
> >
> > For example, the config that is installed shows this:
> >
> > $VARDIR="${BASEDIR}/var/%%PORTNAME%%";
> >
> >
> > When it should be this:
> >
> > $VARDIR="${BASEDIR}/var/nfsen";
> >
> > I have attached the patch, but also included it in-line below. I emailed
> > the maintainer, but hadn't heard a response so figured I would send it
> here
> > just in case.
> >
> >
> > --- Makefile2013-11-03 12:31:00.0 -0500
> >
> > +++ Makefile.new2013-11-03 12:30:51.0 -0500
> >
> > @@ -37,6 +37,7 @@
> >
> > SUB_LIST+= "PORTVERSION=${PORTVERSION}"
> >
> > SUB_LIST+= "PREFIX=${PREFIX}"
> >
> > SUB_LIST+= "WWWDIR=${WWWDIR}"
> >
> > +SUB_LIST+= "PORTNAME=${PORTNAME}"
> >
> >
> >
> > NO_STAGE=  yes
> >
> > post-patch:
> >
> >
> > Thanks,
> >
>
> Thanks for catching this. I’m not sure how I missed this when I rewrote
> the port… I definitely tested clean installs, but I must have provided my
> own configs
>
>
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: NfSen Port PATCH

2013-11-13 Thread Mark Felder 

On Nov 13, 2013, at 12:27, Chad Gross  wrote:

> I found an issue with the nfsen port Makefile. It is not properly
> configured to expand the %%PORTNAME%% variable used when generating the
> nfsen config file.
> 
> 
> For example, the config that is installed shows this:
> 
> $VARDIR="${BASEDIR}/var/%%PORTNAME%%";
> 
> 
> When it should be this:
> 
> $VARDIR="${BASEDIR}/var/nfsen";
> 
> I have attached the patch, but also included it in-line below. I emailed
> the maintainer, but hadn't heard a response so figured I would send it here
> just in case.
> 
> 
> --- Makefile2013-11-03 12:31:00.0 -0500
> 
> +++ Makefile.new2013-11-03 12:30:51.0 -0500
> 
> @@ -37,6 +37,7 @@
> 
> SUB_LIST+= "PORTVERSION=${PORTVERSION}"
> 
> SUB_LIST+= "PREFIX=${PREFIX}"
> 
> SUB_LIST+= "WWWDIR=${WWWDIR}"
> 
> +SUB_LIST+= "PORTNAME=${PORTNAME}"
> 
> 
> 
> NO_STAGE=  yes
> 
> post-patch:
> 
> 
> Thanks,
> 

Thanks for catching this. I’m not sure how I missed this when I rewrote the 
port… I definitely tested clean installs, but I must have provided my own 
configs



signature.asc
Description: Message signed with OpenPGP using GPGMail

NfSen Port PATCH

2013-11-13 Thread Chad Gross 
I found an issue with the nfsen port Makefile. It is not properly
configured to expand the %%PORTNAME%% variable used when generating the
nfsen config file.


For example, the config that is installed shows this:

$VARDIR="${BASEDIR}/var/%%PORTNAME%%";


When it should be this:

$VARDIR="${BASEDIR}/var/nfsen";

I have attached the patch, but also included it in-line below. I emailed
the maintainer, but hadn't heard a response so figured I would send it here
just in case.


--- Makefile2013-11-03 12:31:00.0 -0500

+++ Makefile.new2013-11-03 12:30:51.0 -0500

@@ -37,6 +37,7 @@

 SUB_LIST+= "PORTVERSION=${PORTVERSION}"

 SUB_LIST+= "PREFIX=${PREFIX}"

 SUB_LIST+= "WWWDIR=${WWWDIR}"

+SUB_LIST+= "PORTNAME=${PORTNAME}"



 NO_STAGE=  yes

 post-patch:


Thanks,

Chad


nfsen.patch
Description: Binary data
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"