Re: Patch compiler warnings away?
On Thu, 1 Oct 2020, Moritz Schmitt wrote: I recently took over my first maintainership of a port and I have a question regarding on how to deal with compiler warnings. I've always treated warnings as potential errors, and act accordingly. One place I worked insisted that "-Wall" produce no messages, and my own Perl stuff has "use strict". -- Dave ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Patch compiler warnings away?
On Thu, Oct 1, 2020 at 4:12 PM Moritz Schmitt wrote: > > Hi, > > I recently took over my first maintainership of a port and I have a > question regarding on how to deal with compiler warnings. > > The port is devel/cscope and it seems to be in a rather good shape. It > contains the newest version of cscope and it builds without any major > problems. However, when building it the compiler issues three warnings > that I could easily patch away. > > What's the recommended approach? Just ignore the warnings and don't > modify the software since it builds anyway? Or create patches even > though they don't seem to be strictly necessary? > > In any case, I will send the patches to the project in the hope that > they fix it upstream in the long run. > This is kind of your prerogative as the maintainer to do whatever you feel is right. Personally, I would usually not bother patching the port if I can easily send it upstream and they don't look like actual functional/security issues, *unless* I'm doing a version update anyways that would cause folks to rebuild the port -- then I might tack them on at the same time just so I can later point to the port and say "Hey, we've been running with these and everything is (fine / on fire)!" In any event, +1 for sending them upstream regardless. :-) ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Patch compiler warnings away?
On Thu, 1 Oct 2020 23:11:49 +0200 Moritz Schmitt wrote: > What's the recommended approach? Just ignore the warnings and don't > modify the software since it builds anyway? Or create patches even > though they don't seem to be strictly necessary? I tend to patch them away, as if they don't fix them upstream they might obscure more important warnings when building the next version. And it's neater! I should say that I usually have to deal with more than three warnings; you case is more marginal. ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Patch compiler warnings away?
Hi, I recently took over my first maintainership of a port and I have a question regarding on how to deal with compiler warnings. The port is devel/cscope and it seems to be in a rather good shape. It contains the newest version of cscope and it builds without any major problems. However, when building it the compiler issues three warnings that I could easily patch away. What's the recommended approach? Just ignore the warnings and don't modify the software since it builds anyway? Or create patches even though they don't seem to be strictly necessary? In any case, I will send the patches to the project in the hope that they fix it upstream in the long run. Best, Moritz ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
