Re: Ports failing with -fno-common with clang 9/gcc 9
On 24/06/2020 7:00 am, Kyle Evans wrote: > On Mon, Jun 22, 2020 at 1:35 AM Tobias Kortkamp wrote: >> >> On Thu, Apr 30, 2020, at 14:56, Kyle Evans wrote: >>> In any event, I would urge folks to be proactive and identify this >>> stuff, reporting issues upstream and spreading awareness of the >>> impending default change for those projects that may not already be >>> actively aware. >>> >>> On a closing note, I'm just going to kinda drop these patches here for >>> anyone that's willing/able to help make this a collective effort to >>> identify/fix/report problems here; they backport the default >>> -fno-common patch from future-LLVM11 to the base system compiler on a >>> system near you: >>> >>> HEAD: https://people.freebsd.org/~kevans/llvm-fnocommon-head.diff >> >> Can you ask for an exp-run with this patch applied? There needs >> to be a comprehensive list of failing ports for people to be able >> to work on this. We see some failing ports because of default >> -fno-common in GCC 10 [1] already. >> >> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246700 > > I can, but my only problem in doing so is that I cannot take > responsibility for following up on the issues discovered. I have some > outstanding exp-run that I've dropped the ball on, I'm a bit wobbly on > personally requesting one for this unless some group of people > can/will offer to make sure the issues are fixed so that the exp-run > can actually be completed in a reasonable timeframe. > > Thanks, > > Kyle Evans > ___ > freebsd-ports@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org" > Kyle, at best the maintainers should be advised to either: 1. add CFLAGS+=-fcommon to their problematic port's Makefile 2. pursue their respective upstream to address the issue as its going to "endemic" once clang10+ and gcc10+ become widespread. I don't see this as a problem for you alone to carry. I built all my ports using -fno-common in make.conf, and added CFLAGS+=-fcommon to the problem ports. It can be a simple fix, or you could apply the same kind of patching (llvm-fnocommon-head.diff) to gcc10+ and llvm10+ in ports to delay "the problem" being experienced for FreeBSD folk, but... (in my view, -fno-common is a good thing) PS if I had a send-pr functionality, I would've happily raised the 47 PR's (of the 1400+ ports built/used) ;) ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Ports failing with -fno-common with clang 9/gcc 9
On Mon, Jun 22, 2020 at 1:35 AM Tobias Kortkamp wrote: > > On Thu, Apr 30, 2020, at 14:56, Kyle Evans wrote: > > In any event, I would urge folks to be proactive and identify this > > stuff, reporting issues upstream and spreading awareness of the > > impending default change for those projects that may not already be > > actively aware. > > > > On a closing note, I'm just going to kinda drop these patches here for > > anyone that's willing/able to help make this a collective effort to > > identify/fix/report problems here; they backport the default > > -fno-common patch from future-LLVM11 to the base system compiler on a > > system near you: > > > > HEAD: https://people.freebsd.org/~kevans/llvm-fnocommon-head.diff > > Can you ask for an exp-run with this patch applied? There needs > to be a comprehensive list of failing ports for people to be able > to work on this. We see some failing ports because of default > -fno-common in GCC 10 [1] already. > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246700 I can, but my only problem in doing so is that I cannot take responsibility for following up on the issues discovered. I have some outstanding exp-run that I've dropped the ball on, I'm a bit wobbly on personally requesting one for this unless some group of people can/will offer to make sure the issues are fixed so that the exp-run can actually be completed in a reasonable timeframe. Thanks, Kyle Evans ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Ports failing with -fno-common with clang 9/gcc 9
On Thu, Apr 30, 2020, at 14:56, Kyle Evans wrote: > In any event, I would urge folks to be proactive and identify this > stuff, reporting issues upstream and spreading awareness of the > impending default change for those projects that may not already be > actively aware. > > On a closing note, I'm just going to kinda drop these patches here for > anyone that's willing/able to help make this a collective effort to > identify/fix/report problems here; they backport the default > -fno-common patch from future-LLVM11 to the base system compiler on a > system near you: > > HEAD: https://people.freebsd.org/~kevans/llvm-fnocommon-head.diff Can you ask for an exp-run with this patch applied? There needs to be a comprehensive list of failing ports for people to be able to work on this. We see some failing ports because of default -fno-common in GCC 10 [1] already. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246700 ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Ports failing with -fno-common with clang 9/gcc 9
On Thu, Apr 30, 2020 at 2:20 AM Dewayne Geraghty wrote: > > As -fno-common will become the default in gcc10/llvm11 per > https://lists.freebsd.org/pipermail/svn-src-stable-12/2020-April/004761.html > First- thanks! It's nice to see confirmation that the messages being written here aren't just being broadcasted to the void, doubly so when said confirmation is in the form of e-mails like this. :-) > I thought I might share the list of ports that failed to build for > maintainers to be aware of using -fno-common: > > I'm sorry this is a small list but I only use 1488 ports. Indeed, it looks like a small list, but you've just identified 42 problems to work on while only using ~5% (? based on 30,000 ports, which I know is probably low) of the ports tree. That is to say, I think this speaks to the magnitude of the issue we're dealing with here. Many will escape unscathed, but it's a good idea for everyone to start taking action *now* to identify and fix or report these so that we're not overloading our relatively small group of toolchain folks in the next ~6 months. My experience in base revealed that most of the third party software we had there was already aware of the coming change and had patches to accommodate, so: - For projects with a faster release cadence, this may be easily overcome by events - For projects with a slower release cadence, you may find patches that can be or have been backported In any event, I would urge folks to be proactive and identify this stuff, reporting issues upstream and spreading awareness of the impending default change for those projects that may not already be actively aware. On a closing note, I'm just going to kinda drop these patches here for anyone that's willing/able to help make this a collective effort to identify/fix/report problems here; they backport the default -fno-common patch from future-LLVM11 to the base system compiler on a system near you: HEAD: https://people.freebsd.org/~kevans/llvm-fnocommon-head.diff stable/12: https://people.freebsd.org/~kevans/llvm-fnocommon-12.diff **Note that FreeBSD branches earlier than these (in the past couple of weeks!) will not fully build with this patch applied:** - r360072 (head) - r360496 (stable/12) - r360494 (stable/11) Userland builds (all that's needed for most poudriere jails) should be fine in the past couple of weeks earlier than those commits, but no active releases will build with these patches applied. Folks can feel free to tag me in -fno-common related PRs if assistance is needed for any reason. Thanks, Kyle Evans ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Ports failing with -fno-common with clang 9/gcc 9
As -fno-common will become the default in gcc10/llvm11 per https://lists.freebsd.org/pipermail/svn-src-stable-12/2020-April/004761.html I thought I might share the list of ports that failed to build for maintainers to be aware of using -fno-common: archivers/arc benchmarks/iozone benchmarks/netperf databases/gdbm databases/libmemcached databases/pgpool-II-40 databases/postgresql11-client databases/postgresql11-server devel/gnustep-make devel/libunwind graphics/freeglut lang/erlang lang/gnustep-base lang/libobjc2 lang/yap-devel mail/isoqlog mail/spamilter net-mgmt/argus3 net-mgmt/argus3-clients net-mgmt/iftop net-mgmt/nagios4 net/fping net/isc-dhcp44-client net/isc-dhcp44-relay net/isc-dhcp44-server net/socat net/ss5 net/tableutil ports-mgmt/pkg security/gnupg1 security/openvas9-manager security/openvpn-auth-ldap security/ossec-hids-local security/ossec-hids-server security/snort security/suricata sysutils/LPRng sysutils/logrotate sysutils/lsof sysutils/mpiexec www/squidguard www/webalizer I'm sorry this is a small list but I only use 1488 ports. ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
