Please commit it in the meantime, I'll fix the rest shortly. Can't remember if
you have a ports bit, if not Approved :)
Thanks,
Chris
On 14 April 2014 11:59:21 BST, Stefan Esser s...@freebsd.org wrote:
Am 14.04.2014 10:25, schrieb Benjamin Podszun:
I'd say this is a bug in sshguard: Failing to start shouldn't exit
with 0.
That said, it first and foremost is a bug in the port.
Looking at the rc script and the diff [1] the problem's easy enough:
${sshguard_pidfile} is passed as parameter to -i, but isn't set in
the
script/has no default value. Either the related line from the
previous
revision should be revived or the substitution should change to use
${pidfile}, which _is_ set.
The attached diff fixes the problems in the sshguard rc file. I have
replaced occurences of ${name} with sshguard, in accordance with
newer rc script style conventions. The diff has to be applied within
the files sub-directory of the sshguard port.
The other problems of this port (see previous mail) are not fixed and
should still be addressed ...
Regards, STefan
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
