Re: Delete a port
On 4 August 2018 18:59:30 BST, Eugene Grosbein wrote: >05.08.2018 0:42, Eitan Adler wrote: > >>> Feel free to commit, but please use the absolute path to vi? >> >> Why? Would't one want to respect the user's preference when it comes >> to an editor? This preference is implicit when it comes to PATH. > >This is traditional overcautiousness against user's possibly insecure >PATH having current directory that can lead to running malignant >/tmp/vi >in multiuser environment. > >Eugene To be honest, I prefer this just so it definitely works. If you choose to set PATH to something else, so you then put a symlink to emacs... Why not just set EDITOR to emacs? I'm really not that bothered. If you want to put plain vi there, go ahead. I'm just glad you chose the correct default :) Chris -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Delete a port
Am 04.08.2018 um 17:06 schrieb René Ladan: > How about the attached patch? LGTM. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook signature.asc Description: OpenPGP digital signature
Re: Delete a port
On Sat, 4 Aug 2018 10:42:36 -0700
Eitan Adler wrote:
> On Sat, 4 Aug 2018 at 08:13, Chris Rees wrote:
> >
> > Hey,
> >
> > On 4 August 2018 15:15:23 BST, Eugene Grosbein
> > wrote:
> > >04.08.2018 21:03, Romain Tartière wrote:
> > >
> > >> On Sat, Aug 04, 2018 at 12:28:41PM +0200, Matthias Fechner
> > >> wrote:
> > >>> ./rmport: svnlog: not found
> > >>>
> > >>> Anyone an idea what is wrong?
> > >>
> > >> Never used this script, but I guess you are hitting line 390:
> > >>
> > >> | $EDITOR svnlog
> > >>
> > >> Any chance $EDITOR is not set?
> > >
> > >It seems, rmport script needs a patch:
> > >
> > >Index: Tools/scripts/rmport
> > >===
> > >--- Tools/scripts/rmport(revision 476322)
> > >+++ Tools/scripts/rmport(working copy)
> > >@@ -39,6 +39,7 @@
> > > # MAINTAINER= cr...@freebsd.org
> > > #
> > >
> > >+EDITOR=${EDITOR:-vi}
> > > PORTSDIR=${PORTSDIR:-/usr/ports}
> > > INDEX=${PORTSDIR}/`make -C ${PORTSDIR} -V INDEXFILE`
> >
> > Thanks both.
> >
> > Feel free to commit, but please use the absolute path to vi?
>
> Why? Would't one want to respect the user's preference when it comes
> to an editor? This preference is implicit when it comes to PATH.
>
>
This simply adds vi as a default; it doesn't force it to be used.
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Delete a port
05.08.2018 0:42, Eitan Adler wrote: >> Feel free to commit, but please use the absolute path to vi? > > Why? Would't one want to respect the user's preference when it comes > to an editor? This preference is implicit when it comes to PATH. This is traditional overcautiousness against user's possibly insecure PATH having current directory that can lead to running malignant /tmp/vi in multiuser environment. Eugene ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Delete a port
On Sat, 4 Aug 2018 at 08:13, Chris Rees wrote:
>
> Hey,
>
> On 4 August 2018 15:15:23 BST, Eugene Grosbein wrote:
> >04.08.2018 21:03, Romain Tartière wrote:
> >
> >> On Sat, Aug 04, 2018 at 12:28:41PM +0200, Matthias Fechner wrote:
> >>> ./rmport: svnlog: not found
> >>>
> >>> Anyone an idea what is wrong?
> >>
> >> Never used this script, but I guess you are hitting line 390:
> >>
> >> | $EDITOR svnlog
> >>
> >> Any chance $EDITOR is not set?
> >
> >It seems, rmport script needs a patch:
> >
> >Index: Tools/scripts/rmport
> >===
> >--- Tools/scripts/rmport(revision 476322)
> >+++ Tools/scripts/rmport(working copy)
> >@@ -39,6 +39,7 @@
> > # MAINTAINER= cr...@freebsd.org
> > #
> >
> >+EDITOR=${EDITOR:-vi}
> > PORTSDIR=${PORTSDIR:-/usr/ports}
> > INDEX=${PORTSDIR}/`make -C ${PORTSDIR} -V INDEXFILE`
>
> Thanks both.
>
> Feel free to commit, but please use the absolute path to vi?
Why? Would't one want to respect the user's preference when it comes
to an editor? This preference is implicit when it comes to PATH.
--
Eitan Adler
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Delete a port
Hey,
On 4 August 2018 15:15:23 BST, Eugene Grosbein wrote:
>04.08.2018 21:03, Romain Tartière wrote:
>
>> On Sat, Aug 04, 2018 at 12:28:41PM +0200, Matthias Fechner wrote:
>>> ./rmport: svnlog: not found
>>>
>>> Anyone an idea what is wrong?
>>
>> Never used this script, but I guess you are hitting line 390:
>>
>> | $EDITOR svnlog
>>
>> Any chance $EDITOR is not set?
>
>It seems, rmport script needs a patch:
>
>Index: Tools/scripts/rmport
>===
>--- Tools/scripts/rmport(revision 476322)
>+++ Tools/scripts/rmport(working copy)
>@@ -39,6 +39,7 @@
> # MAINTAINER= cr...@freebsd.org
> #
>
>+EDITOR=${EDITOR:-vi}
> PORTSDIR=${PORTSDIR:-/usr/ports}
> INDEX=${PORTSDIR}/`make -C ${PORTSDIR} -V INDEXFILE`
Thanks both.
Feel free to commit, but please use the absolute path to vi?
Chris
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Delete a port
On Sat, Aug 4, 2018 at 9:06 AM René Ladan wrote:
>
> How about the attached patch?
>
> Rene
Hi René,
You have:
+PAGER=${PAGER:-more}
svn up --quiet ports 2>&1 |${PAGER:-less}
# Adam
--
Adam Weinberger
ad...@adamw.org
https://www.adamw.org
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: Delete a port
Thanks Eugene,
Am 04.08.2018 um 16:15 schrieb Eugene Grosbein:
> It seems, rmport script needs a patch:
>
> Index: Tools/scripts/rmport
> ===
> --- Tools/scripts/rmport(revision 476322)
> +++ Tools/scripts/rmport(working copy)
> @@ -39,6 +39,7 @@
> # MAINTAINER= cr...@freebsd.org
> #
>
> +EDITOR=${EDITOR:-vi}
> PORTSDIR=${PORTSDIR:-/usr/ports}
> INDEX=${PORTSDIR}/`make -C ${PORTSDIR} -V INDEXFILE`
that fixes it for me.
Gruß
Matthias
--
"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
signature.asc
Description: OpenPGP digital signature
Re: Delete a port
On 8/4/18 4:15 PM, Eugene Grosbein wrote:
> 04.08.2018 21:03, Romain Tartière wrote:
>
>> On Sat, Aug 04, 2018 at 12:28:41PM +0200, Matthias Fechner wrote:
>>> ./rmport: svnlog: not found
>>>
>>> Anyone an idea what is wrong?
>> Never used this script, but I guess you are hitting line 390:
>>
>> | $EDITOR svnlog
>>
>> Any chance $EDITOR is not set?
> It seems, rmport script needs a patch:
>
> Index: Tools/scripts/rmport
> ===
> --- Tools/scripts/rmport(revision 476322)
> +++ Tools/scripts/rmport(working copy)
> @@ -39,6 +39,7 @@
> # MAINTAINER= cr...@freebsd.org
> #
>
> +EDITOR=${EDITOR:-vi}
> PORTSDIR=${PORTSDIR:-/usr/ports}
> INDEX=${PORTSDIR}/`make -C ${PORTSDIR} -V INDEXFILE`
How about the attached patch?
Rene
Index: Tools/scripts/rmport
===
--- Tools/scripts/rmport (revision 476346)
+++ Tools/scripts/rmport (working copy)
@@ -45,9 +45,13 @@
TODAY=`date -u -v+0d +%Y-%m-%d`
SED="sed -i .orig -E"
-# use ~/.ssh/config to set up the desired username if different than $LOGNAME
+# use ~/.ssh/config to set up the desired username if different than ${LOGNAME}
SVNREPO=${SVNREPO:-svn+ssh://repo.FreeBSD.org/ports}
+# set some default values
+EDITOR=${EDITOR:-vi}
+PAGER=${PAGER:-more}
+
if ! CDIFF=$(which cdiff) ; then
CDIFF=${PAGER}
fi
@@ -275,7 +279,7 @@
port=${2}
log "${cat}/${port}: getting ${cat}/Makefile and port's files from repository"
- svn up --depth empty ports/${cat} ports/$cat/Makefile
+ svn up --depth empty ports/${cat} ports/${cat}/Makefile
svn up ports/${cat}/${port}
}
@@ -387,7 +391,7 @@
log "running svn update"
svn up --quiet ports 2>&1 |${PAGER:-less}
- $EDITOR svnlog
+ ${EDITOR} svnlog
answer=`ask "do you want to commit?"`
signature.asc
Description: OpenPGP digital signature
Re: Delete a port
04.08.2018 21:03, Romain Tartière wrote:
> On Sat, Aug 04, 2018 at 12:28:41PM +0200, Matthias Fechner wrote:
>> ./rmport: svnlog: not found
>>
>> Anyone an idea what is wrong?
>
> Never used this script, but I guess you are hitting line 390:
>
> | $EDITOR svnlog
>
> Any chance $EDITOR is not set?
It seems, rmport script needs a patch:
Index: Tools/scripts/rmport
===
--- Tools/scripts/rmport(revision 476322)
+++ Tools/scripts/rmport(working copy)
@@ -39,6 +39,7 @@
# MAINTAINER= cr...@freebsd.org
#
+EDITOR=${EDITOR:-vi}
PORTSDIR=${PORTSDIR:-/usr/ports}
INDEX=${PORTSDIR}/`make -C ${PORTSDIR} -V INDEXFILE`
signature.asc
Description: OpenPGP digital signature
Re: Delete a port
On Sat, Aug 04, 2018 at 12:28:41PM +0200, Matthias Fechner wrote: > ./rmport: svnlog: not found > > Anyone an idea what is wrong? Never used this script, but I guess you are hitting line 390: | $EDITOR svnlog Any chance $EDITOR is not set? -- Romain Tartière http://people.FreeBSD.org/~romain/ pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F) (plain text =non-HTML= PGP/GPG encrypted/signed e-mail much appreciated) signature.asc Description: PGP signature
Re: Delete a port I maintain
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wednesday 07 October 2009 05:15:00 Eitan Adler wrote: The upstream author no longer maintains this port and I don't have the time to fix it. This port could be removed from the ports tree. portname: hebrew/geresh broken because: needs update for the new fribidi paragraph API build errors: http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/e.6.2009081417/iw -geresh-0.6.3_1.log (_Aug_23_08:41:05_UTC_2009) overview: http://portsmon.FreeBSD.org/portoverview.py?category=hebrewamp;portname=ge resh Done PRs are preferred :) Thomas - -- Thomas Abthorpe | FreeBSD Committer tabtho...@freebsd.org | http://people.freebsd.org/~tabthorpe -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.13 (FreeBSD) iEYEARECAAYFAkrN4GkACgkQ5Gm/jNBp8qB3nACfThipxycOY4HPdD4abR6Msgpy zXYAn0wQHlUmB9pF5qk95DcwtLzfMrLv =eCSV -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
