Re: Fping with WITH_IPV6=YES
On Sat, Jun 4, 2011 at 9:24 PM, Jason Hellenthal jh...@dataix.net wrote:
And if I might suggest, remove the old ifdef and replace with ...
pre-extract:
.if defined(WITH_IPV6)
.undef WITH_IPV6
@${ECHO_MSG}
*
@${ECHO_MSG} *** IPV6 IS NOT ENABLED FOR net/fping, IT DOES NOT WORK WITH
IPV4 ***
@${ECHO_MSG} *** PLEASE SEE/USE net/fping+ipv6 INSTEAD
***
@${ECHO_MSG} *** THESE PORTS CAN CO-EXIST TOGETHER AND BOTH BE INSTALLED
***
@${ECHO_MSG}
*
@sleep 10
.endif
I would suggest the following changes for net/fping:
- remove the ipv6 category from net/fping, since it is ipv4 only.
Change comment to:
COMMENT=Quickly ping N hosts w/o flooding the network - IPv4 Only
version
- Remove this define from the ports Makefile:
.if defined(WITH_IPV6)
# IPv6 not enabled by default, as it does not work together with IPv4.
CFLAGS+=-DIPV6
.endif
I also noticed that the net/fping includes a source address patch
(net/fping/files/patch-sourceaddr) that is missing in the
net/fping+ipv6 port. The patch seems to support both ipv4 or ipv6
depending on if IPV6 is defined.
Scot
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Fping with WITH_IPV6=YES
Thank you! And if I need IPV6 I'll use /usr/ports/net/fping+ipv6. IPv6 not enabled by default, as it does not work together with IPv4. I think it better to put this to pkg-message. 2011/6/3 Yuri Pankov yuri.pan...@gmail.com On Fri, Jun 03, 2011 at 05:57:44PM +0400, Pavel Timofeev wrote: Is it normal that /usr/ports/net/fping doesn't work correct if you have WITH_IPV6=YES in /etc/make.conf? Port's Makefile has the following comment: # IPv6 not enabled by default, as it does not work together with IPv4. and looking at the code, it seems that fping can use either ipv6 or ipv4 but not both (see the #if(n)def's in the code). With -DWITH_IPV6: $ fping 192.168.1.4 192.168.1.252 fping: hostname nor servname provided, or not known $ fping 2001:470:28:4ba:89c1:323b:9032:86ea \ 2001:470:28:4ba:4a5b:39ff:feb3:b824 2001:470:28:4ba:89c1:323b:9032:86ea is alive 2001:470:28:4ba:4a5b:39ff:feb3:b824 is alive Without -DWITH_IPV6: $ fping 192.168.1.4 192.168.1.252 192.168.1.4 is alive 192.168.1.252 is alive $ fping 2001:470:28:4ba:89c1:323b:9032:86ea \ 2001:470:28:4ba:4a5b:39ff:feb3:b824 2001:470:28:4ba:89c1:323b:9032:86ea address not found 2001:470:28:4ba:4a5b:39ff:feb3:b824 address not found HTH, Yuri ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Fping with WITH_IPV6=YES
Pavel Timofeev writes: Thank you! And if I need IPV6 I'll use /usr/ports/net/fping+ipv6. IPv6 not enabled by default, as it does not work together with IPv4. I think it better to put this to pkg-message. I would rather know this before actually building; perhaps in pkg-descr and/or displayed via the pre-fetch make target? Robert Huff ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Fping with WITH_IPV6=YES
On Jun 4, 2011, at 11:49 AM, Robert Huff wrote: Pavel Timofeev writes: Thank you! And if I need IPV6 I'll use /usr/ports/net/fping+ipv6. IPv6 not enabled by default, as it does not work together with IPv4. I think it better to put this to pkg-message. I would rather know this before actually building; perhaps in pkg-descr and/or displayed via the pre-fetch make target? I'd love to see someone just fixing it. It cannot be too hard. -- Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Fping with WITH_IPV6=YES
Bjoern A. Zeeb writes: I'd love to see someone just fixing it. It cannot be too hard. Do we have a volunteer? :-) Robert Huff ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Fping with WITH_IPV6=YES
On Fri, Jun 03, 2011 at 05:57:44PM +0400, Pavel Timofeev wrote: Is it normal that /usr/ports/net/fping doesn't work correct if you have WITH_IPV6=YES in /etc/make.conf? Port's Makefile has the following comment: # IPv6 not enabled by default, as it does not work together with IPv4. and looking at the code, it seems that fping can use either ipv6 or ipv4 but not both (see the #if(n)def's in the code). With -DWITH_IPV6: $ fping 192.168.1.4 192.168.1.252 fping: hostname nor servname provided, or not known $ fping 2001:470:28:4ba:89c1:323b:9032:86ea \ 2001:470:28:4ba:4a5b:39ff:feb3:b824 2001:470:28:4ba:89c1:323b:9032:86ea is alive 2001:470:28:4ba:4a5b:39ff:feb3:b824 is alive Without -DWITH_IPV6: $ fping 192.168.1.4 192.168.1.252 192.168.1.4 is alive 192.168.1.252 is alive $ fping 2001:470:28:4ba:89c1:323b:9032:86ea \ 2001:470:28:4ba:4a5b:39ff:feb3:b824 2001:470:28:4ba:89c1:323b:9032:86ea address not found 2001:470:28:4ba:4a5b:39ff:feb3:b824 address not found HTH, Yuri pgpH05Me42iRt.pgp Description: PGP signature
