Re: dspam install
On Thu, 15 Jul 2010 15:52:45 -0700 (PDT) Doug Barton do...@freebsd.org wrote: On Thu, 15 Jul 2010, David DEMELIER wrote: I'm writing a brand new mail/dspam port from scratch, if I finally finish it in the next fews days I will show you. The only problem I have for now is that there is no WITH_CYRUS_VER like variable so I can't make a per-user defined variable for which cyrus version to install. Sure you can, you just won't have it all handed to you on a silver platter. :) For example, look at how mail/alpine handles the selection of speller. I am away right now, and with very bad abd random net access. I'm afraid anything will have to wait until I get back, at the end of the month. Thanks for your work. -- Ion-Mihai Tetcu io...@tetcu.info ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
On Thu, 15 Jul 2010 22:50:32 +0200
David DEMELIER demelier.da...@gmail.com wrote:
2010/7/14 Sahil Tandon sa...@freebsd.org:
[mail/dspam maintainer Cc:'d]
On Tue, 2010-07-13 at 09:46:04 +0200, David DEMELIER wrote:
2010/7/13 Sahil Tandon sa...@freebsd.org:
On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote:
.if defined(WITH_MYSQL)
WANT_MYSQL_VER= 55 ...
.endif
Then if the user wants a different version he still can change using :
WITH_MYSQL_VER= 44.
That change by itself will not work because in bsd.database.mk:
.if defined(WITH_MYSQL_VER) ${WITH_MYSQL_VER} != ${WANT_MYSQL_VER}
IGNORE= ...
Then, explain me why do both php5 and php5-pgsql have not
KNOBS/OPTIONS like dspam and work with this variable WITH_PGSQL_VER ?
This is a good opportunity for you to learn about how the ports system
works. Compare the contents of both ports and also review
bsd.database.mk; if, after that, you still do not understand the current
behavior, let us know.
For short, it's like this because it (AFAIR) not all what we have now
in the framework we had back when I worte the port, and because I
wanted to also be able to depend on the server.
--
Ion-Mihai Tetcu io...@tetcu.info
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
2010/7/14 Sahil Tandon sa...@freebsd.org:
[mail/dspam maintainer Cc:'d]
On Tue, 2010-07-13 at 09:46:04 +0200, David DEMELIER wrote:
2010/7/13 Sahil Tandon sa...@freebsd.org:
On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote:
.if defined(WITH_MYSQL)
WANT_MYSQL_VER= 55 ...
.endif
Then if the user wants a different version he still can change using :
WITH_MYSQL_VER= 44.
That change by itself will not work because in bsd.database.mk:
.if defined(WITH_MYSQL_VER) ${WITH_MYSQL_VER} != ${WANT_MYSQL_VER}
IGNORE= ...
Then, explain me why do both php5 and php5-pgsql have not
KNOBS/OPTIONS like dspam and work with this variable WITH_PGSQL_VER ?
This is a good opportunity for you to learn about how the ports system
works. Compare the contents of both ports and also review
bsd.database.mk; if, after that, you still do not understand the current
behavior, let us know.
I'm writing a brand new mail/dspam port from scratch, if I finally
finish it in the next fews days I will show you. The only problem I
have for now is that there is no WITH_CYRUS_VER like variable so I
can't make a per-user defined variable for which cyrus version to
install.
Because I meant, if someone made these KNOBS, that's would suppose
they should be used. As shown just above it works with php5-pgsql.
So if a variable could be used to specify a specific version, it must
be used instead of a couple of option that set the package version. I
think WITH_MYSQL_VER and WITH_PGSQL_VER were made for that. (There is
one for apache too)
I appreciate your frustration, but please realize that there are often
many ways to accomplish the same task. Trade-offs are involved. If you
believe a port can be improved, please (and now I'm repeating myself)
submit a patch! If you are unable to create a patch, then clearly
explain your idea in pseudo-code and submit it as a PR for the
maintainer's consideration. If you have trouble creating a patch, also
feel free to ping me off-list; I'm happy to work with you on this.
We must make a big KISS cleanup in the ports tree to make it as good
as NetBSD' pkgsrc.
Please send PRs or provide specific details; general comments like the
above are not helpful.
Yes sometime I'm nasty with people, I'm sorry about that but when I
saw this port I just didn't understand.
What did you not understand?
I apologize for my english.
No apology needed, as that is not the problem here.
--
Sahil Tandon sa...@freebsd.org
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
--
Demelier David
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
Sahil Tandon wrote: [mail/dspam maintainer Cc:'d] On Tue, 2010-07-13 at 09:46:04 +0200, David DEMELIER wrote: 2010/7/13 Sahil Tandon sa...@freebsd.org: On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote: Yes sometime I'm nasty with people, I'm sorry about that but when I saw this port I just didn't understand. What did you not understand? I apologize for my english. No apology needed, as that is not the problem here. my own ports confusion (in general) is that in some ports you use a -Dxx to define a required (or not required) option while in others (at least dspam) you use WITHOUT_xxx or WITH_xxx=1. It would be nice if all ports has the same standard of definitions. Or... am I confused? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
2010/7/14 Jim Pazarena fpo...@paz.bz: Sahil Tandon wrote: [mail/dspam maintainer Cc:'d] On Tue, 2010-07-13 at 09:46:04 +0200, David DEMELIER wrote: 2010/7/13 Sahil Tandon sa...@freebsd.org: On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote: Yes sometime I'm nasty with people, I'm sorry about that but when I saw this port I just didn't understand. What did you not understand? I apologize for my english. No apology needed, as that is not the problem here. my own ports confusion (in general) is that in some ports you use a -Dxx to define a required (or not required) option while in others (at least dspam) you use WITHOUT_xxx or WITH_xxx=1. It would be nice if all ports has the same standard of definitions. Or... am I confused? If FreeBSD people agree, KNOBS will be removed in the future (but this will take a long long time). -- Demelier David ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Pazarena wrote: Sahil Tandon wrote: [mail/dspam maintainer Cc:'d] On Tue, 2010-07-13 at 09:46:04 +0200, David DEMELIER wrote: 2010/7/13 Sahil Tandon sa...@freebsd.org: On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote: Yes sometime I'm nasty with people, I'm sorry about that but when I saw this port I just didn't understand. What did you not understand? I apologize for my english. No apology needed, as that is not the problem here. my own ports confusion (in general) is that in some ports you use a -Dxx to define a required (or not required) option while in others (at least dspam) you use WITHOUT_xxx or WITH_xxx=1. It would be nice if all ports has the same standard of definitions. Or... am I confused? I don't know of any ports that use -Dxxx to specify options at the port level. If the port Makefile uses an OPTIONS= variable, then it will use WITH_xxx and WITHOUT_xxx to check the option values. You can also use WITH_xxx and WITHOUT_xxx checks without defining OPTIONS. It's possible that a port Makefile could do something like this: .if defined(WITH_FOOBAR) CFLAGS+=-DHAVE_FOOBAR_H .endif In this case, the -Dxxx option is specific to the application configuration and/or build system, but not part of the ports infrastructure. Hope that helps, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/sourcehosting/ - Follow me, follow you -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iD8DBQFMPeoB0sRouByUApARAib8AKCxHFtzNdvWmptZRiyjTY/BD39nNQCgpgnB hbE7yT1lBq5OrbwIgaCifYA= =uIbz -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
On Wed, 14 Jul 2010, Jim Pazarena wrote: my own ports confusion (in general) is that in some ports you use a -Dxx to define a required (or not required) option while in others (at least dspam) you use WITHOUT_xxx or WITH_xxx=1. It would be nice if all ports has the same standard of definitions. Or... am I confused? The two methods have the same result. For example: cd /usr/ports/editors/openoffice.org-3 make -V WITHOUT_MOZILLA Shows nothing, since that variable is undefined by default. Using -D tells make to define it, which it does by setting it to 1: make -DWITHOUT_MOZILLA -V WITHOUT_MOZILLA 1 Manually setting the variable to a value also defines it: make WITHOUT_MOZILLA=1 -V WITHOUT_MOZILLA 1 make WITHOUT_MOZILLA=yes -V WITHOUT_MOZILLA yes The Makefiles usually only care about whether a WITH_ variable has been defined, not the actual value, so the result is the same. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
2010/7/13 Sahil Tandon sa...@freebsd.org:
On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote:
.if defined(WITH_MYSQL)
WANT_MYSQL_VER= 55 ...
.endif
Then if the user wants a different version he still can change using :
WITH_MYSQL_VER= 44.
That change by itself will not work because in bsd.database.mk:
.if defined(WITH_MYSQL_VER) ${WITH_MYSQL_VER} != ${WANT_MYSQL_VER}
IGNORE= ...
Then, explain me why do both php5 and php5-pgsql have not
KNOBS/OPTIONS like dspam and work with this variable WITH_PGSQL_VER ?
$ pwd
/usr/ports/databases/php5-pgsql
$ WITH_PGSQL_VER=83 make all-depends-list
/usr/ports/lang/php5
[...]
/usr/ports/databases/postgresql83-client
[...]
$ WITH_PGSQL_VER=84 make all-depends-list
/usr/ports/lang/php5
[...]
/usr/ports/databases/postgresql84-client
[...]
Why don't keep it simple and simple?
I am not sure what you mean. Complexity is not a goal of the project.
If you have an idea that does not forfeit existing functionality or
violate POLA, please submit it as a patch.
And why don't use things how they should be used?
Once again, I am confused by your question. Please clarify your
meaning.
Because I meant, if someone made these KNOBS, that's would suppose
they should be used. As shown just above it works with php5-pgsql.
So if a variable could be used to specify a specific version, it must
be used instead of a couple of option that set the package version. I
think WITH_MYSQL_VER and WITH_PGSQL_VER were made for that. (There is
one for apache too)
I think there is still a lot of problems in many ports.
I think we all agree that there is room for improvement. Since you have
identified many problems, I look forward to your PRs.
We must make a big KISS cleanup in the ports tree to make it as good
as NetBSD' pkgsrc.
Please send PRs or provide specific details; general comments like the
above are not helpful.
Yes sometime I'm nasty with people, I'm sorry about that but when I
saw this port I just didn't understand.
I apologize for my english.
--
Demelier David
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
On Mon, 2010-07-12 at 21:28:56 +0200, David DEMELIER wrote:
.if defined(WITH_MYSQL)
WANT_MYSQL_VER= 55 ...
.endif
Then if the user wants a different version he still can change using :
WITH_MYSQL_VER= 44.
That change by itself will not work because in bsd.database.mk:
.if defined(WITH_MYSQL_VER) ${WITH_MYSQL_VER} != ${WANT_MYSQL_VER}
IGNORE= ...
Why don't keep it simple and simple?
I am not sure what you mean. Complexity is not a goal of the project.
If you have an idea that does not forfeit existing functionality or
violate POLA, please submit it as a patch.
And why don't use things how they should be used?
Once again, I am confused by your question. Please clarify your
meaning.
I think there is still a lot of problems in many ports.
I think we all agree that there is room for improvement. Since you have
identified many problems, I look forward to your PRs.
We must make a big KISS cleanup in the ports tree to make it as good
as NetBSD' pkgsrc.
Please send PRs or provide specific details; general comments like the
above are not helpful.
--
Sahil Tandon sa...@freebsd.org
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: dspam install
On Sun, 2010-07-11 at 13:51:51 -0700, Jim Pazarena wrote: tried to make mail/dspam and it exits nagging that it requires MySQL 5.0 client, where I have MySQL 5.1 Is there a way to convince the dspam routine that 5.1 is acceptable? (presuming that it IS). Yes, 'make config' and choose MYSQL51 (MYSQL50 is the default). Or: % make WITH_MYSQL51=1 WITHOUT_MYSQL50=1 -- Sahil Tandon sa...@freebsd.org ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
