Re: portmaster: printing messages that do not come from pkg-message files
2010/1/2 Nikola Lečić nikola.le...@anthesphoria.net: Hello, portmaster's feature to print collected pkg-message files after successful installation is very useful. However, there are many ports that echo messages from inside Makefile, usually in post-install phase (but not exclusively there). A simple question: would it be possible (or better, would it be desirable) to collect that text as well and to include it in the final output in the same way it is done with pkg-messages? Hi, It's better to correct these ports to make them use pkg-message, so it will be printed by portmaster *and* pkg_add (dont forget packages !) Best, Julien ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: portmaster: printing messages that do not come from pkg-message files
On Sat 02 Jan 2010 at 09:14:11 PST Julien Laffaye wrote: 2010/1/2 Nikola Le??i?? nikola.le...@anthesphoria.net: Hello, portmaster's feature to print collected pkg-message files after successful installation is very useful. However, there are many ports that echo messages from inside Makefile, usually in post-install phase (but not exclusively there). A simple question: would it be possible (or better, would it be desirable) to collect that text as well and to include it in the final output in the same way it is done with pkg-messages? Hi, It's better to correct these ports to make them use pkg-message, so it will be printed by portmaster *and* pkg_add (dont forget packages !) Sometimes whether a message is echoed depends on a knob. The porter's handbook includes examples of this. Is there a way to get the same effect with pkg-messages? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: portmaster: printing messages that do not come from pkg-message files
On Sat, Jan 02, 2010 at 01:11:38PM -0800, Charlie Kester wrote: On Sat 02 Jan 2010 at 09:14:11 PST Julien Laffaye wrote: 2010/1/2 Nikola Le??i?? nikola.le...@anthesphoria.net: Hello, portmaster's feature to print collected pkg-message files after successful installation is very useful. However, there are many ports that echo messages from inside Makefile, usually in post-install phase (but not exclusively there). A simple question: would it be possible (or better, would it be desirable) to collect that text as well and to include it in the final output in the same way it is done with pkg-messages? Hi, It's better to correct these ports to make them use pkg-message, so it will be printed by portmaster *and* pkg_add (dont forget packages !) Sometimes whether a message is echoed depends on a knob. The porter's handbook includes examples of this. Is there a way to get the same effect with pkg-messages? See devel/git for an example of displaying pkg-message depending upon a knob. I'm sure with a bit of creativity you could display only a portion of pkg-message depending upon a knob. -- WXS ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: portmaster: printing messages that do not come from pkg-message files
Nikola Lečić wrote: Hello, portmaster's feature to print collected pkg-message files after successful installation is very useful. However, there are many ports that echo messages from inside Makefile, usually in post-install phase (but not exclusively there). A simple question: would it be possible (or better, would it be desirable) to collect that text as well and to include it in the final output in the same way it is done with pkg-messages? In a word, no. :) Random messages emitted by the port at random points in the process are evil (well, usually they are evil), and should not be encouraged. Messages related to build choices should be handled by OPTIONS, information that the user needs after the port is installed should be handled in the pkg-message. Portmaster has support for both of those. If you have something specific in mind, or specific examples of a port that emits something meaningful I'll be glad to take another look, but as a general principle my opinion is that using the established mechanisms is the better route to take. Doug PS, I'm glad you find the pkg-message feature useful. :) -- Improve the effectiveness of your Internet presence with a domain name makeover!http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: portmaster: printing messages that do not come from pkg-message files
On Sat 02 Jan 2010 at 13:32:05 PST Wesley Shields wrote: On Sat, Jan 02, 2010 at 01:11:38PM -0800, Charlie Kester wrote: Sometimes whether a message is echoed depends on a knob. The porter's handbook includes examples of this. Is there a way to get the same effect with pkg-messages? See devel/git for an example of displaying pkg-message depending upon a knob. I'm sure with a bit of creativity you could display only a portion of pkg-message depending upon a knob. Thanks. I just checked the handbook again and couldn't find the examples I thought I had seen there. I'll take a look at devel/git. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: portmaster: printing messages that do not come from pkg-message files
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 On Sat, 02 Jan 2010 13:41:25 -0800 in 4b3fbd85.9090...@freebsd.org Doug Barton do...@freebsd.org wrote: Nikola Lečić wrote: Hello, portmaster's feature to print collected pkg-message files after successful installation is very useful. However, there are many ports that echo messages from inside Makefile, usually in post-install phase (but not exclusively there). A simple question: would it be possible (or better, would it be desirable) to collect that text as well and to include it in the final output in the same way it is done with pkg-messages? In a word, no. :) Random messages emitted by the port at random points in the process are evil (well, usually they are evil), and should not be encouraged. I see. I asked because the practice to emit such messages seems to be widespread and I cannot find any place where the Porters Handbook discourages it -- correct me if I am wrong. Messages related to build choices should be handled by OPTIONS, information that the user needs after the port is installed should be handled in the pkg-message. Portmaster has support for both of those. Yes, but port messages often tells what could have been done differently _before_; see below. If you have something specific in mind, or specific examples of a port that emits something meaningful I'll be glad to take another look, but as a general principle my opinion is that using the established mechanisms is the better route to take. editors/openoffice.org-*: the ports emit a lot of important info through files/Makefile.knobs; it would be nice to have these messages printed after the build; they are not about what should be done after the install, but about what *could* be done differently. multimedia/mplayer: the same thing, two important messages that should not be lost somewhere in a huge build log. net/quagga: big pre-everything and crucial post-install info. security/stunnel: again, crucial post-install info. databases/mysql60-server: everything that is important is echoed in advance. devel/tmake: an example of short post-install message -- is it worth adding pkg-message instead? Also, lang/php_doc www/apache22 www/moinmoin mail/squirrelmail Finally, not that important, but some my own ports have Makefile messages: textproc/scim-kmfl-imengine in pre-patch and other scim-kmfl-* ports in post-install; I never met any resistance by any committer in regard to that fact. I understand that these things could be handled by OPTIONS and pkg_message, but this is not the case. So, if this behaviour is considered definitely bad, maybe maintainers should be called to gradually adapt their ports accordingly (as Julien Laffaye suggested in his reply and as it was done in the past, e.g. for adding more DESKTOP_ENTRIES)? PS, I'm glad you find the pkg-message feature useful. :) Indeed, among many others. :-) Best wishes, - -- Nikola Lečić = Никола Лечић fingerprint : FEF3 66AF C90E EDC3 D878 7CDC 956D F4AB A377 1C9B -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.11 (FreeBSD) iJwEAQEDAAYFAks/33IACgkQ/MM/0rYIoZgs5wQAqtZw+Eo202UROBisv3cAQZTR ee7GbA+JTQ9UphbMhWQ+M65S2fysr+1Lo2VrE0RZ9QGWGQQXxljsbqFQXLOGzd2J mnwJypW8xHbB+10mA2xJ7HgFDtIV1yc3dsgU1wAK96OF4zWsaz/BLMUG/TSJM9Gb vfiVootdRYyhqzET10c= =oqBc -END PGP SIGNATURE- ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
