Redports, broken regression tests and missing check-orphans

2014-08-13 Thread Vitaly Magerya
Bernhard, while we're at it, there are currently two problems with 
redports which diminish it's usefulness significantly:


1. Redports used to run make regression-test on every build; right 
now, each log has this instead:


phase 5: make test
[: -eq: unexpected operator
=== Regression tests skipped. ===


So, no regression tests are executed. I don't know what the problem is here.

2. Most ports now have stage support; this means that checking for 
leftover files under ${PREFIX} is close to useless: only files in 
pkg-plist are copied there. Instead, leftovers should be searched for in 
${STAGEDIR} -- running make stage-qa and make check-orphans with 
every build would do that.


(I've already botched two patches when I assumed that successful 
redports run means that pkg-plist is complete).


So, can the first problem be fixed and the second suggestion 
implemented? Should I be bothering tinderbox author(s) instead?

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: Redports, broken regression tests and missing check-orphans

2014-08-13 Thread Bernhard Fröhlich
Am 13.08.2014 12:10 schrieb Vitaly Magerya vmage...@gmail.com:

 Bernhard, while we're at it, there are currently two problems with
redports which diminish it's usefulness significantly:

 1. Redports used to run make regression-test on every build; right now,
each log has this instead:

 phase 5: make test
 [: -eq: unexpected operator
 === Regression tests skipped. ===
 

 So, no regression tests are executed. I don't know what the problem is
here.

 2. Most ports now have stage support; this means that checking for
leftover files under ${PREFIX} is close to useless: only files in pkg-plist
are copied there. Instead, leftovers should be searched for in ${STAGEDIR}
-- running make stage-qa and make check-orphans with every build would
do that.

 (I've already botched two patches when I assumed that successful redports
run means that pkg-plist is complete).

 So, can the first problem be fixed and the second suggestion implemented?
Should I be bothering tinderbox author(s) instead?

I am not sure where the first issue is coming from but the second is
definitely a tinderbox task. We are asking for tinderbox staging and modern
leftover checks for some time already. I am working on a poudriere
migration but it's quite a moving target and it requires quite a bit of
work.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org