Re: Request for new port review: TortoiseHG.
I've updated port. The only thing left - setting dependency on py-gobject by USE_GNOME variable. But if i run pkg_info -f on installed port, i see: Dependency: py26-gobject-2.26.0 dependency origin: devel/py-gobject So, maybe this dependency is implicit and i should not care? Updated port can be obtained here: http://intara.org.ru/tortoisehg1.shar or from attachment. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote:
I've updated port. The only thing left - setting dependency on py-gobject by
USE_GNOME variable.
But if i run pkg_info -f on installed port, i see:
Dependency: py26-gobject-2.26.0
dependency origin: devel/py-gobject
So, maybe this dependency is implicit and i should not care?
Obviously USE_GNOME does not support devel/py-gobject now. All you can
do is to use BUILD_DEPENDS/RUN_DEPENDS.
Your pkg_info result indicates that you've installed gobject, but it
means nothing to users of this port. The ports infrastructure generates
dependency list according to the Makefile. If py-gobject is required,
add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will
not be installed.
Updated port can be obtained here:
http://intara.org.ru/tortoisehg1.shar
or from attachment.
Some comments:
- PORTNAME can be different with the path. PORTNAME=tortoisehg is OK.
- We usually use USE_PYTHON=yes
- It would be better to keep patches in *-patch: targets.
Move ${REINPLACE_CMD} actions to post-patch:.
- If this port does not need to run configure or so. Use
do-configure:
@${DO_NADA}
Regards,
--
Sunpoet Po-Chuan Hsieh sunpoet at sunpoet.net sunpoet at FreeBSD.org
4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Thu, Feb 10, 2011 at 5:35 PM, Sunpoet Po-Chuan Hsieh sunp...@freebsd.org
wrote:
On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote:
I've updated port. The only thing left - setting dependency on py-gobject
by
USE_GNOME variable.
But if i run pkg_info -f on installed port, i see:
Dependency: py26-gobject-2.26.0
dependency origin: devel/py-gobject
So, maybe this dependency is implicit and i should not care?
Obviously USE_GNOME does not support devel/py-gobject now. All you can
do is to use BUILD_DEPENDS/RUN_DEPENDS.
Your pkg_info result indicates that you've installed gobject, but it
means nothing to users of this port. The ports infrastructure generates
dependency list according to the Makefile. If py-gobject is required,
add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will
not be installed.
Updated port can be obtained here:
http://intara.org.ru/tortoisehg1.shar
or from attachment.
Some comments:
- PORTNAME can be different with the path. PORTNAME=tortoisehg is OK.
- We usually use USE_PYTHON=yes
- It would be better to keep patches in *-patch: targets.
Move ${REINPLACE_CMD} actions to post-patch:.
- If this port does not need to run configure or so. Use
do-configure:
@${DO_NADA}
Regards,
Done.
How should i submit new port? Open an PR?
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
How should i submit new port? Open an PR? There are two easy ways to submit the port. The first is to use send-pr(1) or the web base form to submit the problem report. Please make sure to submit it as a shar and use the change-request option. The second way does the above for you. Install ports-mgmt/porttools and run port submit. Of course you should run port test first :-) -- Eitan Adler ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Thu, 2011-02-10 at 18:21 +0300, arrowdodger wrote:
On Thu, Feb 10, 2011 at 5:35 PM, Sunpoet Po-Chuan Hsieh sunp...@freebsd.org
wrote:
On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote:
I've updated port. The only thing left - setting dependency on py-gobject
by
USE_GNOME variable.
But if i run pkg_info -f on installed port, i see:
Dependency: py26-gobject-2.26.0
dependency origin: devel/py-gobject
So, maybe this dependency is implicit and i should not care?
Obviously USE_GNOME does not support devel/py-gobject now. All you can
do is to use BUILD_DEPENDS/RUN_DEPENDS.
There is now a pygobject USE_GNOME switch.
-Koop
Your pkg_info result indicates that you've installed gobject, but it
means nothing to users of this port. The ports infrastructure generates
dependency list according to the Makefile. If py-gobject is required,
add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will
not be installed.
Updated port can be obtained here:
http://intara.org.ru/tortoisehg1.shar
or from attachment.
Some comments:
- PORTNAME can be different with the path. PORTNAME=tortoisehg is OK.
- We usually use USE_PYTHON=yes
- It would be better to keep patches in *-patch: targets.
Move ${REINPLACE_CMD} actions to post-patch:.
- If this port does not need to run configure or so. Use
do-configure:
@${DO_NADA}
Regards,
Done.
How should i submit new port? Open an PR?
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Tue, Feb 8, 2011 at 9:29 PM, Sunpoet Hsieh sunp...@sunpoet.net wrote:
Hi,
First of all, I suggest to set PORTNAME=tortoisehg
If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=-hgtk
instead.
It makes portlint happier.
It also simplifies Makefile since DISTNAME is already the default value.
Well, i added -hgtk because TortoiseHG 2.0 (which will be released at March)
will be using PyQT, but current GTK version will be supported as long as it
is used. So, user will be able to choose between hgtk if he prefers GTK or
pyqt if he likes Qt. It is not an option for a port, but two different
programs and they can be installed simultaneously.
Maybe the port itself should be called tortoisehg-hgtk?
In your case, it can be done without extra patch files.
.if !defined(WITH_NAUTILUS)
@${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP}
.endif
.if !defined(WITH_NLS)
@${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP}
.endif
That's definetely nicer than any patches.
Here, I suggest a shorter option name NAUTILUS instead of
NAUTILUS_EXTENSION.
Also, for PLIST_SUB, I think NLS is OK for most ports.
.if !defined(WITH_NLS)
PLIST_SUB+= NLS=@comment
.else
PLIST_SUB+= NLS=
.endif
Will do.
2. The port also installs *.egg-info file and i'm not sure how to include
it
in the plist.
You should set PYDISTUTILS_EGGINFO=egg-info files.
bsd.python.mk will add them to PLIST automatically.
PYDISTUTILS_EGGINFO defaults to tortoisehg-1.1.9.1-py2.6.egg-info.
(when PORTNAME=tortoisehg)
What if PORTNAME!=tortoisehg? I mean, if i'm setting PYDISTUTILS_EGGINFO,
where should i obtain that -py2.6- part?
On Tue, Feb 8, 2011 at 10:11 PM, Eitan Adler li...@eitanadler.com wrote:
Hi,
Congrats on your first attempt! Here are a few issues with the port.
Please don't take them personally.
1) install port-mgmt/portlint and run it on your port (portlint -CN)
it will point out a lot of things
2) The preferred format for new ports is a shar - not a .tar.gz file
3) It is not newline terminated
4) the .egg-info files should not be included in the pkg-plist
5) replace @dirrm lib/nautilus with @dirrmtry lib/nautilus because
your port does not directly create this directories
Ok.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Wed, Feb 9, 2011 at 5:15 PM, arrowdodger 6year...@gmail.com wrote:
On Tue, Feb 8, 2011 at 9:29 PM, Sunpoet Hsieh sunp...@sunpoet.net wrote:
Hi,
First of all, I suggest to set PORTNAME=tortoisehg
If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=-hgtk
instead.
It makes portlint happier.
It also simplifies Makefile since DISTNAME is already the default value.
Well, i added -hgtk because TortoiseHG 2.0 (which will be released at March)
will be using PyQT, but current GTK version will be supported as long as it
is used. So, user will be able to choose between hgtk if he prefers GTK or
pyqt if he likes Qt. It is not an option for a port, but two different
programs and they can be installed simultaneously.
Maybe the port itself should be called tortoisehg-hgtk?
It looks like you'll have two ports, version 1 and 2, and these two
ports do not conflict with each other.
IMHO, I would simply use devel/tortoisehg1 for version 1 and
devel/tortoisehg for upcoming version 2.
You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK or Qt.
In your case, it can be done without extra patch files.
.if !defined(WITH_NAUTILUS)
@${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP}
.endif
.if !defined(WITH_NLS)
@${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP}
.endif
That's definetely nicer than any patches.
Here, I suggest a shorter option name NAUTILUS instead of
NAUTILUS_EXTENSION.
Also, for PLIST_SUB, I think NLS is OK for most ports.
.if !defined(WITH_NLS)
PLIST_SUB+= NLS=@comment
.else
PLIST_SUB+= NLS=
.endif
Will do.
2. The port also installs *.egg-info file and i'm not sure how to
include it
in the plist.
You should set PYDISTUTILS_EGGINFO=egg-info files.
bsd.python.mk will add them to PLIST automatically.
PYDISTUTILS_EGGINFO defaults to tortoisehg-1.1.9.1-py2.6.egg-info.
(when PORTNAME=tortoisehg)
What if PORTNAME!=tortoisehg? I mean, if i'm setting PYDISTUTILS_EGGINFO,
where should i obtain that -py2.6- part?
PYDISTUTILS_EGGINFO defaults to
${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/[^A-Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info
(Mk/bsd.python.mk, around line 509)
For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_VER.
(Mk/bsd.python.mk, around line 372-410)
--
Sunpoet Po-Chuan Hsieh sunpoet at sunpoet.net sunpoet at FreeBSD.org
4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Wed, Feb 9, 2011 at 4:42 PM, Sunpoet Hsieh sunp...@sunpoet.net wrote:
It looks like you'll have two ports, version 1 and 2, and these two
ports do not conflict with each other.
IMHO, I would simply use devel/tortoisehg1 for version 1 and
devel/tortoisehg for upcoming version 2.
You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK or
Qt.
Okay.
Now regarding this:
In your case, it can be done without extra patch files.
.if !defined(WITH_NAUTILUS)
@${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP}
.endif
.if !defined(WITH_NLS)
@${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP}
.endif
-e 'x,y D' removes whole line, so all lines under removed line get shifted.
So, it's impossible to apply them in all combinations.
I'm not familiar with sed, but is it possible to delete whole line, but
leave \n at the end so line numbers will not be shifted?
PYDISTUTILS_EGGINFO defaults to
${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/[^A-Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info
(Mk/bsd.python.mk, around line 509)
For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_VER.
(Mk/bsd.python.mk, around line 372-410)
Okay, i will look there.
By the way, currently 'make fetch' does not work, because hosting site have
broken certs. So, i was forced to do this:
RUN_DEPENDS=hg:${PORTSDIR}/devel/mercurial \
wget:${PORTSDIR}/ftp/wget
FETCH_CMD=wget
FETCH_BEFORE_ARGS=--no-check-certificate
Is it ok?
On Tue, Feb 8, 2011 at 10:11 PM, Eitan Adler li...@eitanadler.com wrote:
Hi,
Congrats on your first attempt! Here are a few issues with the port.
Please don't take them personally.
1) install port-mgmt/portlint and run it on your port (portlint -CN)
it will point out a lot of things
2) The preferred format for new ports is a shar - not a .tar.gz file
3) It is not newline terminated
4) the .egg-info files should not be included in the pkg-plist
5) replace @dirrm lib/nautilus with @dirrmtry lib/nautilus because
your port does not directly create this directories
6) And what i've been told is that i should use EXTRA_PATCHES, insteand of
invoking patch. -- yes. Please use a patch file unless it something
that has to be run on a significant number of files. reinplace makes
it harder to find out what is being patched. You may want to use 'make
makepatch' to generate them.
Eitan, thanks for your suggestions too.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Wed, Feb 09, 2011 at 06:24:34PM +0300, arrowdodger wrote:
On Wed, Feb 9, 2011 at 4:42 PM, Sunpoet Hsieh sunp...@sunpoet.net wrote:
It looks like you'll have two ports, version 1 and 2, and these two
ports do not conflict with each other.
IMHO, I would simply use devel/tortoisehg1 for version 1 and
devel/tortoisehg for upcoming version 2.
You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK or
Qt.
Okay.
Now regarding this:
In your case, it can be done without extra patch files.
.if !defined(WITH_NAUTILUS)
@${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP}
.endif
.if !defined(WITH_NLS)
@${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP}
.endif
-e 'x,y D' removes whole line, so all lines under removed line get shifted.
So, it's impossible to apply them in all combinations.
I'm not familiar with sed, but is it possible to delete whole line, but
leave \n at the end so line numbers will not be shifted?
You're right.
I'll use @${REINPLACE_CMD} -e '153,154 s|^|# |' ${WRKSRC}/${PYSETUP} instead.
PYDISTUTILS_EGGINFO defaults to
${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/[^A-Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info
(Mk/bsd.python.mk, around line 509)
For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_VER.
(Mk/bsd.python.mk, around line 372-410)
Okay, i will look there.
By the way, currently 'make fetch' does not work, because hosting site have
broken certs. So, i was forced to do this:
RUN_DEPENDS=hg:${PORTSDIR}/devel/mercurial \
wget:${PORTSDIR}/ftp/wget
FETCH_CMD=wget
FETCH_BEFORE_ARGS=--no-check-certificate
Is it ok?
First, it should be FETCH_DEPENDS, not RUN_DEPENDS.
Back to the download problem, make fetch fails due to the default FETCH_ARGS
(-AFpr).
-A flag denies 301/302 redirect used by bitbucket.org to redirect requests to
the destination.
It finally goes to cdn.bitbucket.org.
Therefore, you have two options:
1. Set MASTER_SITES=http://cdn.bitbucket.org/tortoisehg/targz/downloads/ to
skip redirection.
2. Set FETCH_ARGS=-Fpr to allow redirect.
I prefer 1.
Detailed logs shown as follows:
% make fetch
= tortoisehg-1.1.9.1.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
= Attempting to fetch
http://bitbucket.org/tortoisehg/targz/downloads//tortoisehg-1.1.9.1.tar.gz
looking up bitbucket.org
connecting to bitbucket.org:80
requesting
http://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
301 redirect to
https://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
looking up bitbucket.org
connecting to bitbucket.org:443
SSL connection established using DHE-RSA-AES256-SHA
Certificate subject: /C=NL/O=bitbucket.org/OU=GT16385137/OU=See
www.geotrust.com/resources/cps (c)09/OU=Domain Control Validated -
QuickSSL(R)/CN=bitbucket.org
Certificate issuer: /C=US/O=Equifax/OU=Equifax Secure Certificate Authority
requesting
https://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
302 redirect to
http://cdn.bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
looking up cdn.bitbucket.org
connecting to cdn.bitbucket.org:80
requesting
http://cdn.bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
remote size / mtime: 6815613 / 1296700276
Best regards,
--
Sunpoet Po-Chuan Hsieh sunpoet at sunpoet.net sunpoet at FreeBSD.org
4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Request for new port review: TortoiseHG.
Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is
my first attempt in port creation, so i want someone to review it.
The current problems are following:
1. The user can choose to not install nautilus extension and translation
files (if defined(WITHOUT_NLS)). To prevent setup.py from installing those
stuff, i've made two patches, that resides in ${FILESDIR}. They are
generated from 'diff -u' and the problem is that they cannot be applied
together. If i generate patches with simply 'diff', then everythink works,
except that i should apply them manually (${PATCH} ${PYSETUP}
${FILESDIR}/no-locale.patch).
And what i've been told is that i should use EXTRA_PATCHES, insteand of
invoking patch.
2. The port also installs *.egg-info file and i'm not sure how to include it
in the plist.
3. The port also depends on py-gobject port, but there is no such value in
USE_GNOME. I've already mentioned that on freebsd-gnome@ and they said, that
it will be fixed after 8.2-RELEASE.
You can obtain port from attachement or here:
http://intara.org.ru/tortoisehg.tar.gz
Thanks in advance.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
Hi,
08.02.2011 14:40, arrowdodger пишет:
Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is
my first attempt in port creation, so i want someone to review it.
The current problems are following:
1. The user can choose to not install nautilus extension and translation
files (if defined(WITHOUT_NLS)). To prevent setup.py from installing those
stuff, i've made two patches, that resides in ${FILESDIR}. They are
generated from 'diff -u' and the problem is that they cannot be applied
together. If i generate patches with simply 'diff', then everythink works,
except that i should apply them manually (${PATCH} ${PYSETUP}
${FILESDIR}/no-locale.patch).
And what i've been told is that i should use EXTRA_PATCHES, insteand of
invoking patch.
2. The port also installs *.egg-info file and i'm not sure how to include it
in the plist.
It shouldn't be listed in pkg-plist, because it will be removed
automatically on port deinstall.
3. The port also depends on py-gobject port, but there is no such value in
USE_GNOME. I've already mentioned that on freebsd-gnome@ and they said, that
it will be fixed after 8.2-RELEASE.
You can obtain port from attachement or here:
http://intara.org.ru/tortoisehg.tar.gz
Thanks in advance.
dirrm's for lib/nautilus and it's subdirectories should be dirrmtry's
actually, because it's doesn't created by tortoisehg-hgtk, but nautilus
or nautilus-plugins. Also consider to use:
USE_GETTEXT=yes
INSTALLS_ICONS= yes
In port's Makefile.
BLDDIR is defined but seems not used in Makefile. What it is for?
--
Regards,
Ruslan
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Tue, Feb 8, 2011 at 4:05 PM, Ruslan Mahmatkhanov cvs-...@yandex.ruwrote: It shouldn't be listed in pkg-plist, because it will be removed automatically on port deinstall. Well, if i 'make PREFIX=/home/arr/prefix install make PREFIX=/home/arr/prefix deinstall' then this file is not deleted. You mean, it will be deleted if i install port without PREFIX? dirrm's for lib/nautilus and it's subdirectories should be dirrmtry's actually, because it's doesn't created by tortoisehg-hgtk, but nautilus or nautilus-plugins. Okay. Also consider to use: USE_GETTEXT=yes INSTALLS_ICONS= yes In port's Makefile. Should it be .if !defined(WITHOUT_NLS) USE_GETTEXT=yes .endif ? And what's the purpose of INSTALLS_ICONS? BLDDIR is defined but seems not used in Makefile. What it is for? Oh, this is not needed now. I will remove that. Спасибо за подсказки. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
08.02.2011 16:29, arrowdodger пишет:
On Tue, Feb 8, 2011 at 4:05 PM, Ruslan Mahmatkhanovcvs-...@yandex.ruwrote:
It shouldn't be listed in pkg-plist, because it will be removed
automatically on port deinstall.
Well, if i 'make PREFIX=/home/arr/prefix install make
PREFIX=/home/arr/prefix deinstall' then this file is not deleted. You mean,
it will be deleted if i install port without PREFIX?
I can't say anything about custom ${PREFIX}, but it definitelly works
for default ${PREFIX} (/usr/local)
dirrm's for lib/nautilus and it's subdirectories should be dirrmtry's
actually, because it's doesn't created by tortoisehg-hgtk, but nautilus or
nautilus-plugins.
Okay.
Also consider to use:
USE_GETTEXT=yes
INSTALLS_ICONS= yes
In port's Makefile.
Should it be
.if !defined(WITHOUT_NLS)
USE_GETTEXT=yes
.endif
?
Yes.
And what's the purpose of INSTALLS_ICONS?
I can't find description in porters handbook, i believe it was there
some time ago. It's needed for indicate that your ports installs some
icons :)
BLDDIR is defined but seems not used in Makefile. What it is for?
Oh, this is not needed now. I will remove that.
Спасибо за подсказки.
Пожалуйста :)
--
Regards,
Ruslan
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: Request for new port review: TortoiseHG.
On Tue, Feb 8, 2011 at 6:40 AM, arrowdodger 6year...@gmail.com wrote: Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is my first attempt in port creation, so i want someone to review it. Hi, Congrats on your first attempt! Here are a few issues with the port. Please don't take them personally. 1) install port-mgmt/portlint and run it on your port (portlint -CN) it will point out a lot of things 2) The preferred format for new ports is a shar - not a .tar.gz file 3) It is not newline terminated 4) the .egg-info files should not be included in the pkg-plist 5) replace @dirrm lib/nautilus with @dirrmtry lib/nautilus because your port does not directly create this directories 6) And what i've been told is that i should use EXTRA_PATCHES, insteand of invoking patch. -- yes. Please use a patch file unless it something that has to be run on a significant number of files. reinplace makes it harder to find out what is being patched. You may want to use 'make makepatch' to generate them. -- Eitan Adler ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
