Re: Which to bump for distfile location change?

2011-07-27 Thread Peter Jeremy
On 2011-Jul-26 17:03:24 -0400, Wesley Shields w...@atarininja.org wrote:
On Tue, Jul 26, 2011 at 09:08:13PM +0100, Chris Rees wrote:
 No default package change, no portrevision bump. Leave it as is.

Chris is right but I don't want to give people the impression that is
the only time to bump PORTREVISION.

Another way of looking at it is:  Should a user who has the port
successfully installed rebuild the port, even though the distfile
version hasn't changed.

-- 
Peter Jeremy


pgpdoZpZTL7sJ.pgp
Description: PGP signature


Which to bump for distfile location change?

2011-07-26 Thread Bob Eager
Following a recent post to this list, I need to update a port, just to
change a distfile location.

It seems excessive to bump PORTREVISION, so what is the best thing to
change (if any).
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: Which to bump for distfile location change?

2011-07-26 Thread Chuck Swiger
On Jul 26, 2011, at 12:47 PM, Bob Eager wrote:
 Following a recent post to this list, I need to update a port, just to
 change a distfile location.
 
 It seems excessive to bump PORTREVISION, so what is the best thing to
 change (if any).

Probably nothing-- if someone already has a copy of the distfile, and there are 
no other changes, then there is no need to force them to rebuild the port by 
bumping PORTREVISION.

Regards,
-- 
-Chuck

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: Which to bump for distfile location change?

2011-07-26 Thread Chris Rees
On 26 Jul 2011 20:47, Bob Eager r...@tavi.co.uk wrote:

 Following a recent post to this list, I need to update a port, just to
 change a distfile location.

 It seems excessive to bump PORTREVISION, so what is the best thing to
 change (if any).


No default package change, no portrevision bump. Leave it as is.

Chris
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org


Re: Which to bump for distfile location change?

2011-07-26 Thread Wesley Shields
On Tue, Jul 26, 2011 at 09:08:13PM +0100, Chris Rees wrote:
 On 26 Jul 2011 20:47, Bob Eager r...@tavi.co.uk wrote:
 
  Following a recent post to this list, I need to update a port, just to
  change a distfile location.
 
  It seems excessive to bump PORTREVISION, so what is the best thing to
  change (if any).
 
 
 No default package change, no portrevision bump. Leave it as is.

Chris is right but I don't want to give people the impression that is
the only time to bump PORTREVISION.

While the default package change rule of thumb is always a good one
there is more to it than just that when deciding to bump PORTREVISION or
not. Here's the rough questions I go through in my head when I'm facing
this kind of decision:

If the default package changes, bump it. Only caveat here is if it's a
minor change (say a typo in a man page or something).

If it's chasing a shlib bump of another port and this port defaults to
off, bump it anyways as some people may be bit by this.

If it's a change to an option that defaults to off, and one can expect a
reasonable number of people to benefit from it, bump it.

I'm sure there are others and I'm sure some people will disagree with
some of these. But those are the rough guidelines I follow.

-- WXS
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org