Re: dns/knot2 Would much appreciate committer

2015-12-11 Thread Kubilay Kocak
On 11/12/2015 2:05 PM, Chad J. Milios wrote:
> Maintainer seems to have overlooked this PR. Trying again seeking
> maintainer feedback/approval. Thanks to everyone. Viva la FreeBSD
> 
> Changes should be pretty cut and dried if any committer would like to
> take a look. I copied the implementation more or less verbatim from
> openvpn's rc.d script.
> 
> Any feedback/issues, I'd be happy to resolve. I'm well versed in
> Bourne sh.
> 
> Bug 203931 - [PATCH] dns/knot2 enable multiple instances in rc.d
> script
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203931
> 

The rebased attachment was added today, so the current Assignee, has not
overlooked it.

Your new attachment requires MAINTAINER approval, prior to it being
committed.

You have unfortunately put yourself in the maintainer-approval ? value.

I'll take care of bringing the issue up to date.


___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: dns/knot2 Would much appreciate committer

2015-12-11 Thread Kubilay Kocak
On 11/12/2015 7:30 PM, Kubilay Kocak wrote:
> On 11/12/2015 2:05 PM, Chad J. Milios wrote:
>> Maintainer seems to have overlooked this PR. Trying again seeking
>> maintainer feedback/approval. Thanks to everyone. Viva la FreeBSD
>>
>> Changes should be pretty cut and dried if any committer would like to
>> take a look. I copied the implementation more or less verbatim from
>> openvpn's rc.d script.
>>
>> Any feedback/issues, I'd be happy to resolve. I'm well versed in
>> Bourne sh.
>>
>> Bug 203931 - [PATCH] dns/knot2 enable multiple instances in rc.d
>> script
>>
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203931
>>
> 
> The rebased attachment was added today, so the current Assignee, has not
> overlooked it.

Apologies Chad, I misunderstood. The maintainer hasn't yet replied, correct.

> Your new attachment requires MAINTAINER approval, prior to it being
> committed.

This is the downside of submitting multiple unrelated changes in a
single issue, particularly part way through committing changes.

Each independent change requires maintainer approval, and resets the
timeout timer

> You have unfortunately put yourself in the maintainer-approval ? value.
> 
> I'll take care of bringing the issue up to date.

I've done this now.


___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


dns/knot2 Would much appreciate committer

2015-12-10 Thread Chad J. Milios
Maintainer seems to have overlooked this PR. Trying again seeking maintainer 
feedback/approval. Thanks to everyone. Viva la FreeBSD

Changes should be pretty cut and dried if any committer would like to take a 
look. I copied the implementation more or less verbatim from openvpn's rc.d 
script.

Any feedback/issues, I'd be happy to resolve. I'm well versed in Bourne sh.

Bug 203931 - [PATCH] dns/knot2 enable multiple instances in rc.d script

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203931


___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"